svn commit: r6995 - trunk: resources/languages src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup


#1

Hey Matthieu,

A quick note regarding your 6995 and 6996 commits. Currently, directly
modifying localized resources_XX.properties files may lead to the loss
of your changes next time someone contributes through our pootle
instance on translate.sip-communicator.org.

I believe you already have an account there so let me know if you are
having issues uploading your string translations there.

Cheers,
Emil

···

On Wed, Apr 14, 2010 at 9:23 PM, <kpouer@dev.java.net> wrote:

Author: kpouer
Date: 2010-04-14 19:23:51+0000
New Revision: 6995

Modified:
trunk/resources/languages/resources.properties
trunk/resources/languages/resources_fr.properties
trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java

Log:
forbid creation of of contact group with empty name

Modified: trunk/resources/languages/resources.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/resources/languages/resources.properties?view=diff&rev=6995&p1=trunk/resources/languages/resources.properties&p2=trunk/resources/languages/resources.properties&r1=6994&r2=6995

--- trunk/resources/languages/resources.properties (original)
+++ trunk/resources/languages/resources.properties 2010-04-14 19:23:51+0000
@@ -45,6 +45,7 @@
service.gui.ADD_GROUP_EXIST_ERROR=The group {0} already exists in your contact list. Please choose another name.
service.gui.ADD_GROUP_NET_ERROR=Failed to add group with name: {0}. The problem occured due to a network failure. Please check your network connection and try again.
service.gui.ADD_GROUP_ERROR=Failed to add group with name: {0}.
+service.gui.ADD_GROUP_EMPTY_NAME=The group name must not be empty.
service.gui.ADD_GROUP=Create group
service.gui.ADD_SUBCONTACT=&Add subcontact
service.gui.ADMINISTRATOR=administrator

Modified: trunk/resources/languages/resources_fr.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/resources/languages/resources_fr.properties?view=diff&rev=6995&p1=trunk/resources/languages/resources_fr.properties&p2=trunk/resources/languages/resources_fr.properties&r1=6994&r2=6995

--- trunk/resources/languages/resources_fr.properties (original)
+++ trunk/resources/languages/resources_fr.properties 2010-04-14 19:23:51+0000
@@ -45,6 +45,7 @@
service.gui.ADD_GROUP_EXIST_ERROR=Le groupe {0} existe déjà dans votre liste de contact. Veuillez choisir un nom différent.
service.gui.ADD_GROUP_NET_ERROR=Échec lors de l''ajout du groupe : {0}. Le problème est dû à une erreur réseau. Veuillez vérifier votre connexion au réseau et réessayez.
service.gui.ADD_GROUP_ERROR=Échec lors de l''ajout du groupe : {0}.
+service.gui.ADD_GROUP_EMPTY_NAME=Le nom du groupe ne doit pas etre vide.
service.gui.ADD_GROUP=Créer un groupe
service.gui.ADD_SUBCONTACT=&Ajouter un sous-contact
service.gui.ADMINISTRATOR=administrateur

Modified: trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java?view=diff&rev=6995&p1=trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java&p2=trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java&r1=6994&r2=6995

--- trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java (original)
+++ trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java 2010-04-14 19:23:51+0000
@@ -149,7 +149,16 @@

    if \(name\.equals\(&quot;create&quot;\)\)
    \{

- new CreateGroup(clist, groupPanel.getGroupName()).start();
+ String groupName = groupPanel.getGroupName().trim();
+ if (groupName.length() == 0)
+ {
+ groupPanel.showErrorMessage(
+ GuiActivator.getResources().getI18NString(
+ "service.gui.ADD_GROUP_EMPTY_NAME",
+ new String[]{groupName}));
+ }
+ else
+ new CreateGroup(clist, groupName).start();
}
else if(name.equals("cancel"))
{

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31


#2

Oh sorry so I have to upload my modified properties file to
translate.sip-communicator.org instead of committing them and pottle
will merge them, is that right ?

Matthieu

···

2010/4/15 Emil Ivov <emcho@sip-communicator.org>:

Hey Matthieu,

A quick note regarding your 6995 and 6996 commits. Currently, directly
modifying localized resources_XX.properties files may lead to the loss
of your changes next time someone contributes through our pootle
instance on translate.sip-communicator.org.

I believe you already have an account there so let me know if you are
having issues uploading your string translations there.

Cheers,
Emil

On Wed, Apr 14, 2010 at 9:23 PM, <kpouer@dev.java.net> wrote:

Author: kpouer
Date: 2010-04-14 19:23:51+0000
New Revision: 6995

Modified:
trunk/resources/languages/resources.properties
trunk/resources/languages/resources_fr.properties
trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java

Log:
forbid creation of of contact group with empty name

Modified: trunk/resources/languages/resources.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/resources/languages/resources.properties?view=diff&rev=6995&p1=trunk/resources/languages/resources.properties&p2=trunk/resources/languages/resources.properties&r1=6994&r2=6995

--- trunk/resources/languages/resources.properties (original)
+++ trunk/resources/languages/resources.properties 2010-04-14 19:23:51+0000
@@ -45,6 +45,7 @@
service.gui.ADD_GROUP_EXIST_ERROR=The group {0} already exists in your contact list. Please choose another name.
service.gui.ADD_GROUP_NET_ERROR=Failed to add group with name: {0}. The problem occured due to a network failure. Please check your network connection and try again.
service.gui.ADD_GROUP_ERROR=Failed to add group with name: {0}.
+service.gui.ADD_GROUP_EMPTY_NAME=The group name must not be empty.
service.gui.ADD_GROUP=Create group
service.gui.ADD_SUBCONTACT=&Add subcontact
service.gui.ADMINISTRATOR=administrator

Modified: trunk/resources/languages/resources_fr.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/resources/languages/resources_fr.properties?view=diff&rev=6995&p1=trunk/resources/languages/resources_fr.properties&p2=trunk/resources/languages/resources_fr.properties&r1=6994&r2=6995

--- trunk/resources/languages/resources_fr.properties (original)
+++ trunk/resources/languages/resources_fr.properties 2010-04-14 19:23:51+0000
@@ -45,6 +45,7 @@
service.gui.ADD_GROUP_EXIST_ERROR=Le groupe {0} existe déjà dans votre liste de contact. Veuillez choisir un nom différent.
service.gui.ADD_GROUP_NET_ERROR=Échec lors de l''ajout du groupe : {0}. Le problème est dû à une erreur réseau. Veuillez vérifier votre connexion au réseau et réessayez.
service.gui.ADD_GROUP_ERROR=Échec lors de l''ajout du groupe : {0}.
+service.gui.ADD_GROUP_EMPTY_NAME=Le nom du groupe ne doit pas etre vide.
service.gui.ADD_GROUP=Créer un groupe
service.gui.ADD_SUBCONTACT=&Ajouter un sous-contact
service.gui.ADMINISTRATOR=administrateur

Modified: trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java?view=diff&rev=6995&p1=trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java&p2=trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java&r1=6994&r2=6995

--- trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java (original)
+++ trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java 2010-04-14 19:23:51+0000
@@ -149,7 +149,16 @@

    if \(name\.equals\(&quot;create&quot;\)\)
    \{

- new CreateGroup(clist, groupPanel.getGroupName()).start();
+ String groupName = groupPanel.getGroupName().trim();
+ if (groupName.length() == 0)
+ {
+ groupPanel.showErrorMessage(
+ GuiActivator.getResources().getI18NString(
+ "service.gui.ADD_GROUP_EMPTY_NAME",
+ new String[]{groupName}));
+ }
+ else
+ new CreateGroup(clist, groupName).start();
}
else if(name.equals("cancel"))
{

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

На 15.04.10 11:39, Matthieu Casanova написа:

Oh sorry so I have to upload my modified properties file to
translate.sip-communicator.org instead of committing them and pottle
will merge them, is that right ?

You only need to commit changes to the resources.properties file. Pootle
will then retrieve them during its next periodic update (you can also
trigger one through the web interface). It will then let you and other
localization contributors address the new translations through its web
interface.

On translate.sip-communicator.org click on SIP Communicator, then on the
line of the language you are interested in click on the "X words need
attention" link. Pootle will then serve you the new strings that need
translation.

Cheers,
Emil

···

Matthieu

2010/4/15 Emil Ivov <emcho@sip-communicator.org>:

Hey Matthieu,

A quick note regarding your 6995 and 6996 commits. Currently, directly
modifying localized resources_XX.properties files may lead to the loss
of your changes next time someone contributes through our pootle
instance on translate.sip-communicator.org.

I believe you already have an account there so let me know if you are
having issues uploading your string translations there.

Cheers,
Emil

On Wed, Apr 14, 2010 at 9:23 PM, <kpouer@dev.java.net> wrote:

Author: kpouer
Date: 2010-04-14 19:23:51+0000
New Revision: 6995

Modified:
  trunk/resources/languages/resources.properties
  trunk/resources/languages/resources_fr.properties
  trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java

Log:
forbid creation of of contact group with empty name

Modified: trunk/resources/languages/resources.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/resources/languages/resources.properties?view=diff&rev=6995&p1=trunk/resources/languages/resources.properties&p2=trunk/resources/languages/resources.properties&r1=6994&r2=6995

--- trunk/resources/languages/resources.properties (original)
+++ trunk/resources/languages/resources.properties 2010-04-14 19:23:51+0000
@@ -45,6 +45,7 @@
service.gui.ADD_GROUP_EXIST_ERROR=The group {0} already exists in your contact list. Please choose another name.
service.gui.ADD_GROUP_NET_ERROR=Failed to add group with name: {0}. The problem occured due to a network failure. Please check your network connection and try again.
service.gui.ADD_GROUP_ERROR=Failed to add group with name: {0}.
+service.gui.ADD_GROUP_EMPTY_NAME=The group name must not be empty.
service.gui.ADD_GROUP=Create group
service.gui.ADD_SUBCONTACT=&Add subcontact
service.gui.ADMINISTRATOR=administrator

Modified: trunk/resources/languages/resources_fr.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/resources/languages/resources_fr.properties?view=diff&rev=6995&p1=trunk/resources/languages/resources_fr.properties&p2=trunk/resources/languages/resources_fr.properties&r1=6994&r2=6995

--- trunk/resources/languages/resources_fr.properties (original)
+++ trunk/resources/languages/resources_fr.properties 2010-04-14 19:23:51+0000
@@ -45,6 +45,7 @@
service.gui.ADD_GROUP_EXIST_ERROR=Le groupe {0} existe déjà dans votre liste de contact. Veuillez choisir un nom différent.
service.gui.ADD_GROUP_NET_ERROR=Échec lors de l''ajout du groupe : {0}. Le problème est dû à une erreur réseau. Veuillez vérifier votre connexion au réseau et réessayez.
service.gui.ADD_GROUP_ERROR=Échec lors de l''ajout du groupe : {0}.
+service.gui.ADD_GROUP_EMPTY_NAME=Le nom du groupe ne doit pas etre vide.
service.gui.ADD_GROUP=Créer un groupe
service.gui.ADD_SUBCONTACT=&Ajouter un sous-contact
service.gui.ADMINISTRATOR=administrateur

Modified: trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java?view=diff&rev=6995&p1=trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java&p2=trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java&r1=6994&r2=6995

--- trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java (original)
+++ trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java 2010-04-14 19:23:51+0000
@@ -149,7 +149,16 @@

        if (name.equals("create"))
        {
- new CreateGroup(clist, groupPanel.getGroupName()).start();
+ String groupName = groupPanel.getGroupName().trim();
+ if (groupName.length() == 0)
+ {
+ groupPanel.showErrorMessage(
+ GuiActivator.getResources().getI18NString(
+ "service.gui.ADD_GROUP_EMPTY_NAME",
+ new String[]{groupName}));
+ }
+ else
+ new CreateGroup(clist, groupName).start();
        }
        else if(name.equals("cancel"))
        {

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

На 15.04.10 11:39, Matthieu Casanova написа:

Oh sorry so I have to upload my modified properties file to
translate.sip-communicator.org instead of committing them and pottle
will merge them, is that right ?

You only need to commit changes to the resources.properties file. Pootle
will then retrieve them during its next periodic update (you can also
trigger one through the web interface). It will then let you and other
localization contributors address the new translations through its web
interface.

Actually, we also need to manually "update from templates" from Pootle in order to import new strings in the translation files. I have to check the possibility to run this action automatically.

Martin

···

On 04/15/2010 06:56 PM, Emil Ivov wrote:

On translate.sip-communicator.org click on SIP Communicator, then on the
line of the language you are interested in click on the "X words need
attention" link. Pootle will then serve you the new strings that need
translation.

Cheers,
Emil

Matthieu

2010/4/15 Emil Ivov<emcho@sip-communicator.org>:

Hey Matthieu,

A quick note regarding your 6995 and 6996 commits. Currently, directly
modifying localized resources_XX.properties files may lead to the loss
of your changes next time someone contributes through our pootle
instance on translate.sip-communicator.org.

I believe you already have an account there so let me know if you are
having issues uploading your string translations there.

Cheers,
Emil

On Wed, Apr 14, 2010 at 9:23 PM,<kpouer@dev.java.net> wrote:

Author: kpouer
Date: 2010-04-14 19:23:51+0000
New Revision: 6995

Modified:
   trunk/resources/languages/resources.properties
   trunk/resources/languages/resources_fr.properties
   trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java

Log:
forbid creation of of contact group with empty name

Modified: trunk/resources/languages/resources.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/resources/languages/resources.properties?view=diff&rev=6995&p1=trunk/resources/languages/resources.properties&p2=trunk/resources/languages/resources.properties&r1=6994&r2=6995

--- trunk/resources/languages/resources.properties (original)
+++ trunk/resources/languages/resources.properties 2010-04-14 19:23:51+0000
@@ -45,6 +45,7 @@
  service.gui.ADD_GROUP_EXIST_ERROR=The group {0} already exists in your contact list. Please choose another name.
  service.gui.ADD_GROUP_NET_ERROR=Failed to add group with name: {0}. The problem occured due to a network failure. Please check your network connection and try again.
  service.gui.ADD_GROUP_ERROR=Failed to add group with name: {0}.
+service.gui.ADD_GROUP_EMPTY_NAME=The group name must not be empty.
  service.gui.ADD_GROUP=Create group
  service.gui.ADD_SUBCONTACT=&Add subcontact
  service.gui.ADMINISTRATOR=administrator

Modified: trunk/resources/languages/resources_fr.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/resources/languages/resources_fr.properties?view=diff&rev=6995&p1=trunk/resources/languages/resources_fr.properties&p2=trunk/resources/languages/resources_fr.properties&r1=6994&r2=6995

--- trunk/resources/languages/resources_fr.properties (original)
+++ trunk/resources/languages/resources_fr.properties 2010-04-14 19:23:51+0000
@@ -45,6 +45,7 @@
  service.gui.ADD_GROUP_EXIST_ERROR=Le groupe {0} existe déjà dans votre liste de contact. Veuillez choisir un nom différent.
  service.gui.ADD_GROUP_NET_ERROR=Échec lors de l''ajout du groupe : {0}. Le problème est dû à une erreur réseau. Veuillez vérifier votre connexion au réseau et réessayez.
  service.gui.ADD_GROUP_ERROR=Échec lors de l''ajout du groupe : {0}.
+service.gui.ADD_GROUP_EMPTY_NAME=Le nom du groupe ne doit pas etre vide.
  service.gui.ADD_GROUP=Créer un groupe
  service.gui.ADD_SUBCONTACT=&Ajouter un sous-contact
  service.gui.ADMINISTRATOR=administrateur

Modified: trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java?view=diff&rev=6995&p1=trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java&p2=trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java&r1=6994&r2=6995

--- trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java (original)
+++ trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java 2010-04-14 19:23:51+0000
@@ -149,7 +149,16 @@

         if (name.equals("create"))
         {
- new CreateGroup(clist, groupPanel.getGroupName()).start();
+ String groupName = groupPanel.getGroupName().trim();
+ if (groupName.length() == 0)
+ {
+ groupPanel.showErrorMessage(
+ GuiActivator.getResources().getI18NString(
+ "service.gui.ADD_GROUP_EMPTY_NAME",
+ new String[]{groupName}));
+ }
+ else
+ new CreateGroup(clist, groupName).start();
         }
         else if(name.equals("cancel"))
         {

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

На 15.04.10 16:38, Martin André написа:

Actually, we also need to manually "update from templates" from Pootle
in order to import new strings in the translation files. I have to check
the possibility to run this action automatically.

Oh, I see! I guess I mistook you for a cron script then ;).

Cheers,
Emil

···

Martin

On translate.sip-communicator.org click on SIP Communicator, then on the
line of the language you are interested in click on the "X words need
attention" link. Pootle will then serve you the new strings that need
translation.

Cheers,
Emil

Matthieu

2010/4/15 Emil Ivov<emcho@sip-communicator.org>:

Hey Matthieu,

A quick note regarding your 6995 and 6996 commits. Currently, directly
modifying localized resources_XX.properties files may lead to the loss
of your changes next time someone contributes through our pootle
instance on translate.sip-communicator.org.

I believe you already have an account there so let me know if you are
having issues uploading your string translations there.

Cheers,
Emil

On Wed, Apr 14, 2010 at 9:23 PM,<kpouer@dev.java.net> wrote:

Author: kpouer
Date: 2010-04-14 19:23:51+0000
New Revision: 6995

Modified:
   trunk/resources/languages/resources.properties
   trunk/resources/languages/resources_fr.properties
   trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java

Log:
forbid creation of of contact group with empty name

Modified: trunk/resources/languages/resources.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/resources/languages/resources.properties?view=diff&rev=6995&p1=trunk/resources/languages/resources.properties&p2=trunk/resources/languages/resources.properties&r1=6994&r2=6995

--- trunk/resources/languages/resources.properties (original)
+++ trunk/resources/languages/resources.properties 2010-04-14 19:23:51+0000
@@ -45,6 +45,7 @@
  service.gui.ADD_GROUP_EXIST_ERROR=The group {0} already exists in your contact list. Please choose another name.
  service.gui.ADD_GROUP_NET_ERROR=Failed to add group with name: {0}. The problem occured due to a network failure. Please check your network connection and try again.
  service.gui.ADD_GROUP_ERROR=Failed to add group with name: {0}.
+service.gui.ADD_GROUP_EMPTY_NAME=The group name must not be empty.
  service.gui.ADD_GROUP=Create group
  service.gui.ADD_SUBCONTACT=&Add subcontact
  service.gui.ADMINISTRATOR=administrator

Modified: trunk/resources/languages/resources_fr.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/resources/languages/resources_fr.properties?view=diff&rev=6995&p1=trunk/resources/languages/resources_fr.properties&p2=trunk/resources/languages/resources_fr.properties&r1=6994&r2=6995

--- trunk/resources/languages/resources_fr.properties (original)
+++ trunk/resources/languages/resources_fr.properties 2010-04-14 19:23:51+0000
@@ -45,6 +45,7 @@
  service.gui.ADD_GROUP_EXIST_ERROR=Le groupe {0} existe déjà dans votre liste de contact. Veuillez choisir un nom différent.
  service.gui.ADD_GROUP_NET_ERROR=Échec lors de l''ajout du groupe : {0}. Le problème est dû à une erreur réseau. Veuillez vérifier votre connexion au réseau et réessayez.
  service.gui.ADD_GROUP_ERROR=Échec lors de l''ajout du groupe : {0}.
+service.gui.ADD_GROUP_EMPTY_NAME=Le nom du groupe ne doit pas etre vide.
  service.gui.ADD_GROUP=Créer un groupe
  service.gui.ADD_SUBCONTACT=&Ajouter un sous-contact
  service.gui.ADMINISTRATOR=administrateur

Modified: trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java?view=diff&rev=6995&p1=trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java&p2=trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java&r1=6994&r2=6995

--- trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java (original)
+++ trunk/src/net/java/sip/communicator/impl/gui/main/contactlist/addgroup/CreateGroupDialog.java 2010-04-14 19:23:51+0000
@@ -149,7 +149,16 @@

         if (name.equals("create"))
         {
- new CreateGroup(clist, groupPanel.getGroupName()).start();
+ String groupName = groupPanel.getGroupName().trim();
+ if (groupName.length() == 0)
+ {
+ groupPanel.showErrorMessage(
+ GuiActivator.getResources().getI18NString(
+ "service.gui.ADD_GROUP_EMPTY_NAME",
+ new String[]{groupName}));
+ }
+ else
+ new CreateGroup(clist, groupName).start();
         }
         else if(name.equals("cancel"))
         {

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net