Sometimes source-add is not propagated properly

hi im working on upgrade new version to stable/jitsi-meet_7648.
while test, i think there is bug with propagate participant’s sources

In a normal case, all participants in the meeting receive a new participant’s source-add signal twice each, video and audio like below log

Jicofo 2022-11-21 17:00:05.691 INFO: [26317] DiscoveryUtil.discoverParticipantFeatures#166: Discovered features for 9639213097@conference.test.com/bab42c11 in 0 ms.
Jicofo 2022-11-21 17:00:05.691 INFO: [26317] DiscoveryUtil.discoverParticipantFeatures#180: Successfully discovered features for 9639213097@conference.test.com/bab42c11 in 0
Jicofo 2022-11-21 17:00:05.692 INFO: [26323] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] ColibriV2SessionManager.allocate#253: Allocating for bab42c11
Jicofo 2022-11-21 17:00:05.692 INFO: [26323] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] ColibriV2SessionManager.allocate#296: Selected 9f066300-d6f5-4e90-90f2-5a84cee325a6, session exists: true
Jicofo 2022-11-21 17:00:05.697 INFO: [26323] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=bab42c11] ParticipantInviteRunnable.doInviteOrReinvite#379: Sending session-initiate to: 9639213097@conference.test.com/bab42c11 sources={9639213097@conference.test.com/14e333e4=[audio=[1100075411], video=[3429090865, 2063799735, 2112586487, 452006279, 684090528, 734593588], groups=[FID[3429090865, 2063799735], SIM[3429090865, 2112586487, 452006279], FID[2112586487, 684090528], FID[452006279, 734593588]]], 9639213097@conference.test.com/291b3b34=[audio=[2588028662], video=[880792005, 2787614692, 2840435697, 2863040948, 2894173535, 4214792954], groups=[FID[2787614692, 880792005], SIM[2787614692, 4214792954, 2863040948], FID[4214792954, 2840435697], FID[2863040948, 2894173535]]], 9639213097@conference.test.com/78d53afb=[audio=[1827672853], video=[1302544479, 1747352594, 2767858754, 3217204104, 3711633493, 3743199869], groups=[FID[1302544479, 3711633493], SIM[1302544479, 2767858754, 3743199869], FID[2767858754, 3217204104], FID[3743199869, 1747352594]]], jvb=[audio=[324322772], video=[259119290], groups=[]], 9639213097@conference.test.com/eed8ea01=[audio=[1446399465], video=[286446639, 339765968, 731704859, 770180038, 1855128653, 3766275510], groups=[FID[1855128653, 339765968], SIM[1855128653, 770180038, 731704859], FID[770180038, 286446639], FID[731704859, 3766275510]]]}
Jicofo 2022-11-21 17:00:06.432 INFO: [26312] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] JitsiMeetConferenceImpl.onSessionAccept#938: Receive session-accept from 9639213097@conference.test.com/bab42c11
Jicofo 2022-11-21 17:00:06.432 INFO: [26312] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] JitsiMeetConferenceImpl.onSessionAcceptInternal#1290: Accepted initial sources from bab42c11: {9639213097@conference.test.com/bab42c11=[audio=[], video=[], groups=[]]}
Jicofo 2022-11-21 17:00:06.432 INFO: [26312] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] ColibriV2SessionManager.updateParticipant#473: Updating Participant[9639213097@conference.test.com/bab42c11]@1376952270 with transport=org.jitsi.xmpp.extensions.jingle.IceUdpTransportPacketExtension@5821327, sources={9639213097@conference.test.com/bab42c11=[audio=[], video=[], groups=[]]}
Jicofo 2022-11-21 17:00:06.436 INFO: [26312] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] ColibriV2SessionManager.updateParticipant#473: Updating Participant[9639213097@conference.test.com/bab42c11]@1376952270 with transport=org.jitsi.xmpp.extensions.jingle.IceUdpTransportPacketExtension@14a774d4, sources=null
Jicofo 2022-11-21 17:00:06.436 INFO: [26312] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] ColibriV2SessionManager.updateParticipant#473: Updating Participant[9639213097@conference.test.com/bab42c11]@1376952270 with transport=null, sources={9639213097@conference.test.com/bab42c11=[audio=[], video=[1373920249, 1394222082, 2221754500, 2424479632, 3263696669, 3360224830], groups=[FID[2424479632, 1373920249], SIM[2424479632, 1394222082, 2221754500], FID[1394222082, 3360224830], FID[2221754500, 3263696669]]]}
Jicofo 2022-11-21 17:00:06.436 INFO: [34] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=78d53afb] Participant.sendQueuedRemoteSources#585: Sending a queued source-add, sources:{9639213097@conference.test.com/bab42c11=[audio=[], video=[1373920249, 2424479632], groups=[FID[2424479632, 1373920249]]]}
Jicofo 2022-11-21 17:00:06.436 INFO: [15] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=eed8ea01] Participant.sendQueuedRemoteSources#585: Sending a queued source-add, sources:{9639213097@conference.test.com/bab42c11=[audio=[], video=[1373920249, 2424479632], groups=[FID[2424479632, 1373920249]]]}
Jicofo 2022-11-21 17:00:06.436 INFO: [34] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=14e333e4] Participant.sendQueuedRemoteSources#585: Sending a queued source-add, sources:{9639213097@conference.test.com/bab42c11=[audio=[], video=[1373920249, 2424479632], groups=[FID[2424479632, 1373920249]]]}
Jicofo 2022-11-21 17:00:06.436 INFO: [15] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=291b3b34] Participant.sendQueuedRemoteSources#585: Sending a queued source-add, sources:{9639213097@conference.test.com/bab42c11=[audio=[], video=[1373920249, 2424479632], groups=[FID[2424479632, 1373920249]]]}
Jicofo 2022-11-21 17:00:06.845 INFO: [26312] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] ColibriV2SessionManager.updateParticipant#473: Updating Participant[9639213097@conference.test.com/bab42c11]@1376952270 with transport=null, sources={9639213097@conference.test.com/bab42c11=[audio=[1236438338], video=[1373920249, 1394222082, 2221754500, 2424479632, 3263696669, 3360224830], groups=[FID[2424479632, 1373920249], SIM[2424479632, 1394222082, 2221754500], FID[1394222082, 3360224830], FID[2221754500, 3263696669]]]}
Jicofo 2022-11-21 17:00:06.845 INFO: [34] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=14e333e4] Participant.sendQueuedRemoteSources#585: Sending a queued source-add, sources:{9639213097@conference.test.com/bab42c11=[audio=[1236438338], video=[], groups=[]]}
Jicofo 2022-11-21 17:00:06.845 INFO: [35] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=78d53afb] Participant.sendQueuedRemoteSources#585: Sending a queued source-add, sources:{9639213097@conference.test.com/bab42c11=[audio=[1236438338], video=[], groups=[]]}
Jicofo 2022-11-21 17:00:06.845 INFO: [15] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=291b3b34] Participant.sendQueuedRemoteSources#585: Sending a queued source-add, sources:{9639213097@conference.test.com/bab42c11=[audio=[1236438338], video=[], groups=[]]}
Jicofo 2022-11-21 17:00:06.845 INFO: [35] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=eed8ea01] Participant.sendQueuedRemoteSources#585: Sending a queued source-add, sources:{9639213097@conference.test.com/bab42c11=[audio=[1236438338], video=[], groups=[]]}

In an error situation, all participants in the meeting receive a new participant’s source-add signal only once. Some participants receive both audio and video, but some receives only video(without audio) like below

Jicofo 2022-11-21 17:00:01.569 INFO: [26312] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] JitsiMeetConferenceImpl.onMemberJoined#590: Member joined:78d53afb stats-id=Dawson-b4I region=null audioMuted=true videoMuted=true isJibri=false isJigasi=false
Jicofo 2022-11-21 17:00:01.570 INFO: [26312] DiscoveryUtil.discoverParticipantFeatures#166: Discovered features for 9639213097@conference.test.com/78d53afb in 0 ms.
Jicofo 2022-11-21 17:00:01.570 INFO: [26312] DiscoveryUtil.discoverParticipantFeatures#180: Successfully discovered features for 9639213097@conference.test.com/78d53afb in 0
Jicofo 2022-11-21 17:00:01.570 INFO: [26319] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] ColibriV2SessionManager.allocate#253: Allocating for 78d53afb
Jicofo 2022-11-21 17:00:01.570 INFO: [26319] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] ColibriV2SessionManager.allocate#296: Selected 9f066300-d6f5-4e90-90f2-5a84cee325a6, session exists: true
Jicofo 2022-11-21 17:00:01.575 INFO: [26319] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=78d53afb] ParticipantInviteRunnable.doInviteOrReinvite#379: Sending session-initiate to: 9639213097@conference.test.com/78d53afb sources={9639213097@conference.test.com/14e333e4=[audio=[1100075411], video=[3429090865, 2063799735, 2112586487, 452006279, 684090528, 734593588], groups=[FID[3429090865, 2063799735], SIM[3429090865, 2112586487, 452006279], FID[2112586487, 684090528], FID[452006279, 734593588]]], 9639213097@conference.test.com/291b3b34=[audio=[2588028662], video=[880792005, 2787614692, 2840435697, 2863040948, 2894173535, 4214792954], groups=[FID[2787614692, 880792005], SIM[2787614692, 4214792954, 2863040948], FID[4214792954, 2840435697], FID[2863040948, 2894173535]]], jvb=[audio=[324322772], video=[259119290], groups=[]], 9639213097@conference.test.com/eed8ea01=[audio=[1446399465], video=[286446639, 339765968, 731704859, 770180038, 1855128653, 3766275510], groups=[FID[1855128653, 339765968], SIM[1855128653, 770180038, 731704859], FID[770180038, 286446639], FID[731704859, 3766275510]]]}
Jicofo 2022-11-21 17:00:02.192 INFO: [26312] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] JitsiMeetConferenceImpl.onSessionAccept#938: Receive session-accept from 9639213097@conference.test.com/78d53afb
Jicofo 2022-11-21 17:00:02.192 INFO: [26312] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] JitsiMeetConferenceImpl.onSessionAcceptInternal#1290: Accepted initial sources from 78d53afb: {9639213097@conference.test.com/78d53afb=[audio=[], video=[], groups=[]]}
Jicofo 2022-11-21 17:00:02.192 INFO: [26312] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] ColibriV2SessionManager.updateParticipant#473: Updating Participant[9639213097@conference.test.com/78d53afb]@869044586 with transport=org.jitsi.xmpp.extensions.jingle.IceUdpTransportPacketExtension@57a8c380, sources={9639213097@conference.test.com/78d53afb=[audio=[], video=[], groups=[]]}
Jicofo 2022-11-21 17:00:02.193 INFO: [26312] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] ColibriV2SessionManager.updateParticipant#473: Updating Participant[9639213097@conference.test.com/78d53afb]@869044586 with transport=null, sources={9639213097@conference.test.com/78d53afb=[audio=[], video=[1302544479, 1747352594, 2767858754, 3217204104, 3711633493, 3743199869], groups=[FID[1302544479, 3711633493], SIM[1302544479, 2767858754, 3743199869], FID[2767858754, 3217204104], FID[3743199869, 1747352594]]]}
Jicofo 2022-11-21 17:00:02.193 INFO: [26312] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] ColibriV2SessionManager.updateParticipant#473: Updating Participant[9639213097@conference.test.com/78d53afb]@869044586 with transport=null, sources={9639213097@conference.test.com/78d53afb=[audio=[1827672853], video=[1302544479, 1747352594, 2767858754, 3217204104, 3711633493, 3743199869], groups=[FID[1302544479, 3711633493], SIM[1302544479, 2767858754, 3743199869], FID[2767858754, 3217204104], FID[3743199869, 1747352594]]]}
Jicofo 2022-11-21 17:00:02.193 INFO: [34] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=14e333e4] Participant.sendQueuedRemoteSources#585: Sending a queued source-add, sources:{9639213097@conference.test.com/78d53afb=[audio=[], video=[1302544479, 3711633493], groups=[FID[1302544479, 3711633493]]]}
Jicofo 2022-11-21 17:00:02.194 INFO: [15] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=291b3b34] Participant.sendQueuedRemoteSources#585: Sending a queued source-add, sources:{9639213097@conference.test.com/78d53afb=[audio=[], video=[1302544479, 3711633493], groups=[FID[1302544479, 3711633493]]]}
Jicofo 2022-11-21 17:00:02.194 INFO: [34] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=eed8ea01] Participant.sendQueuedRemoteSources#585: Sending a queued source-add, sources:{9639213097@conference.test.com/78d53afb=[audio=[], video=[1302544479, 3711633493], groups=[FID[1302544479, 3711633493]]]}
Jicofo 2022-11-21 17:00:02.194 INFO: [34] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=291b3b34] Participant.sendQueuedRemoteSources#585: Sending a queued source-add, sources:{9639213097@conference.test.com/78d53afb=[audio=[1827672853], video=[], groups=[]]}
Jicofo 2022-11-21 17:00:02.194 INFO: [34] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5 participant=eed8ea01] Participant.sendQueuedRemoteSources#585: Sending a queued source-add, sources:{9639213097@conference.test.com/78d53afb=[audio=[1827672853], video=[], groups=[]]}
Jicofo 2022-11-21 17:00:02.603 INFO: [26312] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] ColibriV2SessionManager.updateParticipant#473: Updating Participant[9639213097@conference.test.com/78d53afb]@869044586 with transport=org.jitsi.xmpp.extensions.jingle.IceUdpTransportPacketExtension@312ffe68, sources=null
Jicofo 2022-11-21 17:00:05.642 INFO: [26323] ConferenceIqHandler.handleConferenceIq#63: Focus request for room: 9639213097@conference.test.com
Jicofo 2022-11-21 17:00:05.691 INFO: [26317] [room=9639213097@conference.test.com meeting_id=3d139cce-86a2-42e0-a7fa-6531c3eb93f5] JitsiMeetConferenceImpl.onMemberJoined#590: Member joined:bab42c11 stats-id=Earnestine-ATe region=null audioMuted=true videoMuted=true isJibri=false isJigasi=false

as a result above error situation, some participants could hear new participant’s voice, but some couldn’t
I’ve tried to solve this situation, but it’s difficult. I’d really appreciate your help.

comment for history
this issue resolved by fix: update sourcesignaling when received simultaneously source-add by tinyhhj · Pull Request #1009 · jitsi/jicofo · GitHub