[sip-comm] Problems with call status "Ringing"


#1

Hi,

This is about the function processResponse in SipManager.

Since all "provisional responses" are handled in the case TRYING, the case
of RINGING never occurs. A change of the order of the TRYING and RINGING
cases is an easy fix.

- �sa Karlsson

···

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: users-help@sip-communicator.dev.java.net


#2

Nice catch Asa,

I've fixed, committed to CVS, and ack-ed ur effort.

Thanks :slight_smile:
Emil

�sa Karlsson wrote:

···

Hi,

This is about the function processResponse in SipManager.

Since all "provisional responses" are handled in the case TRYING, the case
of RINGING never occurs. A change of the order of the TRYING and RINGING
cases is an easy fix.

- �sa Karlsson

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: users-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: users-help@sip-communicator.dev.java.net


#3

Hi,
I don't known if this happen only to me.
Every time I click Dial, the status 'Ringing' only play once then it is soon
overridden after entering
processTrying, thus making the Status back to Dialing and no ringing tone
heard.

I then added this line to CallProcessing.java and then it works fine.

            //change status
- if (!call.getState().equals(Call.MOVING_LOCALLY))
+ if (!call.getState().equals(Call.MOVING_LOCALLY) &&
!call.getState().equals(Call.RINGING))
                call.setState(Call.DIALING);

Is this ok or I'll have other problem elsewhere from this. This far, I get
no other side effect. Yet :slight_smile:
Advice please.

Regards,
Hendro Lim

···

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: users-help@sip-communicator.dev.java.net


#4

Hi,
I don't known if this happen only to me.
Every time I click Dial, the status 'Ringing' only play once then it is soon
overridden after entering
processTrying, thus making the Status back to Dialing and no ringing tone
heard.
(even after I applied Asa's update)

I then added this line to CallProcessing.java and then it works fine.

            //change status
- if (!call.getState().equals(Call.MOVING_LOCALLY))
+ if (!call.getState().equals(Call.MOVING_LOCALLY) &&
+ !call.getState().equals(Call.RINGING))
                call.setState(Call.DIALING);

Is this ok or I'll have other problem elsewhere from this. This far, I get
no other side effect. Yet :slight_smile: Advice please.

Regards,
Hendro Lim

···

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: users-help@sip-communicator.dev.java.net


#5

Hello Hendro,

The bug has been reported (and fixed) a couple of hours earlier by Asa Karlsson. The problem was actually SipManager.processResponse method was treating generic non-final responses befor the ringing response.

Anyways it's now all ok and you can CVS update.

Cheers
Emil

Hendro Lim wrote:

···

Hi,
I don't known if this happen only to me.
Every time I click Dial, the status 'Ringing' only play once then it is soon
overridden after entering processTrying, thus making the Status back to Dialing and no ringing tone
heard.
(even after I applied Asa's update)

I then added this line to CallProcessing.java and then it works fine.

            //change status
- if (!call.getState().equals(Call.MOVING_LOCALLY))
+ if (!call.getState().equals(Call.MOVING_LOCALLY) && + !call.getState().equals(Call.RINGING))
                call.setState(Call.DIALING);

Is this ok or I'll have other problem elsewhere from this. This far, I get
no other side effect. Yet :slight_smile: Advice please.

Regards,
Hendro Lim

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: users-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: users-help@sip-communicator.dev.java.net