[sip-comm] fix to work with sipxpbx


#1

I filed the issue as a defect even though it is really not, but just a
compatibility issue, and from/to should really just identify the user
anyways. Via and Contact would have port and transport anyways.
thanks,
dean

···

-----Original Message-----

From: Emil Ivov [mailto:emil_ivov@yahoo.com]

Sent: Friday, November 18, 2005 3:24 AM
To: users@sip-communicator.dev.java.net
Subject: Re: [sip-comm] fix to work with sipxpbx

Hello Jean-Baptiste,

You are right,

we'd need to take care of that. Could you please start an issue in the
issue tracker, so that we don't let it slip away?

We so far have three i think:
1) don't include port number and transport in from headers - Dean
2) make sure 1) does not harm reregistrations - Jean-Baptiste
3) only include domain name in requests' sip uri - Litty

could the guys that reported each of those start corresponding issues in
the sip-communicator-1-0-draft issue tracker?

Thanks!
Emil

Jean-Baptiste Mounier wrote:

Hello,

Well of course I can be wrong but I am talking of this piece of code
from the RegisterProcessing class :

void processOK(ClientTransaction clientTransatcion, Response response)

    {

        try {

            console.logEntry();

            isRegistered = true;

            FromHeader fromHeader = ( (FromHeader)
response.getHeader(FromHeader.NAME));

            Address address = fromHeader.getAddress();

            …

            if (expires > 0) {

               //[issue 2] Schedule re registrations

               //bug reported by LynlvL@netscape.com

               //use the value returned by the server to reschedule
registration

              SipURI uri = (SipURI) address.getURI();

              scheduleReRegistration(uri.getHost(), uri.getPort(),
uri.getTransportParam(), expires);

            }

            sipManCallback.fireRegistered(address.toString());

        }

        finally {

            console.logExit();

        }

    }

Hope I am not creating more confusion :wink:

Jean-Baptiste

------------------------------------------------------------------------

*From:* Litty Preeth [mailto:iamlitty@yahoo.com]
*Sent:* 18. marraskuuta 2005 11:31
*To:* users@sip-communicator.dev.java.net
*Subject:* RE: [sip-comm] fix to work with sipxpbx

Hi Jean

Its not true. RegisterProcessor is not using the from header for the
purpose. But it passes the same arguments that is passed to the
register() function.Also i have tested with the expire time set to 5
secs and still the appln didnt collapse(ofcourse i waited for more than
5 sec). And i dont think sip communicator is using the port and
transport of the from header anywhere else. Well may be the version of
sip-communicator that we two are having are different.

With Regards,
Litty Preeth

*/Jean-Baptiste Mounier <jean-baptiste.mounier@plenware.com>/* wrote:

Hello,

Be carefull with this kind of fixes, I also removed those 2 lines (so
setting port and transport in the fromURI) and the application crashed

while

performing a re-registration (after reaching the register "expires" time).

An easy way to test is to set the "REGISTRATIONS_EXPIRATION" in the conf
file to few seconds.

The problem is that in the "RegisterProcessing" class the "processOK"

method

is using the "from" address to discover the port and transport values to
pass to the "scheduleReRegistration" method ... which triggers a null
pointer exception.

I guess that we could easily fix this as well by picking the port and
transport value from somewhere else (like registrar values) but can we be
sure that removing the port and transport from the fromURI won't create

new

bugs in other places ...

Jean-Baptiste

-----Original Message-----
From: Emil Ivov [mailto:emil_ivov@yahoo.com]
Sent: 18. marraskuuta 2005 0:36
To: users@sip-communicator.dev.java.net
Subject: Re: [sip-comm] fix to work with sipxpbx

Hello Dean, Litty, all
> So, I took out these two lines*> >
fromURI.setTransportParam(listeningPoint.getTransport());
> fromURI.setPort(listeningPoint.getPort());
> from SipManager.java and sip-comm now registers with sipxpbx just

fine.

> Do we really need these two lines?

No we don't, you're absolutely right. I even think this has already been
discussed once in the past (but it might have been on the nist-sip

list).

I am currently focusing on the ICQ bundle for sip-communicator 1.0. I
guess I'll have it up and running near the end of next week, and I'll
get to the sip bundle right after that.

Until then, guys could you please create issues in the issue tracker for
the sip-communicator-1-0-draft project for this and the SipURI problems
so that they don't sleep out of mind?

Thanks
Emil

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:

users-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:

users-help@sip-communicator.dev.java.net***

* *

*
------------------------------------------------------------------------
*

*Yahoo! FareChase - Search multiple travel sites in one click.

<http://us.lrd.yahoo.com/_ylc=X3oDMTFqODRtdXQ4BF9TAzMyOTc1MDIEX3MDOTY2ODgxNj
kEcG9zAzEEc2VjA21haWwtZm9vdGVyBHNsawNmYw--/SIG=110oav78o/**http%3a/farechase
.yahoo.com/>

*

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: users-help@sip-communicator.dev.java.net