[sip-comm-dev] ZRTP jar file and a small fix


#1

Romain,

while you are integrating the latest ZRTP stuff:
attached is the latest version (only a small enhancement
in the code, a small fix in error reporting - sometimes
it's good to look ate the code while you write some
description/documentation :slight_smile: ).

Also a small fix in ZRTPTransformerEngine. At line 766

     public void srtpSecretsOn(String c, String s, boolean verified)
     {

       if (userCallback != null)
       {
         userCallback.secureOn(c);
       }
       if (userCallback != null)
       {
         userCallback.showSAS(s, verified);
       }
     }

can you please modify the second if statement to

   if (userCallback != null && s != null)

Thanks. The SAS string may be null in multi-stream mode.

Regards,
Werner

zrtp4j-1.3.1.jar (75.7 KB)


#2

Hi Werner,

I have updated the ZRTP4J jar to version 1.3.1 (and also updated all references from 0.9.0 to 1.3.1 in build.xml and netbeans/eclipse project files). I've also applied the patch you sent in your previous mail that comment the refences to the goClear/goSecure parts in SCCallback and ZRTPTransformEngine. I've also apply the fix you proposed below, and acked your contributions!

Thanks!
Romain

···

On 2008/10/21, at 17:30, Werner Dittmann wrote:

Romain,

while you are integrating the latest ZRTP stuff:
attached is the latest version (only a small enhancement
in the code, a small fix in error reporting - sometimes
it's good to look ate the code while you write some
description/documentation :slight_smile: ).

Also a small fix in ZRTPTransformerEngine. At line 766

   public void srtpSecretsOn(String c, String s, boolean verified)
   {

     if (userCallback != null)
     {
       userCallback.secureOn(c);
     }
     if (userCallback != null)
     {
       userCallback.showSAS(s, verified);
     }
   }

can you please modify the second if statement to

if (userCallback != null && s != null)

Thanks. The SAS string may be null in multi-stream mode.

Regards,
Werner
<zrtp4j-1.3.1.jar>---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net