[sip-comm-dev] White-window-bug update


#1

Hi all,
After a little digging through the repository and the commit logs I
found that the white-window-bug is caused by the changes to the
ensureDocumentSize() method in ChatConversationPanel in revision 1.10
of the file (details here:
https://sip-communicator.dev.java.net/source/browse/sip-communicator/src/net/java/sip/communicator/impl/gui/main/chat/ChatConversationPanel.java?r1=1.9&r2=1.10&diff_format=l
)
For the moment I can't come with a fix because:
  a) I'm not very familiar with the GUI code, and even less with the
HTML magic in our renderer
  b) don't know what were the reasons for which Yana made those modifications.

So I would gently ask Yana to have a look at the code and at least
give me a few guidelines or hints.

All the best,
Mihai

PS: Attached is a patch file that fixes smiley processing in HTML messages.

smileyPatch.patch (2.66 KB)


#2

Hi Mihai,

nice catch! I'll have a look at the code tomorrow morning and will let you know as soon as I find the problem.

Thanks!

Yana

Mihai Balan wrote:

···

Hi all,
After a little digging through the repository and the commit logs I
found that the white-window-bug is caused by the changes to the
ensureDocumentSize() method in ChatConversationPanel in revision 1.10
of the file (details here:
https://sip-communicator.dev.java.net/source/browse/sip-communicator/src/net/java/sip/communicator/impl/gui/main/chat/ChatConversationPanel.java?r1=1.9&r2=1.10&diff_format=l
)
For the moment I can't come with a fix because:
  a) I'm not very familiar with the GUI code, and even less with the
HTML magic in our renderer
  b) don't know what were the reasons for which Yana made those modifications.

So I would gently ask Yana to have a look at the code and at least
give me a few guidelines or hints.

All the best,
Mihai

PS: Attached is a patch file that fixes smiley processing in HTML messages.

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net