[sip-comm-dev] Weekly warnings fix


#1

Hi all,

In attachement patch that fix code and javadoc warnings ;).

I want to say that contributors / commiters should take some time to check their code before submit / commit to fix warnings. I know it could be painful to do it (someone say "lake of time",...) but really take 5 min to do it. If we don't do this, SIP Communicator will reach thousands warnings again in a few month. And fix 10 warnings in 5 min is very easy... fix more than thousands is really really painful believe me.

Just my two euro cents,

Best regards,

sip-communicator-warnings.diff (10.4 KB)

···

--
Sebastien


#2

Hi Sebastien,

I'm terribly sorry for the new warnings, at least a part of them were mine because of the Facebook patch I integrated.

So that I can try to do better next time, could you please share with us how you discover the Javadoc warnings. I know there's a Javadoc preference page in Eclipse SDK which is configured by default to ignore such warnings and I'm not sure which preferences to check when I enable it.

Thank you,
Lubomir

···

On 23.09.2009 11:35, Sebastien Vincent wrote:

Hi all,

In attachement patch that fix code and javadoc warnings ;).

I want to say that contributors / commiters should take some time to
check their code before submit / commit to fix warnings. I know it could
be painful to do it (someone say "lake of time",...) but really take 5
min to do it. If we don't do this, SIP Communicator will reach thousands
warnings again in a few month. And fix 10 warnings in 5 min is very
easy... fix more than thousands is really really painful believe me.

Just my two euro cents,

Best regards,
--
Sebastien

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi,

Sebastien, thanks for taking care of all the warnings that have piled up during the last months!!

I've also introduced some warnings lately (with my last commit on ad hoc chat rooms) and I'm sorry for that! I'll take care of them when applying the second part of Valentin's work on the subject.

Cheers,
Yana

···

On Sep 23, 2009, at 1:20 PM, Lubomir Marinov wrote:

Hi Sebastien,

I'm terribly sorry for the new warnings, at least a part of them were mine because of the Facebook patch I integrated.

So that I can try to do better next time, could you please share with us how you discover the Javadoc warnings. I know there's a Javadoc preference page in Eclipse SDK which is configured by default to ignore such warnings and I'm not sure which preferences to check when I enable it.

Thank you,
Lubomir

On 23.09.2009 11:35, Sebastien Vincent wrote:

Hi all,

In attachement patch that fix code and javadoc warnings ;).

I want to say that contributors / commiters should take some time to
check their code before submit / commit to fix warnings. I know it could
be painful to do it (someone say "lake of time",...) but really take 5
min to do it. If we don't do this, SIP Communicator will reach thousands
warnings again in a few month. And fix 10 warnings in 5 min is very
easy... fix more than thousands is really really painful believe me.

Just my two euro cents,

Best regards,
--
Sebastien

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi Lubomir,

···

On Wed, 23 Sep 2009 14:20:52 +0300, Lubomir Marinov <lubomir.marinov@gmail.com> wrote:

Hi Sebastien,

I'm terribly sorry for the new warnings, at least a part of them were
mine because of the Facebook patch I integrated.

So that I can try to do better next time, could you please share with us
how you discover the Javadoc warnings. I know there's a Javadoc
preference page in Eclipse SDK which is configured by default to ignore
such warnings and I'm not sure which preferences to check when I enable

it.

I run "ant javadoc" via command line.

--
Sebastien

Thank you,
Lubomir

On 23.09.2009 11:35, Sebastien Vincent wrote:

Hi all,

In attachement patch that fix code and javadoc warnings ;).

I want to say that contributors / commiters should take some time to
check their code before submit / commit to fix warnings. I know it could
be painful to do it (someone say "lake of time",...) but really take 5
min to do it. If we don't do this, SIP Communicator will reach thousands
warnings again in a few month. And fix 10 warnings in 5 min is very
easy... fix more than thousands is really really painful believe me.

Just my two euro cents,

Best regards,
--
Sebastien

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net