[sip-comm-dev] Upgrade of the dict protocol


#1

Hi,

Since I got some times while watching the TV (Euro 2008), I write a
little upgrade for the DICT protocol.

It will name the contacts with the full dictionary name and not the
dictionary "code".

There is still a little problem : the name of the olds ones in the
contact list and in the chat window aren't renamed. I think it's
because the name of the contacts is stored in the contactlist file.

@+

Damien

dict_name.patch (3.32 KB)


#2

Hi Damien,

Thank you to keep on improving the SIP-Communicator and the DICT protocol :slight_smile:
Your patch is (finally) applied and acked.

There is a little review of the changed I brought:
1) Please verify your editor is using 4 spaces in order of the "tab" character. Please use the formatter http://www.sip-communicator.org/wiki/pub/sip-communicator/Formatter if you are developing under "Eclipse". Or if you are developping under "vim" use the following commands in your ".vimrc":

" determines how far something shifts when you use >> or <<
set shiftwidth=4
" determines how many spaces your tabs shift text on your screen
set tabstop=4
" use only spaces instead of tab characters when you hit <tab>
set expandtab

2) Be sure to comment every new attributes: here the "dictName" in "src/net/java/sip/communicator/impl/protocol/dict/ContactDictImpl.java" was found lonely and abandoned without any comments ... snif (this is surely the fault of the TV-Euro2008).

3) I have resolved a little bug when the description contained space character. For example, your patch for the dictionary "gcide" was renaming with "The" in order of "The Collaborative International Dictionary of English v.0.48".

Otherwise, it is a very good work!

Thank you once again,
Vincent

Damien Roth wrote:

ยทยทยท

Hi,

Since I got some times while watching the TV (Euro 2008), I write a
little upgrade for the DICT protocol.

It will name the contacts with the full dictionary name and not the
dictionary "code".

There is still a little problem : the name of the olds ones in the
contact list and in the chat window aren't renamed. I think it's
because the name of the contacts is stored in the contactlist file.

@+

Damien

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net