[sip-comm-dev] Update debian installer (issue 709), warnings and typo


#1

Hi,

Here is a patch against r6194 of trunk repository. It removes the non-free
sun-java6-jre dependancy and put openjdk-6-jre instead. The other effect is
that sip-communicator can be in "net" section of Debian repository (before
it was in contrib/net because of non-free package dependancy).

I fix also a few redundant cast warnings and a typo.

BTW is anyone is aware of the SRTP stuff to tell us if warning at
/src/net/java/sip/communicator/impl/media/transform/srtp/SRTPCryptoContext.java:242:
(warning: [fallthrough] possible fall-through into case case
SRTPPolicy.AESCM_ENCRYPTION) is correct or not and put a
@SuppressWarnings("fallthrough") ?

Excluding the previous warning, it stay two warnings with
sun.awt.shell.ShellFolder which a SUN proprietary API. I will see if I can
find something to replace it.

Best regards,

sip-communicator-debian-warnings-typo.diff (2.8 KB)

···

--
Sebastien


#2

Hey Seb,

Sebastien Vincent wrote:

Hi,

Here is a patch against r6194 of trunk repository. It removes the non-free
sun-java6-jre dependancy and put openjdk-6-jre instead.

Cool! I am thinking we better keep sun-java6-jre as a possible
alternative though. Just in case we get installed on a machine that
already has Sun's JDK and not openjdk (since in this case we don't want
to be unnecessarily downloading stuff).

The other effect is
that sip-communicator can be in "net" section of Debian repository (before
it was in contrib/net because of non-free package dependancy).

Cool!

BTW is anyone is aware of the SRTP stuff to tell us if warning at
/src/net/java/sip/communicator/impl/media/transform/srtp/SRTPCryptoContext.java:242:
(warning: [fallthrough] possible fall-through into case case
SRTPPolicy.AESCM_ENCRYPTION) is correct or not and put a
@SuppressWarnings("fallthrough") ?

That one has been puzzling me too. I've been meaning to ask Werner for a
while now but keep forgetting.

Cheers,
Emil

···

Excluding the previous warning, it stay two warnings with
sun.awt.shell.ShellFolder which a SUN proprietary API. I will see if I can
find something to replace it.

Best regards,
--
Sebastien

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hey Seb,

Sebastien Vincent wrote:

Hi,

Here is a patch against r6194 of trunk repository. It removes the
non-free
sun-java6-jre dependancy and put openjdk-6-jre instead.

Cool! I am thinking we better keep sun-java6-jre as a possible
alternative though. Just in case we get installed on a machine that
already has Sun's JDK and not openjdk (since in this case we don't want
to be unnecessarily downloading stuff).

Yes. In attachement new patch (with warnings and typo too).

The other effect is
that sip-communicator can be in "net" section of Debian repository
(before
it was in contrib/net because of non-free package dependancy).

Cool!

BTW is anyone is aware of the SRTP stuff to tell us if warning at

/src/net/java/sip/communicator/impl/media/transform/srtp/SRTPCryptoContext.java:242:

sip-communicator-debian-warnings-typo.diff (2.81 KB)

···

On Tue, 27 Oct 2009 15:30:48 +0100, Emil Ivov <emcho@sip-communicator.org> wrote:

(warning: [fallthrough] possible fall-through into case case
SRTPPolicy.AESCM_ENCRYPTION) is correct or not and put a
@SuppressWarnings("fallthrough") ?

That one has been puzzling me too. I've been meaning to ask Werner for a
while now but keep forgetting.

Cheers,
Emil

Excluding the previous warning, it stay two warnings with
sun.awt.shell.ShellFolder which a SUN proprietary API. I will see if I
can
find something to replace it.

Best regards,
--
Sebastien

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net