[sip-comm-dev] Typo in the LATENCY_UNSEPCIFIED static field?


#1

Hi,

I've noticed that the LATENCY_UNSEPCIFIED field is defined in impl/media/protocol/portaudio/PortAudio.java and used in several places in portaudio. Is there any reason why it is not spelled LATENCY_UNSPECIFIED instead? I can commit a fix if it's a mistake.

Cheers,
romain

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Romain,

It's mistakenly written that way and it should be safe to change it to the correct spelling. However, please note that the media package isn't of much interest any more because neomedia is replacing it and thus neomedia is the place where its fix is more necessary.

Best regards,
Lubomir

···

On 10.12.2009 00:15, Romain KUNTZ wrote:

Hi,

I've noticed that the LATENCY_UNSEPCIFIED field is defined in impl/media/protocol/portaudio/PortAudio.java and used in several places in portaudio. Is there any reason why it is not spelled LATENCY_UNSPECIFIED instead? I can commit a fix if it's a mistake.

Cheers,
romain

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi Lubomir,

I've fixed it everywhere. The JNI header file was also changed, but it seems that there's no need to recompile the native library (it does not seem to use the LATENCY_UNSPECIFIED field). Let me know if I'm wrong.

Cheers,
romain

···

On 2009/12/09, at 23:26, Lubomir Marinov wrote:

Hi Romain,

It's mistakenly written that way and it should be safe to change it to the correct spelling. However, please note that the media package isn't of much interest any more because neomedia is replacing it and thus neomedia is the place where its fix is more necessary.

Best regards,
Lubomir

On 10.12.2009 00:15, Romain KUNTZ wrote:

Hi,

I've noticed that the LATENCY_UNSEPCIFIED field is defined in impl/media/protocol/portaudio/PortAudio.java and used in several places in portaudio. Is there any reason why it is not spelled LATENCY_UNSPECIFIED instead? I can commit a fix if it's a mistake.

Cheers,
romain

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi,

yes its not used. This entry in the JNI header file is just created by
the javah tool as it exists in the class file but its not used in the
C source. Just for info - I noticed that javah 1.5 doen't create this
entries, but javah 1.6 creates them.
Yes I think there is no need to recompile all the portaudio libs.

Thanks for taking care of this
damencho

···

On Thu, Dec 10, 2009 at 11:27 AM, Romain KUNTZ <kuntz@unistra.fr> wrote:

Hi Lubomir,

I've fixed it everywhere. The JNI header file was also changed, but it seems that there's no need to recompile the native library (it does not seem to use the LATENCY_UNSPECIFIED field). Let me know if I'm wrong.

Cheers,
romain

On 2009/12/09, at 23:26, Lubomir Marinov wrote:

Hi Romain,

It's mistakenly written that way and it should be safe to change it to the correct spelling. However, please note that the media package isn't of much interest any more because neomedia is replacing it and thus neomedia is the place where its fix is more necessary.

Best regards,
Lubomir

On 10.12.2009 00:15, Romain KUNTZ wrote:

Hi,

I've noticed that the LATENCY_UNSEPCIFIED field is defined in impl/media/protocol/portaudio/PortAudio.java and used in several places in portaudio. Is there any reason why it is not spelled LATENCY_UNSPECIFIED instead? I can commit a fix if it's a mistake.

Cheers,
romain

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

As I was writing that they are not used Lubomir removed them :wink:
Thanks Lubo

···

On Thu, Dec 10, 2009 at 11:33 AM, Damian Minkov <damencho@sip-communicator.org> wrote:

Hi,

yes its not used. This entry in the JNI header file is just created by
the javah tool as it exists in the class file but its not used in the
C source. Just for info - I noticed that javah 1.5 doen't create this
entries, but javah 1.6 creates them.
Yes I think there is no need to recompile all the portaudio libs.

Thanks for taking care of this
damencho

On Thu, Dec 10, 2009 at 11:27 AM, Romain KUNTZ <kuntz@unistra.fr> wrote:

Hi Lubomir,

I've fixed it everywhere. The JNI header file was also changed, but it seems that there's no need to recompile the native library (it does not seem to use the LATENCY_UNSPECIFIED field). Let me know if I'm wrong.

Cheers,
romain

On 2009/12/09, at 23:26, Lubomir Marinov wrote:

Hi Romain,

It's mistakenly written that way and it should be safe to change it to the correct spelling. However, please note that the media package isn't of much interest any more because neomedia is replacing it and thus neomedia is the place where its fix is more necessary.

Best regards,
Lubomir

On 10.12.2009 00:15, Romain KUNTZ wrote:

Hi,

I've noticed that the LATENCY_UNSEPCIFIED field is defined in impl/media/protocol/portaudio/PortAudio.java and used in several places in portaudio. Is there any reason why it is not spelled LATENCY_UNSPECIFIED instead? I can commit a fix if it's a mistake.

Cheers,
romain

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net