[sip-comm-dev] Trunk build failed


#1

Hi,

I checked out the latest revision of sip-communicator, and tried to make it run with 'ant make run', but I have 4 errors and 904 warnings.
The 4 error is regarding to net/java/sip/communicator/impl/gui/main/chat/ChatPanel.java:

ChatPanel.java:943: reference to SwingWorker is ambiguous,
both class net.java.sip.communicator.util.swing.SwingWorker in net.java.sip.communicator.util.swing and class javax.swing.SwingWorker in javax.swing match
     [javac] SwingWorker worker = new SwingWorker()

and the same message for line 1387.

The most of the warnings are 'unchecked', but there are some 'deprecation' and 'fallthrough' warnings too.
Can't you just suppress the unchecked warnings with
@SuppressWarnings("unchecked")
?
You can apply this annotation on classes, or methods too.

Best Regards,
Peter Major

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Peter,

The 4 error is regarding to
net/java/sip/communicator/impl/gui/main/chat/ChatPanel.java:

ChatPanel.java:943: reference to SwingWorker is ambiguous,
both class net.java.sip.communicator.util.swing.SwingWorker in
net.java.sip.communicator.util.swing and class javax.swing.SwingWorker in
javax.swing match
[javac] SwingWorker worker = new SwingWorker()

and the same message for line 1387.

Thank you!

I just committed r5883 which disambiguates SwingWorker. The problem is
that SwingWorker isn't available in Java 5 and it's not ambiguous for
developers working on such a Java version.

Anyway, since we're targeting Java 5 yet there are developers working
on Java 6, I start thinking that it may be better to just rename our
SwingWorker.

Regards,
Lubomir

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

My bad here. I permanently switched to java5 a couple of days ago
because the otr plugin didn't work properly with java5. Didn't think
that the opposite could happen as well! I will verify that the project
builds with both java6 and java5 from now on.

I'm sorry for the frustration.

George

···

On Sun, Aug 30, 2009 at 10:58 AM, Lubomir Marinov<lubomir.marinov@gmail.com> wrote:

Hi Peter,

The 4 error is regarding to
net/java/sip/communicator/impl/gui/main/chat/ChatPanel.java:

ChatPanel.java:943: reference to SwingWorker is ambiguous,
both class net.java.sip.communicator.util.swing.SwingWorker in
net.java.sip.communicator.util.swing and class javax.swing.SwingWorker in
javax.swing match
[javac] SwingWorker worker = new SwingWorker()

and the same message for line 1387.

Thank you!

I just committed r5883 which disambiguates SwingWorker. The problem is
that SwingWorker isn't available in Java 5 and it's not ambiguous for
developers working on such a Java version.

Anyway, since we're targeting Java 5 yet there are developers working
on Java 6, I start thinking that it may be better to just rename our
SwingWorker.

Regards,
Lubomir

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net