[sip-comm-dev] Throwing an exception during SDP processing results in stray call window


#1

Hello

When an exception is thrown during the creation of the SDP while answering a SIP-Call (CallPeerSipImpl.answer(), ~line 997), the exception is caught and a NOT_ACCEPTABLE_HERE is sent to the peer (~line 1014). Nevertheless processing continues and in the end leaves a call window open that says "Connecting*" - but does nothing at all.
The attached patch solved it for me.

Ingo

stop_call_when_returned_not-acceptable.patch (731 Bytes)


#2

Hi,

I've just committed your patch and acked your contribution on our Team
And Contributors page.

Thanks
damencho

···

On Thu, Dec 2, 2010 at 4:12 PM, Bauersachs Ingo <ingo.bauersachs@fhnw.ch> wrote:

Hello

When an exception is thrown during the creation of the SDP while answering a SIP-Call (CallPeerSipImpl.answer(), ~line 997), the exception is caught and a NOT_ACCEPTABLE_HERE is sent to the peer (~line 1014). Nevertheless processing continues and in the end leaves a call window open that says "Connecting*" - but does nothing at all.
The attached patch solved it for me.

Ingo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi

I've just committed your patch and acked your contribution on our Team
And Contributors page.

Thanks
damencho

Thanks!

I just scrolled through the issues list and I think we closed #732.
https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=732

Ingo

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Its closed now.

Thanks for reminding me :slight_smile:

···

On Mon, Dec 13, 2010 at 8:42 PM, Bauersachs Ingo <ingo.bauersachs@fhnw.ch> wrote:

Hi

I've just committed your patch and acked your contribution on our Team
And Contributors page.

Thanks
damencho

Thanks!

I just scrolled through the issues list and I think we closed #732.
https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=732

Ingo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net