[sip-comm-dev] subscription timers for SIMPLE


#1

Hi Ben,

I was looking at one of your latest commits on SIMPLE and noticed that
the expiration timers for both subscriptions and publish requests are
set in the code

     /**
      * The default expiration value of a PUBLISH request
      */
    private static final int PUBLISH_DEFAULT_EXPIRE = 3600;

     /**
      * The default expiration value of a SUBSCRIBE request
      */
    private static final int SUBSCRIBE_DEFAULT_EXPIRE = 3600;

I was wondering whether it would not be a better idea to have these set
in an "Advanced" tab of the SIP Account Creation Wizard in case users
would like to set specific behaviour according to the server they are using.

I could agree that this is way too advanced a concept for most users to
handle so if you think that exposing them in the wizard is unnecessary
then perhaps we could at least have them configurable through the
sip-communicator.xml config file.

WDYT?

Emil

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Emil,

Having some parameters for SIMPLE that the user can change through the interface is a very good idea, I'll find the most pertinent settings and add them to the interface in an Advanced tab.

However, because there is always a "however", these two variables must absolutely not being set by the user because more than representing the value SC uses for its expires value, it's also the variable which stores the default value defined in the RFCs.
Allowing the user to set the default value of a subscription remains a good idea.

Cheers,
Ben

Emil Ivov a �crit :

···

Hi Ben,

I was looking at one of your latest commits on SIMPLE and noticed that
the expiration timers for both subscriptions and publish requests are
set in the code

     /**
      * The default expiration value of a PUBLISH request
      */
    private static final int PUBLISH_DEFAULT_EXPIRE = 3600;

     /**
      * The default expiration value of a SUBSCRIBE request
      */
    private static final int SUBSCRIBE_DEFAULT_EXPIRE = 3600;

I was wondering whether it would not be a better idea to have these set
in an "Advanced" tab of the SIP Account Creation Wizard in case users
would like to set specific behaviour according to the server they are using.

I could agree that this is way too advanced a concept for most users to
handle so if you think that exposing them in the wizard is unnecessary
then perhaps we could at least have them configurable through the
sip-communicator.xml config file.

WDYT?

Emil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net