[sip-comm-dev] Submitted patch 2 weeks ago, no feedback received


#1

Hi all,

I submitted a patch over 2 weeks ago, and never got any feedback, I just wondered if anyone had looked at it yet or if it slipped through the cracks.

This patch adds support for SRV DNS records for SIP calling. The patch may not be the perfect fix, but it's a good start.

My original message can be found here:

https://sip-communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4101

Thanks,

Alan

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hey again Alan,

Guess the others were waiting on me to apply it and I was pretty busy
for the last few weeks. Will look at it very soon (early next week at
the latest) and let you know how it goes.

Cheers
Emil

Alan C Kelly написа:

···

Hi all,

I submitted a patch over 2 weeks ago, and never got any feedback, I just wondered if anyone had looked at it yet or if it slipped through the cracks.

This patch adds support for SRV DNS records for SIP calling. The patch may not be the perfect fix, but it's a good start.

My original message can be found here:

https://sip-communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4101

Thanks,

Alan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Emil: Alright, thanks! No hurry, I just didn't want it to get lost.

···

----- Original Message -----

From: Emil Ivov <emcho@sip-communicator.org>

Date: Thursday, August 14, 2008 9:24 am
Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no feedback received

Hey again Alan,

Guess the others were waiting on me to apply it and I was pretty busy
for the last few weeks. Will look at it very soon (early next week at
the latest) and let you know how it goes.

Cheers
Emil

Alan C Kelly написа:
> Hi all,
>
> I submitted a patch over 2 weeks ago, and never got any
feedback, I just wondered if anyone had looked at it yet or if it
slipped through the cracks.
>
> This patch adds support for SRV DNS records for SIP calling. The
patch may not be the perfect fix, but it's a good start.
>
> My original message can be found here:
>
> https://sip-
communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4101>
> Thanks,
>
> Alan
>
> -----------------------------------------------------------------
----
> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net> For additional commands, e-mail: dev-
help@sip-communicator.dev.java.net
>
>

-------------------------------------------------------------------
--
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Emil,

I have noticed one issue with this, which is that sometimes it attempts an SRV dns lookup on an IP address, because it does not realize it already has the IP address. I am working on a solution. It looks like I need to add a regex filter for IP addresses.

Alan

···

----- Original Message -----

From: Emil Ivov <emcho@sip-communicator.org>

Date: Thursday, August 14, 2008 9:24 am
Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no feedback received

Hey again Alan,

Guess the others were waiting on me to apply it and I was pretty busy
for the last few weeks. Will look at it very soon (early next week at
the latest) and let you know how it goes.

Cheers
Emil

Alan C Kelly написа:
> Hi all,
>
> I submitted a patch over 2 weeks ago, and never got any
feedback, I just wondered if anyone had looked at it yet or if it
slipped through the cracks.
>
> This patch adds support for SRV DNS records for SIP calling. The
patch may not be the perfect fix, but it's a good start.
>
> My original message can be found here:
>
> https://sip-
communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4101>
> Thanks,
>
> Alan
>
> -----------------------------------------------------------------
----
> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net> For additional commands, e-mail: dev-
help@sip-communicator.dev.java.net
>
>

-------------------------------------------------------------------
--
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hello Alan,

There was a report for a different but similar problem from Thomas Hofer
about a month ago. I've sent a reply today:

https://sip-communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4247

I was saying that we'd probably need to do some IP address parsing in
there but that we'd need to be careful so as not to miss any cases. We
could add an extra utility method in NetworkUtils.

What do you think?

Emil

Alan C Kelly написа:

···

Emil,

I have noticed one issue with this, which is that sometimes it attempts an SRV dns lookup on an IP address, because it does not realize it already has the IP address. I am working on a solution. It looks like I need to add a regex filter for IP addresses.

Alan

----- Original Message -----
From: Emil Ivov <emcho@sip-communicator.org>
Date: Thursday, August 14, 2008 9:24 am
Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no feedback received

Hey again Alan,

Guess the others were waiting on me to apply it and I was pretty busy
for the last few weeks. Will look at it very soon (early next week at
the latest) and let you know how it goes.

Cheers
Emil

Alan C Kelly написа:

Hi all,

I submitted a patch over 2 weeks ago, and never got any

feedback, I just wondered if anyone had looked at it yet or if it
slipped through the cracks.

This patch adds support for SRV DNS records for SIP calling. The

patch may not be the perfect fix, but it's a good start.

My original message can be found here:

https://sip-

communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4101>

Thanks,

Alan

-----------------------------------------------------------------

----

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net> For additional commands, e-mail: dev-
help@sip-communicator.dev.java.net

-------------------------------------------------------------------
--
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hi Emil,

I played around with this for a while, and I agree, we need to do our own IP address parsing, and putting such a method in NetworkUtils is a good idea. I am attaching a proposed patch for NetworkUtils that includes a new isValidIPAddress() method. This should help fix Thomas' problem.

I will be able to use this method in my SRV record patch for SIP calling as well. I need to test the new version of the SRV patch and then I will send you that as well.

I also changed NetworkUtils.isIPv6Address() to be more complete and added NetworkUtils.isIPv4Address()

Hope this helps!

Alan

networkUtils_isValidIPAddress.patch (3.84 KB)

···

----- Original Message -----

From: Emil Ivov <emcho@sip-communicator.org>

Date: Thursday, August 21, 2008 5:41 pm
Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no feedback received

Hello Alan,

There was a report for a different but similar problem from Thomas
Hoferabout a month ago. I've sent a reply today:

https://sip-
communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4247
I was saying that we'd probably need to do some IP address parsing in
there but that we'd need to be careful so as not to miss any
cases. We
could add an extra utility method in NetworkUtils.

What do you think?

Emil

Alan C Kelly написа:
> Emil,
>
> I have noticed one issue with this, which is that sometimes it
attempts an SRV dns lookup on an IP address, because it does not
realize it already has the IP address. I am working on a solution.
It looks like I need to add a regex filter for IP addresses.
>
> Alan
>
> ----- Original Message -----
> From: Emil Ivov <emcho@sip-communicator.org>
> Date: Thursday, August 14, 2008 9:24 am
> Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no
feedback received
>
>> Hey again Alan,
>>
>> Guess the others were waiting on me to apply it and I was
pretty busy
>> for the last few weeks. Will look at it very soon (early next
week at
>> the latest) and let you know how it goes.
>>
>> Cheers
>> Emil
>>
>> Alan C Kelly написа:
>>> Hi all,
>>>
>>> I submitted a patch over 2 weeks ago, and never got any
>> feedback, I just wondered if anyone had looked at it yet or if
it
>> slipped through the cracks.
>>> This patch adds support for SRV DNS records for SIP calling.
The
>> patch may not be the perfect fix, but it's a good start.
>>> My original message can be found here:
>>>
>>> https://sip-
>> communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4101>
>>> Thanks,
>>>
>>> Alan
>>>
>>> ---------------------------------------------------------------
--
>> ----
>>> To unsubscribe, e-mail: dev-unsubscribe@sip-
>> communicator.dev.java.net> For additional commands, e-mail: dev-
>> help@sip-communicator.dev.java.net
>>>
>>
>> ----------------------------------------------------------------
---
>> --
>> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net>> For additional commands, e-mail: dev-
help@sip-
>> communicator.dev.java.net
>>
>
> -----------------------------------------------------------------
----
> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net> For additional commands, e-mail: dev-
help@sip-communicator.dev.java.net
>
>

-------------------------------------------------------------------
--
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net


#7

Sorry, that patch got corrupted. This one should work.

networkUtils_isValidIPAddress.patch (3.86 KB)

···

----- Original Message -----

From: Alan C Kelly <akelly7@gmu.edu>

Date: Friday, August 22, 2008 1:25 pm
Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no feedback received

Hi Emil,

I played around with this for a while, and I agree, we need to do
our own IP address parsing, and putting such a method in
NetworkUtils is a good idea. I am attaching a proposed patch for
NetworkUtils that includes a new isValidIPAddress() method. This
should help fix Thomas' problem.

I will be able to use this method in my SRV record patch for SIP
calling as well. I need to test the new version of the SRV patch
and then I will send you that as well.

I also changed NetworkUtils.isIPv6Address() to be more complete
and added NetworkUtils.isIPv4Address()

Hope this helps!

Alan

----- Original Message -----
From: Emil Ivov <emcho@sip-communicator.org>
Date: Thursday, August 21, 2008 5:41 pm
Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no
feedback received

> Hello Alan,
>
> There was a report for a different but similar problem from
Thomas
> Hoferabout a month ago. I've sent a reply today:
>
> https://sip-
> communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4247
> I was saying that we'd probably need to do some IP address
parsing in
> there but that we'd need to be careful so as not to miss any
> cases. We
> could add an extra utility method in NetworkUtils.
>
> What do you think?
>
> Emil
>
>
>
> Alan C Kelly написа:
> > Emil,
> >
> > I have noticed one issue with this, which is that sometimes it
> attempts an SRV dns lookup on an IP address, because it does not
> realize it already has the IP address. I am working on a
solution.
> It looks like I need to add a regex filter for IP addresses.
> >
> > Alan
> >
> > ----- Original Message -----
> > From: Emil Ivov <emcho@sip-communicator.org>
> > Date: Thursday, August 14, 2008 9:24 am
> > Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no
> feedback received
> >
> >> Hey again Alan,
> >>
> >> Guess the others were waiting on me to apply it and I was
> pretty busy
> >> for the last few weeks. Will look at it very soon (early next
> week at
> >> the latest) and let you know how it goes.
> >>
> >> Cheers
> >> Emil
> >>
> >> Alan C Kelly написа:
> >>> Hi all,
> >>>
> >>> I submitted a patch over 2 weeks ago, and never got any
> >> feedback, I just wondered if anyone had looked at it yet or
if
> it
> >> slipped through the cracks.
> >>> This patch adds support for SRV DNS records for SIP calling.
> The
> >> patch may not be the perfect fix, but it's a good start.
> >>> My original message can be found here:
> >>>
> >>> https://sip-
> >>
communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4101>
> >>> Thanks,
> >>>
> >>> Alan
> >>>
> >>> -------------------------------------------------------------
--
> --
> >> ----
> >>> To unsubscribe, e-mail: dev-unsubscribe@sip-
> >> communicator.dev.java.net> For additional commands, e-mail:
dev-
> >> help@sip-communicator.dev.java.net
> >>>
> >>
> >> --------------------------------------------------------------
--
> ---
> >> --
> >> To unsubscribe, e-mail: dev-unsubscribe@sip-
> communicator.dev.java.net>> For additional commands, e-mail: dev-
> help@sip-
> >> communicator.dev.java.net
> >>
> >
> > ---------------------------------------------------------------
--
> ----
> > To unsubscribe, e-mail: dev-unsubscribe@sip-
> communicator.dev.java.net> For additional commands, e-mail: dev-
> help@sip-communicator.dev.java.net
> >
> >
>
>
> -----------------------------------------------------------------
--
> --
> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net> For additional commands, e-mail: dev-
help@sip-
> communicator.dev.java.net
>


#8

Thanks Alan,

Will try to apply it during the weekend but don't get worried if it
takes a bit longer. I am in the middle of something else right now so I
tend to be laggy.

Cheers
Emil

Alan C Kelly написа:

···

Sorry, that patch got corrupted. This one should work.

----- Original Message -----
From: Alan C Kelly <akelly7@gmu.edu>
Date: Friday, August 22, 2008 1:25 pm
Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no feedback received

Hi Emil,

I played around with this for a while, and I agree, we need to do
our own IP address parsing, and putting such a method in
NetworkUtils is a good idea. I am attaching a proposed patch for
NetworkUtils that includes a new isValidIPAddress() method. This
should help fix Thomas' problem.

I will be able to use this method in my SRV record patch for SIP
calling as well. I need to test the new version of the SRV patch
and then I will send you that as well.

I also changed NetworkUtils.isIPv6Address() to be more complete
and added NetworkUtils.isIPv4Address()

Hope this helps!

Alan

----- Original Message -----
From: Emil Ivov <emcho@sip-communicator.org>
Date: Thursday, August 21, 2008 5:41 pm
Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no
feedback received

Hello Alan,

There was a report for a different but similar problem from

Thomas

Hoferabout a month ago. I've sent a reply today:

https://sip-
communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4247
I was saying that we'd probably need to do some IP address

parsing in

there but that we'd need to be careful so as not to miss any
cases. We
could add an extra utility method in NetworkUtils.

What do you think?

Emil

Alan C Kelly написа:

Emil,

I have noticed one issue with this, which is that sometimes it

attempts an SRV dns lookup on an IP address, because it does not
realize it already has the IP address. I am working on a

solution.

It looks like I need to add a regex filter for IP addresses.

Alan

----- Original Message -----
From: Emil Ivov <emcho@sip-communicator.org>
Date: Thursday, August 14, 2008 9:24 am
Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no

feedback received

Hey again Alan,

Guess the others were waiting on me to apply it and I was

pretty busy

for the last few weeks. Will look at it very soon (early next

week at

the latest) and let you know how it goes.

Cheers
Emil

Alan C Kelly написа:

Hi all,

I submitted a patch over 2 weeks ago, and never got any

feedback, I just wondered if anyone had looked at it yet or

if

it

slipped through the cracks.

This patch adds support for SRV DNS records for SIP calling.

The

patch may not be the perfect fix, but it's a good start.

My original message can be found here:

https://sip-

communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4101>

Thanks,

Alan

-------------------------------------------------------------

--

--

----

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net> For additional commands, e-mail:

dev-

help@sip-communicator.dev.java.net
--------------------------------------------------------------

--

---

--
To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net>> For additional commands, e-mail: dev-
help@sip-

communicator.dev.java.net

---------------------------------------------------------------

--

----

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net> For additional commands, e-mail: dev-
help@sip-communicator.dev.java.net

-----------------------------------------------------------------

--

--
To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net> For additional commands, e-mail: dev-
help@sip-

communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#9

No problem. I'm going to be offline most of the weekend anyways. Thanks!

···

----- Original Message -----

From: Emil Ivov <emcho@sip-communicator.org>

Date: Friday, August 22, 2008 4:22 pm
Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no feedback received

Thanks Alan,

Will try to apply it during the weekend but don't get worried if it
takes a bit longer. I am in the middle of something else right now
so I
tend to be laggy.

Cheers
Emil

Alan C Kelly написа:
> Sorry, that patch got corrupted. This one should work.
>
> ----- Original Message -----
> From: Alan C Kelly <akelly7@gmu.edu>
> Date: Friday, August 22, 2008 1:25 pm
> Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no
feedback received
>
>> Hi Emil,
>>
>> I played around with this for a while, and I agree, we need to
do
>> our own IP address parsing, and putting such a method in
>> NetworkUtils is a good idea. I am attaching a proposed patch
for
>> NetworkUtils that includes a new isValidIPAddress() method.
This
>> should help fix Thomas' problem.
>>
>> I will be able to use this method in my SRV record patch for
SIP
>> calling as well. I need to test the new version of the SRV
patch
>> and then I will send you that as well.
>>
>> I also changed NetworkUtils.isIPv6Address() to be more complete
>> and added NetworkUtils.isIPv4Address()
>>
>> Hope this helps!
>>
>> Alan
>>
>> ----- Original Message -----
>> From: Emil Ivov <emcho@sip-communicator.org>
>> Date: Thursday, August 21, 2008 5:41 pm
>> Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no
>> feedback received
>>
>>> Hello Alan,
>>>
>>> There was a report for a different but similar problem from
>> Thomas
>>> Hoferabout a month ago. I've sent a reply today:
>>>
>>> https://sip-
>>> communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4247
>>> I was saying that we'd probably need to do some IP address
>> parsing in
>>> there but that we'd need to be careful so as not to miss any
>>> cases. We
>>> could add an extra utility method in NetworkUtils.
>>>
>>> What do you think?
>>>
>>> Emil
>>>
>>>
>>>
>>> Alan C Kelly написа:
>>>> Emil,
>>>>
>>>> I have noticed one issue with this, which is that sometimes
it
>>> attempts an SRV dns lookup on an IP address, because it does
not
>>> realize it already has the IP address. I am working on a
>> solution.
>>> It looks like I need to add a regex filter for IP addresses.
>>>> Alan
>>>>
>>>> ----- Original Message -----
>>>> From: Emil Ivov <emcho@sip-communicator.org>
>>>> Date: Thursday, August 14, 2008 9:24 am
>>>> Subject: Re: [sip-comm-dev] Submitted patch 2 weeks ago, no
>>> feedback received
>>>>> Hey again Alan,
>>>>>
>>>>> Guess the others were waiting on me to apply it and I was
>>> pretty busy
>>>>> for the last few weeks. Will look at it very soon (early
next
>>> week at
>>>>> the latest) and let you know how it goes.
>>>>>
>>>>> Cheers
>>>>> Emil
>>>>>
>>>>> Alan C Kelly написа:
>>>>>> Hi all,
>>>>>>
>>>>>> I submitted a patch over 2 weeks ago, and never got any
>>>>> feedback, I just wondered if anyone had looked at it yet or
>> if
>>> it
>>>>> slipped through the cracks.
>>>>>> This patch adds support for SRV DNS records for SIP
calling.
>>> The
>>>>> patch may not be the perfect fix, but it's a good start.
>>>>>> My original message can be found here:
>>>>>>
>>>>>> https://sip-
>> communicator.dev.java.net/servlets/ReadMsg?list=dev&msgNo=4101>
>>>>>> Thanks,
>>>>>>
>>>>>> Alan
>>>>>>
>>>>>> ------------------------------------------------------------
-
>> --
>>> --
>>>>> ----
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@sip-
>>>>> communicator.dev.java.net> For additional commands, e-mail:
>> dev-
>>>>> help@sip-communicator.dev.java.net
>>>>> -------------------------------------------------------------
-
>> --
>>> ---
>>>>> --
>>>>> To unsubscribe, e-mail: dev-unsubscribe@sip-
>>> communicator.dev.java.net>> For additional commands, e-mail:
dev-
>>> help@sip-
>>>>> communicator.dev.java.net
>>>>>
>>>> --------------------------------------------------------------
-
>> --
>>> ----
>>>> To unsubscribe, e-mail: dev-unsubscribe@sip-
>>> communicator.dev.java.net> For additional commands, e-mail:
dev-
>>> help@sip-communicator.dev.java.net
>>>>
>>>
>>> ---------------------------------------------------------------
--
>> --
>>> --
>>> To unsubscribe, e-mail: dev-unsubscribe@sip-
>> communicator.dev.java.net> For additional commands, e-mail: dev-
>> help@sip-
>>> communicator.dev.java.net
>>>
>>
>> ----------------------------------------------------------------
--------
>>
>> ----------------------------------------------------------------
-----
>> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net>> For additional commands, e-mail: dev-
help@sip-communicator.dev.java.net

-------------------------------------------------------------------
--
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net