[sip-comm-dev] Smiley bug?


#1

I got a message from an ICQ account on Miranda IM to my AIM account on
SIP Communicator. The message had smileys in places I didn't think
would match smileys known to me (i.e. the letter D got turned into a
laughing face), and it had a strange </DIV> at the end. Refer to the
attached sip-communicator.png for a screenshot. The same message sent
once again and received in Empathy is show in the attached
empathy.png. Is this a bug in our smiley replacement?


#2

Hi,

This is because quote (") is processed as &quot; and the &quot;D (D followed
by a quote ) matches ;D ( the laughing smiley ). HTML chars are processed
before the replacements are handled. I've added a patch which modifies a
part of the regex for smilies, escaping these chars. It should fix this
issue.

Thanks,
Purvesh

ReplacementServiceSmileyImpl.patch (793 Bytes)

ยทยทยท

On Fri, Dec 10, 2010 at 6:00 PM, Lyubomir Marinov <lubo@sip-communicator.org > wrote:

I got a message from an ICQ account on Miranda IM to my AIM account on
SIP Communicator. The message had smileys in places I didn't think
would match smileys known to me (i.e. the letter D got turned into a
laughing face), and it had a strange </DIV> at the end. Refer to the
attached sip-communicator.png for a screenshot. The same message sent
once again and received in Empathy is show in the attached
empathy.png. Is this a bug in our smiley replacement?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net