[sip-comm-dev] SIP, messaging and presence -> Patch


#1

Hi,

in July I wrote something about messaging and presence on this mailing list.

Here is now a patch, that fixes the following things:

- don't add the "OperationsetBasicInstantMessaging" and
"OperationSetTypeNotifications" to the list of supported operationSets
for the SIP protocol, if SIMPLE is not supported (currently determined
by the "Enable presence (SIMPLE)" checkbox in the advanced settings)
- only add those protocols to the protocolSelector in the chat window
that actually do support IM
- display a message to the user in the chat dialogue, if the selected
contact does not support IM with any of its protocols (as this window
opens as a default on a double-click - the entry for IM in the context
menu is already disabled if there is no protocol supporting IM). Also
disable the "Send" button in this case

There should be a second patch for the other thing that I mentioned back
in July (presence for contacts of SIP servers that do not support
SIMPLE) within the next weeks.

Sebastian

sip_no_IM.patch (9.44 KB)

···

--
/**
* Sebastian Heib
* Software Developer
*
* Synyx GmbH & Co. KG
* Business in Components
* Karlstr. 68
* 76137 Karlsruhe
*
* phone +49(0)721 66 24 866
* fax +49(0)721 66 48 877
* eMail heib@synyx.de
* www http://www.synyx.de
* irc irc.synyx.de
*
* Sitz der Gesellschaft: Karlsruhe
* Registergericht: Mannheim
* Handelsregisternummer: HRA 4793
* USt-IdNr.: DE249264296
*
* Komplement�rin: Elatech Verwaltungs GmbH
* Sitz der Gesellschaft: Karlsruhe
* Gesch�ftsf�hrer: Markus Daniel
* Registergericht: Mannheim
* Handelsregisternummer: HRB 7250
*/


#2

I believe we missed this one.

Could you please open an issue for it?

Thanks
Emil

Sebastian Heib wrote:

···

Hi,

in July I wrote something about messaging and presence on this mailing list.

Here is now a patch, that fixes the following things:

- don't add the "OperationsetBasicInstantMessaging" and
"OperationSetTypeNotifications" to the list of supported operationSets
for the SIP protocol, if SIMPLE is not supported (currently determined
by the "Enable presence (SIMPLE)" checkbox in the advanced settings)
- only add those protocols to the protocolSelector in the chat window
that actually do support IM
- display a message to the user in the chat dialogue, if the selected
contact does not support IM with any of its protocols (as this window
opens as a default on a double-click - the entry for IM in the context
menu is already disabled if there is no protocol supporting IM). Also
disable the "Send" button in this case

There should be a second patch for the other thing that I mentioned back
in July (presence for contacts of SIP servers that do not support
SIMPLE) within the next weeks.

Sebastian

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi,

I've just committed and ack-ed your patch.

Thanks
damencho

Sebastian Heib wrote:

···

Hi,

in July I wrote something about messaging and presence on this mailing list.

Here is now a patch, that fixes the following things:

- don't add the "OperationsetBasicInstantMessaging" and
"OperationSetTypeNotifications" to the list of supported operationSets
for the SIP protocol, if SIMPLE is not supported (currently determined
by the "Enable presence (SIMPLE)" checkbox in the advanced settings)
- only add those protocols to the protocolSelector in the chat window
that actually do support IM
- display a message to the user in the chat dialogue, if the selected
contact does not support IM with any of its protocols (as this window
opens as a default on a double-click - the entry for IM in the context
menu is already disabled if there is no protocol supporting IM). Also
disable the "Send" button in this case

There should be a second patch for the other thing that I mentioned back
in July (presence for contacts of SIP servers that do not support
SIMPLE) within the next weeks.

Sebastian

  ------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net