Thank you for your contribution and for how reactive you've been. Very nice code. The feature is really very useful! I've never been using RSS that much before. Really nice!
I've been modifying some things over the last few days so I am attaching a list of everything I changed (don't let this discourage you though, it's still a great contribution!)
So, here goes:
* Renamded recupFlux() to retrieveFlow()
- nothing but English in source code!
* Added an OperationFailedException to retrieveFlow()
- we need to have some kind of indication if retrieving a flow fails so that we could act accordingly (e.g. not add a contact to the contact list)
* The reader should be created with a URL object and not an unparsed string.
- URL objects must be created as early as possible (e.g. at the time a contact is added to the contact list) so that we could parse and test the syntax of the URL and ignore the contact if we encounter any problems.
* Made the sortItems() method private
- seems that there's no one else using it.
* Made sortItems use Arrays.sort()
- thought it would be better this way rather than let it implement the sort itself. I've therefore also added a comparatator class.
* ReReversed sort order for RSS posts.
- given the way SC wokrs and what it is used for, the user is most likely to only be seeing the last messages being printed out. In the meantime, the msgs that a user would be most likely to be looking for are the newest, so it would be better if they were printed last.
* Removed calls to System.out.println()
- we should be using net.java.sip.communicator.util.Logger instead.
* Store a reference of the source RSS url and RssFeedReader
- did this so that OperationSetBasicInstantMessagingRssImpl could then reuse them.
* Removed the getToken() method
- seems no one was using it.
* Removed the deliverAuthentication() method
- seems like Gibberish residue so I decided to drop it. I don't think we handle or need authorizations in RSS do we?
* Remove the createVolatileContact() method.
- we don't really have that for RSS
* Remove the getNonPersistentGroup() method
* Remove the findProviderForRssID() method
- unused. (Gibberish residue?)
* Removed java.awt imports
* Removed the deliverMessage() method.
- I guess this too was a residue from gibberish that we don't need here.
* The sendInstantMessage() method was creating a MessageDeliveredEvent instance that it was not using
- the event instance is actually created by the fireMessageDelivered() method
* Constructor shouldn't be calling start()
- this is the responsibility of the one creating the thread.
* Do not use RssThred
- All timer tasks are being run in a thread of their own, created by the java.util.Timer. Hence, there's no need to be executing a new thread
* Removed the class since we don't need typing notifications for RSS.
OK, I guess that's all. In case you don't agree with any of the changes, please let me know.
Oh, and btw, I've ack-ed your effort on the team and contributors page.
Thanks for all your efforts!
Jean-Albert Vescovo wrote:
Ok Damian, but I have a problem building the project: ant seems not
to like the empty lines between instructions into the manifest
files... ("rss.provider.manifest.mf" and "rssaccregwizz.manifest.mf"
Besides, that seems ok !!!
Can you precise me what you would like that I mention ? (you wrote:
Just a little tip about the distribution you have provided. Please
provide and properties with comments for
accounts.properties.template - used for tests. Everything else
I've just committed RSS protocol provider with some minor changes
like : code formating, fix some javadoc conflicts and in
ContactRssImpl changed converting Dates to String and String to Dates - now using SimpleDateFormat. Thats it for now I've
already started to use it. Great
To unsubscribe, e-mail:
firstname.lastname@example.org For additional
commands, e-mail: email@example.com
To unsubscribe, e-mail: firstname.lastname@example.org
For additional commands, e-mail: email@example.com