[sip-comm-dev] refactoring the about-dialog


#1

Hi developers and others!

I'd like to start a discussion about the "about-dialog".

In my opinion the about-dialog should be - like the splash screen - a
bundle, which can be exchanged. This would make it possible to "brand"
the sip-communicator even better than it is possible now.

What do you think about?

[ ] Good idea

[ ] No, the about dialog must not be exchanged and therefore should be
part of the main plugin

[ ] Does not matter me.


#2

Hi Thomas,

very good idea. We could move it in a separate bundle and add it in the gui as a "gui plugin". Would you like to do it?

Cheers,
Yana

Hofer Thomas wrote:

···

Hi developers and others!

I'd like to start a discussion about the "about-dialog".

In my opinion the about-dialog should be - like the splash screen - a
bundle, which can be exchanged. This would make it possible to "brand"
the sip-communicator even better than it is possible now.

What do you think about?

[ ] Good idea

[ ] No, the about dialog must not be exchanged and therefore should be
part of the main plugin

[ ] Does not matter me.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

I'd like to start a discussion about the "about-dialog".

In my opinion the about-dialog should be - like the splash
screen - a bundle, which can be exchanged. This would
make it possible to "brand" the sip-communicator even
better than it is possible now.

What do you think about?

[x] Does not matter me.

It does not matter to me, since I'm not working on this part of the code.
But nevertheless this approach seems to be the right thing to do.

Regards
Michael Koch


#4

Hi Thomas,

I also think it's a good idea, especially if you have already worked on
something in that direction.

Emil

Hofer Thomas wrote:

···

Hi developers and others!

I�d like to start a discussion about the �about-dialog�.

In my opinion the about-dialog should be � like the splash screen � a
bundle, which can be exchanged. This would make it possible to �brand�
the sip-communicator even better than it is possible now.

What do you think about?

[ ] Good idea

[ ] No, the about dialog must not be exchanged and therefore should be
part of the main plugin

[ ] Does not matter me.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

I might add that it could be worthwhile to put all of this "branding" stuff into a single bundle, rather than having them in separate bundles. Makes it easier to know what to replace, but also proliferating lots of little bundles will slow down system start up eventually.

-> richard

Emil Ivov wrote:

···

Hi Thomas,

I also think it's a good idea, especially if you have already worked on
something in that direction.

Emil

Hofer Thomas wrote:
  

Hi developers and others!

I�d like to start a discussion about the �about-dialog�.

In my opinion the about-dialog should be � like the splash screen � a
bundle, which can be exchanged. This would make it possible to �brand�
the sip-communicator even better than it is possible now.

What do you think about?

[ ] Good idea

[ ] No, the about dialog must not be exchanged and therefore should be
part of the main plugin

[ ] Does not matter me.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Yes, no problem! I just checked, as it is "your" code. I will wait for a few
comments, and if no one has a good argument not to do it, I'll refactor it.

Cheers, thomas

···

-----Ursprüngliche Nachricht-----
Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
Gesendet: Dienstag, 13. November 2007 11:33
An: dev@sip-communicator.dev.java.net
Betreff: Re: [sip-comm-dev] refactoring the about-dialog

Hi Thomas,

very good idea. We could move it in a separate bundle and add it in the
gui as a "gui plugin". Would you like to do it?

Cheers,
Yana

Hofer Thomas wrote:
> Hi developers and others!
>
>
>
> I'd like to start a discussion about the "about-dialog".
>
> In my opinion the about-dialog should be - like the splash screen - a
> bundle, which can be exchanged. This would make it possible to
"brand"
> the sip-communicator even better than it is possible now.
>
>
>
> What do you think about?
>
>
>
> [ ] Good idea
>
> [ ] No, the about dialog must not be exchanged and therefore should
be
> part of the main plugin
>
> [ ] Does not matter me.
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hi Richard,

Richard S. Hall wrote:

I might add that it could be worthwhile to put all of this "branding"
stuff into a single bundle, rather than having them in separate bundles.

I completely agree. Right now we have two places where one has to change
content for branding. One is the about dialog and the other is the
splash screen. It would be a good thing to have them merged.

We were also thinking with Yana that since the splash screen is now a
bundle it takes a while for it to show so in the future it would
probably be a good idea to display it from the SIP Communicator launcher
that we talked about previously. At that point it may also make sense to
also try and merge the launcher with the new branding bundle.

Emil

···

Makes it easier to know what to replace, but also proliferating lots of
little bundles will slow down system start up eventually.

-> richard

Emil Ivov wrote:

Hi Thomas,

I also think it's a good idea, especially if you have already worked on
something in that direction.

Emil

Hofer Thomas wrote:
  

Hi developers and others!

I�d like to start a discussion about the �about-dialog�.

In my opinion the about-dialog should be � like the splash screen � a
bundle, which can be exchanged. This would make it possible to �brand�
the sip-communicator even better than it is possible now.

What do you think about?

[ ] Good idea

[ ] No, the about dialog must not be exchanged and therefore should be
part of the main plugin

[ ] Does not matter me.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Hi Thomas,

I also think this is a good idea. This would easier integration of "tuned" version of SC.

romain

···

On 2007/11/13, at 13:43, Thomas Hofer wrote:

Yes, no problem! I just checked, as it is "your" code. I will wait for a few
comments, and if no one has a good argument not to do it, I'll refactor it.

Cheers, thomas

-----Ursprüngliche Nachricht-----
Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
Gesendet: Dienstag, 13. November 2007 11:33
An: dev@sip-communicator.dev.java.net
Betreff: Re: [sip-comm-dev] refactoring the about-dialog

Hi Thomas,

very good idea. We could move it in a separate bundle and add it in the
gui as a "gui plugin". Would you like to do it?

Cheers,
Yana

Hofer Thomas wrote:

Hi developers and others!

I'd like to start a discussion about the "about-dialog".

In my opinion the about-dialog should be - like the splash screen - a
bundle, which can be exchanged. This would make it possible to

"brand"

the sip-communicator even better than it is possible now.

What do you think about?

[ ] Good idea

[ ] No, the about dialog must not be exchanged and therefore should

be

part of the main plugin

[ ] Does not matter me.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#9

So what do we do now? Make one bundle for splashscreen and aboutdialog? Or
somehow move the splashcreen into the launcher?

Cheers, thomas

···

-----Ursprüngliche Nachricht-----
Von: Emil Ivov [mailto:emcho@sip-communicator.org]
Gesendet: Mittwoch, 14. November 2007 10:14
An: dev@sip-communicator.dev.java.net
Betreff: Re: [sip-comm-dev] refactoring the about-dialog

Hi Richard,

Richard S. Hall wrote:
> I might add that it could be worthwhile to put all of this "branding"
> stuff into a single bundle, rather than having them in separate
bundles.

I completely agree. Right now we have two places where one has to
change
content for branding. One is the about dialog and the other is the
splash screen. It would be a good thing to have them merged.

We were also thinking with Yana that since the splash screen is now a
bundle it takes a while for it to show so in the future it would
probably be a good idea to display it from the SIP Communicator
launcher
that we talked about previously. At that point it may also make sense
to
also try and merge the launcher with the new branding bundle.

Emil

> Makes it easier to know what to replace, but also proliferating lots
of
> little bundles will slow down system start up eventually.
>
> -> richard
>
> Emil Ivov wrote:
>> Hi Thomas,
>>
>> I also think it's a good idea, especially if you have already worked
on
>> something in that direction.
>>
>> Emil
>>
>> Hofer Thomas wrote:
>>
>>> Hi developers and others!
>>>
>>>
>>>
>>> I’d like to start a discussion about the „about-dialog“.
>>>
>>> In my opinion the about-dialog should be – like the splash screen –
a
>>> bundle, which can be exchanged. This would make it possible to
“brand”
>>> the sip-communicator even better than it is possible now.
>>>
>>>
>>>
>>> What do you think about?
>>>
>>>
>>>
>>> [ ] Good idea
>>>
>>> [ ] No, the about dialog must not be exchanged and therefore should
be
>>> part of the main plugin
>>>
>>> [ ] Does not matter me.
>>>
>>>
>> --------------------------------------------------------------------
-
>> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net
>> For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#10

Hi!

Another question?

As java 1.5 is now the official base java version [is it really? I didn't
find any comment on the homepage?] is it preferred to use the new features
like generics and annotations?

Cheers, thomas

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#11

Hi Thomas,

I think that what Emil meant is that in the future we could think of displaying the splash screen from the launcher. For now I think we could start with merging the splashscreen and the about dialog, as you proposed in one separate bundle. You could move the about dialog in the splash screen bundle and just give this bundle a more appropriate name.

Cheers,
Yana

Thomas Hofer wrote:

···

So what do we do now? Make one bundle for splashscreen and aboutdialog? Or
somehow move the splashcreen into the launcher?

Cheers, thomas

-----Urspr�ngliche Nachricht-----
Von: Emil Ivov [mailto:emcho@sip-communicator.org]
Gesendet: Mittwoch, 14. November 2007 10:14
An: dev@sip-communicator.dev.java.net
Betreff: Re: [sip-comm-dev] refactoring the about-dialog

Hi Richard,

Richard S. Hall wrote:

I might add that it could be worthwhile to put all of this "branding"
stuff into a single bundle, rather than having them in separate

bundles.

I completely agree. Right now we have two places where one has to
change
content for branding. One is the about dialog and the other is the
splash screen. It would be a good thing to have them merged.

We were also thinking with Yana that since the splash screen is now a
bundle it takes a while for it to show so in the future it would
probably be a good idea to display it from the SIP Communicator
launcher
that we talked about previously. At that point it may also make sense
to
also try and merge the launcher with the new branding bundle.

Emil

Makes it easier to know what to replace, but also proliferating lots

of

little bundles will slow down system start up eventually.

-> richard

Emil Ivov wrote:

Hi Thomas,

I also think it's a good idea, especially if you have already worked

on

something in that direction.

Emil

Hofer Thomas wrote:

Hi developers and others!

I�d like to start a discussion about the �about-dialog�.

In my opinion the about-dialog should be � like the splash screen �

a

bundle, which can be exchanged. This would make it possible to

�brand�

the sip-communicator even better than it is possible now.

What do you think about?

[ ] Good idea

[ ] No, the about dialog must not be exchanged and therefore should

be

part of the main plugin

[ ] Does not matter me.

--------------------------------------------------------------------

-

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#12

Hi Thomas, all,

I think that all the programming techniques which makes the code clearer, more reliable and more understandable should be used.

IMHO some of the 1.5 improvements can really improve the readability of the code (like auto encapsulation) and some makes it really more reliable like generics but some others are, to me, not really a good idea like the "for each" way of coding.

So I think that if the feature helps to have a better code it should be used and if it's just an eye candy effect it may probably be avoided.

But it's just my personal opinions :slight_smile:
WDYT ?

Ben

Thomas Hofer a �crit :

···

Hi!

Another question?

As java 1.5 is now the official base java version [is it really? I didn't
find any comment on the homepage?] is it preferred to use the new features
like generics and annotations?

Cheers, thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#13

Hello Thomas,

Thomas Hofer wrote:

Hi!

Another question?

As java 1.5 is now the official base java version [is it really? I didn't
find any comment on the homepage?]

Yes, absolutely.

is it preferred to use the new features like generics and annotations?

You are certainly allowed to use them wherever they fit.

As for whether or not they are the preferred way to go, that is whether
programmers should avoid not using them, we haven't really discussed
this yet. I'd be interested to hear opinions on this one. Should we make
an effort on using J1.5 conventions, or should we, for the time being,
leave the the choice to developers?

Emil

···

Cheers, thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#14

OK! I'll put it on my task list for next week. Cheers, thomas

···

-----Ursprüngliche Nachricht-----
Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
Gesendet: Mittwoch, 28. November 2007 12:49
An: dev@sip-communicator.dev.java.net
Betreff: Re: AW: [sip-comm-dev] refactoring the about-dialog

Hi Thomas,

I think that what Emil meant is that in the future we could think of
displaying the splash screen from the launcher. For now I think we
could
start with merging the splashscreen and the about dialog, as you
proposed in one separate bundle. You could move the about dialog in the
splash screen bundle and just give this bundle a more appropriate name.

Cheers,
Yana

Thomas Hofer wrote:
> So what do we do now? Make one bundle for splashscreen and
aboutdialog? Or
> somehow move the splashcreen into the launcher?
>
> Cheers, thomas
>
>> -----Ursprüngliche Nachricht-----
>> Von: Emil Ivov [mailto:emcho@sip-communicator.org]
>> Gesendet: Mittwoch, 14. November 2007 10:14
>> An: dev@sip-communicator.dev.java.net
>> Betreff: Re: [sip-comm-dev] refactoring the about-dialog
>>
>> Hi Richard,
>>
>> Richard S. Hall wrote:
>>> I might add that it could be worthwhile to put all of this
"branding"
>>> stuff into a single bundle, rather than having them in separate
>> bundles.
>>
>> I completely agree. Right now we have two places where one has to
>> change
>> content for branding. One is the about dialog and the other is the
>> splash screen. It would be a good thing to have them merged.
>>
>> We were also thinking with Yana that since the splash screen is now
a
>> bundle it takes a while for it to show so in the future it would
>> probably be a good idea to display it from the SIP Communicator
>> launcher
>> that we talked about previously. At that point it may also make
sense
>> to
>> also try and merge the launcher with the new branding bundle.
>>
>> Emil
>>
>>> Makes it easier to know what to replace, but also proliferating
lots
>> of
>>> little bundles will slow down system start up eventually.
>>>
>>> -> richard
>>>
>>> Emil Ivov wrote:
>>>> Hi Thomas,
>>>>
>>>> I also think it's a good idea, especially if you have already
worked
>> on
>>>> something in that direction.
>>>>
>>>> Emil
>>>>
>>>> Hofer Thomas wrote:
>>>>
>>>>> Hi developers and others!
>>>>>
>>>>>
>>>>>
>>>>> I’d like to start a discussion about the „about-dialog“.
>>>>>
>>>>> In my opinion the about-dialog should be – like the splash screen
–
>> a
>>>>> bundle, which can be exchanged. This would make it possible to
>> “brand”
>>>>> the sip-communicator even better than it is possible now.
>>>>>
>>>>>
>>>>>
>>>>> What do you think about?
>>>>>
>>>>>
>>>>>
>>>>> [ ] Good idea
>>>>>
>>>>> [ ] No, the about dialog must not be exchanged and therefore
should
>> be
>>>>> part of the main plugin
>>>>>
>>>>> [ ] Does not matter me.
>>>>>
>>>>>
>>>> ------------------------------------------------------------------
--
>> -
>>>> To unsubscribe, e-mail: dev-unsubscribe@sip-
>> communicator.dev.java.net
>>>> For additional commands, e-mail: dev-help@sip-
>> communicator.dev.java.net
>>>>
>>> -------------------------------------------------------------------
--
>>> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net
>>> For additional commands, e-mail: dev-help@sip-
>> communicator.dev.java.net
>>>
>> --------------------------------------------------------------------
-
>> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net
>> For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#15

For my point of view, it is important really good to use them, as they
improve the readability, and - more important - can prevent a
classcast-runtime-execptions. And everyone makes mistakes, one more often,
one more seldom, but we do make them.

Cheers, thomas

···

-----Ursprüngliche Nachricht-----
Von: Emil Ivov [mailto:emcho@sip-communicator.org]
Gesendet: Dienstag, 13. November 2007 16:16
An: dev@sip-communicator.dev.java.net
Betreff: Re: [sip-comm-dev] Using Java 1.5 features

Hello Thomas,

Thomas Hofer wrote:
> Hi!
>
> Another question?
>
> As java 1.5 is now the official base java version [is it really? I
didn't
> find any comment on the homepage?]

Yes, absolutely.

> is it preferred to use the new features like generics and
annotations?

You are certainly allowed to use them wherever they fit.

As for whether or not they are the preferred way to go, that is whether
programmers should avoid not using them, we haven't really discussed
this yet. I'd be interested to hear opinions on this one. Should we
make
an effort on using J1.5 conventions, or should we, for the time being,
leave the the choice to developers?

Emil

>
> Cheers, thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#16

Hey Yana, Thomas,

Yes that's what I meant, Yana, thanks for answering, and thank you,
Thomas, for accepting to take care of it.

Cheers
Emil

Thomas Hofer wrote:

···

OK! I'll put it on my task list for next week. Cheers, thomas

-----Urspr�ngliche Nachricht-----
Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
Gesendet: Mittwoch, 28. November 2007 12:49
An: dev@sip-communicator.dev.java.net
Betreff: Re: AW: [sip-comm-dev] refactoring the about-dialog

Hi Thomas,

I think that what Emil meant is that in the future we could think of
displaying the splash screen from the launcher. For now I think we
could
start with merging the splashscreen and the about dialog, as you
proposed in one separate bundle. You could move the about dialog in the
splash screen bundle and just give this bundle a more appropriate name.

Cheers,
Yana

Thomas Hofer wrote:

So what do we do now? Make one bundle for splashscreen and

aboutdialog? Or

somehow move the splashcreen into the launcher?

Cheers, thomas

-----Urspr�ngliche Nachricht-----
Von: Emil Ivov [mailto:emcho@sip-communicator.org]
Gesendet: Mittwoch, 14. November 2007 10:14
An: dev@sip-communicator.dev.java.net
Betreff: Re: [sip-comm-dev] refactoring the about-dialog

Hi Richard,

Richard S. Hall wrote:

I might add that it could be worthwhile to put all of this

"branding"

stuff into a single bundle, rather than having them in separate

bundles.

I completely agree. Right now we have two places where one has to
change
content for branding. One is the about dialog and the other is the
splash screen. It would be a good thing to have them merged.

We were also thinking with Yana that since the splash screen is now

a

bundle it takes a while for it to show so in the future it would
probably be a good idea to display it from the SIP Communicator
launcher
that we talked about previously. At that point it may also make

sense

to
also try and merge the launcher with the new branding bundle.

Emil

Makes it easier to know what to replace, but also proliferating

lots

of

little bundles will slow down system start up eventually.

-> richard

Emil Ivov wrote:

Hi Thomas,

I also think it's a good idea, especially if you have already

worked

on

something in that direction.

Emil

Hofer Thomas wrote:

Hi developers and others!

I�d like to start a discussion about the �about-dialog�.

In my opinion the about-dialog should be � like the splash screen

a

bundle, which can be exchanged. This would make it possible to

�brand�

the sip-communicator even better than it is possible now.

What do you think about?

[ ] Good idea

[ ] No, the about dialog must not be exchanged and therefore

should

be

part of the main plugin

[ ] Does not matter me.

------------------------------------------------------------------

--

-

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

-------------------------------------------------------------------

--

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net
--------------------------------------------------------------------

-

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#17

I've gotten used to the new language features really fast when I switched to
Java 1.5, so it was a bit of an inconvenience when I couldn't use them when
working on SIP-Communicator. So I am happy about the switch. I think that
the new features make the code less error-prone and easier for the
programmer.

Cheers
Michael Koch

···

Von: Thomas Hofer [mailto:mailinglisten@familie-hofer.net]
Gesendet: Dienstag, 13. November 2007 16:26
An: dev@sip-communicator.dev.java.net
Betreff: AW: [sip-comm-dev] Using Java 1.5 features

For my point of view, it is important really good to use them, as they
improve the readability, and - more important - can prevent a
classcast-runtime-execptions. And everyone makes mistakes,
one more often,
one more seldom, but we do make them.

Cheers, thomas

> -----Ursprüngliche Nachricht-----
> Von: Emil Ivov [mailto:emcho@sip-communicator.org]
> Gesendet: Dienstag, 13. November 2007 16:16
> An: dev@sip-communicator.dev.java.net
> Betreff: Re: [sip-comm-dev] Using Java 1.5 features
>
> Hello Thomas,
>
> Thomas Hofer wrote:
> > Hi!
> >
> > Another question?
> >
> > As java 1.5 is now the official base java version [is it really? I
> didn't
> > find any comment on the homepage?]
>
> Yes, absolutely.
>
> > is it preferred to use the new features like generics and
> annotations?
>
> You are certainly allowed to use them wherever they fit.
>
> As for whether or not they are the preferred way to go,
that is whether
> programmers should avoid not using them, we haven't really discussed
> this yet. I'd be interested to hear opinions on this one. Should we
> make
> an effort on using J1.5 conventions, or should we, for the
time being,
> leave the the choice to developers?
>
> Emil
>
>
>
> >
> > Cheers, thomas


#18

Seems that the about dialog is tighter integrated in the gui bundle as I
thought.

As there is no possibility to register an exported window in the UIService
(there is no interface for that), the about-window cannot be accessed from
the chat-window any more.
But I think, this is not important and we can live with that.

What do you think?

···

-----Ursprüngliche Nachricht-----
Von: Emil Ivov [mailto:emcho@sip-communicator.org]
Gesendet: Mittwoch, 28. November 2007 12:59
An: dev@sip-communicator.dev.java.net
Betreff: Re: AW: AW: [sip-comm-dev] refactoring the about-dialog

Hey Yana, Thomas,

Yes that's what I meant, Yana, thanks for answering, and thank you,
Thomas, for accepting to take care of it.

Cheers
Emil

Thomas Hofer wrote:
> OK! I'll put it on my task list for next week. Cheers, thomas
>
>> -----Ursprüngliche Nachricht-----
>> Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
>> Gesendet: Mittwoch, 28. November 2007 12:49
>> An: dev@sip-communicator.dev.java.net
>> Betreff: Re: AW: [sip-comm-dev] refactoring the about-dialog
>>
>> Hi Thomas,
>>
>> I think that what Emil meant is that in the future we could think of
>> displaying the splash screen from the launcher. For now I think we
>> could
>> start with merging the splashscreen and the about dialog, as you
>> proposed in one separate bundle. You could move the about dialog in
the
>> splash screen bundle and just give this bundle a more appropriate
name.
>>
>> Cheers,
>> Yana
>>
>> Thomas Hofer wrote:
>>> So what do we do now? Make one bundle for splashscreen and
>> aboutdialog? Or
>>> somehow move the splashcreen into the launcher?
>>>
>>> Cheers, thomas
>>>
>>>> -----Ursprüngliche Nachricht-----
>>>> Von: Emil Ivov [mailto:emcho@sip-communicator.org]
>>>> Gesendet: Mittwoch, 14. November 2007 10:14
>>>> An: dev@sip-communicator.dev.java.net
>>>> Betreff: Re: [sip-comm-dev] refactoring the about-dialog
>>>>
>>>> Hi Richard,
>>>>
>>>> Richard S. Hall wrote:
>>>>> I might add that it could be worthwhile to put all of this
>> "branding"
>>>>> stuff into a single bundle, rather than having them in separate
>>>> bundles.
>>>>
>>>> I completely agree. Right now we have two places where one has to
>>>> change
>>>> content for branding. One is the about dialog and the other is the
>>>> splash screen. It would be a good thing to have them merged.
>>>>
>>>> We were also thinking with Yana that since the splash screen is
now
>> a
>>>> bundle it takes a while for it to show so in the future it would
>>>> probably be a good idea to display it from the SIP Communicator
>>>> launcher
>>>> that we talked about previously. At that point it may also make
>> sense
>>>> to
>>>> also try and merge the launcher with the new branding bundle.
>>>>
>>>> Emil
>>>>
>>>>> Makes it easier to know what to replace, but also proliferating
>> lots
>>>> of
>>>>> little bundles will slow down system start up eventually.
>>>>>
>>>>> -> richard
>>>>>
>>>>> Emil Ivov wrote:
>>>>>> Hi Thomas,
>>>>>>
>>>>>> I also think it's a good idea, especially if you have already
>> worked
>>>> on
>>>>>> something in that direction.
>>>>>>
>>>>>> Emil
>>>>>>
>>>>>> Hofer Thomas wrote:
>>>>>>
>>>>>>> Hi developers and others!
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> I’d like to start a discussion about the „about-dialog“.
>>>>>>>
>>>>>>> In my opinion the about-dialog should be – like the splash
screen
>> –
>>>> a
>>>>>>> bundle, which can be exchanged. This would make it possible to
>>>> “brand”
>>>>>>> the sip-communicator even better than it is possible now.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> What do you think about?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> [ ] Good idea
>>>>>>>
>>>>>>> [ ] No, the about dialog must not be exchanged and therefore
>> should
>>>> be
>>>>>>> part of the main plugin
>>>>>>>
>>>>>>> [ ] Does not matter me.
>>>>>>>
>>>>>>>
>>>>>> ----------------------------------------------------------------
--
>> --
>>>> -
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@sip-
>>>> communicator.dev.java.net
>>>>>> For additional commands, e-mail: dev-help@sip-
>>>> communicator.dev.java.net
>>>>> -----------------------------------------------------------------
--
>> --
>>>>> To unsubscribe, e-mail: dev-unsubscribe@sip-
>> communicator.dev.java.net
>>>>> For additional commands, e-mail: dev-help@sip-
>>>> communicator.dev.java.net
>>>> ------------------------------------------------------------------
--
>> -
>>>> To unsubscribe, e-mail: dev-unsubscribe@sip-
>> communicator.dev.java.net
>>>> For additional commands, e-mail: dev-help@sip-
>> communicator.dev.java.net
>>> -------------------------------------------------------------------
--
>>> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net
>>> For additional commands, e-mail: dev-help@sip-
>> communicator.dev.java.net
>>>
>> --------------------------------------------------------------------
-
>> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net
>> For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#19

Hi!
Another issue I now discovered with the splash screen: it is closed too
fast, in fact, when the UIService bundle is resolved. But the UI is only
visible, when the bundle is started (active). I changed this issue, so that
the splash screen now hides, when the mainwindow is visible, and not before.

I'll commit this change, when the merging with the about dialog is complete.

Cheers
Thomas

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#20

Hi Thomas,

normally if we use the gui plugin mechanism we could add the AboutWindow as a plugin in both the Main window menu and the Chat window menu. I will take care that both Help menus become supported containers for gui plugins. Then in this new bundle we need just to ask uiService.addComponent().

Yana

Thomas Hofer wrote:

···

Seems that the about dialog is tighter integrated in the gui bundle as I
thought.

As there is no possibility to register an exported window in the UIService
(there is no interface for that), the about-window cannot be accessed from
the chat-window any more. But I think, this is not important and we can live with that.

What do you think?

-----Urspr�ngliche Nachricht-----
Von: Emil Ivov [mailto:emcho@sip-communicator.org]
Gesendet: Mittwoch, 28. November 2007 12:59
An: dev@sip-communicator.dev.java.net
Betreff: Re: AW: AW: [sip-comm-dev] refactoring the about-dialog

Hey Yana, Thomas,

Yes that's what I meant, Yana, thanks for answering, and thank you,
Thomas, for accepting to take care of it.

Cheers
Emil

Thomas Hofer wrote:

OK! I'll put it on my task list for next week. Cheers, thomas

-----Urspr�ngliche Nachricht-----
Von: Yana Stamcheva [mailto:yana@sip-communicator.org]
Gesendet: Mittwoch, 28. November 2007 12:49
An: dev@sip-communicator.dev.java.net
Betreff: Re: AW: [sip-comm-dev] refactoring the about-dialog

Hi Thomas,

I think that what Emil meant is that in the future we could think of
displaying the splash screen from the launcher. For now I think we
could
start with merging the splashscreen and the about dialog, as you
proposed in one separate bundle. You could move the about dialog in

the

splash screen bundle and just give this bundle a more appropriate

name.

Cheers,
Yana

Thomas Hofer wrote:

So what do we do now? Make one bundle for splashscreen and

aboutdialog? Or

somehow move the splashcreen into the launcher?

Cheers, thomas

-----Urspr�ngliche Nachricht-----
Von: Emil Ivov [mailto:emcho@sip-communicator.org]
Gesendet: Mittwoch, 14. November 2007 10:14
An: dev@sip-communicator.dev.java.net
Betreff: Re: [sip-comm-dev] refactoring the about-dialog

Hi Richard,

Richard S. Hall wrote:

I might add that it could be worthwhile to put all of this

"branding"

stuff into a single bundle, rather than having them in separate

bundles.

I completely agree. Right now we have two places where one has to
change
content for branding. One is the about dialog and the other is the
splash screen. It would be a good thing to have them merged.

We were also thinking with Yana that since the splash screen is

now

a

bundle it takes a while for it to show so in the future it would
probably be a good idea to display it from the SIP Communicator
launcher
that we talked about previously. At that point it may also make

sense

to
also try and merge the launcher with the new branding bundle.

Emil

Makes it easier to know what to replace, but also proliferating

lots

of

little bundles will slow down system start up eventually.

-> richard

Emil Ivov wrote:

Hi Thomas,

I also think it's a good idea, especially if you have already

worked

on

something in that direction.

Emil

Hofer Thomas wrote:

Hi developers and others!

I�d like to start a discussion about the �about-dialog�.

In my opinion the about-dialog should be � like the splash

screen

a

bundle, which can be exchanged. This would make it possible to

�brand�

the sip-communicator even better than it is possible now.

What do you think about?

[ ] Good idea

[ ] No, the about dialog must not be exchanged and therefore

should

be

part of the main plugin

[ ] Does not matter me.

----------------------------------------------------------------

--

--

-

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

-----------------------------------------------------------------

--

--

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net
------------------------------------------------------------------

--

-

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

-------------------------------------------------------------------

--

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net
--------------------------------------------------------------------

-

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net

For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-

communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net