[sip-comm-dev] Re: svn commit: r7753 - trunk/src/net/java/sip/communicator: impl/gui/main/call impl/gui/main/chat impl/protocol/sip service/protocol service/protocol/...


#1

Damencho, thank you for working on issue #862! I no longer get the
missed-call indicator in SIP Communicator for calls I've accepted on
my other phone.

However, these calls seem to continue to be depicted in the "Call
history" with the red square image with the downward pointing arrow
used for missed calls. Is it intentional?

···

On Wed, Sep 29, 2010 at 12:15 PM, <damencho@dev.java.net> wrote:

New Revision: 7753
Log:
Intorduce issue#862 SIP call markes as missed though answered elsewhere (rfc3326).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi,

···

On Thu, Sep 30, 2010 at 3:58 PM, Lubomir Marinov <lubo@sip-communicator.org> wrote:

On Wed, Sep 29, 2010 at 12:15 PM, <damencho@dev.java.net> wrote:

New Revision: 7753
Log:
Intorduce issue#862 SIP call markes as missed though answered elsewhere (rfc3326).

Damencho, thank you for working on issue #862! I no longer get the
missed-call indicator in SIP Communicator for calls I've accepted on
my other phone.

However, these calls seem to continue to be depicted in the "Call
history" with the red square image with the downward pointing arrow
used for missed calls. Is it intentional?

No its not intentional. What do you think should be our behaviour
here? We should mark them as incoming with 0 sec. duration?

Cheers
damencho

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

На 30.09.10 15:10, Damian Minkov написа:

Hi,

New Revision: 7753
Log:
Intorduce issue#862 SIP call markes as missed though answered elsewhere (rfc3326).

Damencho, thank you for working on issue #862! I no longer get the
missed-call indicator in SIP Communicator for calls I've accepted on
my other phone.

However, these calls seem to continue to be depicted in the "Call
history" with the red square image with the downward pointing arrow
used for missed calls. Is it intentional?

No its not intentional. What do you think should be our behaviour
here? We should mark them as incoming with 0 sec. duration?

Sounds reasonable indeed.

Emil

···

On Thu, Sep 30, 2010 at 3:58 PM, Lubomir Marinov > <lubo@sip-communicator.org> wrote:

On Wed, Sep 29, 2010 at 12:15 PM, <damencho@dev.java.net> wrote:

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

The other day we discusses incoming calls in SIP Communicator which
the receiver cancels and we thought it was a good idea to leave them
marked as missed so that the receiver can later look at the "Call
history" and be reminded to call back. If we decide that the incoming
calls answered elsewhere are to also be marked as missed in the "Call
history", I think the missed-call flag will begin to be overloaded
with respect to meaning. Besides, these calls are answered. So I
support marking them as answered incoming calls.

As to the duration, I don't have a strong opinion (because I'm not
sure I'm entirely convinced we must display "duration: 00:00:00" for
missed calls and calls answered elsewhere). But I expect it to be
easier to just have the calls answered elsewhere as answered incoming
calls with 0 sec. duration so... yeah.

···

On Thu, Sep 30, 2010 at 4:10 PM, Damian Minkov <damencho@sip-communicator.org> wrote:

What do you think should be our behaviour
here? We should mark them as incoming with 0 sec. duration?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

HI,

it comes another problem. It seems that callhistory service consider
all calls with equal start and end time as missed. Actually we don't
have any flag saved in the history whether a call is missed or not.
Maybe we should put one and if flag is missing keep old behaviour.
WDYT?

damencho

···

On Thu, Sep 30, 2010 at 4:33 PM, Lubomir Marinov <lubo@sip-communicator.org> wrote:

On Thu, Sep 30, 2010 at 4:10 PM, Damian Minkov > <damencho@sip-communicator.org> wrote:

What do you think should be our behaviour
here? We should mark them as incoming with 0 sec. duration?

The other day we discusses incoming calls in SIP Communicator which
the receiver cancels and we thought it was a good idea to leave them
marked as missed so that the receiver can later look at the "Call
history" and be reminded to call back. If we decide that the incoming
calls answered elsewhere are to also be marked as missed in the "Call
history", I think the missed-call flag will begin to be overloaded
with respect to meaning. Besides, these calls are answered. So I
support marking them as answered incoming calls.

As to the duration, I don't have a strong opinion (because I'm not
sure I'm entirely convinced we must display "duration: 00:00:00" for
missed calls and calls answered elsewhere). But I expect it to be
easier to just have the calls answered elsewhere as answered incoming
calls with 0 sec. duration so... yeah.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

It seems that callhistory service consider
all calls with equal start and end time as missed. Actually we don't
have any flag saved in the history whether a call is missed or not.
Maybe we should put one

For that matter, we could add a reason instead? Like the reason code
and string in the SIP case. (I guess Jingle is advanced enough to be
likely to provide such a reason as well.)

if flag is missing keep old behaviour.

Well, sure.

···

On Thu, Sep 30, 2010 at 4:59 PM, Damian Minkov <damencho@sip-communicator.org> wrote:

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Its done in r7774. If you have any other comment you are welcome :slight_smile:

···

On Thu, Sep 30, 2010 at 5:28 PM, Lubomir Marinov <lubo@sip-communicator.org> wrote:

On Thu, Sep 30, 2010 at 4:59 PM, Damian Minkov > <damencho@sip-communicator.org> wrote:

It seems that callhistory service consider
all calls with equal start and end time as missed. Actually we don't
have any flag saved in the history whether a call is missed or not.
Maybe we should put one

For that matter, we could add a reason instead? Like the reason code
and string in the SIP case. (I guess Jingle is advanced enough to be
likely to provide such a reason as well.)

if flag is missing keep old behaviour.

Well, sure.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net