[sip-comm-dev] Re: svn commit: r7477 - trunk: resources/languages src/net/java/sip/communicator/impl/gui/main/chat/conference src/net/java/sip/communicator/impl/gui/m...


#1

Damencho, I haven't looked at the code but I think the suggested chat
rooms are loaded into the "Chat room name" combo in the UI thread and
the "Go to chat room" dialog opens too slow at times. I have a Jabber
account which is preselected in the "Go to chat room" dialog when it
opens and the "Chat room name" combo contains three chat rooms but the
dialog opens with a noticeable delay and at first I thought there was
an exception and it would never open. Do you think we could have the
suggested chat rooms loaded in the background so that the opening of
the "Go to chat room" dialog doesn't block for such a long time?

BTW, I find the "name" in "Chat room name" obsolete.

···

On Wed, Jul 21, 2010 at 6:23 PM, <damencho@dev.java.net> wrote:

Author: damencho
Date: 2010-07-21 15:23:17+0000
New Revision: 7477

Log:
Introduce new dialog for creating and joining chat rooms.
Add option for autojoin on startup for the chat rooms.
Add option in general configuration form, will we leave the room when we close the window.
Add new button in chat window for leaving a room if closing window doesn't leave it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

I'm sorry I forgot to mention it before: the combo is labeled "Chat
room name" and the table bellow as a column "Room Name". While I don't
know the reasons for the differences in the phrases and the
capitalization, I think I'd appreciate them being one and the same
string for the purposes of relating them more easily.

···

On Fri, Jul 23, 2010 at 12:46 PM, Lubomir Marinov <lubo@sip-communicator.org> wrote:

BTW, I find the "name" in "Chat room name" obsolete.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi,

you were right. Loading of chat rooms was in different thread, but the
initial loading when dialog is being open was in the thread creating
the dialog (the swing one). I've fixed the issues you mentioned with
r7487.

Thanks
damencho

···

On Fri, Jul 23, 2010 at 12:59 PM, Lubomir Marinov <lubo@sip-communicator.org> wrote:

On Fri, Jul 23, 2010 at 12:46 PM, Lubomir Marinov > <lubo@sip-communicator.org> wrote:

BTW, I find the "name" in "Chat room name" obsolete.

I'm sorry I forgot to mention it before: the combo is labeled "Chat
room name" and the table bellow as a column "Room Name". While I don't
know the reasons for the differences in the phrases and the
capitalization, I think I'd appreciate them being one and the same
string for the purposes of relating them more easily.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net