[sip-comm-dev] Re: svn commit: r7170 - trunk/src/net/java/sip/communicator/impl/neomedia/codec/video/h264/JNIEncoder.java


#1

Seb, why do you use both DEFAULT_FRAME_RATE and frameRate? As far as I
understand the code, using the frameRate of the outputFormat is
preferable because it respects more properties of the outputFormat. I
guess DEFAULT_FRAME_RATE and frameRate are likely to be equal but...

···

On Wed, May 26, 2010 at 12:38 PM, <s_vincent@dev.java.net> wrote:

+ FFmpeg.avcodeccontext_set_bit_rate_tolerance(avcontext, (int)(bitRate /
+ DEFAULT_FRAME_RATE));

    FFmpeg\.avcodeccontext\_set\_time\_base\(avcontext, 1, frameRate\);

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Lubomir,

Le 26/05/2010 11:57, Lubomir Marinov a �crit :

···

On Wed, May 26, 2010 at 12:38 PM,<s_vincent@dev.java.net> wrote:
   

+ FFmpeg.avcodeccontext_set_bit_rate_tolerance(avcontext, (int)(bitRate /
+ DEFAULT_FRAME_RATE));
     
         FFmpeg.avcodeccontext_set_time_base(avcontext, 1, frameRate);
     

Seb, why do you use both DEFAULT_FRAME_RATE and frameRate? As far as I
understand the code, using the frameRate of the outputFormat is
preferable because it respects more properties of the outputFormat. I
guess DEFAULT_FRAME_RATE and frameRate are likely to be equal but...

You are right, I move up the frameRate variable for this purpose but forget to rename in set_bit_rate_tolerance. I will fix it, thanks.

--
Seb

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net