[sip-comm-dev] Re: svn commit: r7158 - trunk/src/net/java/sip/communicator: impl/neomedia impl/protocol/sip service/neomedia


#1

Hi Werner,

I believe some change in r7158, r7159 and/or r7160 breaks the
streaming of video in such a way that the whole video is replaced by
mostly gray i.e. the video is streaming, its width and height is
correct but the image that it's supposed to display is wrong.

Best regards,
Lubo

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

На 23.05.10 07:06, Lubomir Marinov написа:

Hi Werner,

I believe some change in r7158, r7159 and/or r7160 breaks the
streaming of video in such a way that the whole video is replaced by
mostly gray i.e. the video is streaming, its width and height is
correct but the image that it's supposed to display is wrong.

Confirmed! Looks like an issue with one of the changes on the RTP buffers.

Cheers,
Emil

···

Best regards,
Lubo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi Lubo, Emil,

it's part of r7159. I just fixed most of it already, Video and Audio, with
and without ZRTP is working here again (Linux to Windows XP). Just need to
fix some stuff in the RawPacket class to maintain the buffers, length, offset
etc correctly. I'll checkin the fixes later today.

Regards,
Werner

···

Am 23.05.2010 07:06, schrieb Lubomir Marinov:

Hi Werner,

I believe some change in r7158, r7159 and/or r7160 breaks the
streaming of video in such a way that the whole video is replaced by
mostly gray i.e. the video is streaming, its width and height is
correct but the image that it's supposed to display is wrong.

Best regards,
Lubo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi Lubo, Emil,

I just checked in r7162 that should fix the problems. I've tested it with
Linux - windows XP Audio and video, with and without ZRTP/SRTP and it looks
ok.

Emil, Lubo: can you have a look to some RawPacket methods and cross check if
my assumptions / enhancements are ok? In particular to setCsrcList(...). As
said in he checkin comment now the buffer.length may differ from the length
field of RawPacket. Only the length field gives the real info about the length
of the data.

I need to check RFC 5285 to grok the way the new extension work
and if I can do an in-buffer copying in addExtension(...) as well (as it is
done for the setCsrcList).

This also depends how often these methods are used, maybe often during
conference calls? If they are not much used then we could just leave
addExtension(...) as it is.

Regards,
Werner

···

Am 23.05.2010 13:16, schrieb Emil Ivov:

На 23.05.10 07:06, Lubomir Marinov написа:

Hi Werner,

I believe some change in r7158, r7159 and/or r7160 breaks the
streaming of video in such a way that the whole video is replaced by
mostly gray i.e. the video is streaming, its width and height is
correct but the image that it's supposed to display is wrong.

Confirmed! Looks like an issue with one of the changes on the RTP buffers.

Cheers,
Emil

Best regards,
Lubo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hey Werner,

На 23.05.10 18:37, Werner Dittmann написа:

Hi Lubo, Emil,

I just checked in r7162 that should fix the problems. I've tested it with
Linux - windows XP Audio and video, with and without ZRTP/SRTP and it looks
ok.

Emil, Lubo: can you have a look to some RawPacket methods and cross check if
my assumptions / enhancements are ok? In particular to setCsrcList(...). As
said in he checkin comment now the buffer.length may differ from the length
field of RawPacket. Only the length field gives the real info about the length
of the data.

I need to check RFC 5285 to grok the way the new extension work
and if I can do an in-buffer copying in addExtension(...) as well (as it is
done for the setCsrcList).

Unfortunately, the changes seem to be causing a problem with conference
calls that have audio level delivery enabled. The problem prevents some
participants from hearing or being heard (not all though).

I am afraid our hands are currently full as we are preparing for a demo
this Friday and won't be able to investigate and properly fix the issue
until then.

We do need conference calls to be working again though so, if you can't
investigate this either, could you please revert your changes? We can
schedule the optimization as an issue and try to have a look at it later
on. Would that be ok?

Emil

···

This also depends how often these methods are used, maybe often during
conference calls? If they are not much used then we could just leave
addExtension(...) as it is.

Regards,
Werner

Am 23.05.2010 13:16, schrieb Emil Ivov:

На 23.05.10 07:06, Lubomir Marinov написа:

Hi Werner,

I believe some change in r7158, r7159 and/or r7160 breaks the
streaming of video in such a way that the whole video is replaced by
mostly gray i.e. the video is streaming, its width and height is
correct but the image that it's supposed to display is wrong.

Confirmed! Looks like an issue with one of the changes on the RTP buffers.

Cheers,
Emil

Best regards,
Lubo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Emil,

try r7163. I reverted some optimizations in csrc list, this should now work again.

If not I need to revert much more and can do this only later afternoon
today.

Regards,
Werner

···

Am 24.05.2010 21:59, schrieb Emil Ivov:

Hey Werner,

На 23.05.10 18:37, Werner Dittmann написа:

Hi Lubo, Emil,

I just checked in r7162 that should fix the problems. I've tested it with
Linux - windows XP Audio and video, with and without ZRTP/SRTP and it looks
ok.

Emil, Lubo: can you have a look to some RawPacket methods and cross check if
my assumptions / enhancements are ok? In particular to setCsrcList(...). As
said in he checkin comment now the buffer.length may differ from the length
field of RawPacket. Only the length field gives the real info about the length
of the data.

I need to check RFC 5285 to grok the way the new extension work
and if I can do an in-buffer copying in addExtension(...) as well (as it is
done for the setCsrcList).

Unfortunately, the changes seem to be causing a problem with conference
calls that have audio level delivery enabled. The problem prevents some
participants from hearing or being heard (not all though).

I am afraid our hands are currently full as we are preparing for a demo
this Friday and won't be able to investigate and properly fix the issue
until then.

We do need conference calls to be working again though so, if you can't
investigate this either, could you please revert your changes? We can
schedule the optimization as an issue and try to have a look at it later
on. Would that be ok?

Emil

This also depends how often these methods are used, maybe often during
conference calls? If they are not much used then we could just leave
addExtension(...) as it is.

Regards,
Werner

Am 23.05.2010 13:16, schrieb Emil Ivov:

На 23.05.10 07:06, Lubomir Marinov написа:

Hi Werner,

I believe some change in r7158, r7159 and/or r7160 breaks the
streaming of video in such a way that the whole video is replaced by
mostly gray i.e. the video is streaming, its width and height is
correct but the image that it's supposed to display is wrong.

Confirmed! Looks like an issue with one of the changes on the RTP buffers.

Cheers,
Emil

Best regards,
Lubo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hi,

I've just tested audio levels and they are working. But I still has
some errors when going from One2One call to conference call, and I'm
not sure where the problems come from. I'm currently looking at it.

Thanks
damencho

···

On Tue, May 25, 2010 at 8:51 AM, Werner Dittmann <Werner.Dittmann@t-online.de> wrote:

Emil,

try r7163. I reverted some optimizations in csrc list, this should now work again.

If not I need to revert much more and can do this only later afternoon
today.

Regards,
Werner

Am 24.05.2010 21:59, schrieb Emil Ivov:

Hey Werner,

На 23.05.10 18:37, Werner Dittmann написа:

Hi Lubo, Emil,

I just checked in r7162 that should fix the problems. I've tested it with
Linux - windows XP Audio and video, with and without ZRTP/SRTP and it looks
ok.

Emil, Lubo: can you have a look to some RawPacket methods and cross check if
my assumptions / enhancements are ok? In particular to setCsrcList(...). As
said in he checkin comment now the buffer.length may differ from the length
field of RawPacket. Only the length field gives the real info about the length
of the data.

I need to check RFC 5285 to grok the way the new extension work
and if I can do an in-buffer copying in addExtension(...) as well (as it is
done for the setCsrcList).

Unfortunately, the changes seem to be causing a problem with conference
calls that have audio level delivery enabled. The problem prevents some
participants from hearing or being heard (not all though).

I am afraid our hands are currently full as we are preparing for a demo
this Friday and won't be able to investigate and properly fix the issue
until then.

We do need conference calls to be working again though so, if you can't
investigate this either, could you please revert your changes? We can
schedule the optimization as an issue and try to have a look at it later
on. Would that be ok?

Emil

This also depends how often these methods are used, maybe often during
conference calls? If they are not much used then we could just leave
addExtension(...) as it is.

Regards,
Werner

Am 23.05.2010 13:16, schrieb Emil Ivov:

На 23.05.10 07:06, Lubomir Marinov написа:

Hi Werner,

I believe some change in r7158, r7159 and/or r7160 breaks the
streaming of video in such a way that the whole video is replaced by
mostly gray i.e. the video is streaming, its width and height is
correct but the image that it's supposed to display is wrong.

Confirmed! Looks like an issue with one of the changes on the RTP buffers.

Cheers,
Emil

Best regards,
Lubo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Hi,

the problems was on the protocol side :), it must be fixed now (r7168).

Thanks
damencho

···

2010/5/25 Damian Minkov <damencho@sip-communicator.org>:

Hi,

I've just tested audio levels and they are working. But I still has
some errors when going from One2One call to conference call, and I'm
not sure where the problems come from. I'm currently looking at it.

Thanks
damencho

On Tue, May 25, 2010 at 8:51 AM, Werner Dittmann > <Werner.Dittmann@t-online.de> wrote:

Emil,

try r7163. I reverted some optimizations in csrc list, this should now work again.

If not I need to revert much more and can do this only later afternoon
today.

Regards,
Werner

Am 24.05.2010 21:59, schrieb Emil Ivov:

Hey Werner,

На 23.05.10 18:37, Werner Dittmann написа:

Hi Lubo, Emil,

I just checked in r7162 that should fix the problems. I've tested it with
Linux - windows XP Audio and video, with and without ZRTP/SRTP and it looks
ok.

Emil, Lubo: can you have a look to some RawPacket methods and cross check if
my assumptions / enhancements are ok? In particular to setCsrcList(...). As
said in he checkin comment now the buffer.length may differ from the length
field of RawPacket. Only the length field gives the real info about the length
of the data.

I need to check RFC 5285 to grok the way the new extension work
and if I can do an in-buffer copying in addExtension(...) as well (as it is
done for the setCsrcList).

Unfortunately, the changes seem to be causing a problem with conference
calls that have audio level delivery enabled. The problem prevents some
participants from hearing or being heard (not all though).

I am afraid our hands are currently full as we are preparing for a demo
this Friday and won't be able to investigate and properly fix the issue
until then.

We do need conference calls to be working again though so, if you can't
investigate this either, could you please revert your changes? We can
schedule the optimization as an issue and try to have a look at it later
on. Would that be ok?

Emil

This also depends how often these methods are used, maybe often during
conference calls? If they are not much used then we could just leave
addExtension(...) as it is.

Regards,
Werner

Am 23.05.2010 13:16, schrieb Emil Ivov:

На 23.05.10 07:06, Lubomir Marinov написа:

Hi Werner,

I believe some change in r7158, r7159 and/or r7160 breaks the
streaming of video in such a way that the whole video is replaced by
mostly gray i.e. the video is streaming, its width and height is
correct but the image that it's supposed to display is wrong.

Confirmed! Looks like an issue with one of the changes on the RTP buffers.

Cheers,
Emil

Best regards,
Lubo

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net