[sip-comm-dev] Re: svn commit: r6454 - trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf


#1

Hi Werner,

Could you please share with me why neomedia needs ZrtpConfigure? To my
knowledge, neomedia's latest version doesn't contain ZRTP-specific
code.

Best regards,
Lubomir

···

On Mon, Dec 7, 2009 at 8:07 PM, <wernerd@dev.java.net> wrote:

Author: wernerd
Date: 2009-12-07 18:07:55+0000
New Revision: 6454

Modified:
trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf

Log:
Neomedia needs ZrtpConfigure too

Modified: trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf?view=diff&rev=6454&p1=trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf&p2=trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf&r1=6453&r2=6454

--- trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf (original)
+++ trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf 2009-12-07 18:07:55+0000
@@ -28,6 +28,7 @@
net.java.sip.communicator.service.resources,
net.java.sip.communicator.util,
net.java.sip.communicator.util.swing,
+ net.java.sip.communicator.plugin.zrtpconfigure,
quicktime,
quicktime.std.sg,
quicktime.qd,

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Lubo,

the neomedia manifest imports ZRTP as far as I have seen. The
error message of the last failed build reported a unresolved contraint
in neomedia and the only thing that that was missing was zrtpconfigure
package. Does neomedia somehow references code from the old media that
uses zrtpconfigure already?

Regards,
Werner

···

Am 07.12.2009 19:18, schrieb Lubomir Marinov:

Hi Werner,

Could you please share with me why neomedia needs ZrtpConfigure? To my
knowledge, neomedia's latest version doesn't contain ZRTP-specific
code.

Best regards,
Lubomir

On Mon, Dec 7, 2009 at 8:07 PM, <wernerd@dev.java.net> wrote:

Author: wernerd
Date: 2009-12-07 18:07:55+0000
New Revision: 6454

Modified:
  trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf

Log:
Neomedia needs ZrtpConfigure too

Modified: trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf?view=diff&rev=6454&p1=trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf&p2=trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf&r1=6453&r2=6454

--- trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf (original)
+++ trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf 2009-12-07 18:07:55+0000
@@ -28,6 +28,7 @@
net.java.sip.communicator.service.resources,
net.java.sip.communicator.util,
net.java.sip.communicator.util.swing,
+ net.java.sip.communicator.plugin.zrtpconfigure,
quicktime,
quicktime.std.sg,
quicktime.qd,

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hey Werner,

The thing is that we generally don't import plugin packages into core
bundles (or anywhere else for that matter). By the way, I am sorry for
not answering your placement question earlier.

I guess that if impl.neomedia needs to access code that is in
zrtpconfigure then it would be best to commit the whole form in
impl.neomedia.zrtpconfigure and get rid of all the inter-bundle
dependencies.

I also noticed that all configuration optionsoptions are unchecked by
default and I need to click one of the buttons at the top in order to
have some of them selected. Is that intentional?

Also, I am thinking that it would be nice to use the grey padlock icon
that we are using in the chat window for example. (Later on we may
call the button security and also add an OTR tab in the same form)

How does that sound?

Cheers,
Emil

···

On Mon, Dec 7, 2009 at 9:38 PM, Werner Dittmann <Werner.Dittmann@t-online.de> wrote:

Lubo,

the neomedia manifest imports ZRTP as far as I have seen. The
error message of the last failed build reported a unresolved contraint
in neomedia and the only thing that that was missing was zrtpconfigure
package. Does neomedia somehow references code from the old media that
uses zrtpconfigure already?

Regards,
Werner

Am 07.12.2009 19:18, schrieb Lubomir Marinov:

Hi Werner,

Could you please share with me why neomedia needs ZrtpConfigure? To my
knowledge, neomedia's latest version doesn't contain ZRTP-specific
code.

Best regards,
Lubomir

On Mon, Dec 7, 2009 at 8:07 PM, <wernerd@dev.java.net> wrote:

Author: wernerd
Date: 2009-12-07 18:07:55+0000
New Revision: 6454

Modified:
trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf

Log:
Neomedia needs ZrtpConfigure too

Modified: trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf?view=diff&rev=6454&p1=trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf&p2=trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf&r1=6453&r2=6454

--- trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf (original)
+++ trunk/src/net/java/sip/communicator/impl/neomedia/neomedia.manifest.mf 2009-12-07 18:07:55+0000
@@ -28,6 +28,7 @@
net.java.sip.communicator.service.resources,
net.java.sip.communicator.util,
net.java.sip.communicator.util.swing,
+ net.java.sip.communicator.plugin.zrtpconfigure,
quicktime,
quicktime.std.sg,
quicktime.qd,

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31