[sip-comm-dev] Re: svn commit: r5396 - branches/1.0/resources/languages/resources.properties


#1

Hi Romain,

just a typo from me :slight_smile:
a while ago I struggled with MessageFormatters in java and I found a problem when using
parameters and single quotes. So I put a info in the resource file :

# - cannot use single quotes and parameters.
# If you want a single quote to appear in the translated message
# put ''(two quotes)

So the use of two quotes is on purpose :slight_smile:

Cheers
damencho

rkuntz@dev.java.net wrote:

路路路

Author: rkuntz
Date: 2009-06-18 08:53:42+0000
New Revision: 5396

Modified:
聽聽聽branches/1.0/resources/languages/resources.properties

Log:
Fixing a few typos in the english resources file

Modified: branches/1.0/resources/languages/resources.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/branches/1.0/resources/languages/resources.properties?view=diff&rev=5396&p1=branches/1.0/resources/languages/resources.properties&p2=branches/1.0/resources/languages/resources.properties&r1=5395&r2=5396

--- branches/1.0/resources/languages/resources.properties (original)
+++ branches/1.0/resources/languages/resources.properties 2009-06-18 08:53:42+0000
@@ -102,7 +102,7 @@
service.gui.CONNECTION_EXPIRED_MSG=You are currently disconnected from the {0} server.
service.gui.CONNECTION_REQUIRED_TO_JOIN=You have to be connected in order to join a chat room. Please connect and then try again.
service.gui.CONNECTION_REQUIRED_TO_LEAVE=You have to be connected in order to leave a chat room.
-service.gui.CONTACT_NOT_SUPPORTING_TELEPHONY=The choosen {0} contact doesn''t support telephony.
+service.gui.CONTACT_NOT_SUPPORTING_TELEPHONY=The choosen {0} contact doesn't support telephony.
service.gui.CONTACT_PAUSED_TYPING={0} paused typing the message
service.gui.CONTACT_TYPING={0} is typing a message
service.gui.CONTACT_TYPING_STATE_STALE=typing state not updated
@@ -181,7 +181,7 @@
service.gui.KICK_FAILED_NOT_ENOUGH_PERMISSIONS=Failed to kick {0}. You don''t have enough privileges to do that.
service.gui.LAST=Last
service.gui.LEAVE=&Leave
-service.gui.LIMIT_REACHED_FOR_IP=You have too many existing registrations from the local IP address and the {0} server doesn''t allow to open any more of them.
+service.gui.LIMIT_REACHED_FOR_IP=You have too many existing registrations from the local IP address and the {0} server doesn't allow to open any more of them.
service.gui.LOGIN=&Login
service.gui.LOGIN_NETWORK_ERROR=Unable to log in with account: User name: {0}, Server name: {1}, due to a network failure. Please check your network connection.
User name: {0}<BR>\
@@ -431,7 +431,7 @@
plugin.dictaccregwizz.FIRST_MATCH=First Match
plugin.dictaccregwizz.NO_MATCH=No match
plugin.dictaccregwizz.MATCH_RESULT=No definitions found for "{0}", perhaps you mean:\n
-plugin.dictaccregwizz.INVALID_DATABASE=The current dictionary "{0}" doesn''t exist anymore on the server.
+plugin.dictaccregwizz.INVALID_DATABASE=The current dictionary "{0}" doesn't exist anymore on the server.
plugin.dictaccregwizz.INVALID_STRATEGY=The current strategy isn't available on the server.
plugin.dictaccregwizz.PROTOCOL_NAME=Dict
plugin.dictaccregwizz.PROTOCOL_DESCRIPTION=The Dict service protocol

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Damian,

Hi Romain,

just a typo from me :slight_smile:
a while ago I struggled with MessageFormatters in java and I found a problem when using
parameters and single quotes. So I put a info in the resource file :

# - cannot use single quotes and parameters.
# If you want a single quote to appear in the translated message
# put ''(two quotes)

So the use of two quotes is on purpose :slight_smile:

Oh, my mistake, I somehow skipped this note. But the problem is that double quotes are actually displayed as double quotes on my mac (see the enclosed picture), that's why I initially changed it. May it be mac-specific?

I can revert the fix if you want (but there's a lot of single quotes in the translation, should we consider changing them to?).

romain

路路路

On 2009/06/18, at 11:08, Damian Minkov wrote:


#3

Hi again,

aha I see, it seems my mistake. Now its obvious who put those double quotes :wink:
I cannot remember what was the order of the problem was it parameter-quote or quote-parameter.
I test it myself on linux that double quotes are problem (as the example screenshot you provided).

Sorry for the wrong typo :slight_smile:
damencho

Romain KUNTZ wrote:

路路路

Hi Damian,

On 2009/06/18, at 11:08, Damian Minkov wrote:

Hi Romain,

just a typo from me :slight_smile:
a while ago I struggled with MessageFormatters in java and I found a problem when using
parameters and single quotes. So I put a info in the resource file :

# - cannot use single quotes and parameters.
# If you want a single quote to appear in the translated message
# put ''(two quotes)

So the use of two quotes is on purpose :slight_smile:

Oh, my mistake, I somehow skipped this note. But the problem is that double quotes are actually displayed as double quotes on my mac (see the enclosed picture), that's why I initially changed it. May it be mac-specific?

I can revert the fix if you want (but there's a lot of single quotes in the translation, should we consider changing them to?).

romain

------------------------------------------------------------------------

rkuntz@dev.java.net wrote:

Author: rkuntz
Date: 2009-06-18 08:53:42+0000
New Revision: 5396

Modified:
聽聽branches/1.0/resources/languages/resources.properties

Log:
Fixing a few typos in the english resources file

Modified: branches/1.0/resources/languages/resources.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/branches/1.0/resources/languages/resources.properties?view=diff&rev=5396&p1=branches/1.0/resources/languages/resources.properties&p2=branches/1.0/resources/languages/resources.properties&r1=5395&r2=5396

=

--- branches/1.0/resources/languages/resources.properties (original)
+++ branches/1.0/resources/languages/resources.properties 2009-06-18 08:53:42+0000
@@ -102,7 +102,7 @@
service.gui.CONNECTION_EXPIRED_MSG=You are currently disconnected from the {0} server.
service.gui.CONNECTION_REQUIRED_TO_JOIN=You have to be connected in order to join a chat room. Please connect and then try again.
service.gui.CONNECTION_REQUIRED_TO_LEAVE=You have to be connected in order to leave a chat room.
-service.gui.CONTACT_NOT_SUPPORTING_TELEPHONY=The choosen {0} contact doesn''t support telephony.
+service.gui.CONTACT_NOT_SUPPORTING_TELEPHONY=The choosen {0} contact doesn't support telephony.
service.gui.CONTACT_PAUSED_TYPING={0} paused typing the message
service.gui.CONTACT_TYPING={0} is typing a message
service.gui.CONTACT_TYPING_STATE_STALE=typing state not updated
@@ -181,7 +181,7 @@
service.gui.KICK_FAILED_NOT_ENOUGH_PERMISSIONS=Failed to kick {0}. You don''t have enough privileges to do that.
service.gui.LAST=Last
service.gui.LEAVE=&Leave
-service.gui.LIMIT_REACHED_FOR_IP=You have too many existing registrations from the local IP address and the {0} server doesn''t allow to open any more of them.
+service.gui.LIMIT_REACHED_FOR_IP=You have too many existing registrations from the local IP address and the {0} server doesn't allow to open any more of them.
service.gui.LOGIN=&Login
service.gui.LOGIN_NETWORK_ERROR=Unable to log in with account: User name: {0}, Server name: {1}, due to a network failure. Please check your network connection.
User name: {0}<BR>\
@@ -431,7 +431,7 @@
plugin.dictaccregwizz.FIRST_MATCH=First Match
plugin.dictaccregwizz.NO_MATCH=No match
plugin.dictaccregwizz.MATCH_RESULT=No definitions found for "{0}", perhaps you mean:\n
-plugin.dictaccregwizz.INVALID_DATABASE=The current dictionary "{0}" doesn''t exist anymore on the server.
+plugin.dictaccregwizz.INVALID_DATABASE=The current dictionary "{0}" doesn't exist anymore on the server.
plugin.dictaccregwizz.INVALID_STRATEGY=The current strategy isn't available on the server.
plugin.dictaccregwizz.PROTOCOL_NAME=Dict
plugin.dictaccregwizz.PROTOCOL_DESCRIPTION=The Dict service protocol

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi Damian,

Ok I see, it seems that simple quotes are a problem only when used with parameters. For example, with this translation:
service.gui.HISTORY_CONTACT=History - '{0}' - ''{0}'' - "{0}"

We obtain the enclosed picture. If you're OK, I will change the note in the translation file with:

# - cannot use single quotes with parameters (e.g. '{0}').
# If you want a single quote to appear in the translated message
# put '' (two quotes): e.g. ''{0}''

I'll also replace the other double quotes with one, when necessary.

Cheers,
romain


#5

Hi,

you are absolutely right but the situation I was talking about is the following :

System.out.println(MessageFormat.format("don't display param {0}", "Test-Param"));

that was the the problem that I found while ago and tried to fix.

damencho

Romain KUNTZ wrote:

路路路

Hi Damian,

Ok I see, it seems that simple quotes are a problem only when used with parameters. For example, with this translation:
service.gui.HISTORY_CONTACT=History - '{0}' - ''{0}'' - "{0}"

We obtain the enclosed picture. If you're OK, I will change the note in the translation file with:

# - cannot use single quotes with parameters (e.g. '{0}').
# If you want a single quote to appear in the translated message
# put '' (two quotes): e.g. ''{0}''

I'll also replace the other double quotes with one, when necessary.

Cheers,
romain

------------------------------------------------------------------------

On 2009/06/18, at 11:33, Damian Minkov wrote:

Hi again,

aha I see, it seems my mistake. Now its obvious who put those double quotes :wink:
I cannot remember what was the order of the problem was it parameter-quote or quote-parameter.
I test it myself on linux that double quotes are problem (as the example screenshot you provided).

Sorry for the wrong typo :slight_smile:
damencho

Romain KUNTZ wrote:

Hi Damian,

On 2009/06/18, at 11:08, Damian Minkov wrote:

Hi Romain,

just a typo from me :slight_smile:
a while ago I struggled with MessageFormatters in java and I found a problem when using
parameters and single quotes. So I put a info in the resource file :

# - cannot use single quotes and parameters.
# If you want a single quote to appear in the translated message
# put ''(two quotes)

So the use of two quotes is on purpose :slight_smile:

Oh, my mistake, I somehow skipped this note. But the problem is that double quotes are actually displayed as double quotes on my mac (see the enclosed picture), that's why I initially changed it. May it be mac-specific?

I can revert the fix if you want (but there's a lot of single quotes in the translation, should we consider changing them to?).

romain

------------------------------------------------------------------------

rkuntz@dev.java.net wrote:

Author: rkuntz
Date: 2009-06-18 08:53:42+0000
New Revision: 5396

Modified:
branches/1.0/resources/languages/resources.properties

Log:
Fixing a few typos in the english resources file

Modified: branches/1.0/resources/languages/resources.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/branches/1.0/resources/languages/resources.properties?view=diff&rev=5396&p1=branches/1.0/resources/languages/resources.properties&p2=branches/1.0/resources/languages/resources.properties&r1=5395&r2=5396

=

--- branches/1.0/resources/languages/resources.properties (original)
+++ branches/1.0/resources/languages/resources.properties 2009-06-18 08:53:42+0000
@@ -102,7 +102,7 @@
service.gui.CONNECTION_EXPIRED_MSG=You are currently disconnected from the {0} server.
service.gui.CONNECTION_REQUIRED_TO_JOIN=You have to be connected in order to join a chat room. Please connect and then try again.
service.gui.CONNECTION_REQUIRED_TO_LEAVE=You have to be connected in order to leave a chat room.
-service.gui.CONTACT_NOT_SUPPORTING_TELEPHONY=The choosen {0} contact doesn''t support telephony.
+service.gui.CONTACT_NOT_SUPPORTING_TELEPHONY=The choosen {0} contact doesn't support telephony.
service.gui.CONTACT_PAUSED_TYPING={0} paused typing the message
service.gui.CONTACT_TYPING={0} is typing a message
service.gui.CONTACT_TYPING_STATE_STALE=typing state not updated
@@ -181,7 +181,7 @@
service.gui.KICK_FAILED_NOT_ENOUGH_PERMISSIONS=Failed to kick {0}. You don''t have enough privileges to do that.
service.gui.LAST=Last
service.gui.LEAVE=&Leave
-service.gui.LIMIT_REACHED_FOR_IP=You have too many existing registrations from the local IP address and the {0} server doesn''t allow to open any more of them.
+service.gui.LIMIT_REACHED_FOR_IP=You have too many existing registrations from the local IP address and the {0} server doesn't allow to open any more of them.
service.gui.LOGIN=&Login
service.gui.LOGIN_NETWORK_ERROR=Unable to log in with account: User name: {0}, Server name: {1}, due to a network failure. Please check your network connection.
User name: {0}<BR>\
@@ -431,7 +431,7 @@
plugin.dictaccregwizz.FIRST_MATCH=First Match
plugin.dictaccregwizz.NO_MATCH=No match
plugin.dictaccregwizz.MATCH_RESULT=No definitions found for "{0}", perhaps you mean:\n
-plugin.dictaccregwizz.INVALID_DATABASE=The current dictionary "{0}" doesn''t exist anymore on the server.
+plugin.dictaccregwizz.INVALID_DATABASE=The current dictionary "{0}" doesn't exist anymore on the server.
plugin.dictaccregwizz.INVALID_STRATEGY=The current strategy isn't available on the server.
plugin.dictaccregwizz.PROTOCOL_NAME=Dict
plugin.dictaccregwizz.PROTOCOL_DESCRIPTION=The Dict service protocol

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

you are absolutely right but the situation I was talking about is the following :

System.out.println(MessageFormat.format("don't display param {0}", "Test-Param"));

Ok I understand what you mean. Maybe a note in the developer documentation would be more appropriate for that?

I'll commit the fixes for the English translation. I also noticed that the French one uses a lot of double quotes too. Is there a maintainer for this file?

Cheers,
romain

路路路

On 2009/06/18, at 12:02, Damian Minkov wrote:

Romain KUNTZ wrote:

Hi Damian,

Ok I see, it seems that simple quotes are a problem only when used with parameters. For example, with this translation:
service.gui.HISTORY_CONTACT=History - '{0}' - ''{0}'' - "{0}"

We obtain the enclosed picture. If you're OK, I will change the note in the translation file with:

# - cannot use single quotes with parameters (e.g. '{0}').
# If you want a single quote to appear in the translated message
# put '' (two quotes): e.g. ''{0}''

I'll also replace the other double quotes with one, when necessary.

Cheers,
romain

------------------------------------------------------------------------

On 2009/06/18, at 11:33, Damian Minkov wrote:

Hi again,

aha I see, it seems my mistake. Now its obvious who put those double quotes :wink:
I cannot remember what was the order of the problem was it parameter-quote or quote-parameter.
I test it myself on linux that double quotes are problem (as the example screenshot you provided).

Sorry for the wrong typo :slight_smile:
damencho

Romain KUNTZ wrote:

Hi Damian,

On 2009/06/18, at 11:08, Damian Minkov wrote:

Hi Romain,

just a typo from me :slight_smile:
a while ago I struggled with MessageFormatters in java and I found a problem when using
parameters and single quotes. So I put a info in the resource file :

# - cannot use single quotes and parameters.
# If you want a single quote to appear in the translated message
# put ''(two quotes)

So the use of two quotes is on purpose :slight_smile:

Oh, my mistake, I somehow skipped this note. But the problem is that double quotes are actually displayed as double quotes on my mac (see the enclosed picture), that's why I initially changed it. May it be mac-specific?

I can revert the fix if you want (but there's a lot of single quotes in the translation, should we consider changing them to?).

romain

------------------------------------------------------------------------

rkuntz@dev.java.net wrote:

Author: rkuntz
Date: 2009-06-18 08:53:42+0000
New Revision: 5396

Modified:
branches/1.0/resources/languages/resources.properties

Log:
Fixing a few typos in the english resources file

Modified: branches/1.0/resources/languages/resources.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/branches/1.0/resources/languages/resources.properties?view=diff&rev=5396&p1=branches/1.0/resources/languages/resources.properties&p2=branches/1.0/resources/languages/resources.properties&r1=5395&r2=5396

=====================================================================
--- branches/1.0/resources/languages/resources.properties (original)
+++ branches/1.0/resources/languages/resources.properties 2009-06-18 08:53:42+0000
@@ -102,7 +102,7 @@
service.gui.CONNECTION_EXPIRED_MSG=You are currently disconnected from the {0} server.
service.gui.CONNECTION_REQUIRED_TO_JOIN=You have to be connected in order to join a chat room. Please connect and then try again.
service.gui.CONNECTION_REQUIRED_TO_LEAVE=You have to be connected in order to leave a chat room.
-service.gui.CONTACT_NOT_SUPPORTING_TELEPHONY=The choosen {0} contact doesn''t support telephony.
+service.gui.CONTACT_NOT_SUPPORTING_TELEPHONY=The choosen {0} contact doesn't support telephony.
service.gui.CONTACT_PAUSED_TYPING={0} paused typing the message
service.gui.CONTACT_TYPING={0} is typing a message
service.gui.CONTACT_TYPING_STATE_STALE=typing state not updated
@@ -181,7 +181,7 @@
service.gui.KICK_FAILED_NOT_ENOUGH_PERMISSIONS=Failed to kick {0}. You don''t have enough privileges to do that.
service.gui.LAST=Last
service.gui.LEAVE=&Leave
-service.gui.LIMIT_REACHED_FOR_IP=You have too many existing registrations from the local IP address and the {0} server doesn''t allow to open any more of them.
+service.gui.LIMIT_REACHED_FOR_IP=You have too many existing registrations from the local IP address and the {0} server doesn't allow to open any more of them.
service.gui.LOGIN=&Login
service.gui.LOGIN_NETWORK_ERROR=Unable to log in with account: User name: {0}, Server name: {1}, due to a network failure. Please check your network connection.
User name: {0}<BR>\
@@ -431,7 +431,7 @@
plugin.dictaccregwizz.FIRST_MATCH=First Match
plugin.dictaccregwizz.NO_MATCH=No match
plugin.dictaccregwizz.MATCH_RESULT=No definitions found for "{0}", perhaps you mean:\n
-plugin.dictaccregwizz.INVALID_DATABASE=The current dictionary "{0}" doesn''t exist anymore on the server.
+plugin.dictaccregwizz.INVALID_DATABASE=The current dictionary "{0}" doesn't exist anymore on the server.
plugin.dictaccregwizz.INVALID_STRATEGY=The current strategy isn't available on the server.
plugin.dictaccregwizz.PROTOCOL_NAME=Dict
plugin.dictaccregwizz.PROTOCOL_DESCRIPTION=The Dict service protocol

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Me again,

you are absolutely right but the situation I was talking about is the following :

System.out.println(MessageFormat.format("don't display param {0}", "Test-Param"));

Ok I understand what you mean. Maybe a note in the developer documentation would be more appropriate for that?

Ok, now I really understand what you meant. The translation file cannot use single quotes if a parameter is used in the sentence. The problem actually appears if the quote is used before or after the parameter. I'll better reflect that in the note with:

# - cannot use single quotes when a parameter is used in the sentence.
# For exemple, <You can't move contact {0}>, <Contact {0} doesn't

# or <Accept '{0}'> does not display correctly. In such cases, you need to
# use double quotes (''):
# <You can''t move contact {0}>, <Contact {0} doesn''t exist> or <Accept ''{0}''>

If nobody wants to take care of the French file, I'll take care of it.

Cheers,
romain

路路路

On 2009/06/18, at 12:13, Romain KUNTZ wrote:

On 2009/06/18, at 12:02, Damian Minkov wrote:

Romain KUNTZ wrote:

Hi Damian,

Ok I see, it seems that simple quotes are a problem only when used with parameters. For example, with this translation:
service.gui.HISTORY_CONTACT=History - '{0}' - ''{0}'' - "{0}"

We obtain the enclosed picture. If you're OK, I will change the note in the translation file with:

# - cannot use single quotes with parameters (e.g. '{0}').
# If you want a single quote to appear in the translated message
# put '' (two quotes): e.g. ''{0}''

I'll also replace the other double quotes with one, when necessary.

Cheers,
romain

------------------------------------------------------------------------

On 2009/06/18, at 11:33, Damian Minkov wrote:

Hi again,

aha I see, it seems my mistake. Now its obvious who put those double quotes :wink:
I cannot remember what was the order of the problem was it parameter-quote or quote-parameter.
I test it myself on linux that double quotes are problem (as the example screenshot you provided).

Sorry for the wrong typo :slight_smile:
damencho

Romain KUNTZ wrote:

Hi Damian,

On 2009/06/18, at 11:08, Damian Minkov wrote:

Hi Romain,

just a typo from me :slight_smile:
a while ago I struggled with MessageFormatters in java and I found a problem when using
parameters and single quotes. So I put a info in the resource file :

# - cannot use single quotes and parameters.
# If you want a single quote to appear in the translated message
# put ''(two quotes)

So the use of two quotes is on purpose :slight_smile:

Oh, my mistake, I somehow skipped this note. But the problem is that double quotes are actually displayed as double quotes on my mac (see the enclosed picture), that's why I initially changed it. May it be mac-specific?

I can revert the fix if you want (but there's a lot of single quotes in the translation, should we consider changing them to?).

romain

------------------------------------------------------------------------

rkuntz@dev.java.net wrote:

Author: rkuntz
Date: 2009-06-18 08:53:42+0000
New Revision: 5396

Modified:
branches/1.0/resources/languages/resources.properties

Log:
Fixing a few typos in the english resources file

Modified: branches/1.0/resources/languages/resources.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/branches/1.0/resources/languages/resources.properties?view=diff&rev=5396&p1=branches/1.0/resources/languages/resources.properties&p2=branches/1.0/resources/languages/resources.properties&r1=5395&r2=5396

=====================================================================
--- branches/1.0/resources/languages/resources.properties (original)
+++ branches/1.0/resources/languages/resources.properties 2009-06-18 08:53:42+0000
@@ -102,7 +102,7 @@
service.gui.CONNECTION_EXPIRED_MSG=You are currently disconnected from the {0} server.
service.gui.CONNECTION_REQUIRED_TO_JOIN=You have to be connected in order to join a chat room. Please connect and then try again.
service.gui.CONNECTION_REQUIRED_TO_LEAVE=You have to be connected in order to leave a chat room.
-service.gui.CONTACT_NOT_SUPPORTING_TELEPHONY=The choosen {0} contact doesn''t support telephony.
+service.gui.CONTACT_NOT_SUPPORTING_TELEPHONY=The choosen {0} contact doesn't support telephony.
service.gui.CONTACT_PAUSED_TYPING={0} paused typing the message
service.gui.CONTACT_TYPING={0} is typing a message
service.gui.CONTACT_TYPING_STATE_STALE=typing state not updated
@@ -181,7 +181,7 @@
service.gui.KICK_FAILED_NOT_ENOUGH_PERMISSIONS=Failed to kick {0}. You don''t have enough privileges to do that.
service.gui.LAST=Last
service.gui.LEAVE=&Leave
-service.gui.LIMIT_REACHED_FOR_IP=You have too many existing registrations from the local IP address and the {0} server doesn''t allow to open any more of them.
+service.gui.LIMIT_REACHED_FOR_IP=You have too many existing registrations from the local IP address and the {0} server doesn't allow to open any more of them.
service.gui.LOGIN=&Login
service.gui.LOGIN_NETWORK_ERROR=Unable to log in with account: User name: {0}, Server name: {1}, due to a network failure. Please check your network connection.
User name: {0}<BR>\
@@ -431,7 +431,7 @@
plugin.dictaccregwizz.FIRST_MATCH=First Match
plugin.dictaccregwizz.NO_MATCH=No match
plugin.dictaccregwizz.MATCH_RESULT=No definitions found for "{0}", perhaps you mean:\n
-plugin.dictaccregwizz.INVALID_DATABASE=The current dictionary "{0}" doesn''t exist anymore on the server.
+plugin.dictaccregwizz.INVALID_DATABASE=The current dictionary "{0}" doesn't exist anymore on the server.
plugin.dictaccregwizz.INVALID_STRATEGY=The current strategy isn't available on the server.
plugin.dictaccregwizz.PROTOCOL_NAME=Dict
plugin.dictaccregwizz.PROTOCOL_DESCRIPTION=The Dict service protocol

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Hi,

Resource files should be fixed. Let me know if you see any problems due to my commits.

Cheers,
romain

路路路

On 2009/06/18, at 12:23, Romain KUNTZ wrote:

Me again,

On 2009/06/18, at 12:13, Romain KUNTZ wrote:

On 2009/06/18, at 12:02, Damian Minkov wrote:

you are absolutely right but the situation I was talking about is the following :

System.out.println(MessageFormat.format("don't display param {0}", "Test-Param"));

Ok I understand what you mean. Maybe a note in the developer documentation would be more appropriate for that?

Ok, now I really understand what you meant. The translation file cannot use single quotes if a parameter is used in the sentence. The problem actually appears if the quote is used before or after the parameter. I'll better reflect that in the note with:

# - cannot use single quotes when a parameter is used in the sentence.
# For exemple, <You can't move contact {0}>, <Contact {0} doesn't >
# or <Accept '{0}'> does not display correctly. In such cases, you need to
# use double quotes (''):
# <You can''t move contact {0}>, <Contact {0} doesn''t exist> or <Accept ''{0}''>

If nobody wants to take care of the French file, I'll take care of it.

Cheers,
romain

Romain KUNTZ wrote:

Hi Damian,

Ok I see, it seems that simple quotes are a problem only when used with parameters. For example, with this translation:
service.gui.HISTORY_CONTACT=History - '{0}' - ''{0}'' - "{0}"

We obtain the enclosed picture. If you're OK, I will change the note in the translation file with:

# - cannot use single quotes with parameters (e.g. '{0}').
# If you want a single quote to appear in the translated message
# put '' (two quotes): e.g. ''{0}''

I'll also replace the other double quotes with one, when necessary.

Cheers,
romain

------------------------------------------------------------------------

On 2009/06/18, at 11:33, Damian Minkov wrote:

Hi again,

aha I see, it seems my mistake. Now its obvious who put those double quotes :wink:
I cannot remember what was the order of the problem was it parameter-quote or quote-parameter.
I test it myself on linux that double quotes are problem (as the example screenshot you provided).

Sorry for the wrong typo :slight_smile:
damencho

Romain KUNTZ wrote:

Hi Damian,

On 2009/06/18, at 11:08, Damian Minkov wrote:

Hi Romain,

just a typo from me :slight_smile:
a while ago I struggled with MessageFormatters in java and I found a problem when using
parameters and single quotes. So I put a info in the resource file :

# - cannot use single quotes and parameters.
# If you want a single quote to appear in the translated message
# put ''(two quotes)

So the use of two quotes is on purpose :slight_smile:

Oh, my mistake, I somehow skipped this note. But the problem is that double quotes are actually displayed as double quotes on my mac (see the enclosed picture), that's why I initially changed it. May it be mac-specific?

I can revert the fix if you want (but there's a lot of single quotes in the translation, should we consider changing them to?).

romain

------------------------------------------------------------------------

rkuntz@dev.java.net wrote:

Author: rkuntz
Date: 2009-06-18 08:53:42+0000
New Revision: 5396

Modified:
branches/1.0/resources/languages/resources.properties

Log:
Fixing a few typos in the english resources file

Modified: branches/1.0/resources/languages/resources.properties
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/branches/1.0/resources/languages/resources.properties?view=diff&rev=5396&p1=branches/1.0/resources/languages/resources.properties&p2=branches/1.0/resources/languages/resources.properties&r1=5395&r2=5396

=====================================================================
--- branches/1.0/resources/languages/resources.properties (original)
+++ branches/1.0/resources/languages/resources.properties 2009-06-18 08:53:42+0000
@@ -102,7 +102,7 @@
service.gui.CONNECTION_EXPIRED_MSG=You are currently disconnected from the {0} server.
service.gui.CONNECTION_REQUIRED_TO_JOIN=You have to be connected in order to join a chat room. Please connect and then try again.
service.gui.CONNECTION_REQUIRED_TO_LEAVE=You have to be connected in order to leave a chat room.
-service.gui.CONTACT_NOT_SUPPORTING_TELEPHONY=The choosen {0} contact doesn''t support telephony.
+service.gui.CONTACT_NOT_SUPPORTING_TELEPHONY=The choosen {0} contact doesn't support telephony.
service.gui.CONTACT_PAUSED_TYPING={0} paused typing the message
service.gui.CONTACT_TYPING={0} is typing a message
service.gui.CONTACT_TYPING_STATE_STALE=typing state not updated
@@ -181,7 +181,7 @@
service.gui.KICK_FAILED_NOT_ENOUGH_PERMISSIONS=Failed to kick {0}. You don''t have enough privileges to do that.
service.gui.LAST=Last
service.gui.LEAVE=&Leave
-service.gui.LIMIT_REACHED_FOR_IP=You have too many existing registrations from the local IP address and the {0} server doesn''t allow to open any more of them.
+service.gui.LIMIT_REACHED_FOR_IP=You have too many existing registrations from the local IP address and the {0} server doesn't allow to open any more of them.
service.gui.LOGIN=&Login
service.gui.LOGIN_NETWORK_ERROR=Unable to log in with account: User name: {0}, Server name: {1}, due to a network failure. Please check your network connection.
User name: {0}<BR>\
@@ -431,7 +431,7 @@
plugin.dictaccregwizz.FIRST_MATCH=First Match
plugin.dictaccregwizz.NO_MATCH=No match
plugin.dictaccregwizz.MATCH_RESULT=No definitions found for "{0}", perhaps you mean:\n
-plugin.dictaccregwizz.INVALID_DATABASE=The current dictionary "{0}" doesn''t exist anymore on the server.
+plugin.dictaccregwizz.INVALID_DATABASE=The current dictionary "{0}" doesn't exist anymore on the server.
plugin.dictaccregwizz.INVALID_STRATEGY=The current strategy isn't available on the server.
plugin.dictaccregwizz.PROTOCOL_NAME=Dict
plugin.dictaccregwizz.PROTOCOL_DESCRIPTION=The Dict service protocol

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net