[sip-comm-dev] Re: svn commit: r4830 - about the "Enable encryption checkbox"


#1

Hey Werner,

Just noticed one of your latest updates. The one that moved the "Enable
encryption checkbox" in our simple account wizard.

Personally, I don't quite agree with this so I thought we should discuss
it.

Now, the way I see it, these forms contain only information that you
cannot register without. In almost all cases a user id and a password
should therefore be enough.

I do agree that security is important for many but I doubt most users
would like to be explicitly bothered by it. Therefore if we think it is
of utmost importance we should simply make sure that a zrtp exchange is
attempted by default (which I actually think is a good idea). But then
again, the check box that modifies this behavior is probably best in the
advanced tab where it first was.

What do you think? Others?

Cheers
Emil

P.S. It is not a biggie since this isn't exactly breaking anything but I
guess I'd prefer to see such things discussed in advance.

wernerd@dev.java.net wrote:

···

Author: wernerd
Date: 2008-12-10 17:53:11+0000
New Revision: 4830

Modified:
   trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java

Log:
Re-position "Enable security" checkbox to the first page of account registration and modification. Makes it easier for the enduser, is also not an "advanced" option.

Modified: trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java?view=diff&rev=4830&p1=trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java&p2=trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java&r1=4829&r2=4830

--- trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java (original)
+++ trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java 2008-12-10 17:53:11+0000
@@ -39,6 +39,8 @@
     private JPanel labelsPanel = new TransparentPanel();

     private JPanel valuesPanel = new TransparentPanel();
+
+ private JPanel passSecurePanel = new TransparentPanel(new BorderLayout());

     private JLabel uinLabel
         = new JLabel(Resources.getString("plugin.sipaccregwizz.USERNAME"));
@@ -224,9 +226,13 @@
         valuesPanel.add(uinExampleLabel);
         valuesPanel.add(passField);

+ passSecurePanel.add(rememberPassBox, BorderLayout.WEST);
+ enableDefaultEncryption.setVisible(true);
+ passSecurePanel.add(enableDefaultEncryption, BorderLayout.EAST);
+
         uinPassPanel.add(labelsPanel, BorderLayout.WEST);
         uinPassPanel.add(valuesPanel, BorderLayout.CENTER);
- uinPassPanel.add(rememberPassBox, BorderLayout.SOUTH);
+ uinPassPanel.add(passSecurePanel, BorderLayout.SOUTH);

         uinPassPanel.setBorder(BorderFactory.createTitledBorder(Resources
             .getString("plugin.sipaccregwizz.USERNAME_AND_PASSWORD")));
@@ -256,7 +262,7 @@
                 proxyField.setEnabled(cb.isSelected());
                 proxyPortField.setEnabled(cb.isSelected());
                 transportCombo.setEnabled(cb.isSelected());
-
+
                 if(!cb.isSelected())
                 {
                     setServerFieldAccordingToUIN();
@@ -287,7 +293,6 @@
         valuesAdvOpPanel.add(transportCombo);

         advancedOpPanel.add(enableAdvOpButton, BorderLayout.NORTH);
- advancedOpPanel.add(enableDefaultEncryption, BorderLayout.SOUTH);
         advancedOpPanel.add(labelsAdvOpPanel, BorderLayout.WEST);
         advancedOpPanel.add(valuesAdvOpPanel, BorderLayout.CENTER);

@@ -306,7 +311,6 @@
                 forceP2PPresOpButton.setEnabled(cb.isSelected());
                 pollPeriodField.setEnabled(cb.isSelected());
                 subscribeExpiresField.setEnabled(cb.isSelected());
- enableDefaultEncryption.setEnabled(cb.isSelected());
             }
         });

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

I agree with Emil i.e. (1) security is important nowadays, it's likely a good idea to automatically attempt to enable it and (2) explicit enabling/disabling of the feature in question sounds like an advanced setting to me.

Best regards,
Lubo

···

On 12/11/2008 12:17 AM, Emil Ivov wrote:

Hey Werner,

Just noticed one of your latest updates. The one that moved the "Enable
encryption checkbox" in our simple account wizard.

Personally, I don't quite agree with this so I thought we should discuss
it.

Now, the way I see it, these forms contain only information that you
cannot register without. In almost all cases a user id and a password
should therefore be enough.

I do agree that security is important for many but I doubt most users
would like to be explicitly bothered by it. Therefore if we think it is
of utmost importance we should simply make sure that a zrtp exchange is
attempted by default (which I actually think is a good idea). But then
again, the check box that modifies this behavior is probably best in the
advanced tab where it first was.

What do you think? Others?

Cheers
Emil

P.S. It is not a biggie since this isn't exactly breaking anything but I
guess I'd prefer to see such things discussed in advance.

wernerd@dev.java.net wrote:

Author: wernerd
Date: 2008-12-10 17:53:11+0000
New Revision: 4830

Modified:
    trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java

Log:
Re-position "Enable security" checkbox to the first page of account registration and modification. Makes it easier for the enduser, is also not an "advanced" option.

Modified: trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java?view=diff&rev=4830&p1=trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java&p2=trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java&r1=4829&r2=4830

--- trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java (original)
+++ trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java 2008-12-10 17:53:11+0000
@@ -39,6 +39,8 @@
      private JPanel labelsPanel = new TransparentPanel();

      private JPanel valuesPanel = new TransparentPanel();
+
+ private JPanel passSecurePanel = new TransparentPanel(new BorderLayout());

      private JLabel uinLabel
          = new JLabel(Resources.getString("plugin.sipaccregwizz.USERNAME"));
@@ -224,9 +226,13 @@
          valuesPanel.add(uinExampleLabel);
          valuesPanel.add(passField);

+ passSecurePanel.add(rememberPassBox, BorderLayout.WEST);
+ enableDefaultEncryption.setVisible(true);
+ passSecurePanel.add(enableDefaultEncryption, BorderLayout.EAST);
+
          uinPassPanel.add(labelsPanel, BorderLayout.WEST);
          uinPassPanel.add(valuesPanel, BorderLayout.CENTER);
- uinPassPanel.add(rememberPassBox, BorderLayout.SOUTH);
+ uinPassPanel.add(passSecurePanel, BorderLayout.SOUTH);

          uinPassPanel.setBorder(BorderFactory.createTitledBorder(Resources
              .getString("plugin.sipaccregwizz.USERNAME_AND_PASSWORD")));
@@ -256,7 +262,7 @@
                  proxyField.setEnabled(cb.isSelected());
                  proxyPortField.setEnabled(cb.isSelected());
                  transportCombo.setEnabled(cb.isSelected());
-
+
                  if(!cb.isSelected())
                  {
                      setServerFieldAccordingToUIN();
@@ -287,7 +293,6 @@
          valuesAdvOpPanel.add(transportCombo);

          advancedOpPanel.add(enableAdvOpButton, BorderLayout.NORTH);
- advancedOpPanel.add(enableDefaultEncryption, BorderLayout.SOUTH);
          advancedOpPanel.add(labelsAdvOpPanel, BorderLayout.WEST);
          advancedOpPanel.add(valuesAdvOpPanel, BorderLayout.CENTER);

@@ -306,7 +311,6 @@
                  forceP2PPresOpButton.setEnabled(cb.isSelected());
                  pollPeriodField.setEnabled(cb.isSelected());
                  subscribeExpiresField.setEnabled(cb.isSelected());
- enableDefaultEncryption.setEnabled(cb.isSelected());
              }
          });

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi all,

I agree with Emil, IMHO we should keep optionnal functionalities in
the advanced tab as much as possible to simplify the account creation
process.

Ben

···

2008/12/10 Emil Ivov <emcho@sip-communicator.org>:

Hey Werner,

Just noticed one of your latest updates. The one that moved the "Enable
encryption checkbox" in our simple account wizard.

Personally, I don't quite agree with this so I thought we should discuss
it.

Now, the way I see it, these forms contain only information that you
cannot register without. In almost all cases a user id and a password
should therefore be enough.

I do agree that security is important for many but I doubt most users
would like to be explicitly bothered by it. Therefore if we think it is
of utmost importance we should simply make sure that a zrtp exchange is
attempted by default (which I actually think is a good idea). But then
again, the check box that modifies this behavior is probably best in the
advanced tab where it first was.

What do you think? Others?

Cheers
Emil

P.S. It is not a biggie since this isn't exactly breaking anything but I
guess I'd prefer to see such things discussed in advance.

wernerd@dev.java.net wrote:

Author: wernerd
Date: 2008-12-10 17:53:11+0000
New Revision: 4830

Modified:
   trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java

Log:
Re-position "Enable security" checkbox to the first page of account registration and modification. Makes it easier for the enduser, is also not an "advanced" option.

Modified: trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java
Url: https://sip-communicator.dev.java.net/source/browse/sip-communicator/trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java?view=diff&rev=4830&p1=trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java&p2=trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java&r1=4829&r2=4830

--- trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java (original)
+++ trunk/src/net/java/sip/communicator/plugin/sipaccregwizz/FirstWizardPage.java 2008-12-10 17:53:11+0000
@@ -39,6 +39,8 @@
     private JPanel labelsPanel = new TransparentPanel();

     private JPanel valuesPanel = new TransparentPanel();
+
+ private JPanel passSecurePanel = new TransparentPanel(new BorderLayout());

     private JLabel uinLabel
         = new JLabel(Resources.getString("plugin.sipaccregwizz.USERNAME"));
@@ -224,9 +226,13 @@
         valuesPanel.add(uinExampleLabel);
         valuesPanel.add(passField);

+ passSecurePanel.add(rememberPassBox, BorderLayout.WEST);
+ enableDefaultEncryption.setVisible(true);
+ passSecurePanel.add(enableDefaultEncryption, BorderLayout.EAST);
+
         uinPassPanel.add(labelsPanel, BorderLayout.WEST);
         uinPassPanel.add(valuesPanel, BorderLayout.CENTER);
- uinPassPanel.add(rememberPassBox, BorderLayout.SOUTH);
+ uinPassPanel.add(passSecurePanel, BorderLayout.SOUTH);

         uinPassPanel.setBorder(BorderFactory.createTitledBorder(Resources
             .getString("plugin.sipaccregwizz.USERNAME_AND_PASSWORD")));
@@ -256,7 +262,7 @@
                 proxyField.setEnabled(cb.isSelected());
                 proxyPortField.setEnabled(cb.isSelected());
                 transportCombo.setEnabled(cb.isSelected());
-
+
                 if(!cb.isSelected())
                 {
                     setServerFieldAccordingToUIN();
@@ -287,7 +293,6 @@
         valuesAdvOpPanel.add(transportCombo);

         advancedOpPanel.add(enableAdvOpButton, BorderLayout.NORTH);
- advancedOpPanel.add(enableDefaultEncryption, BorderLayout.SOUTH);
         advancedOpPanel.add(labelsAdvOpPanel, BorderLayout.WEST);
         advancedOpPanel.add(valuesAdvOpPanel, BorderLayout.CENTER);

@@ -306,7 +311,6 @@
                 forceP2PPresOpButton.setEnabled(cb.isSelected());
                 pollPeriodField.setEnabled(cb.isSelected());
                 subscribeExpiresField.setEnabled(cb.isSelected());
- enableDefaultEncryption.setEnabled(cb.isSelected());
             }
         });

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: commits-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Emil,

no problem. I've reverted the modifications and changed the default
setting to "true" (enabled).

Actaully my e-mail asking for comments after checking in the modifications
somehow didn't made it to the list. It was just a small change, easy
to do and to show :slight_smile: .

Regards,
Werner

Emil Ivov schrieb:

Hey Werner,

Just noticed one of your latest updates. The one that moved the "Enable
encryption checkbox" in our simple account wizard.

Personally, I don't quite agree with this so I thought we should discuss
it.

Now, the way I see it, these forms contain only information that you
cannot register without. In almost all cases a user id and a password
should therefore be enough.

I do agree that security is important for many but I doubt most users
would like to be explicitly bothered by it. Therefore if we think it is
of utmost importance we should simply make sure that a zrtp exchange is
attempted by default (which I actually think is a good idea). But then
again, the check box that modifies this behavior is probably best in the
advanced tab where it first was.

What do you think? Others?

Cheers
Emil

P.S. It is not a biggie since this isn't exactly breaking anything but I
guess I'd prefer to see such things discussed in advance.

<SNIP ---- SNAP >

···

wernerd@dev.java.net wrote:

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net