[sip-comm-dev] Re: [sip-comm-issues] [Issue 723] New - keep focus on write area when trying to send an empty message


#1

Oups, I sent it to the wrong mailing list. Here it is again.

···

On Sep 9, 2009, at 1:45 PM, Yana Stamcheva wrote:

Hi Edgar,

Thanks for this bug report and fix!

Your patch is now applied, committed and ack-ed.

I've just allowed myself one little modification. Instead of putting the

chatPanel.requestFocusInWriteArea();

in the "else" clause, I left it happen for all the cases and removed the other "requestFocusInWriteArea" invoked when a real message has been sent. In other words we're now sure that this is the only code that will request the focus in the write area no matter whether a message is sent or not.

Hope you agree.

Cheers,
Yana

On Sep 7, 2009, at 2:46 AM, edgarpoce@dev.java.net wrote:

https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=723
               Issue #|723
               Summary>keep focus on write area when trying to send an empty
                      >message
             Component>sip-communicator
               Version>current
              Platform>All
            OS/Version|All
                   URL>
                Status>NEW
     Status whiteboard|
              Keywords>
            Resolution>
            Issue type|ENHANCEMENT
              Priority>P3
          Subcomponent>development
           Assigned to|issues@sip-communicator
           Reported by|edgarpoce

------- Additional comments from edgarpoce@dev.java.net Mon Sep 7 00:46:18 +0000 2009 -------
If the write area is empty and the user invokes the send message action, e.g. by
pressing the "enter" key, the focus is lost from the write area.

the following patch maintains the focus in the write area:

Index: src/net/java/sip/communicator/impl/gui/main/chat/ChatSendPanel.java

--- src/net/java/sip/communicator/impl/gui/main/chat/ChatSendPanel.java
(revision 5930)
+++ src/net/java/sip/communicator/impl/gui/main/chat/ChatSendPanel.java (working
copy)
@@ -76,7 +76,10 @@
                   chatPanel.sendMessage();
               }
           }.start();
+ } else {
+ chatPanel.requestFocusInWriteArea();
       }
+
   }

   /**

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: issues-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Yana,

thanks for reviewing the patch!. I agree with the change.

br,
Edgar

···

On Wed, Sep 9, 2009 at 1:49 PM, Yana Stamcheva<yana@sip-communicator.org> wrote:

Oups, I sent it to the wrong mailing list. Here it is again.

On Sep 9, 2009, at 1:45 PM, Yana Stamcheva wrote:

Hi Edgar,

Thanks for this bug report and fix!

Your patch is now applied, committed and ack-ed.

I've just allowed myself one little modification. Instead of putting the

chatPanel.requestFocusInWriteArea();

in the "else" clause, I left it happen for all the cases and removed the
other "requestFocusInWriteArea" invoked when a real message has been sent.
In other words we're now sure that this is the only code that will request
the focus in the write area no matter whether a message is sent or not.

Hope you agree.

Cheers,
Yana

On Sep 7, 2009, at 2:46 AM, edgarpoce@dev.java.net wrote:

https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=723
Issue #|723
Summary>keep focus on write area when trying to send an
empty
>message
Component>sip-communicator
Version>current
Platform>All
OS/Version|All
URL>
Status>NEW
Status whiteboard|
Keywords>
Resolution>
Issue type|ENHANCEMENT
Priority>P3
Subcomponent>development
Assigned to|issues@sip-communicator
Reported by|edgarpoce

------- Additional comments from edgarpoce@dev.java.net Mon Sep 7
00:46:18 +0000 2009 -------
If the write area is empty and the user invokes the send message action,
e.g. by
pressing the "enter" key, the focus is lost from the write area.

the following patch maintains the focus in the write area:

Index:
src/net/java/sip/communicator/impl/gui/main/chat/ChatSendPanel.java

--- src/net/java/sip/communicator/impl/gui/main/chat/ChatSendPanel.java
(revision 5930)
+++ src/net/java/sip/communicator/impl/gui/main/chat/ChatSendPanel.java
(working
copy)
@@ -76,7 +76,10 @@
chatPanel.sendMessage();
}
}.start();
+ } else {
+ chatPanel.requestFocusInWriteArea();
}
+
}

/**

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:
issues-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net