[sip-comm-dev] Re: [sip-comm-issues] [Issue 579] Moving a non-persistent contact to a persistent group should make it persistent


#1

Damian,

https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=579
------- Additional comments from damencho@dev.java.net Wed Apr 15 09:22:54 +0000 2009 -------
When the message is received no OK message is replied so we keep receiving the
message. The exception is :

     [java] javax.sip.TransactionAlreadyExistsException: Transaction exists!
     [java] at
gov.nist.javax.sip.SipProviderImpl.getNewServerTransaction(SipProviderImpl.java:502)
     [java] at
net.java.sip.communicator.impl.protocol.sip.OperationSetTypingNotificationsSipImpl.sendResponse(OperationSetTypingNotificationsSipImpl.java:532)
     [java] at
net.java.sip.communicator.impl.protocol.sip.OperationSetTypingNotificationsSipImpl.processMessage(OperationSetTypingNotificationsSipImpl.java:313)
     [java] at
net.java.sip.communicator.impl.protocol.sip.OperationSetBasicInstantMessagingSipImpl$BasicInstantMessagingMethodProcessor.processRequest(OperationSetBasicInstantMessagingSipImpl.java:695)
     [java] at
net.java.sip.communicator.impl.protocol.sip.ProtocolProviderServiceSipImpl.processRequest(ProtocolProviderServiceSipImpl.java:771)
     [java] at
net.java.sip.communicator.impl.protocol.sip.SipStackSharing.processRequest(SipStackSharing.java:551)
     [java] at
gov.nist.javax.sip.EventScanner.deliverEvent(EventScanner.java:223)
     [java] at gov.nist.javax.sip.EventScanner.run(EventScanner.java:492)
     [java] at java.lang.Thread.run(Thread.java:613)

If we replace current code :
     jainSipProvider.getNewServerTransaction(
                    requestEvent.getRequest()).sendResponse(ok);
with :
     requestEvent.getServerTransaction().sendResponse(ok);
it works. We need to discuss is it correct And whether there are other places
with this problem.

You probably figured it out, but impl.sip.SipStackSharing.processRequest
always creates the server transaction before dispatching the message to
a service provider, so there should be no need to create server
transactions outside of it.

We will have to make sure your new method:
SipStackSharing.getOrCreateServerTransaction is used in new code.

Cheers,

···

On Wed, Apr 15, 2009 at 09:22:54AM -0000, damencho@dev.java.net wrote:

--
Sébastien Mazy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net