[sip-comm-dev] Re : [sip-comm-dev] OperationSetMultiUserChat and ChatRoom tests


#1

Hi,

1. What's the reason of having both
TestOperationSetMultiUserChat and
TestOperationSetMultiUserChat2. If they serve different
purposes then
their names and class comments should probably indicate so.
If either of
them is unnecessary, we should then get rid of it.

I wasn't aware of the existence of TestOperationSetMultiUserChat
when I started to write tests cause I first put my class
in another package.
When I moved it to net.java.sip.communicator.slick.protocol.jabber
and discovered the duplication, I thought it will be better to
fully complete the tests before deleting the existing file.

> When a member is kicked or banned from a chatroom,
> all remaining participants in the chatroom are
informed
> by the corresponding event but not the kicked or
banned
> user.

We should definitely change this. If this is a problem with
smack we
should then try to fix it, or (if that would take too much
effort)
implement some kind of polling. Either way, we can't only
rely on a call
to isJoined() to detect whether we are banned from a chat
room.

So, once we have an event notifying us of this we are
simply going to
implement the tests in a way that would make them wait()
for this event
before assert()ing that isJoined()==false. This is what we
do in the
case of messages and presence statuses for example.

Does this make sense?

I agree with you. The culprit here (I think) is smack which delivers
not event. The smack method ParticipantStatusListener#banned() is not
excuted on the banned user side.
I even implemented all available MUC listeners to see if
the event was delivered in an unexcpected place but got nothing.

I will look in smack code to have more infos about that.

Sympho.

ยทยทยท

Cheers
Emil

> He will be aware of it only if checks his joined
status
> or try to do something which requires to be in the
room.
>
> However, someRoom.isJoined() method could return true
for a banned
> or kicked user if called immediatly after he is chased
away.
> I introduced a small wait before the check on
someRoom.isJoined()
> to have the user status properly updated and it seems
to work.

>
> Sympho
>
>> on cruisecontrol.
>> So there is still work to do. That said, if any
one has
>> time to
>> look at it, I will appreciate any suggestion for
>> enhancements and/or
>> new tests.
>>
>> Regards
>> Sympho
>>
>>
>>
>>
>>
>>
>>
---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
>> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>>
>>
>
>
>
>
>
---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net