Damian Johnson wrote:
Hi Yana. I've begun integrating JOrtho into the spell checker plugin but
it's looking like it's gonna take a couple days. Before I dig in any further
I'd like to make sure: is having an alternative spell checker desirable
functionality? I've mentioned this API's advantages on my blog but I've
never seen an application with multiple alternative spell checkers. If not,
I'll begin making the changes against the trunk so there's a fresh patch.
I see what the advantages of JOrtho are, but I'm not sure we're already there. In my opinion there are still some issues to resolve in order to make the existing implementation more stable, before going with adding a new implementation.
I was playing with the spellchecker today and I find it great!! Really well done with the configuration form and all dictionaries. However I have encountered a problem when I tried to delete what I have typed. Just press backspace and you'll see the following exception : java.lang.IllegalArgumentException: offset out of bounds. If you don't experience the same problem, I'll have a look and will give you more information on the exception.
The "Add word" functionality is awesome! And you could even add words through the configuration form, which is great. I was just wondering if we really need to manage the personal dictionary in a different window. The spell check configuration form contains only a combobox, so we have enough space to add directly there the table with added words. In the bottom we could add the text field and the "Add to dictionary" button. In this configuration we won't need the apply button. What do you think?
Otherwise, I was looking at how you manage the different dictionaries. I think that it could be a good idea to allow users to see what dictionaries they have installed, to update or remove dictionaries. At this moment when you select a dictionary in the configuration form it's downloaded in the home directory, but we could neither update it, nor remove it or may be I have missed it. I was also looking at the parameters.xml you use to store configuration parameters, does this xml do something special or we could use instead the ConfigurationService?
Some other things we should think of is allow user to change the dictionary while typing and also allow user to disable/enable the spellchecking while typing. Like for example in any text area in Firefox you have "Spell checking" and "Languages" items in the right button menu. You could even add a new Dictionary from there. I think that could be handy.
PS. A few unrelated UI questions:
Why was the setting dialog's "Close" button removed?
We thought that we have already the "x" button on the window and we have left more space for the configuration forms, but we could think of returning it, we're playing a lot with the gui these days and try to find more user friendly solutions.
The settings dialog is gonna get pretty crowded as more functionality is
added. Are there any plans to come up with an alternative means of listing
Agree. Do you have something in mind? We didn't think of this yet.
It's spiffy that the ChatWritePanel now supports basic formatting (bold,
italic, and such) but can IM protocols handle the spiffy, fancier
functionality (fonts and coloring)?
We have now support for ICQ, MSN, Yahoo, Aim and Jabber. Protocols which does not support this functionality just send plain text.
P.S. Damian, hope you don't mind that I'm sending also a copy to the dev mailing list, so that we could continue discussing the spellchecker there. You could even send some screenshots, so that the others get an idea of what we're talking about