[sip-comm-dev] Question about the help menu


#1

Hi,

While working on my GSoC project, I noticed that in the Help menu the
about entry is in double.

I sought the source of the problem. It's located in the :
net.java.sip.communicator.plugin.branding.BrandingActivator.java.
In the method "registerMenuEntry", the AboutWindow is registred twice,
but with different ids.

Is the double registration is really needed ?

@+

Damien

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Damian,

we have also noticed this bug. But, actually the registerMenuEntry registers the About menu once for the main window and once for the chat window. The bug must be somewhere else. If you find it, we'll be very happy to fix that.

Cheers,
Yana

Damien Roth wrote:

···

Hi,

While working on my GSoC project, I noticed that in the Help menu the
about entry is in double.

I sought the source of the problem. It's located in the :
net.java.sip.communicator.plugin.branding.BrandingActivator.java.
In the method "registerMenuEntry", the AboutWindow is registred twice,
but with different ids.

Is the double registration is really needed ?

@+

Damien

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi! I encountered that there is an issue with window sizes and coordinates,
when SC runs on multi monitor system (windows) not on the primary monitor.

The window (SIPCommFrame and SIPCommDialog) becomes VERY big.

I'll have a look on that issue and post a fix very soon.

Cheers, Thomas

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi Yana,

We add two times the about dialog, the first time for the main window
and the second time for the chat window.

I've added some println in the code and the two instances got the same
Container id.
If we change the return value of the
AboutWindowPluginComponent.getContainer() method from
Container.CONTAINER_HELP_MENU to Container.CONTAINER_CHAT_HELP_MENU :
no item is found in the help menu in the main window and only one item
in the chat window.

The result can be easily explained : when we start the branding
plugin, the main window already exists. The method used is :
pluginComponentAdded and it use the method getContainer of the
component. The chat window, is instanced when we start a new
conversation and it use the osgiFilter.

Since the getContainer method always return the same value. The first
way to solve this problem is to use the value of the dictionary (added
when registered a new service) to check the newly added plugin. The
other way is to change the return value of getContainer.

With the event, I haven't found how to get the dictionary, so I use
the second method and it works (the patch is attached). But, is it
really necessary to have two about dialog ?

In the patch there is also a line to set the title to the splash
screen, before the title was "Java", now it's "SIP-Communicator".

Bye

Damien

about-menu.patch (3.03 KB)

···

2008/7/8 Yana Stamcheva <yana@sip-communicator.org>:

Hi Damian,

we have also noticed this bug. But, actually the registerMenuEntry registers
the About menu once for the main window and once for the chat window. The
bug must be somewhere else. If you find it, we'll be very happy to fix that.

Cheers,
Yana

Damien Roth wrote:

Hi,

While working on my GSoC project, I noticed that in the Help menu the
about entry is in double.

I sought the source of the problem. It's located in the :
net.java.sip.communicator.plugin.branding.BrandingActivator.java.
In the method "registerMenuEntry", the AboutWindow is registred twice,
but with different ids.

Is the double registration is really needed ?

@+

Damien


#5

Hi,

Can anyone give me an idea on how I setup the mailbox plugin to answer a SIP call?

Sorry to ask such basic questions but I can't find anything in the distribution where it is used.

thanks, Kim

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Damien,

this time you caught it:) The title of the splash screen was also a very good point. Excellent patch. It's applied, committed and ack-ed.

Cheers,
Yana

Damien Roth wrote:

···

Hi Yana,

We add two times the about dialog, the first time for the main window
and the second time for the chat window.

I've added some println in the code and the two instances got the same
Container id.
If we change the return value of the
AboutWindowPluginComponent.getContainer() method from
Container.CONTAINER_HELP_MENU to Container.CONTAINER_CHAT_HELP_MENU :
no item is found in the help menu in the main window and only one item
in the chat window.

The result can be easily explained : when we start the branding
plugin, the main window already exists. The method used is :
pluginComponentAdded and it use the method getContainer of the
component. The chat window, is instanced when we start a new
conversation and it use the osgiFilter.

Since the getContainer method always return the same value. The first
way to solve this problem is to use the value of the dictionary (added
when registered a new service) to check the newly added plugin. The
other way is to change the return value of getContainer.

With the event, I haven't found how to get the dictionary, so I use
the second method and it works (the patch is attached). But, is it
really necessary to have two about dialog ?

In the patch there is also a line to set the title to the splash
screen, before the title was "Java", now it's "SIP-Communicator".

Bye

Damien

2008/7/8 Yana Stamcheva <yana@sip-communicator.org>:

Hi Damian,

we have also noticed this bug. But, actually the registerMenuEntry registers
the About menu once for the main window and once for the chat window. The
bug must be somewhere else. If you find it, we'll be very happy to fix that.

Cheers,
Yana

Damien Roth wrote:

Hi,

While working on my GSoC project, I noticed that in the Help menu the
about entry is in double.

I sought the source of the problem. It's located in the :
net.java.sip.communicator.plugin.branding.BrandingActivator.java.
In the method "registerMenuEntry", the AboutWindow is registred twice,
but with different ids.

Is the double registration is really needed ?

@+

Damien

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hey Thomas,

I saw you committed so thanks for taking care of this!

Just a quick question. We noticed you use several int constants in there
(20, 40, 100) so would appreciate if you could explain your reasoning in
a few lines.

Cheers
Emil

Thomas Hofer написа:

···

Hi! I encountered that there is an issue with window sizes and coordinates,
when SC runs on multi monitor system (windows) not on the primary monitor.

The window (SIPCommFrame and SIPCommDialog) becomes VERY big.

I'll have a look on that issue and post a fix very soon.

Cheers, Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Hey Kim,

The voice mail plugin is not in any of the project distributions so you
have to manually build it in order to use it.

The reason for this is that it is only partially implemented. The
developer who contributed it as part of GSoC'07 could not continue
working on it after the end of the program so now we only have the RTP
playback and RTP record parts implemented. In other words there's
currently no way for a user to record a local welcome message and no way
to playback messages that others have left on your voicemail.

So anyways, in order to run the part we have you have to add the
"bundle-mailbox" target to the list of dependencies in the "bundles"
target of the build xml.

Hope this helps
Emil

Kim Michael Fairchild написа:

···

Hi,

Can anyone give me an idea on how I setup the mailbox plugin to answer
a SIP call?

Sorry to ask such basic questions but I can't find anything in the
distribution where it is used.

thanks, Kim

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net