[sip-comm-dev] Problem with Error Dialog messages – Fixed ;)


#1

Hi,

I was simply solved the problem with the Error Dialog messages :

File name :
net/java/sip/communicator.impl.gui/customcontrols/ErrorDialog.java

public ErrorDialog( Frame owner,
String title,
String message)
{

....

// replace this.infoMessagePanel.add(msgTextArea); [line 92] with

*this*.infoMessagePanel.add(*new* JLabel("<html><body><p align=\"left\">"
+message+"</p></body></html>"));

....

}

and :

public ErrorDialog( Frame owner,
String title,
String message,
Exception e)
{

...

// Replace the commented lines [Start at Line 123]
//String startDivTag = "<DIV id=\"message\">";
//String endDivTag = "</DIV>";
//String msgString = startDivTag
// + " <A href=''>more info</A>"
// + endDivTag;
//htmlMsgEditorPane.appendToEnd(msgString);
//this.infoMessagePanel.add(htmlMsgEditorPane);

//with

String startDivTag = "<DIV id=\"message\"></DIV>";

String msgString = " <A href=''>more info</A>";

htmlMsgEditorPane.appendToEnd("<p align=\"right\">"+msgString+"</p>");

*this*.infoMessagePanel.add(*new* JLabel("<html><body><p align=\"left\">"
+startDivTag+"</p></body></html>"));

*this*.infoMessagePanel.add(htmlMsgEditorPane);

. ....

}

2. For hide and show the stackTraceScrollPane, by clicking on the text
"more info" :

*private* *boolean* isLinkClicked=*false*;

*public* *void* hyperlinkUpdate(HyperlinkEvent e)

{

*if* (e.getEventType() == HyperlinkEvent.EventType.*ACTIVATED*)

{

*if*(!isLinkClicked)*this*.messagePanel.add(stackTraceScrollPane,
BorderLayout.*CENTER*);

*else* *this*.messagePanel.add(*new* JLabel(), BorderLayout.*CENTER*);

isLinkClicked=!isLinkClicked;

*this*.messagePanel.revalidate();

*this*.messagePanel.repaint();

*this*.pack();

}

}

/*************************************/

This isn't something special, but is better, I hope this help.

Excuse for my English ;).

Cheers

PS : I have attached the modified file ErrorDialog.java

ErrorDialog.java (7.73 KB)

···

--
Daniel VELJJANOSKI


#2

Hi Daniel,

Thank you for submitted this patch. It's a good proposition and your patch works well. Nevertheless it needs some more changes before we could apply it.
So, here is the review of your patch :
- Each functions, attributes and return parameters must be documented.
- Replace all your "tab" character by 4 spaces.
- Every "if", "else", "while", "for", etc. must be followed by its couple of brackets, even if there is a single line in the "if", "else", etc.
- Every bracket must be on its own line.
- The "import org.bouncycastle.LICENSE;" is not needed. I do not understand why you declare it ?
- In the private attributes, replace the declaration of the "JTextArea msgTextArea" by your "new JLabel".
- Clear all references to DIV tag if you do not use it.
- Move the "private boolean isLinkClicked=false;" in the list of attributes.
Once you have corrected properly your patch, please sends it using a "svn diff" format in place of sending the whole file.

You are welcome, if you have more questions.

Cheers,
Vincent

PS: To have a "clean" code, please have a look to the http://www.sip-communicator.org/index.php/Documentation/CodeConvention

Daniel Veljjanoski wrote:

···

Hi,

I was simply solved the problem with the Error Dialog messages :

File name :
net/java/sip/communicator.impl.gui/customcontrols/ErrorDialog.java

public ErrorDialog( Frame owner,
String title,
String message)
{

....

// replace this.infoMessagePanel.add(msgTextArea); [line 92] with

*this*.infoMessagePanel.add(*new* JLabel("<html><body><p align=\"left\">"
+message+"</p></body></html>"));

....

}

and :

public ErrorDialog( Frame owner,
String title,
String message,
Exception e)
{

...

// Replace the commented lines [Start at Line 123]
//String startDivTag = "<DIV id=\"message\">";
//String endDivTag = "</DIV>";
//String msgString = startDivTag
// + " <A href=''>more info</A>"
// + endDivTag;
//htmlMsgEditorPane.appendToEnd(msgString);
//this.infoMessagePanel.add(htmlMsgEditorPane);

//with

String startDivTag = "<DIV id=\"message\"></DIV>";

String msgString = " <A href=''>more info</A>";

htmlMsgEditorPane.appendToEnd("<p align=\"right\">"+msgString+"</p>");

*this*.infoMessagePanel.add(*new* JLabel("<html><body><p align=\"left\">"
+startDivTag+"</p></body></html>"));

*this*.infoMessagePanel.add(htmlMsgEditorPane);

. ....

}

2. For hide and show the stackTraceScrollPane, by clicking on the text
"more info" :

*private* *boolean* isLinkClicked=*false*;

*public* *void* hyperlinkUpdate(HyperlinkEvent e)

{

*if* (e.getEventType() == HyperlinkEvent.EventType.*ACTIVATED*)

{

*if*(!isLinkClicked)*this*.messagePanel.add(stackTraceScrollPane,
BorderLayout.*CENTER*);

*else* *this*.messagePanel.add(*new* JLabel(), BorderLayout.*CENTER*);

isLinkClicked=!isLinkClicked;

*this*.messagePanel.revalidate();

*this*.messagePanel.repaint();

*this*.pack();

}

}

/*************************************/

This isn't something special, but is better, I hope this help.

Excuse for my English ;).

Cheers

PS : I have attached the modified file ErrorDialog.java

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi Vincent,

I have attached my new proposition for ErrorDialog.java (Is more
interesting that the last one),
But sorry I don't understand, this is a simple proposition, you can use it
if you want :).

I have only copied the existing file ErrorDialog.java and added few line of
code...

Way I must respect your code convention?

Cheers

Hi Daniel,

Thank you for submitted this patch. It's a good proposition and your patch
works well. Nevertheless it needs some more changes before we could apply
it.
So, here is the review of your patch :
- Each functions, attributes and return parameters must be documented.

Don't have any functions, atrib. or return params...

- Replace all your "tab" character by 4 spaces.
- Every "if", "else", "while", "for", etc. must be followed by its couple
of brackets, even if there is a single line in the "if", "else", etc.
- Every bracket must be on its own line.
- The "import org.bouncycastle.LICENSE;" is not needed. I do not understand
why you declare it ?

Is not needed, I see, but like u, I don't know what is it :wink:

- In the private attributes, replace the declaration of the "JTextArea
msgTextArea" by your "new JLabel".
- Clear all references to DIV tag if you do not use it.
- Move the "private boolean isLinkClicked=false;" in the list of
attributes.

Where is this list ? :smiley:

Once you have corrected properly your patch, please sends it using a "svn
diff" format in place of sending the whole file.

How to make a svn diff format?

You are welcome, if you have more questions.

Thanks

ErrorDialog.java (7.6 KB)

···

On Fri, May 30, 2008 at 4:29 PM, Vincent Lucas <lucas@clarinet.u-strasbg.fr> wrote:

Cheers,
Vincent

PS: To have a "clean" code, please have a look to the
http://www.sip-communicator.org/index.php/Documentation/CodeConvention

Daniel Veljjanoski wrote:

Hi,

I was simply solved the problem with the Error Dialog messages :

File name :
net/java/sip/communicator.impl.gui/customcontrols/ErrorDialog.java

public ErrorDialog( Frame owner,
String title,
String message)
{

....

// replace this.infoMessagePanel.add(msgTextArea); [line 92] with

*this*.infoMessagePanel.add(*new* JLabel("<html><body><p align=\"left\">"
+message+"</p></body></html>"));

....

}

and :

public ErrorDialog( Frame owner,
String title,
String message,
Exception e)
{

...

// Replace the commented lines [Start at Line 123]
//String startDivTag = "<DIV id=\"message\">";
//String endDivTag = "</DIV>";
//String msgString = startDivTag
// + " <A href=''>more info</A>"
// + endDivTag;
//htmlMsgEditorPane.appendToEnd(msgString);
//this.infoMessagePanel.add(htmlMsgEditorPane);

//with

String startDivTag = "<DIV id=\"message\"></DIV>";

String msgString = " <A href=''>more info</A>";

htmlMsgEditorPane.appendToEnd("<p align=\"right\">"+msgString+"</p>");

*this*.infoMessagePanel.add(*new* JLabel("<html><body><p align=\"left\">"
+startDivTag+"</p></body></html>"));

*this*.infoMessagePanel.add(htmlMsgEditorPane);

. ....

}

2. For hide and show the stackTraceScrollPane, by clicking on the text
"more info" :

*private* *boolean* isLinkClicked=*false*;

*public* *void* hyperlinkUpdate(HyperlinkEvent e)

{

*if* (e.getEventType() == HyperlinkEvent.EventType.*ACTIVATED*)

{

*if*(!isLinkClicked)*this*.messagePanel.add(stackTraceScrollPane,
BorderLayout.*CENTER*);

*else* *this*.messagePanel.add(*new* JLabel(), BorderLayout.*CENTER*);

isLinkClicked=!isLinkClicked;

*this*.messagePanel.revalidate();

*this*.messagePanel.repaint();

*this*.pack();

}

}

/*************************************/

This isn't something special, but is better, I hope this help.

Excuse for my English ;).

Cheers

PS : I have attached the modified file ErrorDialog.java

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
Daniel VELJJANOSKI


#4

Hi Daniel,

Once again, I want to thank you for the effort. Like my last e-mail, I want to give you some advices in order to allows you to improve your work. The idea behind this, is that advising contributors will lead to improve the software as well as your technical skills.

Concerning the code convention, I think that the first paragraph of the dedicated page give some good explications:
"Coding styles have often started religious wars inside projects with different developers trying to prove superiority of the convention they tend to favor. In the SIP Communicator we believe that there is no such thing as a �better� conding style. It is all a matter of habit. However, we do insist on the fact that uniformity is of great importance for assuring code readability. In other words if we want new developers to comply with our coding style it is not because it is the best but simply because the rest of the code is written this way."

Hope this answers your questions,
Vincent

Daniel Veljjanoski wrote:

···

Hi Vincent,

I have attached my new proposition for ErrorDialog.java (Is more
interesting that the last one),
But sorry I don't understand, this is a simple proposition, you can use it
if you want :).

I have only copied the existing file ErrorDialog.java and added few line of
code...

Way I must respect your code convention?

Cheers

On Fri, May 30, 2008 at 4:29 PM, Vincent Lucas <lucas@clarinet.u-strasbg.fr> > wrote:

Hi Daniel,

Thank you for submitted this patch. It's a good proposition and your patch
works well. Nevertheless it needs some more changes before we could apply
it.
So, here is the review of your patch :
- Each functions, attributes and return parameters must be documented.

Don't have any functions, atrib. or return params...

- Replace all your "tab" character by 4 spaces.
- Every "if", "else", "while", "for", etc. must be followed by its couple
of brackets, even if there is a single line in the "if", "else", etc.
- Every bracket must be on its own line.
- The "import org.bouncycastle.LICENSE;" is not needed. I do not understand
why you declare it ?

Is not needed, I see, but like u, I don't know what is it :wink:

- In the private attributes, replace the declaration of the "JTextArea
msgTextArea" by your "new JLabel".
- Clear all references to DIV tag if you do not use it.
- Move the "private boolean isLinkClicked=false;" in the list of
attributes.

Where is this list ? :smiley:

Once you have corrected properly your patch, please sends it using a "svn
diff" format in place of sending the whole file.

How to make a svn diff format?

You are welcome, if you have more questions.

Thanks

Cheers,
Vincent

PS: To have a "clean" code, please have a look to the
http://www.sip-communicator.org/index.php/Documentation/CodeConvention

Daniel Veljjanoski wrote:

Hi,

I was simply solved the problem with the Error Dialog messages :

File name :
net/java/sip/communicator.impl.gui/customcontrols/ErrorDialog.java

public ErrorDialog( Frame owner,
String title,
String message)
{

....

// replace this.infoMessagePanel.add(msgTextArea); [line 92] with

*this*.infoMessagePanel.add(*new* JLabel("<html><body><p align=\"left\">"
+message+"</p></body></html>"));

....

}

and :

public ErrorDialog( Frame owner,
String title,
String message,
Exception e)
{

...

// Replace the commented lines [Start at Line 123]
//String startDivTag = "<DIV id=\"message\">";
//String endDivTag = "</DIV>";
//String msgString = startDivTag
// + " <A href=''>more info</A>"
// + endDivTag;
//htmlMsgEditorPane.appendToEnd(msgString);
//this.infoMessagePanel.add(htmlMsgEditorPane);

//with

String startDivTag = "<DIV id=\"message\"></DIV>";

String msgString = " <A href=''>more info</A>";

htmlMsgEditorPane.appendToEnd("<p align=\"right\">"+msgString+"</p>");

*this*.infoMessagePanel.add(*new* JLabel("<html><body><p align=\"left\">"
+startDivTag+"</p></body></html>"));

*this*.infoMessagePanel.add(htmlMsgEditorPane);

. ....

}

2. For hide and show the stackTraceScrollPane, by clicking on the text
"more info" :

*private* *boolean* isLinkClicked=*false*;

*public* *void* hyperlinkUpdate(HyperlinkEvent e)

{

*if* (e.getEventType() == HyperlinkEvent.EventType.*ACTIVATED*)

{

*if*(!isLinkClicked)*this*.messagePanel.add(stackTraceScrollPane,
BorderLayout.*CENTER*);

*else* *this*.messagePanel.add(*new* JLabel(), BorderLayout.*CENTER*);

isLinkClicked=!isLinkClicked;

*this*.messagePanel.revalidate();

*this*.messagePanel.repaint();

*this*.pack();

}

}

/*************************************/

This isn't something special, but is better, I hope this help.

Excuse for my English ;).

Cheers

PS : I have attached the modified file ErrorDialog.java

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi!

Looks like I have forgotten the advices :slight_smile:
Here the points:
- Please the SIP-Communicator header in each file (including the reference with the LGPL License).
- Can you explain me what is the purpuse of the "String startDivTag = "<DIV id=\"message\"></DIV>";"? If you like to use a "<DIV>" tag, it is likely to put some data inside it.
- Do not forget to remove "tab" by 4 spaces :slight_smile:

Cheers,
Vincent

Vincent Lucas wrote:

···

Hi Daniel,

Once again, I want to thank you for the effort. Like my last e-mail, I want to give you some advices in order to allows you to improve your work. The idea behind this, is that advising contributors will lead to improve the software as well as your technical skills.

Concerning the code convention, I think that the first paragraph of the dedicated page give some good explications:
"Coding styles have often started religious wars inside projects with different developers trying to prove superiority of the convention they tend to favor. In the SIP Communicator we believe that there is no such thing as a �better� conding style. It is all a matter of habit. However, we do insist on the fact that uniformity is of great importance for assuring code readability. In other words if we want new developers to comply with our coding style it is not because it is the best but simply because the rest of the code is written this way."

Hope this answers your questions,
Vincent

Daniel Veljjanoski wrote:

Hi Vincent,

I have attached my new proposition for ErrorDialog.java (Is more
interesting that the last one),
But sorry I don't understand, this is a simple proposition, you can use it
if you want :).

I have only copied the existing file ErrorDialog.java and added few line of
code...

Way I must respect your code convention?

Cheers

On Fri, May 30, 2008 at 4:29 PM, Vincent Lucas >> <lucas@clarinet.u-strasbg.fr> >> wrote:

Hi Daniel,

Thank you for submitted this patch. It's a good proposition and your patch
works well. Nevertheless it needs some more changes before we could apply
it.
So, here is the review of your patch :
- Each functions, attributes and return parameters must be documented.

Don't have any functions, atrib. or return params...

- Replace all your "tab" character by 4 spaces.
- Every "if", "else", "while", "for", etc. must be followed by its couple
of brackets, even if there is a single line in the "if", "else", etc.
- Every bracket must be on its own line.
- The "import org.bouncycastle.LICENSE;" is not needed. I do not understand
why you declare it ?

Is not needed, I see, but like u, I don't know what is it :wink:

- In the private attributes, replace the declaration of the "JTextArea
msgTextArea" by your "new JLabel".
- Clear all references to DIV tag if you do not use it.
- Move the "private boolean isLinkClicked=false;" in the list of
attributes.

Where is this list ? :smiley:

Once you have corrected properly your patch, please sends it using a "svn
diff" format in place of sending the whole file.

How to make a svn diff format?

You are welcome, if you have more questions.

Thanks

Cheers,
Vincent

PS: To have a "clean" code, please have a look to the
http://www.sip-communicator.org/index.php/Documentation/CodeConvention

Daniel Veljjanoski wrote:

Hi,

I was simply solved the problem with the Error Dialog messages :

File name :
net/java/sip/communicator.impl.gui/customcontrols/ErrorDialog.java

public ErrorDialog( Frame owner,
String title,
String message)
{

....

// replace this.infoMessagePanel.add(msgTextArea); [line 92] with

*this*.infoMessagePanel.add(*new* JLabel("<html><body><p align=\"left\">"
+message+"</p></body></html>"));

....

}

and :

public ErrorDialog( Frame owner,
String title,
String message,
Exception e)
{

...

// Replace the commented lines [Start at Line 123]
//String startDivTag = "<DIV id=\"message\">";
//String endDivTag = "</DIV>";
//String msgString = startDivTag
// + " <A href=''>more info</A>"
// + endDivTag;
//htmlMsgEditorPane.appendToEnd(msgString);
//this.infoMessagePanel.add(htmlMsgEditorPane);

//with

String startDivTag = "<DIV id=\"message\"></DIV>";

String msgString = " <A href=''>more info</A>";

htmlMsgEditorPane.appendToEnd("<p align=\"right\">"+msgString+"</p>");

*this*.infoMessagePanel.add(*new* JLabel("<html><body><p align=\"left\">"
+startDivTag+"</p></body></html>"));

*this*.infoMessagePanel.add(htmlMsgEditorPane);

. ....

}

2. For hide and show the stackTraceScrollPane, by clicking on the text
"more info" :

*private* *boolean* isLinkClicked=*false*;

*public* *void* hyperlinkUpdate(HyperlinkEvent e)

{

*if* (e.getEventType() == HyperlinkEvent.EventType.*ACTIVATED*)

{

*if*(!isLinkClicked)*this*.messagePanel.add(stackTraceScrollPane,
BorderLayout.*CENTER*);

*else* *this*.messagePanel.add(*new* JLabel(), BorderLayout.*CENTER*);

isLinkClicked=!isLinkClicked;

*this*.messagePanel.revalidate();

*this*.messagePanel.repaint();

*this*.pack();

}

}

/*************************************/

This isn't something special, but is better, I hope this help.

Excuse for my English ;).

Cheers

PS : I have attached the modified file ErrorDialog.java

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hi Daniel,

I finally got the time to commit your fix and ack the effort on the contributors page.

Thank you for this contribution,
Vincent

Vincent Lucas wrote:

···

Hi!

Looks like I have forgotten the advices :slight_smile:
Here the points:
- Please the SIP-Communicator header in each file (including the reference with the LGPL License).
- Can you explain me what is the purpuse of the "String startDivTag = "<DIV id=\"message\"></DIV>";"? If you like to use a "<DIV>" tag, it is likely to put some data inside it.
- Do not forget to remove "tab" by 4 spaces :slight_smile:

Cheers,
Vincent

Vincent Lucas wrote:

Hi Daniel,

Once again, I want to thank you for the effort. Like my last e-mail, I want to give you some advices in order to allows you to improve your work. The idea behind this, is that advising contributors will lead to improve the software as well as your technical skills.

Concerning the code convention, I think that the first paragraph of the dedicated page give some good explications:
"Coding styles have often started religious wars inside projects with different developers trying to prove superiority of the convention they tend to favor. In the SIP Communicator we believe that there is no such thing as a �better� conding style. It is all a matter of habit. However, we do insist on the fact that uniformity is of great importance for assuring code readability. In other words if we want new developers to comply with our coding style it is not because it is the best but simply because the rest of the code is written this way."

Hope this answers your questions,
Vincent

Daniel Veljjanoski wrote:

Hi Vincent,

I have attached my new proposition for ErrorDialog.java (Is more
interesting that the last one),
But sorry I don't understand, this is a simple proposition, you can use it
if you want :).

I have only copied the existing file ErrorDialog.java and added few line of
code...

Way I must respect your code convention?

Cheers

On Fri, May 30, 2008 at 4:29 PM, Vincent Lucas >>> <lucas@clarinet.u-strasbg.fr> >>> wrote:

Hi Daniel,

Thank you for submitted this patch. It's a good proposition and your patch
works well. Nevertheless it needs some more changes before we could apply
it.
So, here is the review of your patch :
- Each functions, attributes and return parameters must be documented.

Don't have any functions, atrib. or return params...

- Replace all your "tab" character by 4 spaces.
- Every "if", "else", "while", "for", etc. must be followed by its couple
of brackets, even if there is a single line in the "if", "else", etc.
- Every bracket must be on its own line.
- The "import org.bouncycastle.LICENSE;" is not needed. I do not understand
why you declare it ?

Is not needed, I see, but like u, I don't know what is it :wink:

- In the private attributes, replace the declaration of the "JTextArea
msgTextArea" by your "new JLabel".
- Clear all references to DIV tag if you do not use it.
- Move the "private boolean isLinkClicked=false;" in the list of
attributes.

Where is this list ? :smiley:

Once you have corrected properly your patch, please sends it using a "svn
diff" format in place of sending the whole file.

How to make a svn diff format?

You are welcome, if you have more questions.

Thanks

Cheers,
Vincent

PS: To have a "clean" code, please have a look to the
http://www.sip-communicator.org/index.php/Documentation/CodeConvention

Daniel Veljjanoski wrote:

Hi,

I was simply solved the problem with the Error Dialog messages :

File name :
net/java/sip/communicator.impl.gui/customcontrols/ErrorDialog.java

public ErrorDialog( Frame owner,
String title,
String message)
{

....

// replace this.infoMessagePanel.add(msgTextArea); [line 92] with

*this*.infoMessagePanel.add(*new* JLabel("<html><body><p align=\"left\">"
+message+"</p></body></html>"));

....

}

and :

public ErrorDialog( Frame owner,
String title,
String message,
Exception e)
{

...

// Replace the commented lines [Start at Line 123]
//String startDivTag = "<DIV id=\"message\">";
//String endDivTag = "</DIV>";
//String msgString = startDivTag
// + " <A href=''>more info</A>"
// + endDivTag;
//htmlMsgEditorPane.appendToEnd(msgString);
//this.infoMessagePanel.add(htmlMsgEditorPane);

//with

String startDivTag = "<DIV id=\"message\"></DIV>";

String msgString = " <A href=''>more info</A>";

htmlMsgEditorPane.appendToEnd("<p align=\"right\">"+msgString+"</p>");

*this*.infoMessagePanel.add(*new* JLabel("<html><body><p align=\"left\">"
+startDivTag+"</p></body></html>"));

*this*.infoMessagePanel.add(htmlMsgEditorPane);

. ....

}

2. For hide and show the stackTraceScrollPane, by clicking on the text
"more info" :

*private* *boolean* isLinkClicked=*false*;

*public* *void* hyperlinkUpdate(HyperlinkEvent e)

{

*if* (e.getEventType() == HyperlinkEvent.EventType.*ACTIVATED*)

{

*if*(!isLinkClicked)*this*.messagePanel.add(stackTraceScrollPane,
BorderLayout.*CENTER*);

*else* *this*.messagePanel.add(*new* JLabel(), BorderLayout.*CENTER*);

isLinkClicked=!isLinkClicked;

*this*.messagePanel.revalidate();

*this*.messagePanel.repaint();

*this*.pack();

}

}

/*************************************/

This isn't something special, but is better, I hope this help.

Excuse for my English ;).

Cheers

PS : I have attached the modified file ErrorDialog.java

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hi guys,
I'm working on SIP Communicator integration into another application. However, I'm experiencing a bizzare problem: when making calls, in certain situations I can hear myself with a slight delay. This has, so far, only been happening to one participant side. Usually it's one of applications which have SIP comm integrated in it. But once I could hear myself while calling from regular phone to SIP comm integrated app.

The one thing I noticed is that when I call X-Lite from SIP comm it seems communication is half-duplex, eg. when the other participant is not talking I don't receive anything, but if we talk at the same time I can hear myself. When the call is between two SIP comm integrated apps the call seems to be full duplex, so I can hear myself all the time.

I'll try testing with different SIP registry/proxy, but I was just wondering if anyone experienced similar problem?

Thanks,
Zoran


#8

Hey Zoran,

You might have figured this by yourself already but I thought I'd
mention it anyways. Right now we don't have any echo-cancelation in SIP
Communicator whatsoever which in my opinion would explain most of your
issues.

We did try to make it work using the echo cancellation from speex at one
point (I remember Damian had a rough fight with it), but I remember we
only had satisfactory results on Linux and couldn't get anything out of
windows.

Cheers
Emil

Zoran Lovric написа:

···

Hi guys,
I'm working on SIP Communicator integration into another application.
However, I'm experiencing a bizzare problem: when making calls, in
certain situations I can hear myself with a slight delay. This has, so
far, only been happening to one participant side. Usually it's one of
applications which have SIP comm integrated in it. But once I could hear
myself while calling from regular phone to SIP comm integrated app.

The one thing I noticed is that when I call X-Lite from SIP comm it
seems communication is half-duplex, eg. when the other participant is
not talking I don't receive anything, but if we talk at the same time I
can hear myself. When the call is between two SIP comm integrated apps
the call seems to be full duplex, so I can hear myself all the time.

I'll try testing with different SIP registry/proxy, but I was just
wondering if anyone experienced similar problem?

Thanks,
Zoran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#9

Hi Emil,
Unfortunately, I think the problem I'm experiencing is not a simple echo. Like, when the person I'm talking to is using speakers instead of headphones. The reason why I think this is because sometimes I can hear myself even when I'm calling someone who's using a headphones or even regular a PSTN phone. When this occurs, I can hear myself with the same audio quality as the other person, not like it's in a background.

I didn't have time yet to investigate this further, but when I do I'll let you guys know what the problem was.

Thanks,
Zoran

···

_____

From: Emil Ivov [mailto:emcho@sip-communicator.org]

To: dev@sip-communicator.dev.java.net
Sent: Sat, 14 Jun 2008 18:15:20 +0100
Subject: Re: [sip-comm-dev] hearing myself in a SIP call

Hey Zoran,
  
  You might have figured this by yourself already but I thought I'd
  mention it anyways. Right now we don't have any echo-cancelation in SIP
  Communicator whatsoever which in my opinion would explain most of your
  issues.
  
  We did try to make it work using the echo cancellation from speex at one
  point (I remember Damian had a rough fight with it), but I remember we
  only had satisfactory results on Linux and couldn't get anything out of
  windows.
  
  Cheers
  Emil
  
  Zoran Lovric написа:
  > Hi guys,
  > I'm working on SIP Communicator integration into another application.
  > However, I'm experiencing a bizzare problem: when making calls, in
  > certain situations I can hear myself with a slight delay. This has, so
  > far, only been happening to one participant side. Usually it's one of
  > applications which have SIP comm integrated in it. But once I could hear
  > myself while calling from regular phone to SIP comm integrated app.
  >
  > The one thing I noticed is that when I call X-Lite from SIP comm it
  > seems communication is half-duplex, eg. when the other participant is
  > not talking I don't receive anything, but if we talk at the same time I
  > can hear myself. When the call is between two SIP comm integrated apps
  > the call seems to be full duplex, so I can hear myself all the time.
  >
  > I'll try testing with different SIP registry/proxy, but I was just
  > wondering if anyone experienced similar problem?
  >
  > Thanks,
  > Zoran
  
  ---------------------------------------------------------------------
  To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
  For additional commands, e-mail: dev-help@sip-communicator.dev.java.net