[sip-comm-dev] Previews


#1

Hi Purvesh,

I've updated the previews branch today and couldn't compile. Are you in a process of merging right now? When do you think you'd be able to fix it, so that I could give it a try? :slight_smile:

Cheers,
Yana

路路路

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Purvesh,

Did you try launching "svn status" through the console? The Eclipse's svn plugin has problems from time to time.

Here's what I get after invoking "ant rebuild":

[javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/ActiveCallsRepository.java:130: cannot find symbol
聽聽聽聽[javac] symbol : method contains(org.jivesoftware.smackx.jingle.JingleSession)
聽聽聽聽[javac] location: class net.java.sip.communicator.impl.protocol.jabber.CallJabberImpl
聽聽聽聽[javac] if(call.contains(session))
聽聽聽聽[javac] ^
聽聽聽聽[javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/ActiveCallsRepository.java:168: cannot find symbol
聽聽聽聽[javac] symbol : method findCallPeer(org.jivesoftware.smackx.jingle.JingleSession)
聽聽聽聽[javac] location: class net.java.sip.communicator.impl.protocol.jabber.CallJabberImpl
聽聽聽聽[javac] CallPeerJabberImpl callPeer = call.findCallPeer(session);
聽聽聽聽[javac] ^
聽聽聽聽[javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/OperationSetBasicTelephonyJabberImpl.java:220: cannot find symbol
聽聽聽聽[javac] symbol : method getActiveCalls()
聽聽聽聽[javac] location: class net.java.sip.communicator.impl.protocol.jabber.ActiveCallsRepositoryJabberImpl
聽聽聽聽[javac] return activeCallsRepository.getActiveCalls();
聽聽聽聽[javac] ^
聽聽聽聽[javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/OperationSetBasicTelephonyJabberImpl.java:323: cannot find symbol
聽聽聽聽[javac] symbol : method getActiveCalls()
聽聽聽聽[javac] location: class net.java.sip.communicator.impl.protocol.jabber.ActiveCallsRepositoryJabberImpl
聽聽聽聽[javac] = this.activeCallsRepository.getActiveCalls();
聽聽聽聽[javac] ^
聽聽聽聽[javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/CallJabberImpl.java:53: cannot find symbol
聽聽聽聽[javac] symbol : method addCall(net.java.sip.communicator.impl.protocol.jabber.CallJabberImpl)
聽聽聽聽[javac] location: class net.java.sip.communicator.impl.protocol.jabber.ActiveCallsRepositoryJabberImpl
聽聽聽聽[javac] parentOpSet.getActiveCallsRepository().addCall(this);
聽聽聽聽[javac] ^
聽聽聽聽[javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/ActiveCallsRepositoryJabberImpl.java:57: cannot find symbol
聽聽聽聽[javac] symbol : method getActiveCalls()
聽聽聽聽[javac] location: class net.java.sip.communicator.impl.protocol.jabber.ActiveCallsRepositoryJabberImpl
聽聽聽聽[javac] Iterator<CallJabberImpl> calls = getActiveCalls();
聽聽聽聽[javac] ^
聽聽聽聽[javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/ContentProvider.java:40: cannot find symbol
聽聽聽聽[javac] symbol : variable CREATOR_ARG_NAME
聽聽聽聽[javac] location: class net.java.sip.communicator.impl.protocol.jabber.extensions.jingle.ContentPacketExtension
聽聽聽聽[javac] ContentPacketExtension.CREATOR_ARG_NAME);
聽聽聽聽[javac] ^
聽聽聽聽[javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/ContentProvider.java:42: cannot find symbol
聽聽聽聽[javac] symbol : variable DISPOSITION_ARG_NAME
聽聽聽聽[javac] location: class net.java.sip.communicator.impl.protocol.jabber.extensions.jingle.ContentPacketExtension
聽聽聽聽[javac] ContentPacketExtension.DISPOSITION_ARG_NAME);
聽聽聽聽[javac] ^
聽聽聽聽[javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/ContentProvider.java:44: cannot find symbol
聽聽聽聽[javac] symbol : variable NAME_ARG_NAME
聽聽聽聽[javac] location: class net.java.sip.communicator.impl.protocol.jabber.extensions.jingle.ContentPacketExtension
聽聽聽聽[javac] ContentPacketExtension.NAME_ARG_NAME);
聽聽聽聽[javac] ^
聽聽聽聽[javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/ContentProvider.java:46: cannot find symbol
聽聽聽聽[javac] symbol : variable SENDERS_ARG_NAME
聽聽聽聽[javac] location: class net.java.sip.communicator.impl.protocol.jabber.extensions.jingle.ContentPacketExtension
聽聽聽聽[javac] "", ContentPacketExtension.SENDERS_ARG_NAME);
聽聽聽聽[javac] ^

Cheers,
Yana

p.s. please reply to the dev mailing list, instead of privately

路路路

On Aug 10, 2010, at 12:42 PM, Purvesh Sahoo wrote:

Hi Yana,

I'm looking into it right now. This may be due to the merge issues I had earlier. My WC seems to build fine. Could you please paste the error thrown while build fails? Strangely enough eclipse shows my WC to be in sync with the branch.

Thanks,
Purvesh

On Tue, Aug 10, 2010 at 3:14 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
Hi Purvesh,

I've updated the previews branch today and couldn't compile. Are you in a process of merging right now? When do you think you'd be able to fix it, so that I could give it a try? :slight_smile:

Cheers,
Yana

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi Yana,

Yes, the eclipse plugin does cause lots of issues, esp while merging. I've
learnt this the hard way :/. I've checked out a fresh copy from the branch
and I think the build error was due to the plugin not recognizing to commit
certain changes. Anyhow, I've made a commit using the console, and it should
be be working now. Could you please verify?

Thanks,
Purvesh

路路路

On Tue, Aug 10, 2010 at 7:23 PM, Yana Stamcheva <yana@sip-communicator.org>wrote:

Hi Purvesh,

Did you try launching "svn status" through the console? The Eclipse's svn
plugin has problems from time to time.

Here's what I get after invoking "ant rebuild":

> [javac]
/Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/ActiveCallsRepository.java:130:
cannot find symbol
> [javac] symbol : method
contains(org.jivesoftware.smackx.jingle.JingleSession)
> [javac] location: class
net.java.sip.communicator.impl.protocol.jabber.CallJabberImpl
> [javac] if(call.contains(session))
> [javac] ^
> [javac]
/Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/ActiveCallsRepository.java:168:
cannot find symbol
> [javac] symbol : method
findCallPeer(org.jivesoftware.smackx.jingle.JingleSession)
> [javac] location: class
net.java.sip.communicator.impl.protocol.jabber.CallJabberImpl
> [javac] CallPeerJabberImpl callPeer =
call.findCallPeer(session);
> [javac] ^
> [javac]
/Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/OperationSetBasicTelephonyJabberImpl.java:220:
cannot find symbol
> [javac] symbol : method getActiveCalls()
> [javac] location: class
net.java.sip.communicator.impl.protocol.jabber.ActiveCallsRepositoryJabberImpl
> [javac] return activeCallsRepository.getActiveCalls();
> [javac] ^
> [javac]
/Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/OperationSetBasicTelephonyJabberImpl.java:323:
cannot find symbol
> [javac] symbol : method getActiveCalls()
> [javac] location: class
net.java.sip.communicator.impl.protocol.jabber.ActiveCallsRepositoryJabberImpl
> [javac] = this.activeCallsRepository.getActiveCalls();
> [javac] ^
> [javac]
/Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/CallJabberImpl.java:53:
cannot find symbol
> [javac] symbol : method
addCall(net.java.sip.communicator.impl.protocol.jabber.CallJabberImpl)
> [javac] location: class
net.java.sip.communicator.impl.protocol.jabber.ActiveCallsRepositoryJabberImpl
> [javac] parentOpSet.getActiveCallsRepository().addCall(this);
> [javac] ^
> [javac]
/Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/ActiveCallsRepositoryJabberImpl.java:57:
cannot find symbol
> [javac] symbol : method getActiveCalls()
> [javac] location: class
net.java.sip.communicator.impl.protocol.jabber.ActiveCallsRepositoryJabberImpl
> [javac] Iterator<CallJabberImpl> calls = getActiveCalls();
> [javac] ^
> [javac]
/Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/ContentProvider.java:40:
cannot find symbol
> [javac] symbol : variable CREATOR_ARG_NAME
> [javac] location: class
net.java.sip.communicator.impl.protocol.jabber.extensions.jingle.ContentPacketExtension
> [javac]
ContentPacketExtension.CREATOR_ARG_NAME);
> [javac] ^
> [javac]
/Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/ContentProvider.java:42:
cannot find symbol
> [javac] symbol : variable DISPOSITION_ARG_NAME
> [javac] location: class
net.java.sip.communicator.impl.protocol.jabber.extensions.jingle.ContentPacketExtension
> [javac]
ContentPacketExtension.DISPOSITION_ARG_NAME);
> [javac] ^
> [javac]
/Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/ContentProvider.java:44:
cannot find symbol
> [javac] symbol : variable NAME_ARG_NAME
> [javac] location: class
net.java.sip.communicator.impl.protocol.jabber.extensions.jingle.ContentPacketExtension
> [javac]
ContentPacketExtension.NAME_ARG_NAME);
> [javac] ^
> [javac]
/Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/ContentProvider.java:46:
cannot find symbol
> [javac] symbol : variable SENDERS_ARG_NAME
> [javac] location: class
net.java.sip.communicator.impl.protocol.jabber.extensions.jingle.ContentPacketExtension
> [javac] "",
ContentPacketExtension.SENDERS_ARG_NAME);
> [javac] ^
>

Cheers,
Yana

p.s. please reply to the dev mailing list, instead of privately

On Aug 10, 2010, at 12:42 PM, Purvesh Sahoo wrote:

> Hi Yana,
>
> I'm looking into it right now. This may be due to the merge issues I had
earlier. My WC seems to build fine. Could you please paste the error thrown
while build fails? Strangely enough eclipse shows my WC to be in sync with
the branch.
>
> Thanks,
> Purvesh
>
> On Tue, Aug 10, 2010 at 3:14 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> Hi Purvesh,
>
> I've updated the previews branch today and couldn't compile. Are you in a
process of merging right now? When do you think you'd be able to fix it, so
that I could give it a try? :slight_smile:
>
> Cheers,
> Yana
>


#4

Hi Purvesh,

It works perfect! Thanks!

Yana

路路路

On Aug 10, 2010, at 4:58 PM, Purvesh Sahoo wrote:

Hi Yana,

Yes, the eclipse plugin does cause lots of issues, esp while merging. I've learnt this the hard way :/. I've checked out a fresh copy from the branch and I think the build error was due to the plugin not recognizing to commit certain changes. Anyhow, I've made a commit using the console, and it should be be working now. Could you please verify?

Thanks,
Purvesh

On Tue, Aug 10, 2010 at 7:23 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
Hi Purvesh,

Did you try launching "svn status" through the console? The Eclipse's svn plugin has problems from time to time.

Here's what I get after invoking "ant rebuild":

> [javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/ActiveCallsRepository.java:130: cannot find symbol
> [javac] symbol : method contains(org.jivesoftware.smackx.jingle.JingleSession)
> [javac] location: class net.java.sip.communicator.impl.protocol.jabber.CallJabberImpl
> [javac] if(call.contains(session))
> [javac] ^
> [javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/ActiveCallsRepository.java:168: cannot find symbol
> [javac] symbol : method findCallPeer(org.jivesoftware.smackx.jingle.JingleSession)
> [javac] location: class net.java.sip.communicator.impl.protocol.jabber.CallJabberImpl
> [javac] CallPeerJabberImpl callPeer = call.findCallPeer(session);
> [javac] ^
> [javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/OperationSetBasicTelephonyJabberImpl.java:220: cannot find symbol
> [javac] symbol : method getActiveCalls()
> [javac] location: class net.java.sip.communicator.impl.protocol.jabber.ActiveCallsRepositoryJabberImpl
> [javac] return activeCallsRepository.getActiveCalls();
> [javac] ^
> [javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/OperationSetBasicTelephonyJabberImpl.java:323: cannot find symbol
> [javac] symbol : method getActiveCalls()
> [javac] location: class net.java.sip.communicator.impl.protocol.jabber.ActiveCallsRepositoryJabberImpl
> [javac] = this.activeCallsRepository.getActiveCalls();
> [javac] ^
> [javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/CallJabberImpl.java:53: cannot find symbol
> [javac] symbol : method addCall(net.java.sip.communicator.impl.protocol.jabber.CallJabberImpl)
> [javac] location: class net.java.sip.communicator.impl.protocol.jabber.ActiveCallsRepositoryJabberImpl
> [javac] parentOpSet.getActiveCallsRepository().addCall(this);
> [javac] ^
> [javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/ActiveCallsRepositoryJabberImpl.java:57: cannot find symbol
> [javac] symbol : method getActiveCalls()
> [javac] location: class net.java.sip.communicator.impl.protocol.jabber.ActiveCallsRepositoryJabberImpl
> [javac] Iterator<CallJabberImpl> calls = getActiveCalls();
> [javac] ^
> [javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/ContentProvider.java:40: cannot find symbol
> [javac] symbol : variable CREATOR_ARG_NAME
> [javac] location: class net.java.sip.communicator.impl.protocol.jabber.extensions.jingle.ContentPacketExtension
> [javac] ContentPacketExtension.CREATOR_ARG_NAME);
> [javac] ^
> [javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/ContentProvider.java:42: cannot find symbol
> [javac] symbol : variable DISPOSITION_ARG_NAME
> [javac] location: class net.java.sip.communicator.impl.protocol.jabber.extensions.jingle.ContentPacketExtension
> [javac] ContentPacketExtension.DISPOSITION_ARG_NAME);
> [javac] ^
> [javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/ContentProvider.java:44: cannot find symbol
> [javac] symbol : variable NAME_ARG_NAME
> [javac] location: class net.java.sip.communicator.impl.protocol.jabber.extensions.jingle.ContentPacketExtension
> [javac] ContentPacketExtension.NAME_ARG_NAME);
> [javac] ^
> [javac] /Users/yanastamcheva/workspace/previews/src/net/java/sip/communicator/impl/protocol/jabber/extensions/jingle/ContentProvider.java:46: cannot find symbol
> [javac] symbol : variable SENDERS_ARG_NAME
> [javac] location: class net.java.sip.communicator.impl.protocol.jabber.extensions.jingle.ContentPacketExtension
> [javac] "", ContentPacketExtension.SENDERS_ARG_NAME);
> [javac] ^
>

Cheers,
Yana

p.s. please reply to the dev mailing list, instead of privately

On Aug 10, 2010, at 12:42 PM, Purvesh Sahoo wrote:

> Hi Yana,
>
> I'm looking into it right now. This may be due to the merge issues I had earlier. My WC seems to build fine. Could you please paste the error thrown while build fails? Strangely enough eclipse shows my WC to be in sync with the branch.
>
> Thanks,
> Purvesh
>
> On Tue, Aug 10, 2010 at 3:14 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> Hi Purvesh,
>
> I've updated the previews branch today and couldn't compile. Are you in a process of merging right now? When do you think you'd be able to fix it, so that I could give it a try? :slight_smile:
>
> Cheers,
> Yana
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hey Purvesh,

It works really great!! I've tried all the available sources and every link was replaced by the related image or video snapshot. Good work!

I have a few very minor questions/comments.

When looking to the configuration form (screenshot attached), the two check boxes are indented and are not correctly aligned to the sources list (they're may be placed in the center of the panel, instead to the left area). Could you please try to align them on the left? Could you please also add ":" after the "Image/Video" title?

I was wondering about the preview border in the chat window (the blue border appearing around each preview image), is it possible to change its color to black for example?

Not as minor as other comments:) could you please add javadoc comments for each class, method and field in the replacement service and all its implementations. Don't forget to add the license comment in the beginning of each class.

Cheers,
Yana


#6

Hi Yana,

Hey Purvesh,

It works really great!! I've tried all the available sources and every link
was replaced by the related image or video snapshot. Good work!

I have a few very minor questions/comments.

When looking to the configuration form (screenshot attached), the two check
boxes are indented and are not correctly aligned to the sources list
(they're may be placed in the center of the panel, instead to the left
area). Could you please try to align them on the left? Could you please also
add ":" after the "Image/Video" title?

I've made these changes. I will commit them along with the javadocs.

I was wondering about the preview border in the chat window (the blue
border appearing around each preview image), is it possible to change its
color to black for example?

It seems swing doesn't support all the CSS properties. As listed here:
http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html

路路路

On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva <yana@sip-communicator.org>wrote:
,
"border" or "border-color" isn't rendered. So there isn't a way to control
the color it seems. We can however remove the border altogether by adding a
BORDER="0" attribute to the <IMG> tag.

Thanks,
Purvesh


#7

Hi Purvesh,

Hi Yana,

Hey Purvesh,

It works really great!! I've tried all the available sources and every link was replaced by the related image or video snapshot. Good work!

I have a few very minor questions/comments.

When looking to the configuration form (screenshot attached), the two check boxes are indented and are not correctly aligned to the sources list (they're may be placed in the center of the panel, instead to the left area). Could you please try to align them on the left? Could you please also add ":" after the "Image/Video" title?

I've made these changes. I will commit them along with the javadocs.

Great, thanks.

I was wondering about the preview border in the chat window (the blue border appearing around each preview image), is it possible to change its color to black for example?

It seems swing doesn't support all the CSS properties. As listed here: http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html , "border" or "border-color" isn't rendered. So there isn't a way to control the color it seems. We can however remove the border altogether by adding a BORDER="0" attribute to the <IMG> tag.

Ok. Then we could go for now with the blue border.

Cheers,
Yana

路路路

On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:

On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:

Thanks,
Purvesh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Hi Purvesh,

Thanks for adding all javadocs and fixing the alignment in the configuration form!

I spent some time testing the previews and I have some more remarks, mainly on the configuration form. Here they are:

- Lubomir noticed and shared with me off-list that the "Enable Video/Image replacement" button has to be called "Enable Image/Video replacement", as the title of the paragraph is also "Image/Video".

- The enable checkbox is now acting more like "activate/desactivate all" instead of enable/disable. In order to have a real enable/disable checkbox, when unchecked all listed checkboxes should become disabled (grey), but their state (checked/unchecked) should stay as it is. When checked again, the listed checkboxes become enabled and the their state don't change.

Keep up the good work!
Yana

路路路

On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:

Hi Yana,

On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
Hey Purvesh,

It works really great!! I've tried all the available sources and every link was replaced by the related image or video snapshot. Good work!

I have a few very minor questions/comments.

When looking to the configuration form (screenshot attached), the two check boxes are indented and are not correctly aligned to the sources list (they're may be placed in the center of the panel, instead to the left area). Could you please try to align them on the left? Could you please also add ":" after the "Image/Video" title?

I've made these changes. I will commit them along with the javadocs.

I was wondering about the preview border in the chat window (the blue border appearing around each preview image), is it possible to change its color to black for example?

It seems swing doesn't support all the CSS properties. As listed here: http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html , "border" or "border-color" isn't rendered. So there isn't a way to control the color it seems. We can however remove the border altogether by adding a BORDER="0" attribute to the <IMG> tag.

Thanks,
Purvesh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#9

Hi Yana,

Yes, I think it would be a good idea to retain the selected sources. I had
something like that in mind as well. I've just commited the changes in the
branch.

Thanks,
Purvesh

路路路

On Mon, Aug 16, 2010 at 5:19 PM, Yana Stamcheva <yana@sip-communicator.org>wrote:

Hi Purvesh,

Thanks for adding all javadocs and fixing the alignment in the
configuration form!

I spent some time testing the previews and I have some more remarks, mainly
on the configuration form. Here they are:

- Lubomir noticed and shared with me off-list that the "Enable Video/Image
replacement" button has to be called "Enable Image/Video replacement", as
the title of the paragraph is also "Image/Video".

- The enable checkbox is now acting more like "activate/desactivate all"
instead of enable/disable. In order to have a real enable/disable checkbox,
when unchecked all listed checkboxes should become disabled (grey), but
their state (checked/unchecked) should stay as it is. When checked again,
the listed checkboxes become enabled and the their state don't change.

Keep up the good work!
Yana

On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:

> Hi Yana,
>
>
> On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> Hey Purvesh,
>
> It works really great!! I've tried all the available sources and every
link was replaced by the related image or video snapshot. Good work!
>
> I have a few very minor questions/comments.
>
> When looking to the configuration form (screenshot attached), the two
check boxes are indented and are not correctly aligned to the sources list
(they're may be placed in the center of the panel, instead to the left
area). Could you please try to align them on the left? Could you please also
add ":" after the "Image/Video" title?
>
>
> I've made these changes. I will commit them along with the javadocs.
>
> I was wondering about the preview border in the chat window (the blue
border appearing around each preview image), is it possible to change its
color to black for example?
>
>
> It seems swing doesn't support all the CSS properties. As listed here:
http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html, "border" or "border-color" isn't rendered. So there isn't a way to control
the color it seems. We can however remove the border altogether by adding a
BORDER="0" attribute to the <IMG> tag.
>
>
> Thanks,
> Purvesh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#10

Hi Purvesh,

Great work! Could you please merge your branch with the trunk and prepare a patch, so that we could integrate your work in the repository and everybody could enjoy the new previews:)

Cheers,
Yana

路路路

On Aug 16, 2010, at 7:01 PM, Purvesh Sahoo wrote:

Hi Yana,

Yes, I think it would be a good idea to retain the selected sources. I had something like that in mind as well. I've just commited the changes in the branch.

Thanks,
Purvesh

On Mon, Aug 16, 2010 at 5:19 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
Hi Purvesh,

Thanks for adding all javadocs and fixing the alignment in the configuration form!

I spent some time testing the previews and I have some more remarks, mainly on the configuration form. Here they are:

- Lubomir noticed and shared with me off-list that the "Enable Video/Image replacement" button has to be called "Enable Image/Video replacement", as the title of the paragraph is also "Image/Video".

- The enable checkbox is now acting more like "activate/desactivate all" instead of enable/disable. In order to have a real enable/disable checkbox, when unchecked all listed checkboxes should become disabled (grey), but their state (checked/unchecked) should stay as it is. When checked again, the listed checkboxes become enabled and the their state don't change.

Keep up the good work!
Yana

On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:

> Hi Yana,
>
>
> On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> Hey Purvesh,
>
> It works really great!! I've tried all the available sources and every link was replaced by the related image or video snapshot. Good work!
>
> I have a few very minor questions/comments.
>
> When looking to the configuration form (screenshot attached), the two check boxes are indented and are not correctly aligned to the sources list (they're may be placed in the center of the panel, instead to the left area). Could you please try to align them on the left? Could you please also add ":" after the "Image/Video" title?
>
>
> I've made these changes. I will commit them along with the javadocs.
>
> I was wondering about the preview border in the chat window (the blue border appearing around each preview image), is it possible to change its color to black for example?
>
>
> It seems swing doesn't support all the CSS properties. As listed here: http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html , "border" or "border-color" isn't rendered. So there isn't a way to control the color it seems. We can however remove the border altogether by adding a BORDER="0" attribute to the <IMG> tag.
>
>
> Thanks,
> Purvesh

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#11

Hi Yana,

I've attached the patch. It presently has the gdata libs, which are required
for accessing the Youtube API. I could get rid of the dependencies by using
oembed, if it is an issue. The only downside is, oembed marks the
"thumbnail_url" response parameter as optional. Youtube does return that
value now, but we can't be sure about that since they had removed it in the
past.

Thanks,
Purvesh

Previews.zip (1.11 MB)

路路路

On Fri, Sep 3, 2010 at 2:34 PM, Yana Stamcheva <yana@sip-communicator.org>wrote:

Hi Purvesh,

Great work! Could you please merge your branch with the trunk and prepare a
patch, so that we could integrate your work in the repository and everybody
could enjoy the new previews:)

Cheers,
Yana

On Aug 16, 2010, at 7:01 PM, Purvesh Sahoo wrote:

> Hi Yana,
>
> Yes, I think it would be a good idea to retain the selected sources. I
had something like that in mind as well. I've just commited the changes in
the branch.
>
> Thanks,
> Purvesh
>
> On Mon, Aug 16, 2010 at 5:19 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> Hi Purvesh,
>
> Thanks for adding all javadocs and fixing the alignment in the
configuration form!
>
> I spent some time testing the previews and I have some more remarks,
mainly on the configuration form. Here they are:
>
> - Lubomir noticed and shared with me off-list that the "Enable
Video/Image replacement" button has to be called "Enable Image/Video
replacement", as the title of the paragraph is also "Image/Video".
>
> - The enable checkbox is now acting more like "activate/desactivate all"
instead of enable/disable. In order to have a real enable/disable checkbox,
when unchecked all listed checkboxes should become disabled (grey), but
their state (checked/unchecked) should stay as it is. When checked again,
the listed checkboxes become enabled and the their state don't change.
>
> Keep up the good work!
> Yana
>
> On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:
>
> > Hi Yana,
> >
> >
> > On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > Hey Purvesh,
> >
> > It works really great!! I've tried all the available sources and every
link was replaced by the related image or video snapshot. Good work!
> >
> > I have a few very minor questions/comments.
> >
> > When looking to the configuration form (screenshot attached), the two
check boxes are indented and are not correctly aligned to the sources list
(they're may be placed in the center of the panel, instead to the left
area). Could you please try to align them on the left? Could you please also
add ":" after the "Image/Video" title?
> >
> >
> > I've made these changes. I will commit them along with the javadocs.
> >
> > I was wondering about the preview border in the chat window (the blue
border appearing around each preview image), is it possible to change its
color to black for example?
> >
> >
> > It seems swing doesn't support all the CSS properties. As listed here:
http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html, "border" or "border-color" isn't rendered. So there isn't a way to control
the color it seems. We can however remove the border altogether by adding a
BORDER="0" attribute to the <IMG> tag.
> >
> >
> > Thanks,
> > Purvesh
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>


#12

Hi Purvesh,

Thanks for the patch!! It looks great on a first glance by the way.

(more inline)

Hi Yana,

I've attached the patch. It presently has the gdata libs, which are required for accessing the Youtube API.

Does we really need all the 7 jars in order to continue using the gdata lib?

I could get rid of the dependencies by using oembed, if it is an issue. The only downside is, oembed marks the "thumbnail_url" response parameter as optional. Youtube does return that value now, but we can't be sure about that since they had removed it in the past.

oEmbed sounds like an option for me. Did you use it for the other sources of video/images like daily motion, flickr, etc. ?

Another unrelated question. Where is the mail.jar used?

Cheers,
Yana

路路路

On Sep 6, 2010, at 1:25 PM, Purvesh Sahoo wrote:

Thanks,
Purvesh

On Fri, Sep 3, 2010 at 2:34 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
Hi Purvesh,

Great work! Could you please merge your branch with the trunk and prepare a patch, so that we could integrate your work in the repository and everybody could enjoy the new previews:)

Cheers,
Yana

On Aug 16, 2010, at 7:01 PM, Purvesh Sahoo wrote:

> Hi Yana,
>
> Yes, I think it would be a good idea to retain the selected sources. I had something like that in mind as well. I've just commited the changes in the branch.
>
> Thanks,
> Purvesh
>
> On Mon, Aug 16, 2010 at 5:19 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> Hi Purvesh,
>
> Thanks for adding all javadocs and fixing the alignment in the configuration form!
>
> I spent some time testing the previews and I have some more remarks, mainly on the configuration form. Here they are:
>
> - Lubomir noticed and shared with me off-list that the "Enable Video/Image replacement" button has to be called "Enable Image/Video replacement", as the title of the paragraph is also "Image/Video".
>
> - The enable checkbox is now acting more like "activate/desactivate all" instead of enable/disable. In order to have a real enable/disable checkbox, when unchecked all listed checkboxes should become disabled (grey), but their state (checked/unchecked) should stay as it is. When checked again, the listed checkboxes become enabled and the their state don't change.
>
> Keep up the good work!
> Yana
>
> On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:
>
> > Hi Yana,
> >
> >
> > On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > Hey Purvesh,
> >
> > It works really great!! I've tried all the available sources and every link was replaced by the related image or video snapshot. Good work!
> >
> > I have a few very minor questions/comments.
> >
> > When looking to the configuration form (screenshot attached), the two check boxes are indented and are not correctly aligned to the sources list (they're may be placed in the center of the panel, instead to the left area). Could you please try to align them on the left? Could you please also add ":" after the "Image/Video" title?
> >
> >
> > I've made these changes. I will commit them along with the javadocs.
> >
> > I was wondering about the preview border in the chat window (the blue border appearing around each preview image), is it possible to change its color to black for example?
> >
> >
> > It seems swing doesn't support all the CSS properties. As listed here: http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html , "border" or "border-color" isn't rendered. So there isn't a way to control the color it seems. We can however remove the border altogether by adding a BORDER="0" attribute to the <IMG> tag.
> >
> >
> > Thanks,
> > Purvesh
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>

<Previews.zip>---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#13

Hi Yana,

I think we can do without the jars for now. I've been testing youtube
oEmbed, and it seems they are returning the "thumbnail_url" parameter
consistently, and they have made a post about it in the API blog. I think,
thats's the next best thing to the official documentation.
The jars would be too much overhead. We could get rid of the meta jars and
mail.jar (my bad!) if we still have to use the gdata libs.

I haven't used oEmbed for all the services. Some, which support oEmbed,
don't return the thumbnail param at all. But they have it documented, so
it's easy to figure out.

Here is the new patch without all the jars.

Thanks,
Purvesh

Previews.zip (20.5 KB)

路路路

On Mon, Sep 6, 2010 at 5:32 PM, Yana Stamcheva <yana@sip-communicator.org>wrote:

Hi Purvesh,

Thanks for the patch!! It looks great on a first glance by the way.

(more inline)

On Sep 6, 2010, at 1:25 PM, Purvesh Sahoo wrote:

> Hi Yana,
>
> I've attached the patch. It presently has the gdata libs, which are
required for accessing the Youtube API.

Does we really need all the 7 jars in order to continue using the gdata
lib?

> I could get rid of the dependencies by using oembed, if it is an issue.
The only downside is, oembed marks the "thumbnail_url" response parameter as
optional. Youtube does return that value now, but we can't be sure about
that since they had removed it in the past.

oEmbed sounds like an option for me. Did you use it for the other sources
of video/images like daily motion, flickr, etc. ?

Another unrelated question. Where is the mail.jar used?

Cheers,
Yana

>
> Thanks,
> Purvesh
>
> On Fri, Sep 3, 2010 at 2:34 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> Hi Purvesh,
>
> Great work! Could you please merge your branch with the trunk and prepare
a patch, so that we could integrate your work in the repository and
everybody could enjoy the new previews:)
>
> Cheers,
> Yana
>
> On Aug 16, 2010, at 7:01 PM, Purvesh Sahoo wrote:
>
> > Hi Yana,
> >
> > Yes, I think it would be a good idea to retain the selected sources. I
had something like that in mind as well. I've just commited the changes in
the branch.
> >
> > Thanks,
> > Purvesh
> >
> > On Mon, Aug 16, 2010 at 5:19 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > Hi Purvesh,
> >
> > Thanks for adding all javadocs and fixing the alignment in the
configuration form!
> >
> > I spent some time testing the previews and I have some more remarks,
mainly on the configuration form. Here they are:
> >
> > - Lubomir noticed and shared with me off-list that the "Enable
Video/Image replacement" button has to be called "Enable Image/Video
replacement", as the title of the paragraph is also "Image/Video".
> >
> > - The enable checkbox is now acting more like "activate/desactivate
all" instead of enable/disable. In order to have a real enable/disable
checkbox, when unchecked all listed checkboxes should become disabled
(grey), but their state (checked/unchecked) should stay as it is. When
checked again, the listed checkboxes become enabled and the their state
don't change.
> >
> > Keep up the good work!
> > Yana
> >
> > On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:
> >
> > > Hi Yana,
> > >
> > >
> > > On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > > Hey Purvesh,
> > >
> > > It works really great!! I've tried all the available sources and
every link was replaced by the related image or video snapshot. Good work!
> > >
> > > I have a few very minor questions/comments.
> > >
> > > When looking to the configuration form (screenshot attached), the two
check boxes are indented and are not correctly aligned to the sources list
(they're may be placed in the center of the panel, instead to the left
area). Could you please try to align them on the left? Could you please also
add ":" after the "Image/Video" title?
> > >
> > >
> > > I've made these changes. I will commit them along with the javadocs.
> > >
> > > I was wondering about the preview border in the chat window (the blue
border appearing around each preview image), is it possible to change its
color to black for example?
> > >
> > >
> > > It seems swing doesn't support all the CSS properties. As listed
here:
http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html, "border" or "border-color" isn't rendered. So there isn't a way to control
the color it seems. We can however remove the border altogether by adding a
BORDER="0" attribute to the <IMG> tag.
> > >
> > >
> > > Thanks,
> > > Purvesh
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
> >
> >
>
>
>
<Previews.zip>---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#14

Hi Purvesh,

Thanks for the patch! It's applied, committed (revision 7672) and ack-ed on our team&contributors page.

I've done very minor modifications: adding a new icon for the chat configuration form and some javadocs and removing some unused listeners, fields and methods.

Otherwise I have two more comments and suggestions here:

- Do we really need to put the names of the sources in the localization file? They're names of services, so they're unlikely to be translated. If you agree, could you please move them as static variables in the source implementations?

- I saw you're using a sourceList in the ReplacementService and you're adding to it all source implementations in order to load them in the configuration form. You could actually use the bundle context to obtain the full source list in the configuration form and get rid of the public field this way.

Thanks again for the great work!

Cheers,
Yana

路路路

On Sep 6, 2010, at 6:32 PM, Purvesh Sahoo wrote:

Hi Yana,

I think we can do without the jars for now. I've been testing youtube oEmbed, and it seems they are returning the "thumbnail_url" parameter consistently, and they have made a post about it in the API blog. I think, thats's the next best thing to the official documentation.
The jars would be too much overhead. We could get rid of the meta jars and mail.jar (my bad!) if we still have to use the gdata libs.

I haven't used oEmbed for all the services. Some, which support oEmbed, don't return the thumbnail param at all. But they have it documented, so it's easy to figure out.

Here is the new patch without all the jars.

Thanks,
Purvesh

On Mon, Sep 6, 2010 at 5:32 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
Hi Purvesh,

Thanks for the patch!! It looks great on a first glance by the way.

(more inline)

On Sep 6, 2010, at 1:25 PM, Purvesh Sahoo wrote:

> Hi Yana,
>
> I've attached the patch. It presently has the gdata libs, which are required for accessing the Youtube API.

Does we really need all the 7 jars in order to continue using the gdata lib?

> I could get rid of the dependencies by using oembed, if it is an issue. The only downside is, oembed marks the "thumbnail_url" response parameter as optional. Youtube does return that value now, but we can't be sure about that since they had removed it in the past.

oEmbed sounds like an option for me. Did you use it for the other sources of video/images like daily motion, flickr, etc. ?

Another unrelated question. Where is the mail.jar used?

Cheers,
Yana

>
> Thanks,
> Purvesh
>
> On Fri, Sep 3, 2010 at 2:34 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> Hi Purvesh,
>
> Great work! Could you please merge your branch with the trunk and prepare a patch, so that we could integrate your work in the repository and everybody could enjoy the new previews:)
>
> Cheers,
> Yana
>
> On Aug 16, 2010, at 7:01 PM, Purvesh Sahoo wrote:
>
> > Hi Yana,
> >
> > Yes, I think it would be a good idea to retain the selected sources. I had something like that in mind as well. I've just commited the changes in the branch.
> >
> > Thanks,
> > Purvesh
> >
> > On Mon, Aug 16, 2010 at 5:19 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > Hi Purvesh,
> >
> > Thanks for adding all javadocs and fixing the alignment in the configuration form!
> >
> > I spent some time testing the previews and I have some more remarks, mainly on the configuration form. Here they are:
> >
> > - Lubomir noticed and shared with me off-list that the "Enable Video/Image replacement" button has to be called "Enable Image/Video replacement", as the title of the paragraph is also "Image/Video".
> >
> > - The enable checkbox is now acting more like "activate/desactivate all" instead of enable/disable. In order to have a real enable/disable checkbox, when unchecked all listed checkboxes should become disabled (grey), but their state (checked/unchecked) should stay as it is. When checked again, the listed checkboxes become enabled and the their state don't change.
> >
> > Keep up the good work!
> > Yana
> >
> > On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:
> >
> > > Hi Yana,
> > >
> > >
> > > On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > > Hey Purvesh,
> > >
> > > It works really great!! I've tried all the available sources and every link was replaced by the related image or video snapshot. Good work!
> > >
> > > I have a few very minor questions/comments.
> > >
> > > When looking to the configuration form (screenshot attached), the two check boxes are indented and are not correctly aligned to the sources list (they're may be placed in the center of the panel, instead to the left area). Could you please try to align them on the left? Could you please also add ":" after the "Image/Video" title?
> > >
> > >
> > > I've made these changes. I will commit them along with the javadocs.
> > >
> > > I was wondering about the preview border in the chat window (the blue border appearing around each preview image), is it possible to change its color to black for example?
> > >
> > >
> > > It seems swing doesn't support all the CSS properties. As listed here: http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html , "border" or "border-color" isn't rendered. So there isn't a way to control the color it seems. We can however remove the border altogether by adding a BORDER="0" attribute to the <IMG> tag.
> > >
> > >
> > > Thanks,
> > > Purvesh
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
> >
> >
>
>
> <Previews.zip>---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

<Previews.zip>---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#15

Hi Yana,

Hi Purvesh,

Thanks for the patch! It's applied, committed (revision 7672) and ack-ed on
our team&contributors page.

I've done very minor modifications: adding a new icon for the chat
configuration form and some javadocs and removing some unused listeners,
fields and methods.

Thanks!

Otherwise I have two more comments and suggestions here:

- Do we really need to put the names of the sources in the localization
file? They're names of services, so they're unlikely to be translated. If
you agree, could you please move them as static variables in the source
implementations?

I had put it in the localization file as it was the label of each source
being displayed in the config form. Some names, for example "Direct Image
link" or "Images" could be translated or maybe some other source name in the
future. But it's true that most of the entries are source names which are
unlikely to be be translated. I'll move them into the source implementation.

- I saw you're using a sourceList in the ReplacementService and you're
adding to it all source implementations in order to load them in the
configuration form. You could actually use the bundle context to obtain the
full source list in the configuration form and get rid of the public field
this way.

I'll make a patch for this. Thanks!

Thanks again for the great work!

Cheers,
Yana

Thanks,
Purvesh

路路路

On Tue, Sep 7, 2010 at 9:02 PM, Yana Stamcheva <yana@sip-communicator.org>wrote:

On Sep 6, 2010, at 6:32 PM, Purvesh Sahoo wrote:

> Hi Yana,
>
> I think we can do without the jars for now. I've been testing youtube
oEmbed, and it seems they are returning the "thumbnail_url" parameter
consistently, and they have made a post about it in the API blog. I think,
thats's the next best thing to the official documentation.
> The jars would be too much overhead. We could get rid of the meta jars
and mail.jar (my bad!) if we still have to use the gdata libs.
>
> I haven't used oEmbed for all the services. Some, which support oEmbed,
don't return the thumbnail param at all. But they have it documented, so
it's easy to figure out.
>
> Here is the new patch without all the jars.
>
> Thanks,
> Purvesh
>
> On Mon, Sep 6, 2010 at 5:32 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> Hi Purvesh,
>
> Thanks for the patch!! It looks great on a first glance by the way.
>
> (more inline)
>
> On Sep 6, 2010, at 1:25 PM, Purvesh Sahoo wrote:
>
> > Hi Yana,
> >
> > I've attached the patch. It presently has the gdata libs, which are
required for accessing the Youtube API.
>
> Does we really need all the 7 jars in order to continue using the gdata
lib?
>
> > I could get rid of the dependencies by using oembed, if it is an issue.
The only downside is, oembed marks the "thumbnail_url" response parameter as
optional. Youtube does return that value now, but we can't be sure about
that since they had removed it in the past.
>
> oEmbed sounds like an option for me. Did you use it for the other sources
of video/images like daily motion, flickr, etc. ?
>
> Another unrelated question. Where is the mail.jar used?
>
> Cheers,
> Yana
>
> >
> > Thanks,
> > Purvesh
> >
> > On Fri, Sep 3, 2010 at 2:34 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > Hi Purvesh,
> >
> > Great work! Could you please merge your branch with the trunk and
prepare a patch, so that we could integrate your work in the repository and
everybody could enjoy the new previews:)
> >
> > Cheers,
> > Yana
> >
> > On Aug 16, 2010, at 7:01 PM, Purvesh Sahoo wrote:
> >
> > > Hi Yana,
> > >
> > > Yes, I think it would be a good idea to retain the selected sources.
I had something like that in mind as well. I've just commited the changes in
the branch.
> > >
> > > Thanks,
> > > Purvesh
> > >
> > > On Mon, Aug 16, 2010 at 5:19 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > > Hi Purvesh,
> > >
> > > Thanks for adding all javadocs and fixing the alignment in the
configuration form!
> > >
> > > I spent some time testing the previews and I have some more remarks,
mainly on the configuration form. Here they are:
> > >
> > > - Lubomir noticed and shared with me off-list that the "Enable
Video/Image replacement" button has to be called "Enable Image/Video
replacement", as the title of the paragraph is also "Image/Video".
> > >
> > > - The enable checkbox is now acting more like "activate/desactivate
all" instead of enable/disable. In order to have a real enable/disable
checkbox, when unchecked all listed checkboxes should become disabled
(grey), but their state (checked/unchecked) should stay as it is. When
checked again, the listed checkboxes become enabled and the their state
don't change.
> > >
> > > Keep up the good work!
> > > Yana
> > >
> > > On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:
> > >
> > > > Hi Yana,
> > > >
> > > >
> > > > On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > > > Hey Purvesh,
> > > >
> > > > It works really great!! I've tried all the available sources and
every link was replaced by the related image or video snapshot. Good work!
> > > >
> > > > I have a few very minor questions/comments.
> > > >
> > > > When looking to the configuration form (screenshot attached), the
two check boxes are indented and are not correctly aligned to the sources
list (they're may be placed in the center of the panel, instead to the left
area). Could you please try to align them on the left? Could you please also
add ":" after the "Image/Video" title?
> > > >
> > > >
> > > > I've made these changes. I will commit them along with the
javadocs.
> > > >
> > > > I was wondering about the preview border in the chat window (the
blue border appearing around each preview image), is it possible to change
its color to black for example?
> > > >
> > > >
> > > > It seems swing doesn't support all the CSS properties. As listed
here:
http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html, "border" or "border-color" isn't rendered. So there isn't a way to control
the color it seems. We can however remove the border altogether by adding a
BORDER="0" attribute to the <IMG> tag.
> > > >
> > > >
> > > > Thanks,
> > > > Purvesh
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
> > > For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
> > >
> > >
> >
> >
> >
<Previews.zip>---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>
>
<Previews.zip>---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#16

Hi Purvesh,

Hi Yana,

Hi Purvesh,

Thanks for the patch! It's applied, committed (revision 7672) and ack-ed on our team&contributors page.

I've done very minor modifications: adding a new icon for the chat configuration form and some javadocs and removing some unused listeners, fields and methods.

Thanks!

Otherwise I have two more comments and suggestions here:

- Do we really need to put the names of the sources in the localization file? They're names of services, so they're unlikely to be translated. If you agree, could you please move them as static variables in the source implementations?

I had put it in the localization file as it was the label of each source being displayed in the config form. Some names, for example "Direct Image link" or "Images" could be translated or maybe some other source name in the future. But it's true that most of the entries are source names which are unlikely to be be translated. I'll move them into the source implementation.

Ok, I understand. You can add a new method in ReplacementService named getDisplayName(), and have a different implementation for each service. This way you could provide a localized string for where it has sense.

Otherwise, I was trying to remove the blue image border today and didn't succeeded. Unfortunately the border property didn't work. I was wondering how this border doesn't appear for smilies for example, as we're using the same <img> tag there, only we don't specify the height and the width. May be I'm missing something?

Cheers,
Yana

路路路

On Sep 8, 2010, at 12:59 PM, Purvesh Sahoo wrote:

On Tue, Sep 7, 2010 at 9:02 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:

- I saw you're using a sourceList in the ReplacementService and you're adding to it all source implementations in order to load them in the configuration form. You could actually use the bundle context to obtain the full source list in the configuration form and get rid of the public field this way.

I'll make a patch for this. Thanks!

Thanks again for the great work!

Cheers,
Yana

Thanks,
Purvesh

On Sep 6, 2010, at 6:32 PM, Purvesh Sahoo wrote:

> Hi Yana,
>
> I think we can do without the jars for now. I've been testing youtube oEmbed, and it seems they are returning the "thumbnail_url" parameter consistently, and they have made a post about it in the API blog. I think, thats's the next best thing to the official documentation.
> The jars would be too much overhead. We could get rid of the meta jars and mail.jar (my bad!) if we still have to use the gdata libs.
>
> I haven't used oEmbed for all the services. Some, which support oEmbed, don't return the thumbnail param at all. But they have it documented, so it's easy to figure out.
>
> Here is the new patch without all the jars.
>
> Thanks,
> Purvesh
>
> On Mon, Sep 6, 2010 at 5:32 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> Hi Purvesh,
>
> Thanks for the patch!! It looks great on a first glance by the way.
>
> (more inline)
>
> On Sep 6, 2010, at 1:25 PM, Purvesh Sahoo wrote:
>
> > Hi Yana,
> >
> > I've attached the patch. It presently has the gdata libs, which are required for accessing the Youtube API.
>
> Does we really need all the 7 jars in order to continue using the gdata lib?
>
> > I could get rid of the dependencies by using oembed, if it is an issue. The only downside is, oembed marks the "thumbnail_url" response parameter as optional. Youtube does return that value now, but we can't be sure about that since they had removed it in the past.
>
> oEmbed sounds like an option for me. Did you use it for the other sources of video/images like daily motion, flickr, etc. ?
>
> Another unrelated question. Where is the mail.jar used?
>
> Cheers,
> Yana
>
> >
> > Thanks,
> > Purvesh
> >
> > On Fri, Sep 3, 2010 at 2:34 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > Hi Purvesh,
> >
> > Great work! Could you please merge your branch with the trunk and prepare a patch, so that we could integrate your work in the repository and everybody could enjoy the new previews:)
> >
> > Cheers,
> > Yana
> >
> > On Aug 16, 2010, at 7:01 PM, Purvesh Sahoo wrote:
> >
> > > Hi Yana,
> > >
> > > Yes, I think it would be a good idea to retain the selected sources. I had something like that in mind as well. I've just commited the changes in the branch.
> > >
> > > Thanks,
> > > Purvesh
> > >
> > > On Mon, Aug 16, 2010 at 5:19 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > > Hi Purvesh,
> > >
> > > Thanks for adding all javadocs and fixing the alignment in the configuration form!
> > >
> > > I spent some time testing the previews and I have some more remarks, mainly on the configuration form. Here they are:
> > >
> > > - Lubomir noticed and shared with me off-list that the "Enable Video/Image replacement" button has to be called "Enable Image/Video replacement", as the title of the paragraph is also "Image/Video".
> > >
> > > - The enable checkbox is now acting more like "activate/desactivate all" instead of enable/disable. In order to have a real enable/disable checkbox, when unchecked all listed checkboxes should become disabled (grey), but their state (checked/unchecked) should stay as it is. When checked again, the listed checkboxes become enabled and the their state don't change.
> > >
> > > Keep up the good work!
> > > Yana
> > >
> > > On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:
> > >
> > > > Hi Yana,
> > > >
> > > >
> > > > On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > > > Hey Purvesh,
> > > >
> > > > It works really great!! I've tried all the available sources and every link was replaced by the related image or video snapshot. Good work!
> > > >
> > > > I have a few very minor questions/comments.
> > > >
> > > > When looking to the configuration form (screenshot attached), the two check boxes are indented and are not correctly aligned to the sources list (they're may be placed in the center of the panel, instead to the left area). Could you please try to align them on the left? Could you please also add ":" after the "Image/Video" title?
> > > >
> > > >
> > > > I've made these changes. I will commit them along with the javadocs.
> > > >
> > > > I was wondering about the preview border in the chat window (the blue border appearing around each preview image), is it possible to change its color to black for example?
> > > >
> > > >
> > > > It seems swing doesn't support all the CSS properties. As listed here: http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html , "border" or "border-color" isn't rendered. So there isn't a way to control the color it seems. We can however remove the border altogether by adding a BORDER="0" attribute to the <IMG> tag.
> > > >
> > > >
> > > > Thanks,
> > > > Purvesh
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > > For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
> > >
> > >
> >
> >
> > <Previews.zip>---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>
> <Previews.zip>---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#17

Hi Yana,

Hi Purvesh,

> Hi Yana,
>
> Hi Purvesh,
>
> Thanks for the patch! It's applied, committed (revision 7672) and ack-ed
on our team&contributors page.
>
> I've done very minor modifications: adding a new icon for the chat
configuration form and some javadocs and removing some unused listeners,
fields and methods.
>
>
> Thanks!
>
> Otherwise I have two more comments and suggestions here:
>
> - Do we really need to put the names of the sources in the localization
file? They're names of services, so they're unlikely to be translated. If
you agree, could you please move them as static variables in the source
implementations?
>
>
> I had put it in the localization file as it was the label of each source
being displayed in the config form. Some names, for example "Direct Image
link" or "Images" could be translated or maybe some other source name in the
future. But it's true that most of the entries are source names which are
unlikely to be be translated. I'll move them into the source implementation.

Ok, I understand. You can add a new method in ReplacementService named
getDisplayName(), and have a different implementation for each service. This
way you could provide a localized string for where it has sense.

I was thinking something along those lines as well. I've attached a patch
which removes the entries from the localization files.

Otherwise, I was trying to remove the blue image border today and didn't

succeeded. Unfortunately the border property didn't work. I was wondering
how this border doesn't appear for smilies for example, as we're using the
same <img> tag there, only we don't specify the height and the width. May be
I'm missing something?

Smiles don't have that blue border because those aren't links. The previews
we show are links, and actually, the blue border is due to the <A> tag and
not the <IMG>. Swing doesn't support all css properties :confused: We would
probably have to use some other renderer to support those css properties.

Cheers,
Yana

Thanks,
Purvesh

Previews.patch (43.3 KB)

路路路

On Wed, Sep 8, 2010 at 9:21 PM, Yana Stamcheva <yana@sip-communicator.org>wrote:

On Sep 8, 2010, at 12:59 PM, Purvesh Sahoo wrote:
> On Tue, Sep 7, 2010 at 9:02 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:

>

> - I saw you're using a sourceList in the ReplacementService and you're
adding to it all source implementations in order to load them in the
configuration form. You could actually use the bundle context to obtain the
full source list in the configuration form and get rid of the public field
this way.
>
>
> I'll make a patch for this. Thanks!
>
> Thanks again for the great work!
>
> Cheers,
> Yana
>
>
> Thanks,
> Purvesh
>
>
> On Sep 6, 2010, at 6:32 PM, Purvesh Sahoo wrote:
>
> > Hi Yana,
> >
> > I think we can do without the jars for now. I've been testing youtube
oEmbed, and it seems they are returning the "thumbnail_url" parameter
consistently, and they have made a post about it in the API blog. I think,
thats's the next best thing to the official documentation.
> > The jars would be too much overhead. We could get rid of the meta jars
and mail.jar (my bad!) if we still have to use the gdata libs.
> >
> > I haven't used oEmbed for all the services. Some, which support oEmbed,
don't return the thumbnail param at all. But they have it documented, so
it's easy to figure out.
> >
> > Here is the new patch without all the jars.
> >
> > Thanks,
> > Purvesh
> >
> > On Mon, Sep 6, 2010 at 5:32 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > Hi Purvesh,
> >
> > Thanks for the patch!! It looks great on a first glance by the way.
> >
> > (more inline)
> >
> > On Sep 6, 2010, at 1:25 PM, Purvesh Sahoo wrote:
> >
> > > Hi Yana,
> > >
> > > I've attached the patch. It presently has the gdata libs, which are
required for accessing the Youtube API.
> >
> > Does we really need all the 7 jars in order to continue using the gdata
lib?
> >
> > > I could get rid of the dependencies by using oembed, if it is an
issue. The only downside is, oembed marks the "thumbnail_url" response
parameter as optional. Youtube does return that value now, but we can't be
sure about that since they had removed it in the past.
> >
> > oEmbed sounds like an option for me. Did you use it for the other
sources of video/images like daily motion, flickr, etc. ?
> >
> > Another unrelated question. Where is the mail.jar used?
> >
> > Cheers,
> > Yana
> >
> > >
> > > Thanks,
> > > Purvesh
> > >
> > > On Fri, Sep 3, 2010 at 2:34 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > > Hi Purvesh,
> > >
> > > Great work! Could you please merge your branch with the trunk and
prepare a patch, so that we could integrate your work in the repository and
everybody could enjoy the new previews:)
> > >
> > > Cheers,
> > > Yana
> > >
> > > On Aug 16, 2010, at 7:01 PM, Purvesh Sahoo wrote:
> > >
> > > > Hi Yana,
> > > >
> > > > Yes, I think it would be a good idea to retain the selected
sources. I had something like that in mind as well. I've just commited the
changes in the branch.
> > > >
> > > > Thanks,
> > > > Purvesh
> > > >
> > > > On Mon, Aug 16, 2010 at 5:19 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > > > Hi Purvesh,
> > > >
> > > > Thanks for adding all javadocs and fixing the alignment in the
configuration form!
> > > >
> > > > I spent some time testing the previews and I have some more
remarks, mainly on the configuration form. Here they are:
> > > >
> > > > - Lubomir noticed and shared with me off-list that the "Enable
Video/Image replacement" button has to be called "Enable Image/Video
replacement", as the title of the paragraph is also "Image/Video".
> > > >
> > > > - The enable checkbox is now acting more like "activate/desactivate
all" instead of enable/disable. In order to have a real enable/disable
checkbox, when unchecked all listed checkboxes should become disabled
(grey), but their state (checked/unchecked) should stay as it is. When
checked again, the listed checkboxes become enabled and the their state
don't change.
> > > >
> > > > Keep up the good work!
> > > > Yana
> > > >
> > > > On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:
> > > >
> > > > > Hi Yana,
> > > > >
> > > > >
> > > > > On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > > > > Hey Purvesh,
> > > > >
> > > > > It works really great!! I've tried all the available sources and
every link was replaced by the related image or video snapshot. Good work!
> > > > >
> > > > > I have a few very minor questions/comments.
> > > > >
> > > > > When looking to the configuration form (screenshot attached), the
two check boxes are indented and are not correctly aligned to the sources
list (they're may be placed in the center of the panel, instead to the left
area). Could you please try to align them on the left? Could you please also
add ":" after the "Image/Video" title?
> > > > >
> > > > >
> > > > > I've made these changes. I will commit them along with the
javadocs.
> > > > >
> > > > > I was wondering about the preview border in the chat window (the
blue border appearing around each preview image), is it possible to change
its color to black for example?
> > > > >
> > > > >
> > > > > It seems swing doesn't support all the CSS properties. As listed
here:
http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html, "border" or "border-color" isn't rendered. So there isn't a way to control
the color it seems. We can however remove the border altogether by adding a
BORDER="0" attribute to the <IMG> tag.
> > > > >
> > > > >
> > > > > Thanks,
> > > > > Purvesh
> > > >
> > > >
> > > >
---------------------------------------------------------------------
> > > > To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
> > > > For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
> > > >
> > > >
> > >
> > >
> > >
<Previews.zip>---------------------------------------------------------------------
> > > To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
> > > For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
> >
> >
> >
<Previews.zip>---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#18

Hi Purvesh,

Hi Yana,

Hi Purvesh,

> Hi Yana,
>
> Hi Purvesh,
>
> Thanks for the patch! It's applied, committed (revision 7672) and ack-ed on our team&contributors page.
>
> I've done very minor modifications: adding a new icon for the chat configuration form and some javadocs and removing some unused listeners, fields and methods.
>
>
> Thanks!
>
> Otherwise I have two more comments and suggestions here:
>
> - Do we really need to put the names of the sources in the localization file? They're names of services, so they're unlikely to be translated. If you agree, could you please move them as static variables in the source implementations?
>
>
> I had put it in the localization file as it was the label of each source being displayed in the config form. Some names, for example "Direct Image link" or "Images" could be translated or maybe some other source name in the future. But it's true that most of the entries are source names which are unlikely to be be translated. I'll move them into the source implementation.

Ok, I understand. You can add a new method in ReplacementService named getDisplayName(), and have a different implementation for each service. This way you could provide a localized string for where it has sense.

I was thinking something along those lines as well. I've attached a patch which removes the entries from the localization files.

Thanks for fixing these! The patch is committed in revision 7677.

Otherwise, I was trying to remove the blue image border today and didn't succeeded. Unfortunately the border property didn't work. I was wondering how this border doesn't appear for smilies for example, as we're using the same <img> tag there, only we don't specify the height and the width. May be I'm missing something?

Smiles don't have that blue border because those aren't links. The previews we show are links, and actually, the blue border is due to the <A> tag and not the <IMG>. Swing doesn't support all css properties :confused: We would probably have to use some other renderer to support those css properties.

Right, of course. Ok, I'll try to figure out if there's a simpler way to remove it.

Otherwise, I was looking at getReplacedMessage() implementations and I noticed that we use the same pattern apply and img tag construction mechanisms in all of them. If we decide to change something in the img tag for example, we should go through all implementations in order to apply the change to all sources. In addition if we look at the Smilies implementation, we'd see that we also handle "startPlainTextTag", "endPlainTextTag" and ALT attribute there, which should be handled for all of the defined sources. I was thinking how we could optimize that.

One way to solve the problem is to modify the ReplacementService to have two methods:

String getReplacePattern()
String getReplacement(String sourceString)

Then on processReplacements() in the ChatConversationPanel we could apply the pattern of a replacement service and for each matching string call the getReplacement(String) method and construct our img tag accordingly. If we suppose that we'd have other replacements in the future, we could just define an ImageReplacementService extended the ReplacementService and adding a getImageReplacementPath(String) method to it, or something like that.

WDYT? Does the ReplacementService has yet another utility that doesn't fit this scheme?

Cheers,
Yana

路路路

On Sep 8, 2010, at 6:07 PM, Purvesh Sahoo wrote:

On Wed, Sep 8, 2010 at 9:21 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
On Sep 8, 2010, at 12:59 PM, Purvesh Sahoo wrote:
> On Tue, Sep 7, 2010 at 9:02 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:

Cheers,
Yana

Thanks,
Purvesh

>
> - I saw you're using a sourceList in the ReplacementService and you're adding to it all source implementations in order to load them in the configuration form. You could actually use the bundle context to obtain the full source list in the configuration form and get rid of the public field this way.
>
>
> I'll make a patch for this. Thanks!
>
> Thanks again for the great work!
>
> Cheers,
> Yana
>
>
> Thanks,
> Purvesh
>
>
> On Sep 6, 2010, at 6:32 PM, Purvesh Sahoo wrote:
>
> > Hi Yana,
> >
> > I think we can do without the jars for now. I've been testing youtube oEmbed, and it seems they are returning the "thumbnail_url" parameter consistently, and they have made a post about it in the API blog. I think, thats's the next best thing to the official documentation.
> > The jars would be too much overhead. We could get rid of the meta jars and mail.jar (my bad!) if we still have to use the gdata libs.
> >
> > I haven't used oEmbed for all the services. Some, which support oEmbed, don't return the thumbnail param at all. But they have it documented, so it's easy to figure out.
> >
> > Here is the new patch without all the jars.
> >
> > Thanks,
> > Purvesh
> >
> > On Mon, Sep 6, 2010 at 5:32 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > Hi Purvesh,
> >
> > Thanks for the patch!! It looks great on a first glance by the way.
> >
> > (more inline)
> >
> > On Sep 6, 2010, at 1:25 PM, Purvesh Sahoo wrote:
> >
> > > Hi Yana,
> > >
> > > I've attached the patch. It presently has the gdata libs, which are required for accessing the Youtube API.
> >
> > Does we really need all the 7 jars in order to continue using the gdata lib?
> >
> > > I could get rid of the dependencies by using oembed, if it is an issue. The only downside is, oembed marks the "thumbnail_url" response parameter as optional. Youtube does return that value now, but we can't be sure about that since they had removed it in the past.
> >
> > oEmbed sounds like an option for me. Did you use it for the other sources of video/images like daily motion, flickr, etc. ?
> >
> > Another unrelated question. Where is the mail.jar used?
> >
> > Cheers,
> > Yana
> >
> > >
> > > Thanks,
> > > Purvesh
> > >
> > > On Fri, Sep 3, 2010 at 2:34 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > > Hi Purvesh,
> > >
> > > Great work! Could you please merge your branch with the trunk and prepare a patch, so that we could integrate your work in the repository and everybody could enjoy the new previews:)
> > >
> > > Cheers,
> > > Yana
> > >
> > > On Aug 16, 2010, at 7:01 PM, Purvesh Sahoo wrote:
> > >
> > > > Hi Yana,
> > > >
> > > > Yes, I think it would be a good idea to retain the selected sources. I had something like that in mind as well. I've just commited the changes in the branch.
> > > >
> > > > Thanks,
> > > > Purvesh
> > > >
> > > > On Mon, Aug 16, 2010 at 5:19 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > > > Hi Purvesh,
> > > >
> > > > Thanks for adding all javadocs and fixing the alignment in the configuration form!
> > > >
> > > > I spent some time testing the previews and I have some more remarks, mainly on the configuration form. Here they are:
> > > >
> > > > - Lubomir noticed and shared with me off-list that the "Enable Video/Image replacement" button has to be called "Enable Image/Video replacement", as the title of the paragraph is also "Image/Video".
> > > >
> > > > - The enable checkbox is now acting more like "activate/desactivate all" instead of enable/disable. In order to have a real enable/disable checkbox, when unchecked all listed checkboxes should become disabled (grey), but their state (checked/unchecked) should stay as it is. When checked again, the listed checkboxes become enabled and the their state don't change.
> > > >
> > > > Keep up the good work!
> > > > Yana
> > > >
> > > > On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:
> > > >
> > > > > Hi Yana,
> > > > >
> > > > >
> > > > > On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > > > > Hey Purvesh,
> > > > >
> > > > > It works really great!! I've tried all the available sources and every link was replaced by the related image or video snapshot. Good work!
> > > > >
> > > > > I have a few very minor questions/comments.
> > > > >
> > > > > When looking to the configuration form (screenshot attached), the two check boxes are indented and are not correctly aligned to the sources list (they're may be placed in the center of the panel, instead to the left area). Could you please try to align them on the left? Could you please also add ":" after the "Image/Video" title?
> > > > >
> > > > >
> > > > > I've made these changes. I will commit them along with the javadocs.
> > > > >
> > > > > I was wondering about the preview border in the chat window (the blue border appearing around each preview image), is it possible to change its color to black for example?
> > > > >
> > > > >
> > > > > It seems swing doesn't support all the CSS properties. As listed here: http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html , "border" or "border-color" isn't rendered. So there isn't a way to control the color it seems. We can however remove the border altogether by adding a BORDER="0" attribute to the <IMG> tag.
> > > > >
> > > > >
> > > > > Thanks,
> > > > > Purvesh
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > > > For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
> > > >
> > > >
> > >
> > >
> > > <Previews.zip>---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > > For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
> >
> >
> > <Previews.zip>---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

<Previews.patch>---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#19

Hi Yana,

Thanks for fixing these! The patch is committed in revision 7677.

Thanks. I think there is a change missing in the ChatConversationPanel. The
keys are the display names and not the property label. Thus, the previews
aren't disabled even if we uncheck the source in the config form, because
entry.getKey() wouldn't match the property label. I've attached a patch
which should solve this.

>
> Otherwise, I was trying to remove the blue image border today and didn't
succeeded. Unfortunately the border property didn't work. I was wondering
how this border doesn't appear for smilies for example, as we're using the
same <img> tag there, only we don't specify the height and the width. May be
I'm missing something?
>
>
> Smiles don't have that blue border because those aren't links. The
previews we show are links, and actually, the blue border is due to the <A>
tag and not the <IMG>. Swing doesn't support all css properties :confused: We would
probably have to use some other renderer to support those css properties.

Right, of course. Ok, I'll try to figure out if there's a simpler way to
remove it.

Otherwise, I was looking at getReplacedMessage() implementations and I
noticed that we use the same pattern apply and img tag construction
mechanisms in all of them. If we decide to change something in the img tag
for example, we should go through all implementations in order to apply the
change to all sources. In addition if we look at the Smilies implementation,
we'd see that we also handle "startPlainTextTag", "endPlainTextTag" and ALT
attribute there, which should be handled for all of the defined sources. I
was thinking how we could optimize that.

The links already have the ALT attribute, as the link itself. Should we
change that?

One way to solve the problem is to modify the ReplacementService to have
two methods:

String getReplacePattern()
String getReplacement(String sourceString)

Then on processReplacements() in the ChatConversationPanel we could apply
the pattern of a replacement service and for each matching string call the
getReplacement(String) method and construct our img tag accordingly. If we
suppose that we'd have other replacements in the future, we could just
define an ImageReplacementService extended the ReplacementService and adding
a getImageReplacementPath(String) method to it, or something like that.

WDYT? Does the ReplacementService has yet another utility that doesn't fit
this scheme?

Yes, it seems correct. Initially I thought that each source might end up
having different img tag construction, but ended up using the same
mechanism. It would be better to move it to ChatConversationPanel and reduce
redundancy. I would have to tweak the patterns of some sources a bit to
avoid matching the links twice ( once in href="foo" and another, the actual
link itself); that way we can use the same pattern matching/tag construction
for all the sources.

Wouldn't the two methods ( getReplacementPattern() and
getReplacement(String) ) in ReplacementService suffice for new sources as
well?

Thanks,
Purvesh

ChatConversationPanel.patch (942 Bytes)

路路路

On Thu, Sep 9, 2010 at 7:57 PM, Yana Stamcheva <yana@sip-communicator.org>wrote:

Cheers,
Yana

>
> Cheers,
> Yana
>
>
> Thanks,
> Purvesh
>
>
> >
> > - I saw you're using a sourceList in the ReplacementService and you're
adding to it all source implementations in order to load them in the
configuration form. You could actually use the bundle context to obtain the
full source list in the configuration form and get rid of the public field
this way.
> >
> >
> > I'll make a patch for this. Thanks!
> >
> > Thanks again for the great work!
> >
> > Cheers,
> > Yana
> >
> >
> > Thanks,
> > Purvesh
> >
> >
> > On Sep 6, 2010, at 6:32 PM, Purvesh Sahoo wrote:
> >
> > > Hi Yana,
> > >
> > > I think we can do without the jars for now. I've been testing youtube
oEmbed, and it seems they are returning the "thumbnail_url" parameter
consistently, and they have made a post about it in the API blog. I think,
thats's the next best thing to the official documentation.
> > > The jars would be too much overhead. We could get rid of the meta
jars and mail.jar (my bad!) if we still have to use the gdata libs.
> > >
> > > I haven't used oEmbed for all the services. Some, which support
oEmbed, don't return the thumbnail param at all. But they have it
documented, so it's easy to figure out.
> > >
> > > Here is the new patch without all the jars.
> > >
> > > Thanks,
> > > Purvesh
> > >
> > > On Mon, Sep 6, 2010 at 5:32 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > > Hi Purvesh,
> > >
> > > Thanks for the patch!! It looks great on a first glance by the way.
> > >
> > > (more inline)
> > >
> > > On Sep 6, 2010, at 1:25 PM, Purvesh Sahoo wrote:
> > >
> > > > Hi Yana,
> > > >
> > > > I've attached the patch. It presently has the gdata libs, which are
required for accessing the Youtube API.
> > >
> > > Does we really need all the 7 jars in order to continue using the
gdata lib?
> > >
> > > > I could get rid of the dependencies by using oembed, if it is an
issue. The only downside is, oembed marks the "thumbnail_url" response
parameter as optional. Youtube does return that value now, but we can't be
sure about that since they had removed it in the past.
> > >
> > > oEmbed sounds like an option for me. Did you use it for the other
sources of video/images like daily motion, flickr, etc. ?
> > >
> > > Another unrelated question. Where is the mail.jar used?
> > >
> > > Cheers,
> > > Yana
> > >
> > > >
> > > > Thanks,
> > > > Purvesh
> > > >
> > > > On Fri, Sep 3, 2010 at 2:34 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > > > Hi Purvesh,
> > > >
> > > > Great work! Could you please merge your branch with the trunk and
prepare a patch, so that we could integrate your work in the repository and
everybody could enjoy the new previews:)
> > > >
> > > > Cheers,
> > > > Yana
> > > >
> > > > On Aug 16, 2010, at 7:01 PM, Purvesh Sahoo wrote:
> > > >
> > > > > Hi Yana,
> > > > >
> > > > > Yes, I think it would be a good idea to retain the selected
sources. I had something like that in mind as well. I've just commited the
changes in the branch.
> > > > >
> > > > > Thanks,
> > > > > Purvesh
> > > > >
> > > > > On Mon, Aug 16, 2010 at 5:19 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > > > > Hi Purvesh,
> > > > >
> > > > > Thanks for adding all javadocs and fixing the alignment in the
configuration form!
> > > > >
> > > > > I spent some time testing the previews and I have some more
remarks, mainly on the configuration form. Here they are:
> > > > >
> > > > > - Lubomir noticed and shared with me off-list that the "Enable
Video/Image replacement" button has to be called "Enable Image/Video
replacement", as the title of the paragraph is also "Image/Video".
> > > > >
> > > > > - The enable checkbox is now acting more like
"activate/desactivate all" instead of enable/disable. In order to have a
real enable/disable checkbox, when unchecked all listed checkboxes should
become disabled (grey), but their state (checked/unchecked) should stay as
it is. When checked again, the listed checkboxes become enabled and the
their state don't change.
> > > > >
> > > > > Keep up the good work!
> > > > > Yana
> > > > >
> > > > > On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:
> > > > >
> > > > > > Hi Yana,
> > > > > >
> > > > > >
> > > > > > On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva < > yana@sip-communicator.org> wrote:
> > > > > > Hey Purvesh,
> > > > > >
> > > > > > It works really great!! I've tried all the available sources
and every link was replaced by the related image or video snapshot. Good
work!
> > > > > >
> > > > > > I have a few very minor questions/comments.
> > > > > >
> > > > > > When looking to the configuration form (screenshot attached),
the two check boxes are indented and are not correctly aligned to the
sources list (they're may be placed in the center of the panel, instead to
the left area). Could you please try to align them on the left? Could you
please also add ":" after the "Image/Video" title?
> > > > > >
> > > > > >
> > > > > > I've made these changes. I will commit them along with the
javadocs.
> > > > > >
> > > > > > I was wondering about the preview border in the chat window
(the blue border appearing around each preview image), is it possible to
change its color to black for example?
> > > > > >
> > > > > >
> > > > > > It seems swing doesn't support all the CSS properties. As
listed here:
http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html, "border" or "border-color" isn't rendered. So there isn't a way to control
the color it seems. We can however remove the border altogether by adding a
BORDER="0" attribute to the <IMG> tag.
> > > > > >
> > > > > >
> > > > > > Thanks,
> > > > > > Purvesh
> > > > >
> > > > >
> > > > >
---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
> > > > > For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
> > > > >
> > > > >
> > > >
> > > >
> > > >
<Previews.zip>---------------------------------------------------------------------
> > > > To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
> > > > For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
> > > For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
> > >
> > >
> > >
<Previews.zip>---------------------------------------------------------------------
> > > To unsubscribe, e-mail:
dev-unsubscribe@sip-communicator.dev.java.net
> > > For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>
>
<Previews.patch>---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#20

Hi Purvesh,

Hi Yana,

Thanks for fixing these! The patch is committed in revision 7677.

Thanks. I think there is a change missing in the ChatConversationPanel. The keys are the display names and not the property label. Thus, the previews aren't disabled even if we uncheck the source in the config form, because entry.getKey() wouldn't match the property label. I've attached a patch which should solve this.

Thanks! Committed in revision 7682.

>
> Otherwise, I was trying to remove the blue image border today and didn't succeeded. Unfortunately the border property didn't work. I was wondering how this border doesn't appear for smilies for example, as we're using the same <img> tag there, only we don't specify the height and the width. May be I'm missing something?
>
>
> Smiles don't have that blue border because those aren't links. The previews we show are links, and actually, the blue border is due to the <A> tag and not the <IMG>. Swing doesn't support all css properties :confused: We would probably have to use some other renderer to support those css properties.

Right, of course. Ok, I'll try to figure out if there's a simpler way to remove it.

Otherwise, I was looking at getReplacedMessage() implementations and I noticed that we use the same pattern apply and img tag construction mechanisms in all of them. If we decide to change something in the img tag for example, we should go through all implementations in order to apply the change to all sources. In addition if we look at the Smilies implementation, we'd see that we also handle "startPlainTextTag", "endPlainTextTag" and ALT attribute there, which should be handled for all of the defined sources. I was thinking how we could optimize that.

The links already have the ALT attribute, as the link itself. Should we change that?

No. It's the ChatConversationPanel that would construct the img with all its attributes, so all the sources would have the same attributes (including the ALT).

One way to solve the problem is to modify the ReplacementService to have two methods:

String getReplacePattern()
String getReplacement(String sourceString)

Then on processReplacements() in the ChatConversationPanel we could apply the pattern of a replacement service and for each matching string call the getReplacement(String) method and construct our img tag accordingly. If we suppose that we'd have other replacements in the future, we could just define an ImageReplacementService extended the ReplacementService and adding a getImageReplacementPath(String) method to it, or something like that.

WDYT? Does the ReplacementService has yet another utility that doesn't fit this scheme?

Yes, it seems correct. Initially I thought that each source might end up having different img tag construction, but ended up using the same mechanism. It would be better to move it to ChatConversationPanel and reduce redundancy. I would have to tweak the patterns of some sources a bit to avoid matching the links twice ( once in href="foo" and another, the actual link itself); that way we can use the same pattern matching/tag construction for all the sources.

Didn't you have the same problem even when matching the patterns in the replacement implementations? Because the getReplacedMessage would always get the newly formatted message from the previous implementation.

Wouldn't the two methods ( getReplacementPattern() and getReplacement(String) ) in ReplacementService suffice for new sources as well?

I think so. For now we could go that way.

Cheers,
Yana

路路路

On Sep 9, 2010, at 10:20 PM, Purvesh Sahoo wrote:

On Thu, Sep 9, 2010 at 7:57 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:

Thanks,
Purvesh

Cheers,
Yana

>
> Cheers,
> Yana
>
>
> Thanks,
> Purvesh
>
>
> >
> > - I saw you're using a sourceList in the ReplacementService and you're adding to it all source implementations in order to load them in the configuration form. You could actually use the bundle context to obtain the full source list in the configuration form and get rid of the public field this way.
> >
> >
> > I'll make a patch for this. Thanks!
> >
> > Thanks again for the great work!
> >
> > Cheers,
> > Yana
> >
> >
> > Thanks,
> > Purvesh
> >
> >
> > On Sep 6, 2010, at 6:32 PM, Purvesh Sahoo wrote:
> >
> > > Hi Yana,
> > >
> > > I think we can do without the jars for now. I've been testing youtube oEmbed, and it seems they are returning the "thumbnail_url" parameter consistently, and they have made a post about it in the API blog. I think, thats's the next best thing to the official documentation.
> > > The jars would be too much overhead. We could get rid of the meta jars and mail.jar (my bad!) if we still have to use the gdata libs.
> > >
> > > I haven't used oEmbed for all the services. Some, which support oEmbed, don't return the thumbnail param at all. But they have it documented, so it's easy to figure out.
> > >
> > > Here is the new patch without all the jars.
> > >
> > > Thanks,
> > > Purvesh
> > >
> > > On Mon, Sep 6, 2010 at 5:32 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > > Hi Purvesh,
> > >
> > > Thanks for the patch!! It looks great on a first glance by the way.
> > >
> > > (more inline)
> > >
> > > On Sep 6, 2010, at 1:25 PM, Purvesh Sahoo wrote:
> > >
> > > > Hi Yana,
> > > >
> > > > I've attached the patch. It presently has the gdata libs, which are required for accessing the Youtube API.
> > >
> > > Does we really need all the 7 jars in order to continue using the gdata lib?
> > >
> > > > I could get rid of the dependencies by using oembed, if it is an issue. The only downside is, oembed marks the "thumbnail_url" response parameter as optional. Youtube does return that value now, but we can't be sure about that since they had removed it in the past.
> > >
> > > oEmbed sounds like an option for me. Did you use it for the other sources of video/images like daily motion, flickr, etc. ?
> > >
> > > Another unrelated question. Where is the mail.jar used?
> > >
> > > Cheers,
> > > Yana
> > >
> > > >
> > > > Thanks,
> > > > Purvesh
> > > >
> > > > On Fri, Sep 3, 2010 at 2:34 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > > > Hi Purvesh,
> > > >
> > > > Great work! Could you please merge your branch with the trunk and prepare a patch, so that we could integrate your work in the repository and everybody could enjoy the new previews:)
> > > >
> > > > Cheers,
> > > > Yana
> > > >
> > > > On Aug 16, 2010, at 7:01 PM, Purvesh Sahoo wrote:
> > > >
> > > > > Hi Yana,
> > > > >
> > > > > Yes, I think it would be a good idea to retain the selected sources. I had something like that in mind as well. I've just commited the changes in the branch.
> > > > >
> > > > > Thanks,
> > > > > Purvesh
> > > > >
> > > > > On Mon, Aug 16, 2010 at 5:19 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > > > > Hi Purvesh,
> > > > >
> > > > > Thanks for adding all javadocs and fixing the alignment in the configuration form!
> > > > >
> > > > > I spent some time testing the previews and I have some more remarks, mainly on the configuration form. Here they are:
> > > > >
> > > > > - Lubomir noticed and shared with me off-list that the "Enable Video/Image replacement" button has to be called "Enable Image/Video replacement", as the title of the paragraph is also "Image/Video".
> > > > >
> > > > > - The enable checkbox is now acting more like "activate/desactivate all" instead of enable/disable. In order to have a real enable/disable checkbox, when unchecked all listed checkboxes should become disabled (grey), but their state (checked/unchecked) should stay as it is. When checked again, the listed checkboxes become enabled and the their state don't change.
> > > > >
> > > > > Keep up the good work!
> > > > > Yana
> > > > >
> > > > > On Aug 12, 2010, at 8:31 AM, Purvesh Sahoo wrote:
> > > > >
> > > > > > Hi Yana,
> > > > > >
> > > > > >
> > > > > > On Wed, Aug 11, 2010 at 1:49 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:
> > > > > > Hey Purvesh,
> > > > > >
> > > > > > It works really great!! I've tried all the available sources and every link was replaced by the related image or video snapshot. Good work!
> > > > > >
> > > > > > I have a few very minor questions/comments.
> > > > > >
> > > > > > When looking to the configuration form (screenshot attached), the two check boxes are indented and are not correctly aligned to the sources list (they're may be placed in the center of the panel, instead to the left area). Could you please try to align them on the left? Could you please also add ":" after the "Image/Video" title?
> > > > > >
> > > > > >
> > > > > > I've made these changes. I will commit them along with the javadocs.
> > > > > >
> > > > > > I was wondering about the preview border in the chat window (the blue border appearing around each preview image), is it possible to change its color to black for example?
> > > > > >
> > > > > >
> > > > > > It seems swing doesn't support all the CSS properties. As listed here: http://download.oracle.com/javase/6/docs/api/index.html?javax/swing/text/html/CSS.html , "border" or "border-color" isn't rendered. So there isn't a way to control the color it seems. We can however remove the border altogether by adding a BORDER="0" attribute to the <IMG> tag.
> > > > > >
> > > > > >
> > > > > > Thanks,
> > > > > > Purvesh
> > > > >
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > > > > For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
> > > > >
> > > > >
> > > >
> > > >
> > > > <Previews.zip>---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > > > For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > > For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
> > >
> > >
> > > <Previews.zip>---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > > For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> > For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
>
> <Previews.patch>---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

<ChatConversationPanel.patch>---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net