[sip-comm-dev] Possible solution to dialpad not hiding (Issue 530)


#1

Hi all,

In regards to Issue 530 (https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=530), where the dialpad does not hide when the dialpad button is clicked, I have been testing a possible solution but I'm not comfortable that it's the best/'right' way to fix the problem so I'd like some feedback before I commit it.

Basically, there's two competing listeners (one for the button being pressed and one for the dialpad losing focus), so that when the dial button is pressed, one handler hides the dialpad and the other immediately brings it back. So I have added a new mouse listener to remove the dialpad focus listener whenever the mouse is over the dialpad button (and add it back when the mouse leaves). This allows the event listener on the dial button to do its job without interference.

Note: This effects the call dialog as well as the call panel on the main window.

Please see the attached patch file. Thanks!

-Alan

530_hide_dialpad_v6.patch (4.53 KB)


#2

Hey Alan,

Alan C Kelly wrote:

Hi all,

In regards to Issue 530
(https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=530),
where the dialpad does not hide when the dialpad button is clicked, I
have been testing a possible solution but I'm not comfortable that
it's the best/'right' way to fix the problem so I'd like some
feedback before I commit it.

Basically, there's two competing listeners (one for the button being
pressed and one for the dialpad losing focus), so that when the dial
button is pressed, one handler hides the dialpad and the other
immediately brings it back. So I have added a new mouse listener to
remove the dialpad focus listener whenever the mouse is over the
dialpad button (and add it back when the mouse leaves).

Sounds reasonable.

We were discussing the issue with Yana a few days ago. She suggested
that we should have a look at how the issue is being handled by JMenu-s,
since we'd like to be mimicking their behaviour. You might want to check
it out. It could help us handle corner cases like for example - popup
menu losing focus because of a tab hit, while the mouse is over the
dialpad button.

Anyways, what you suggest is still better than what we currently have so
feel free to commit. Nothing would prevent us from further improving it
whenever that's possible

Cheers
Emil

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi Emil,

We were discussing the issue with Yana a few days ago. She suggested
that we should have a look at how the issue is being handled by
JMenu-s,
since we'd like to be mimicking their behaviour. You might want to
checkit out. It could help us handle corner cases like for example
- popup
menu losing focus because of a tab hit, while the mouse is over the
dialpad button.

Oh, good point! I'll have to take a look at some point.

Anyways, what you suggest is still better than what we currently
have so
feel free to commit.

Done :slight_smile:

-Alan

···

----- Original Message -----

From: Emil Ivov <emcho@sip-communicator.org>

Date: Friday, January 30, 2009 5:37 pm
Subject: Re: [sip-comm-dev] Possible solution to dialpad not hiding (Issue 530)

Hey Alan,

Alan C Kelly wrote:
> Hi all,
>
> In regards to Issue 530
> (https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=530),
> where the dialpad does not hide when the dialpad button is
clicked, I
> have been testing a possible solution but I'm not comfortable that
> it's the best/'right' way to fix the problem so I'd like some
> feedback before I commit it.
>
> Basically, there's two competing listeners (one for the button being
> pressed and one for the dialpad losing focus), so that when the dial
> button is pressed, one handler hides the dialpad and the other
> immediately brings it back. So I have added a new mouse listener to
> remove the dialpad focus listener whenever the mouse is over the
> dialpad button (and add it back when the mouse leaves).

Sounds reasonable.

We were discussing the issue with Yana a few days ago. She suggested
that we should have a look at how the issue is being handled by
JMenu-s,
since we'd like to be mimicking their behaviour. You might want to
checkit out. It could help us handle corner cases like for example
- popup
menu losing focus because of a tab hit, while the mouse is over the
dialpad button.

Anyways, what you suggest is still better than what we currently
have so
feel free to commit. Nothing would prevent us from further
improving it
whenever that's possible

Cheers
Emil

-------------------------------------------------------------------
--
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net