[sip-comm-dev] [Patchs] New account list & Status update


#1

Hi,

Two littles patchs, the first one is for the account list in the new
account wizard. It extends the current table list model to sort the
list by the protocol's name.
If a preferred protocol is stored, it was placed in the first position
and in this version, the preferred protocol has a light blue
background.

The second patch is for the Automatic Status dialog. Modifications :
- Set a title to the dialog
- Allow the user to close the dialog with the cross in the title bar.
- Change setVisible(false) to dispose(), since the dialog is created
each time we click on the menu item.
- Update the design to fit with the other dialogs (for the two buttons
at the bottom of the dialog)
       -> no border and align to the right

@+

Damien

account-list.patch (4.11 KB)

status-update.patch (5.33 KB)


#2

Hey Damien,

Thanks for sending these over. I have just applied (and also committed
and ack-ed) your status-update patch.

While testing it however I was thinking that the content of the Dialog
would fit a lot better into the ConfigurationForm. Do you agree? If yes,
are you interested in moving it there?

As for the ordering of the accounts, the idea is nice but the thing is
that we are not using that form any longer. It has been replaced by a
new one that's smaller and hopefully user friendlier.

Cheers
Emil

Damien Roth написа:

···

Hi,

Two littles patchs, the first one is for the account list in the new
account wizard. It extends the current table list model to sort the
list by the protocol's name.
If a preferred protocol is stored, it was placed in the first position
and in this version, the preferred protocol has a light blue
background.

The second patch is for the Automatic Status dialog. Modifications :
- Set a title to the dialog
- Allow the user to close the dialog with the cross in the title bar.
- Change setVisible(false) to dispose(), since the dialog is created
each time we click on the menu item.
- Update the design to fit with the other dialogs (for the two buttons
at the bottom of the dialog)
       -> no border and align to the right

@+

Damien

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi,

I agree with your idea. I will move it in the ConfigurationForm.

I will send the patch during the next hours.

Bye

Damien

···

2008/7/15 Emil Ivov <emcho@sip-communicator.org>:

Hey Damien,

Thanks for sending these over. I have just applied (and also committed
and ack-ed) your status-update patch.

While testing it however I was thinking that the content of the Dialog
would fit a lot better into the ConfigurationForm. Do you agree? If yes,
are you interested in moving it there?

As for the ordering of the accounts, the idea is nice but the thing is
that we are not using that form any longer. It has been replaced by a
new one that's smaller and hopefully user friendlier.

Cheers
Emil

Damien Roth написа:

Hi,

Two littles patchs, the first one is for the account list in the new
account wizard. It extends the current table list model to sort the
list by the protocol's name.
If a preferred protocol is stored, it was placed in the first position
and in this version, the preferred protocol has a light blue
background.

The second patch is for the Automatic Status dialog. Modifications :
- Set a title to the dialog
- Allow the user to close the dialog with the cross in the title bar.
- Change setVisible(false) to dispose(), since the dialog is created
each time we click on the menu item.
- Update the design to fit with the other dialogs (for the two buttons
at the bottom of the dialog)
       -> no border and align to the right

@+

Damien

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

--
Damien ROTH
Programmeur n.m : Celui qui résout un problème que vous n'aviez pas,
d'une façon que vous ne comprenez pas.


#4

Hello,

Here is the new patch for the status update, moving the dialog in the
configuration window.

@+
Damien

···

2008/7/16 Damien Roth <damien.roth@gmail.com>:

Hi,

I agree with your idea. I will move it in the ConfigurationForm.

I will send the patch during the next hours.

Bye

Damien

2008/7/15 Emil Ivov <emcho@sip-communicator.org>:

Hey Damien,

Thanks for sending these over. I have just applied (and also committed
and ack-ed) your status-update patch.

While testing it however I was thinking that the content of the Dialog
would fit a lot better into the ConfigurationForm. Do you agree? If yes,
are you interested in moving it there?

As for the ordering of the accounts, the idea is nice but the thing is
that we are not using that form any longer. It has been replaced by a
new one that's smaller and hopefully user friendlier.

Cheers
Emil

Damien Roth написа:

Hi,

Two littles patchs, the first one is for the account list in the new
account wizard. It extends the current table list model to sort the
list by the protocol's name.
If a preferred protocol is stored, it was placed in the first position
and in this version, the preferred protocol has a light blue
background.

The second patch is for the Automatic Status dialog. Modifications :
- Set a title to the dialog
- Allow the user to close the dialog with the cross in the title bar.
- Change setVisible(false) to dispose(), since the dialog is created
each time we click on the menu item.
- Update the design to fit with the other dialogs (for the two buttons
at the bottom of the dialog)
       -> no border and align to the right

@+

Damien

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Did you forget to attach?

Emil

Damien Roth написа:

···

Hello,

Here is the new patch for the status update, moving the dialog in the
configuration window.

@+
Damien

2008/7/16 Damien Roth <damien.roth@gmail.com>:

Hi,

I agree with your idea. I will move it in the ConfigurationForm.

I will send the patch during the next hours.

Bye

Damien

2008/7/15 Emil Ivov <emcho@sip-communicator.org>:

Hey Damien,

Thanks for sending these over. I have just applied (and also committed
and ack-ed) your status-update patch.

While testing it however I was thinking that the content of the Dialog
would fit a lot better into the ConfigurationForm. Do you agree? If yes,
are you interested in moving it there?

As for the ordering of the accounts, the idea is nice but the thing is
that we are not using that form any longer. It has been replaced by a
new one that's smaller and hopefully user friendlier.

Cheers
Emil

Damien Roth написа:

Hi,

Two littles patchs, the first one is for the account list in the new
account wizard. It extends the current table list model to sort the
list by the protocol's name.
If a preferred protocol is stored, it was placed in the first position
and in this version, the preferred protocol has a light blue
background.

The second patch is for the Automatic Status dialog. Modifications :
- Set a title to the dialog
- Allow the user to close the dialog with the cross in the title bar.
- Change setVisible(false) to dispose(), since the dialog is created
each time we click on the menu item.
- Update the design to fit with the other dialogs (for the two buttons
at the bottom of the dialog)
       -> no border and align to the right

@+

Damien

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

I think so. This times it's attached

status-update.patch (16.6 KB)

···

2008/7/16 Emil Ivov <emcho@sip-communicator.org>:

Did you forget to attach?

Emil

Damien Roth написа:

Hello,

Here is the new patch for the status update, moving the dialog in the
configuration window.

@+
Damien


#7

Hello Damien,

I've applied and committed the patch but there's just one issue that we
need to address:

You seem to return a null array in your getIcon() method. As a result
when the configuration form loads the auto away tab has the same icon as
the accounts one and it then keeps changing as one clicks through the
other tabs adopting their icons.

I was thinking that you could use this one as a basis:

src/net/java/sip/communicator/impl/gui/resources/common/src/status
icons/na.svg

and then replace the genie head with a clock (unless you or anyone else
has a better idea).

Cheers
Emil

P.S. Oh and by the way, I have changed the form name to "Auto Away". I
was a bit confused when I first saw the "automatic status" label and
most of the time on this list we have referred to this feature as "Auto
away".

Damien Roth написа:

···

I think so. This times it's attached

2008/7/16 Emil Ivov <emcho@sip-communicator.org>:

Did you forget to attach?

Emil

Damien Roth написа:

Hello,

Here is the new patch for the status update, moving the dialog in the
configuration window.

@+
Damien

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Hi,

I found a cool icon this morning (attached).

@+

Damien

···

2008/7/16 Emil Ivov <emcho@sip-communicator.org>:

Hello Damien,

I've applied and committed the patch but there's just one issue that we
need to address:

You seem to return a null array in your getIcon() method. As a result
when the configuration form loads the auto away tab has the same icon as
the accounts one and it then keeps changing as one clicks through the
other tabs adopting their icons.

I was thinking that you could use this one as a basis:

src/net/java/sip/communicator/impl/gui/resources/common/src/status
icons/na.svg

and then replace the genie head with a clock (unless you or anyone else
has a better idea).

Cheers
Emil

P.S. Oh and by the way, I have changed the form name to "Auto Away". I
was a bit confused when I first saw the "automatic status" label and
most of the time on this list we have referred to this feature as "Auto
away".