[sip-comm-dev] Patched patch (was Re: [sip-comm-dev] New HTML news formatting


#1

Hi Vincent, hi all,
I have "reviewed" your patches, made some enhancements/bug fixes to
them and added some new overall features. Briefly, here's what I've
done:
* fixed RssFeedReader to work properly with Blogspot (ATOM?) feeds (up
till now, we had no description for the feed entry although the rss
feed contained it)
* fixes in ChatConversationPanel:
    1. for performance reasons I have replaced numerous calls to
String += String to StringBuffer.append() followed at the end by
StringBuffer.toString(). Did it only in processSmileys(), in
processBrTag() and in processImgTag(). (String-s are immutable classes
so any operation on a String that modifies it demands a new String to
be allocated. StringBuffers use mutable character sequences, thus
being a lot faster and memory efficient)
    2. fixed a bug in processSmileys() - once again it did not care
about the content type, thus messing html formatted strings. Fixed
now.
* modified OperationSetBasicInstantMessagingRssImpl so that, when
manually updating a feed, the text that appears in the window is
«Refreshing feed» (I for one, did not like to appear stuff like
«asldjfh» in my feeds history just because I was lazy enogh not to
type a sensible string to trigger the feed update :smiley: )

Hope everything is ok.

Best,
Mihai

PS: I like how images are handled, although smileys in the title
aren't _that_ nicely handled (they have that thick blue outline :smiley: )

NewsFormattingPatch.tar.gz (3.65 KB)

···

On 7/17/07, Vincent Lucas <lucas@clarinet.u-strasbg.fr> wrote:

Hi Mihai, hi devs,

Let's test these patch (see attachments) that are displaying RSS feeds
with abstract and images.
Just note that these patches are correcting the self-closing of <br> and
<img> tags.
With these features, the
http://ddj.com/rss/all.xml;jsessionid=OEVRSWPBVGBOQQSNDLRSKHSCJUNN2JVN
feeds works but still complain (trace log, but does not crash) with
unreadable images.

Just tell me if you still prefer to delete every images tags.

Cheers,
Vincent

Mihai Balan wrote:
> Hi and sorry for the late answer (stormy weather :frowning: ),
> IMO the best would be to keep things simple. Accepting a minimum of
> formatting code and stripping the rest of the tags while keeping the
> results readable would be optimal, as there is a very wide range of
> content - valid or not valid - that can be included in RSS feeds.
> Let's not forget that usually full-fledged RSS Readers, be they online
> or offline, use a very basic rendering engine for displaying the
> contents *in the feed* and usually display the page referred in the
> feed in a platform dependent HTML rendering component.
> I'll dig a little further on this matter and come up with a solution
> as soon as I get to fix my problems with the Internet connection,
> caused by the storm of the last few days :frowning:
>
> Have a nice weekend,
> Mihai
>
> On 7/11/07, Emil Ivov <emcho@emcho.com> wrote:
>> What's nasty about this is the fact, that there's no way for us to know
>> whether it'll fail before it actually does, and at that point it's
>> already in the history, so chances are we'll be getting failures every
>> time we try to open the corresponding message window.
>>
>> I wonder if there's a way to detect and fix the problem in the message
>> window itself.
>>
>> In case there isn't.
>>
>> Well, it seems to me that DDJ's empty images don't seem to have anything
>> to do with information delivery and are more likely to be there to allow
>> for statistics. More generally, I don't think I've ever seen RSS flows
>> that absolutely require showing images in order for the information they
>> deliver to be meaningful so wouldn't it be best if we simply tried to
>> skip all images in RSS abstracts? (Possibly, replacing them with the alt
>> attribute value when it's available)
>>
>> Emil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#2

Hi Mihai and all,

This is patch is a really good one :slight_smile:
For keeping SC compatible with java 1.4, I have just replaced a "newsAbstract.toString().isEmpty()" by a "newsAbstract.toString().length()".

Now, it's in the hands of the commiters,
Vincent

Mihai Balan wrote:

NewsFormattingPatch.tar.gz (3.65 KB)

···

Hi Vincent, hi all,
I have "reviewed" your patches, made some enhancements/bug fixes to
them and added some new overall features. Briefly, here's what I've
done:
* fixed RssFeedReader to work properly with Blogspot (ATOM?) feeds (up
till now, we had no description for the feed entry although the rss
feed contained it)
* fixes in ChatConversationPanel:
   1. for performance reasons I have replaced numerous calls to
String += String to StringBuffer.append() followed at the end by
StringBuffer.toString(). Did it only in processSmileys(), in
processBrTag() and in processImgTag(). (String-s are immutable classes
so any operation on a String that modifies it demands a new String to
be allocated. StringBuffers use mutable character sequences, thus
being a lot faster and memory efficient)
   2. fixed a bug in processSmileys() - once again it did not care
about the content type, thus messing html formatted strings. Fixed
now.
* modified OperationSetBasicInstantMessagingRssImpl so that, when
manually updating a feed, the text that appears in the window is
«Refreshing feed» (I for one, did not like to appear stuff like
«asldjfh» in my feeds history just because I was lazy enogh not to
type a sensible string to trigger the feed update :smiley: )

Hope everything is ok.

Best,
Mihai

PS: I like how images are handled, although smileys in the title
aren't _that_ nicely handled (they have that thick blue outline :smiley: )
On 7/17/07, Vincent Lucas <lucas@clarinet.u-strasbg.fr> wrote:

Hi Mihai, hi devs,

Let's test these patch (see attachments) that are displaying RSS feeds
with abstract and images.
Just note that these patches are correcting the self-closing of <br> and
<img> tags.
With these features, the
http://ddj.com/rss/all.xml;jsessionid=OEVRSWPBVGBOQQSNDLRSKHSCJUNN2JVN
feeds works but still complain (trace log, but does not crash) with
unreadable images.

Just tell me if you still prefer to delete every images tags.

Cheers,
Vincent

Mihai Balan wrote:
> Hi and sorry for the late answer (stormy weather :frowning: ),
> IMO the best would be to keep things simple. Accepting a minimum of
> formatting code and stripping the rest of the tags while keeping the
> results readable would be optimal, as there is a very wide range of
> content - valid or not valid - that can be included in RSS feeds.
> Let's not forget that usually full-fledged RSS Readers, be they online
> or offline, use a very basic rendering engine for displaying the
> contents *in the feed* and usually display the page referred in the
> feed in a platform dependent HTML rendering component.
> I'll dig a little further on this matter and come up with a solution
> as soon as I get to fix my problems with the Internet connection,
> caused by the storm of the last few days :frowning:
>
> Have a nice weekend,
> Mihai
>
> On 7/11/07, Emil Ivov <emcho@emcho.com> wrote:
>> What's nasty about this is the fact, that there's no way for us to know
>> whether it'll fail before it actually does, and at that point it's
>> already in the history, so chances are we'll be getting failures every
>> time we try to open the corresponding message window.
>>
>> I wonder if there's a way to detect and fix the problem in the message
>> window itself.
>>
>> In case there isn't.
>>
>> Well, it seems to me that DDJ's empty images don't seem to have anything
>> to do with information delivery and are more likely to be there to allow
>> for statistics. More generally, I don't think I've ever seen RSS flows
>> that absolutely require showing images in order for the information they
>> deliver to be meaningful so wouldn't it be best if we simply tried to
>> skip all images in RSS abstracts? (Possibly, replacing them with the alt
>> attribute value when it's available)
>>
>> Emil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hey Mihai,

I just came accross this mail. It seems to me that the patches that it
contains have already been applied but I just wanted to confirm this
with you so let me know if this is not the case.

Thanks
Emil

Mihai Balan wrote:

···

Hi Vincent, hi all,
I have "reviewed" your patches, made some enhancements/bug fixes to
them and added some new overall features. Briefly, here's what I've
done:
* fixed RssFeedReader to work properly with Blogspot (ATOM?) feeds (up
till now, we had no description for the feed entry although the rss
feed contained it)
* fixes in ChatConversationPanel:
    1. for performance reasons I have replaced numerous calls to
String += String to StringBuffer.append() followed at the end by
StringBuffer.toString(). Did it only in processSmileys(), in
processBrTag() and in processImgTag(). (String-s are immutable classes
so any operation on a String that modifies it demands a new String to
be allocated. StringBuffers use mutable character sequences, thus
being a lot faster and memory efficient)
    2. fixed a bug in processSmileys() - once again it did not care
about the content type, thus messing html formatted strings. Fixed
now.
* modified OperationSetBasicInstantMessagingRssImpl so that, when
manually updating a feed, the text that appears in the window is
�Refreshing feed� (I for one, did not like to appear stuff like
�asldjfh� in my feeds history just because I was lazy enogh not to
type a sensible string to trigger the feed update :smiley: )

Hope everything is ok.

Best,
Mihai

PS: I like how images are handled, although smileys in the title
aren't _that_ nicely handled (they have that thick blue outline :smiley: )
On 7/17/07, Vincent Lucas <lucas@clarinet.u-strasbg.fr> wrote:

Hi Mihai, hi devs,

Let's test these patch (see attachments) that are displaying RSS feeds
with abstract and images.
Just note that these patches are correcting the self-closing of <br> and
<img> tags.
With these features, the
http://ddj.com/rss/all.xml;jsessionid=OEVRSWPBVGBOQQSNDLRSKHSCJUNN2JVN
feeds works but still complain (trace log, but does not crash) with
unreadable images.

Just tell me if you still prefer to delete every images tags.

Cheers,
Vincent

Mihai Balan wrote:

Hi and sorry for the late answer (stormy weather :frowning: ),
IMO the best would be to keep things simple. Accepting a minimum of
formatting code and stripping the rest of the tags while keeping the
results readable would be optimal, as there is a very wide range of
content - valid or not valid - that can be included in RSS feeds.
Let's not forget that usually full-fledged RSS Readers, be they online
or offline, use a very basic rendering engine for displaying the
contents *in the feed* and usually display the page referred in the
feed in a platform dependent HTML rendering component.
I'll dig a little further on this matter and come up with a solution
as soon as I get to fix my problems with the Internet connection,
caused by the storm of the last few days :frowning:

Have a nice weekend,
Mihai

On 7/11/07, Emil Ivov <emcho@emcho.com> wrote:

What's nasty about this is the fact, that there's no way for us to know
whether it'll fail before it actually does, and at that point it's
already in the history, so chances are we'll be getting failures every
time we try to open the corresponding message window.

I wonder if there's a way to detect and fix the problem in the message
window itself.

In case there isn't.

Well, it seems to me that DDJ's empty images don't seem to have anything
to do with information delivery and are more likely to be there to allow
for statistics. More generally, I don't think I've ever seen RSS flows
that absolutely require showing images in order for the information they
deliver to be meaningful so wouldn't it be best if we simply tried to
skip all images in RSS abstracts? (Possibly, replacing them with the alt
attribute value when it's available)

Emil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi Vincent, Mihai,

Very good work! I really like the new look of RSS:)

I have just applied and committed your patch.

I've applied your code as it is except of some really minor changes, including moving some brackets on the next line and adding "..." in the end of the "Refreshing feed" message, trying to indicate that this is a process. Hope you agree:)

Yana

Vincent Lucas wrote:

···

Hi Mihai and all,

This is patch is a really good one :slight_smile:
For keeping SC compatible with java 1.4, I have just replaced a "newsAbstract.toString().isEmpty()" by a "newsAbstract.toString().length()".

Now, it's in the hands of the commiters,
Vincent

Mihai Balan wrote:

Hi Vincent, hi all,
I have "reviewed" your patches, made some enhancements/bug fixes to
them and added some new overall features. Briefly, here's what I've
done:
* fixed RssFeedReader to work properly with Blogspot (ATOM?) feeds (up
till now, we had no description for the feed entry although the rss
feed contained it)
* fixes in ChatConversationPanel:
   1. for performance reasons I have replaced numerous calls to
String += String to StringBuffer.append() followed at the end by
StringBuffer.toString(). Did it only in processSmileys(), in
processBrTag() and in processImgTag(). (String-s are immutable classes
so any operation on a String that modifies it demands a new String to
be allocated. StringBuffers use mutable character sequences, thus
being a lot faster and memory efficient)
   2. fixed a bug in processSmileys() - once again it did not care
about the content type, thus messing html formatted strings. Fixed
now.
* modified OperationSetBasicInstantMessagingRssImpl so that, when
manually updating a feed, the text that appears in the window is
«Refreshing feed» (I for one, did not like to appear stuff like
«asldjfh» in my feeds history just because I was lazy enogh not to
type a sensible string to trigger the feed update :smiley: )

Hope everything is ok.

Best,
Mihai

PS: I like how images are handled, although smileys in the title
aren't _that_ nicely handled (they have that thick blue outline :smiley: )
On 7/17/07, Vincent Lucas <lucas@clarinet.u-strasbg.fr> wrote:

Hi Mihai, hi devs,

Let's test these patch (see attachments) that are displaying RSS feeds
with abstract and images.
Just note that these patches are correcting the self-closing of <br> and
<img> tags.
With these features, the
http://ddj.com/rss/all.xml;jsessionid=OEVRSWPBVGBOQQSNDLRSKHSCJUNN2JVN
feeds works but still complain (trace log, but does not crash) with
unreadable images.

Just tell me if you still prefer to delete every images tags.

Cheers,
Vincent

Mihai Balan wrote:
> Hi and sorry for the late answer (stormy weather :frowning: ),
> IMO the best would be to keep things simple. Accepting a minimum of
> formatting code and stripping the rest of the tags while keeping the
> results readable would be optimal, as there is a very wide range of
> content - valid or not valid - that can be included in RSS feeds.
> Let's not forget that usually full-fledged RSS Readers, be they online
> or offline, use a very basic rendering engine for displaying the
> contents *in the feed* and usually display the page referred in the
> feed in a platform dependent HTML rendering component.
> I'll dig a little further on this matter and come up with a solution
> as soon as I get to fix my problems with the Internet connection,
> caused by the storm of the last few days :frowning:
>
> Have a nice weekend,
> Mihai
>
> On 7/11/07, Emil Ivov <emcho@emcho.com> wrote:
>> What's nasty about this is the fact, that there's no way for us to know
>> whether it'll fail before it actually does, and at that point it's
>> already in the history, so chances are we'll be getting failures every
>> time we try to open the corresponding message window.
>>
>> I wonder if there's a way to detect and fix the problem in the message
>> window itself.
>>
>> In case there isn't.
>>
>> Well, it seems to me that DDJ's empty images don't seem to have anything
>> to do with information delivery and are more likely to be there to allow
>> for statistics. More generally, I don't think I've ever seen RSS flows
>> that absolutely require showing images in order for the information they
>> deliver to be meaningful so wouldn't it be best if we simply tried to
>> skip all images in RSS abstracts? (Possibly, replacing them with the alt
>> attribute value when it's available)
>>
>> Emil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hey guys,

I really love the way RSS is rendering flows now (attached is a screen
shot of what I get for google news). Great work! Guess the only real
issue that remains now is that of the unique item identifiers.

Keep it up guys!

Emil

Yana Stamcheva wrote:

···

Hi Vincent, Mihai,

Very good work! I really like the new look of RSS:)

I have just applied and committed your patch.

I've applied your code as it is except of some really minor changes,
including moving some brackets on the next line and adding "..." in the
end of the "Refreshing feed" message, trying to indicate that this is a
process. Hope you agree:)

Yana

Vincent Lucas wrote:

Hi Mihai and all,

This is patch is a really good one :slight_smile:
For keeping SC compatible with java 1.4, I have just replaced a
"newsAbstract.toString().isEmpty()" by a
"newsAbstract.toString().length()".

Now, it's in the hands of the commiters,
Vincent

Mihai Balan wrote:

Hi Vincent, hi all,
I have "reviewed" your patches, made some enhancements/bug fixes to
them and added some new overall features. Briefly, here's what I've
done:
* fixed RssFeedReader to work properly with Blogspot (ATOM?) feeds (up
till now, we had no description for the feed entry although the rss
feed contained it)
* fixes in ChatConversationPanel:
   1. for performance reasons I have replaced numerous calls to
String += String to StringBuffer.append() followed at the end by
StringBuffer.toString(). Did it only in processSmileys(), in
processBrTag() and in processImgTag(). (String-s are immutable classes
so any operation on a String that modifies it demands a new String to
be allocated. StringBuffers use mutable character sequences, thus
being a lot faster and memory efficient)
   2. fixed a bug in processSmileys() - once again it did not care
about the content type, thus messing html formatted strings. Fixed
now.
* modified OperationSetBasicInstantMessagingRssImpl so that, when
manually updating a feed, the text that appears in the window is
«Refreshing feed» (I for one, did not like to appear stuff like
«asldjfh» in my feeds history just because I was lazy enogh not to
type a sensible string to trigger the feed update :smiley: )

Hope everything is ok.

Best,
Mihai

PS: I like how images are handled, although smileys in the title
aren't _that_ nicely handled (they have that thick blue outline :smiley: )
On 7/17/07, Vincent Lucas <lucas@clarinet.u-strasbg.fr> wrote:

Hi Mihai, hi devs,

Let's test these patch (see attachments) that are displaying RSS feeds
with abstract and images.
Just note that these patches are correcting the self-closing of <br> and
<img> tags.
With these features, the
http://ddj.com/rss/all.xml;jsessionid=OEVRSWPBVGBOQQSNDLRSKHSCJUNN2JVN
feeds works but still complain (trace log, but does not crash) with
unreadable images.

Just tell me if you still prefer to delete every images tags.

Cheers,
Vincent

Mihai Balan wrote:

Hi and sorry for the late answer (stormy weather :frowning: ),
IMO the best would be to keep things simple. Accepting a minimum of
formatting code and stripping the rest of the tags while keeping the
results readable would be optimal, as there is a very wide range of
content - valid or not valid - that can be included in RSS feeds.
Let's not forget that usually full-fledged RSS Readers, be they online
or offline, use a very basic rendering engine for displaying the
contents *in the feed* and usually display the page referred in the
feed in a platform dependent HTML rendering component.
I'll dig a little further on this matter and come up with a solution
as soon as I get to fix my problems with the Internet connection,
caused by the storm of the last few days :frowning:

Have a nice weekend,
Mihai

On 7/11/07, Emil Ivov <emcho@emcho.com> wrote:

What's nasty about this is the fact, that there's no way for us to

know

whether it'll fail before it actually does, and at that point it's
already in the history, so chances are we'll be getting failures

every

time we try to open the corresponding message window.

I wonder if there's a way to detect and fix the problem in the

message

window itself.

In case there isn't.

Well, it seems to me that DDJ's empty images don't seem to have

anything

to do with information delivery and are more likely to be there to

allow

for statistics. More generally, I don't think I've ever seen RSS

flows

that absolutely require showing images in order for the

information they

deliver to be meaningful so wouldn't it be best if we simply tried to
skip all images in RSS abstracts? (Possibly, replacing them with

the alt

attribute value when it's available)

Emil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:

dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hi,

Hey guys,

I really love the way RSS is rendering flows now (attached is a screen
shot of what I get for google news). Great work!

I'm really glad you like it :slight_smile:

Guess the only real issue that remains now is that of the unique item identifiers.

I'll fic that problem (and hopefully the RSS-through-proxy issue too),
after I come back to town, as I have to leave for a few (~4 or 5) days
:wink:

Keep it up guys!

Emil

Cheers,
Mihai

···

On 7/20/07, Emil Ivov <emcho@emcho.com> wrote:

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Just anther screen shot from "PhD Cmoics" RSS feed : http://www.phdcomics.com/gradfeed_justcomics.php

Vincent

Mihai Balan wrote:

···

Hi,
On 7/20/07, Emil Ivov <emcho@emcho.com> wrote:

Hey guys,

I really love the way RSS is rendering flows now (attached is a screen
shot of what I get for google news). Great work!

I'm really glad you like it :slight_smile:

Guess the only real issue that remains now is that of the unique item identifiers.

I'll fic that problem (and hopefully the RSS-through-proxy issue too),
after I come back to town, as I have to leave for a few (~4 or 5) days
:wink:

Keep it up guys!

Emil

Cheers,
Mihai

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net