[sip-comm-dev] [PATCH] SIP SDP mappings and attributes


#1

I wrote a patch to SDP creation.

All SDP encodings above 96 should be mapped In sdp packet (with lover
numbers may but it is not obligatory).

For telephone-event encoding you need to add fmtp - for supported
events.

Regards

Przemek

NextiraOne Polska Sp. z o.o.
z siedziba w Warszawie
ul. Chmielna 85/87
00-805 Warszawa
Sad Rejonowy dla m.st. Warszawy,
XII Wydzial Gospodarczy KRS 0000063801
Prezes Zarzadu: Marek Kobielski,
Czlonkowie Zarzadu: Rafi Kouyoumdjian, Jean-Jacques Francois Berthelon
Kapital Zakladowy: 11 192 000 PLN
NIP: 952-18-51-834

Wiadomosc ta jest przeznaczona wylacznie dla ich odbiorcow i jest poufna. Jesli nie jestescie Panstwo adresatami tej wiadomosci, prosimy o jej usuniecie. Kazde przegladanie, rozpowszechnianie oraz kazde inne uzycie, takze uzycie w zaufany sposob przez osoby inne niz zamierzony odbiorca, jest zakazane.

This e-mail message is intended solely for the addressees and is confidential. If you receive this message in error, please delete it. Any review, dissemination or other use of, or taking of any action in reliance upon, this message by persons or entities other than the intended recipient is prohibited.

SDP-attributes-and-mappings.patch (6.57 KB)


#2

Hey Dudek,

Thanks for sending your patch over! A few quick requests before we
integrate it:

1. Can you please make sure you are using our code. While skimming
through SDPMapper I saw conflicts with the following rules:
  * expand all tabs to spaces
  * opening braces are on a line of their own
  * all methods have javadocs with all @return and @param arguments filled in
  * there should be no chars after column 80
  * use package (*) instead of class imports
  * use a space after each comma when enumerating method arguments
2. Any reason why mappEncodingsToSDP has two 'p's?
3. Is there a reason why checkForTelephoneEvents() uses compareTo()
rather than equals()?
4. You currently add two mappings for telephone events.
5. I find usage of plural in the "encodings" param name a bit confusing
since it pertains to a single encoding string. Can you please remove the
s (methods mappEncodingsToSDP, checkForTelephoneEvent)
6. I find the following two method names a bit unclear:
mappEncodingsToSDP and checkForTelephoneEvent

If you want we can discuss these offline (e.g. I can give you a phone
call if you send me land line number).

Thanks again for accepting to take care of the SDP issue!

Cheers
Emil

Dudek Przemyslaw написа:

···

I wrote a patch to SDP creation.

All SDP encodings above 96 should be mapped In sdp packet (with lover
numbers may but it is not obligatory).

For telephone-event encoding you need to add fmtp – for supported events.

Regards

Przemek

NextiraOne Polska Sp. z o.o.
z siedziba w Warszawie
ul. Chmielna 85/87
00-805 Warszawa
Sad Rejonowy dla m.st. Warszawy,
XII Wydzial Gospodarczy KRS 0000063801
Prezes Zarzadu: Marek Kobielski,
Czlonkowie Zarzadu: Rafi Kouyoumdjian, Jean-Jacques Francois Berthelon
Kapital Zakladowy: 11 192 000 PLN
NIP: 952-18-51-834

Wiadomosc ta jest przeznaczona wylacznie dla ich odbiorcow i jest
poufna. Jesli nie jestescie Panstwo adresatami tej wiadomosci, prosimy o
jej usuniecie. Kazde przegladanie, rozpowszechnianie oraz kazde inne
uzycie, takze uzycie w zaufany sposob przez osoby inne niz zamierzony
odbiorca, jest zakazane.

This e-mail message is intended solely for the addressees and is
confidential. If you receive this message in error, please delete it.
Any review, dissemination or other use of, or taking of any action in
reliance upon, this message by persons or entities other than the
intended recipient is prohibited.

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net