[sip-comm-dev] [Patch] only drag contact with primary mouse button


#1

Hi,

This patch makes sure contact dragging will only work with the primary
(left, most of the time) mouse button pressed. Without the patch, SIP
Communicator is unusable with my trackpoint (the middle button is the
scroll button). Each time I scrolled the contact list, I got a lots of
"do you want to move this contact" dialogs.

The patch applies on svn revision 4356.

Cheers.

contact_list_trackpoint.patch (1.15 KB)

···

--
Sébastien Mazy


#2

Hi,

contact_list_trackpoint-20081022.patch (1.08 KB)

···

On Wed, Aug 27, 2008 at 5:51 PM, Sébastien Mazy <sebastien.mazy@insa-lyon.fr> wrote:

This patch makes sure contact dragging will only work with the primary
(left, most of the time) mouse button pressed. Without the patch, SIP
Communicator is unusable with my trackpoint (the middle button is the
scroll button). Each time I scrolled the contact list, I got a lots of
"do you want to move this contact" dialogs.

*bump*

Patch updated for latest SVN revision. The scrolling in the contact
list needs to be tested with a regular wheel mouse though.

Cheers,

--
Sébastien


#3

Hey Seb,

Applied, committed and acked.

I left the first part out though. Was there any specific reason to
disable contact selection with the middle button?

Cheers
Emil

Sébastien Mazy написа:

···

Hi,

On Wed, Aug 27, 2008 at 5:51 PM, Sébastien Mazy > <sebastien.mazy@insa-lyon.fr> wrote:

This patch makes sure contact dragging will only work with the primary
(left, most of the time) mouse button pressed. Without the patch, SIP
Communicator is unusable with my trackpoint (the middle button is the
scroll button). Each time I scrolled the contact list, I got a lots of
"do you want to move this contact" dialogs.

*bump*

Patch updated for latest SVN revision. The scrolling in the contact
list needs to be tested with a regular wheel mouse though.

Cheers,

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Thanks for the commit. This detail was really annoying.

···

On Thu, Oct 23, 2008 at 10:51 AM, Emil Ivov <emcho@sip-communicator.org> wrote:

I left the first part out though. Was there any specific reason to
disable contact selection with the middle button?

I think the only reason was to keep the consistency with other JLists
whose elements are not selected by a middle click but that doesn't
make sense in the roaster list.

--
Sébastien