[sip-comm-dev] [PATCH] New shutdown bundle


#1

Hello,
This patch creates a new bundle with just one purpose, to shutdown
Sip-Communicator.

Science there is now a shutdown bundle i also removed the beginShutdown()
method from
the UIService and altered all code depending on it.

Any feedback is appreciated :slight_smile:

Have a nice day!
Linus

shutdown.txt (18.7 KB)


#2

Hi Linus,

I guess this abstraction and separation of the application shutdown
initiation is necessary for the Geek Communicator project which is
part of Google Summer of Code 2009. But could I please ask you to
provide more information with respect to its necessity? I agree one
may image the purpose of this modification from your involvement in
the project but it's still a few extra brain cycles on each and every
reader of your e-mail.

Thank you,
Lubomir

路路路

On Tue, Aug 11, 2009 at 11:25 PM, Linus<linus.wallgren@gmail.com> wrote:

Hello,
This patch creates a new bundle with just one purpose, to shutdown
Sip-Communicator.
Science there is now a shutdown bundle i also removed the beginShutdown()
method from
the UIService and altered all code depending on it.
Any feedback is appreciated :slight_smile:
Have a nice day!
Linus

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi again,
I knew there were something I had forgotten, sry about that :slight_smile:

You're right about it being a requirement for the Geek Communicator project.

I were looking for a way to implement my exit/quit commands and found the
beginShutdown() method in the UIService. Somehow this came up during a
discussing with Emil and we both agreed that this was the wrong place for a
shutdown method. We decided that it would be more intuitive to have it in
its
own bundle.

However this is, as you said, only an abstraction/separation of the
shutdown
method so it is no important update.

If something still is unclear just ask :slight_smile:

Have a nice day!
Linus

路路路

2009/8/11 Lubomir Marinov <lubomir.marinov@gmail.com>

Hi Linus,

I guess this abstraction and separation of the application shutdown
initiation is necessary for the Geek Communicator project which is
part of Google Summer of Code 2009. But could I please ask you to
provide more information with respect to its necessity? I agree one
may image the purpose of this modification from your involvement in
the project but it's still a few extra brain cycles on each and every
reader of your e-mail.

Thank you,
Lubomir

On Tue, Aug 11, 2009 at 11:25 PM, Linus<linus.wallgren@gmail.com> wrote:
> Hello,
> This patch creates a new bundle with just one purpose, to shutdown
> Sip-Communicator.
> Science there is now a shutdown bundle i also removed the beginShutdown()
> method from
> the UIService and altered all code depending on it.
> Any feedback is appreciated :slight_smile:
> Have a nice day!
> Linus

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi Linus,

Thank you for the additional information!

I have a few questions, notes regarding this implementation though:

- By looking at the file names in the sc-bundles bundles, it seems to
me that the name shutdownTimeout.jar is the first of its kind and the
SC way of naming would rather call it shutdowntimeout.jar or
shutdown-timeout.jar.

- Why is shutdownTimeout started before shutdown? As I get
shutdownTimeout, it's pretty much the very last bundle to be started
so that it can starting timing out on shutdown.

- Why is shutdown started this late anyway? I see it only defines an
interface and registers no service, yet it is kind of unclear to me.

Thank you,
Lubomir

路路路

On Wed, Aug 12, 2009 at 2:02 AM, Linus<linus.wallgren@gmail.com> wrote:

Hi again,
I knew there were something I had forgotten, sry about that :slight_smile:
You're right about it being a requirement for the Geek Communicator project.
I were looking for a way to implement my exit/quit commands and found the
beginShutdown() method in the UIService. Somehow this came up during a
discussing with Emil and we both agreed that this was the wrong place for a
shutdown method. We decided that it would be more intuitive to have it in
its
own bundle.
However this is, as you said, only an abstraction/separation of the
shutdown
method so it is no important update.
If something still is unclear just ask :slight_smile:
Have a nice day!
Linus

2009/8/11 Lubomir Marinov <lubomir.marinov@gmail.com>

Hi Linus,

I guess this abstraction and separation of the application shutdown
initiation is necessary for the Geek Communicator project which is
part of Google Summer of Code 2009. But could I please ask you to
provide more information with respect to its necessity? I agree one
may image the purpose of this modification from your involvement in
the project but it's still a few extra brain cycles on each and every
reader of your e-mail.

Thank you,
Lubomir

On Tue, Aug 11, 2009 at 11:25 PM, Linus<linus.wallgren@gmail.com> wrote:
> Hello,
> This patch creates a new bundle with just one purpose, to shutdown
> Sip-Communicator.
> Science there is now a shutdown bundle i also removed the
> beginShutdown()
> method from
> the UIService and altered all code depending on it.
> Any feedback is appreciated :slight_smile:
> Have a nice day!
> Linus

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi Lubomir,
Yes, it would seem to be one of a kind, I named it with camel case
because of old java-habit, will correct that.

Perhaps it would be better if the shutdown bundle were to be started
right after the ui-service (with regards to that the UIService is the
implementation of the shutdown interface, but does that matter?)
and right before the argdelegation-service because thats the first time
it will be used.
The command handlers in the geek-communicator project will be
in the argdelegation-service, and one of them will need the shutdown
bundle.

Should I send a new patch with the changes?

Have a nice day!
Linus

路路路

2009/8/12 Lubomir Marinov <lubomir.marinov@gmail.com>

Hi Linus,

Thank you for the additional information!

I have a few questions, notes regarding this implementation though:

- By looking at the file names in the sc-bundles bundles, it seems to
me that the name shutdownTimeout.jar is the first of its kind and the
SC way of naming would rather call it shutdowntimeout.jar or
shutdown-timeout.jar.

- Why is shutdownTimeout started before shutdown? As I get
shutdownTimeout, it's pretty much the very last bundle to be started
so that it can starting timing out on shutdown.

- Why is shutdown started this late anyway? I see it only defines an
interface and registers no service, yet it is kind of unclear to me.

Thank you,
Lubomir

On Wed, Aug 12, 2009 at 2:02 AM, Linus<linus.wallgren@gmail.com> wrote:
> Hi again,
> I knew there were something I had forgotten, sry about that :slight_smile:
> You're right about it being a requirement for the Geek Communicator
project.
> I were looking for a way to implement my exit/quit commands and found the
> beginShutdown() method in the UIService. Somehow this came up during a
> discussing with Emil and we both agreed that this was the wrong place for
a
> shutdown method. We decided that it would be more intuitive to have it in
> its
> own bundle.
> However this is, as you said, only an abstraction/separation of the
> shutdown
> method so it is no important update.
> If something still is unclear just ask :slight_smile:
> Have a nice day!
> Linus
>
> 2009/8/11 Lubomir Marinov <lubomir.marinov@gmail.com>
>>
>> Hi Linus,
>>
>> I guess this abstraction and separation of the application shutdown
>> initiation is necessary for the Geek Communicator project which is
>> part of Google Summer of Code 2009. But could I please ask you to
>> provide more information with respect to its necessity? I agree one
>> may image the purpose of this modification from your involvement in
>> the project but it's still a few extra brain cycles on each and every
>> reader of your e-mail.
>>
>> Thank you,
>> Lubomir
>>
>> On Tue, Aug 11, 2009 at 11:25 PM, Linus<linus.wallgren@gmail.com> > wrote:
>> > Hello,
>> > This patch creates a new bundle with just one purpose, to shutdown
>> > Sip-Communicator.
>> > Science there is now a shutdown bundle i also removed the
>> > beginShutdown()
>> > method from
>> > the UIService and altered all code depending on it.
>> > Any feedback is appreciated :slight_smile:
>> > Have a nice day!
>> > Linus
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
>> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hey Linus,

You don't need to create a separate bundle at all. You can keep
everything in the ui bundle. The point of the change was to provde a new
ShutdownService so that the shutdown feature would more intuitive to
find. Programmers however wouldn't be concerned with who's actually
exporting it.

Cheers
Emil

Linus wrote:

路路路

Hi Lubomir,

Yes, it would seem to be one of a kind, I named it with camel case
because of old java-habit, will correct that.

Perhaps it would be better if the shutdown bundle were to be started
right after the ui-service (with regards to that the UIService is the
implementation of the shutdown interface, but does that matter?)
and right before the argdelegation-service because thats the first time
it will be used.
The command handlers in the geek-communicator project will be
in the argdelegation-service, and one of them will need the shutdown
bundle.

Should I send a new patch with the changes?

Have a nice day!
Linus

2009/8/12 Lubomir Marinov <lubomir.marinov@gmail.com
<mailto:lubomir.marinov@gmail.com>>

聽聽聽聽Hi Linus,

聽聽聽聽Thank you for the additional information!

聽聽聽聽I have a few questions, notes regarding this implementation though:

聽聽聽聽- By looking at the file names in the sc-bundles bundles, it seems to
聽聽聽聽me that the name shutdownTimeout.jar is the first of its kind and the
聽聽聽聽SC way of naming would rather call it shutdowntimeout.jar or
聽聽聽聽shutdown-timeout.jar.

聽聽聽聽- Why is shutdownTimeout started before shutdown? As I get
聽聽聽聽shutdownTimeout, it's pretty much the very last bundle to be started
聽聽聽聽so that it can starting timing out on shutdown.

聽聽聽聽- Why is shutdown started this late anyway? I see it only defines an
聽聽聽聽interface and registers no service, yet it is kind of unclear to me.

聽聽聽聽Thank you,
聽聽聽聽Lubomir

聽聽聽聽On Wed, Aug 12, 2009 at 2:02 AM, Linus<linus.wallgren@gmail.com > <mailto:linus.wallgren@gmail.com>> wrote:
聽聽聽聽> Hi again,
聽聽聽聽> I knew there were something I had forgotten, sry about that :slight_smile:
聽聽聽聽> You're right about it being a requirement for the Geek
聽聽聽聽Communicator project.
聽聽聽聽> I were looking for a way to implement my exit/quit commands and
聽聽聽聽found the
聽聽聽聽> beginShutdown() method in the UIService. Somehow this came up during a
聽聽聽聽> discussing with Emil and we both agreed that this was the wrong
聽聽聽聽place for a
聽聽聽聽> shutdown method. We decided that it would be more intuitive to
聽聽聽聽have it in
聽聽聽聽> its
聽聽聽聽> own bundle.
聽聽聽聽> However this is, as you said, only an abstraction/separation of the
聽聽聽聽> shutdown
聽聽聽聽> method so it is no important update.
聽聽聽聽> If something still is unclear just ask :slight_smile:
聽聽聽聽> Have a nice day!
聽聽聽聽> Linus
聽聽聽聽>
聽聽聽聽> 2009/8/11 Lubomir Marinov <lubomir.marinov@gmail.com
聽聽聽聽<mailto:lubomir.marinov@gmail.com>>
聽聽聽聽>>
聽聽聽聽>> Hi Linus,
聽聽聽聽>>
聽聽聽聽>> I guess this abstraction and separation of the application shutdown
聽聽聽聽>> initiation is necessary for the Geek Communicator project which is
聽聽聽聽>> part of Google Summer of Code 2009. But could I please ask you to
聽聽聽聽>> provide more information with respect to its necessity? I agree one
聽聽聽聽>> may image the purpose of this modification from your involvement in
聽聽聽聽>> the project but it's still a few extra brain cycles on each and every
聽聽聽聽>> reader of your e-mail.
聽聽聽聽>>
聽聽聽聽>> Thank you,
聽聽聽聽>> Lubomir
聽聽聽聽>>
聽聽聽聽>> On Tue, Aug 11, 2009 at 11:25 PM, Linus<linus.wallgren@gmail.com > <mailto:linus.wallgren@gmail.com>> wrote:
聽聽聽聽>> > Hello,
聽聽聽聽>> > This patch creates a new bundle with just one purpose, to shutdown
聽聽聽聽>> > Sip-Communicator.
聽聽聽聽>> > Science there is now a shutdown bundle i also removed the
聽聽聽聽>> > beginShutdown()
聽聽聽聽>> > method from
聽聽聽聽>> > the UIService and altered all code depending on it.
聽聽聽聽>> > Any feedback is appreciated :slight_smile:
聽聽聽聽>> > Have a nice day!
聽聽聽聽>> > Linus
聽聽聽聽>>
聽聽聽聽>> ---------------------------------------------------------------------
聽聽聽聽>> To unsubscribe, e-mail:
聽聽聽聽dev-unsubscribe@sip-communicator.dev.java.net
聽聽聽聽<mailto:dev-unsubscribe@sip-communicator.dev.java.net>
聽聽聽聽>> For additional commands, e-mail:
聽聽聽聽dev-help@sip-communicator.dev.java.net
聽聽聽聽<mailto:dev-help@sip-communicator.dev.java.net>
聽聽聽聽>>
聽聽聽聽>
聽聽聽聽>

聽聽聽聽---------------------------------------------------------------------
聽聽聽聽To unsubscribe, e-mail:
聽聽聽聽dev-unsubscribe@sip-communicator.dev.java.net
聽聽聽聽<mailto:dev-unsubscribe@sip-communicator.dev.java.net>
聽聽聽聽For additional commands, e-mail:
聽聽聽聽dev-help@sip-communicator.dev.java.net
聽聽聽聽<mailto:dev-help@sip-communicator.dev.java.net>

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Alright, lets try again :slight_smile:
The shutdown service is now registered through the ui service bundle
and the shutdownTimeout is now shutdown-timeout.

Have a nice day!
Linus

shutdown.txt (21 KB)

路路路

2009/8/12 Emil Ivov <emcho@sip-communicator.org>

Hey Linus,

You don't need to create a separate bundle at all. You can keep
everything in the ui bundle. The point of the change was to provde a new
ShutdownService so that the shutdown feature would more intuitive to
find. Programmers however wouldn't be concerned with who's actually
exporting it.

Cheers
Emil

Linus wrote:
> Hi Lubomir,
>
> Yes, it would seem to be one of a kind, I named it with camel case
> because of old java-habit, will correct that.
>
> Perhaps it would be better if the shutdown bundle were to be started
> right after the ui-service (with regards to that the UIService is the
> implementation of the shutdown interface, but does that matter?)
> and right before the argdelegation-service because thats the first time
> it will be used.
> The command handlers in the geek-communicator project will be
> in the argdelegation-service, and one of them will need the shutdown
> bundle.
>
> Should I send a new patch with the changes?
>
> Have a nice day!
> Linus
>
> 2009/8/12 Lubomir Marinov <lubomir.marinov@gmail.com
> <mailto:lubomir.marinov@gmail.com>>
>
> Hi Linus,
>
> Thank you for the additional information!
>
> I have a few questions, notes regarding this implementation though:
>
> - By looking at the file names in the sc-bundles bundles, it seems to
> me that the name shutdownTimeout.jar is the first of its kind and the
> SC way of naming would rather call it shutdowntimeout.jar or
> shutdown-timeout.jar.
>
>
> - Why is shutdownTimeout started before shutdown? As I get
> shutdownTimeout, it's pretty much the very last bundle to be started
> so that it can starting timing out on shutdown.
>
> - Why is shutdown started this late anyway? I see it only defines an
> interface and registers no service, yet it is kind of unclear to me.
>
>
>
> Thank you,
> Lubomir
>
> On Wed, Aug 12, 2009 at 2:02 AM, Linus<linus.wallgren@gmail.com > > <mailto:linus.wallgren@gmail.com>> wrote:
> > Hi again,
> > I knew there were something I had forgotten, sry about that :slight_smile:
> > You're right about it being a requirement for the Geek
> Communicator project.
> > I were looking for a way to implement my exit/quit commands and
> found the
> > beginShutdown() method in the UIService. Somehow this came up
during a
> > discussing with Emil and we both agreed that this was the wrong
> place for a
> > shutdown method. We decided that it would be more intuitive to
> have it in
> > its
> > own bundle.
> > However this is, as you said, only an abstraction/separation of the
> > shutdown
> > method so it is no important update.
> > If something still is unclear just ask :slight_smile:
> > Have a nice day!
> > Linus
> >
> > 2009/8/11 Lubomir Marinov <lubomir.marinov@gmail.com
> <mailto:lubomir.marinov@gmail.com>>
> >>
> >> Hi Linus,
> >>
> >> I guess this abstraction and separation of the application
shutdown
> >> initiation is necessary for the Geek Communicator project which is
> >> part of Google Summer of Code 2009. But could I please ask you to
> >> provide more information with respect to its necessity? I agree
one
> >> may image the purpose of this modification from your involvement
in
> >> the project but it's still a few extra brain cycles on each and
every
> >> reader of your e-mail.
> >>
> >> Thank you,
> >> Lubomir
> >>
> >> On Tue, Aug 11, 2009 at 11:25 PM, Linus<linus.wallgren@gmail.com > > <mailto:linus.wallgren@gmail.com>> wrote:
> >> > Hello,
> >> > This patch creates a new bundle with just one purpose, to
shutdown
> >> > Sip-Communicator.
> >> > Science there is now a shutdown bundle i also removed the
> >> > beginShutdown()
> >> > method from
> >> > the UIService and altered all code depending on it.
> >> > Any feedback is appreciated :slight_smile:
> >> > Have a nice day!
> >> > Linus
> >>
> >>
---------------------------------------------------------------------
> >> To unsubscribe, e-mail:
> dev-unsubscribe@sip-communicator.dev.java.net
> <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
> >> For additional commands, e-mail:
> dev-help@sip-communicator.dev.java.net
> <mailto:dev-help@sip-communicator.dev.java.net>
> >>
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@sip-communicator.dev.java.net
> <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
> For additional commands, e-mail:
> dev-help@sip-communicator.dev.java.net
> <mailto:dev-help@sip-communicator.dev.java.net>
>
>

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Hello Linus,

Thank you for the contribution! I've committed the patch you provided
into r5809 and r5810 (I'm sorry about splitting it, my svn fu seems to
be getting rusty and I forgot to add the new interface file in r5809).

I hope you will not mind me fiddling with your patch and sharing a few
more notes on it here:

- By looking at the other services I thought services were supposed to
be name with Service at the end. Besides, Emil explicitly used such a
name in this letter. So I used the name ShutdownService instead of
just Shutdown.

- I modified the Javadoc of ShutdownService. Mine isn't all that
useful but I thought "Shuts down SC" was a little too short.

- shudownTimeout hadn't really died in your patch, it was still used
as a package name. With the case sensitivity of the file names on some
of the operating systems, I didn't risk it and used shutdowntimeout
for the package name.

- There were still traces of that new shutdown bundle you created in
your previous patch and that was supposed to not exist in the new
patch.

- The formatting of the code you wrote (e.g. acquiring the
ShutdownService reference) didn't fallow the coding conventions. I'm
not sure mine did 100% but at least I tried to make it look like the
other formatting in the respective files.

- I introduced a method getShutdownService() (ah, then copied and
pasted it) because stuffing the long BundleContext, getService,
getServiceReference, etc. right where it's actually used with the
existing indentation there looked almost too difficult to comprehend
with the single glance that it deserves.

Regards,
Lubomir

路路路

On Thu, Aug 13, 2009 at 1:31 AM, Linus<linus.wallgren@gmail.com> wrote:

Alright, lets try again :slight_smile:
The shutdown service is now registered through the ui service bundle
and the shutdownTimeout is now shutdown-timeout.
Have a nice day!
Linus

2009/8/12 Emil Ivov <emcho@sip-communicator.org>

Hey Linus,

You don't need to create a separate bundle at all. You can keep
everything in the ui bundle. The point of the change was to provde a new
ShutdownService so that the shutdown feature would more intuitive to
find. Programmers however wouldn't be concerned with who's actually
exporting it.

Cheers
Emil

Linus wrote:
> Hi Lubomir,
>
> Yes, it would seem to be one of a kind, I named it with camel case
> because of old java-habit, will correct that.
>
> Perhaps it would be better if the shutdown bundle were to be started
> right after the ui-service (with regards to that the UIService is the
> implementation of the shutdown interface, but does that matter?)
> and right before the argdelegation-service because thats the first time
> it will be used.
> The command handlers in the geek-communicator project will be
> in the argdelegation-service, and one of them will need the shutdown
> bundle.
>
> Should I send a new patch with the changes?
>
> Have a nice day!
> Linus
>
> 2009/8/12 Lubomir Marinov <lubomir.marinov@gmail.com
> <mailto:lubomir.marinov@gmail.com>>
>
> Hi Linus,
>
> Thank you for the additional information!
>
> I have a few questions, notes regarding this implementation though:
>
> - By looking at the file names in the sc-bundles bundles, it seems
> to
> me that the name shutdownTimeout.jar is the first of its kind and
> the
> SC way of naming would rather call it shutdowntimeout.jar or
> shutdown-timeout.jar.
>
>
> - Why is shutdownTimeout started before shutdown? As I get
> shutdownTimeout, it's pretty much the very last bundle to be started
> so that it can starting timing out on shutdown.
>
> - Why is shutdown started this late anyway? I see it only defines an
> interface and registers no service, yet it is kind of unclear to me.
>
>
>
> Thank you,
> Lubomir
>
> On Wed, Aug 12, 2009 at 2:02 AM, Linus<linus.wallgren@gmail.com >> > <mailto:linus.wallgren@gmail.com>> wrote:
> > Hi again,
> > I knew there were something I had forgotten, sry about that :slight_smile:
> > You're right about it being a requirement for the Geek
> Communicator project.
> > I were looking for a way to implement my exit/quit commands and
> found the
> > beginShutdown() method in the UIService. Somehow this came up
> during a
> > discussing with Emil and we both agreed that this was the wrong
> place for a
> > shutdown method. We decided that it would be more intuitive to
> have it in
> > its
> > own bundle.
> > However this is, as you said, only an abstraction/separation of
> the
> > shutdown
> > method so it is no important update.
> > If something still is unclear just ask :slight_smile:
> > Have a nice day!
> > Linus
> >
> > 2009/8/11 Lubomir Marinov <lubomir.marinov@gmail.com
> <mailto:lubomir.marinov@gmail.com>>
> >>
> >> Hi Linus,
> >>
> >> I guess this abstraction and separation of the application
> shutdown
> >> initiation is necessary for the Geek Communicator project which
> is
> >> part of Google Summer of Code 2009. But could I please ask you to
> >> provide more information with respect to its necessity? I agree
> one
> >> may image the purpose of this modification from your involvement
> in
> >> the project but it's still a few extra brain cycles on each and
> every
> >> reader of your e-mail.
> >>
> >> Thank you,
> >> Lubomir
> >>
> >> On Tue, Aug 11, 2009 at 11:25 PM, Linus<linus.wallgren@gmail.com >> > <mailto:linus.wallgren@gmail.com>> wrote:
> >> > Hello,
> >> > This patch creates a new bundle with just one purpose, to
> shutdown
> >> > Sip-Communicator.
> >> > Science there is now a shutdown bundle i also removed the
> >> > beginShutdown()
> >> > method from
> >> > the UIService and altered all code depending on it.
> >> > Any feedback is appreciated :slight_smile:
> >> > Have a nice day!
> >> > Linus
> >>
> >>
> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail:
> dev-unsubscribe@sip-communicator.dev.java.net
> <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
> >> For additional commands, e-mail:
> dev-help@sip-communicator.dev.java.net
> <mailto:dev-help@sip-communicator.dev.java.net>
> >>
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@sip-communicator.dev.java.net
> <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
> For additional commands, e-mail:
> dev-help@sip-communicator.dev.java.net
> <mailto:dev-help@sip-communicator.dev.java.net>
>
>

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#9

Hi again Linus,

I just acknowledged your contribution of ShutdownService on our Team
and Contributors page. I'm sorry about the delay, I had a hard time
remembering my password.

Best regards,
Lubomir

路路路

On Fri, Aug 14, 2009 at 5:36 PM, Lubomir Marinov<lubomir.marinov@gmail.com> wrote:

Hello Linus,

Thank you for the contribution! I've committed the patch you provided
into r5809 and r5810 (I'm sorry about splitting it, my svn fu seems to
be getting rusty and I forgot to add the new interface file in r5809).

I hope you will not mind me fiddling with your patch and sharing a few
more notes on it here:

- By looking at the other services I thought services were supposed to
be name with Service at the end. Besides, Emil explicitly used such a
name in this letter. So I used the name ShutdownService instead of
just Shutdown.

- I modified the Javadoc of ShutdownService. Mine isn't all that
useful but I thought "Shuts down SC" was a little too short.

- shudownTimeout hadn't really died in your patch, it was still used
as a package name. With the case sensitivity of the file names on some
of the operating systems, I didn't risk it and used shutdowntimeout
for the package name.

- There were still traces of that new shutdown bundle you created in
your previous patch and that was supposed to not exist in the new
patch.

- The formatting of the code you wrote (e.g. acquiring the
ShutdownService reference) didn't fallow the coding conventions. I'm
not sure mine did 100% but at least I tried to make it look like the
other formatting in the respective files.

- I introduced a method getShutdownService() (ah, then copied and
pasted it) because stuffing the long BundleContext, getService,
getServiceReference, etc. right where it's actually used with the
existing indentation there looked almost too difficult to comprehend
with the single glance that it deserves.

Regards,
Lubomir

On Thu, Aug 13, 2009 at 1:31 AM, Linus<linus.wallgren@gmail.com> wrote:

Alright, lets try again :slight_smile:
The shutdown service is now registered through the ui service bundle
and the shutdownTimeout is now shutdown-timeout.
Have a nice day!
Linus

2009/8/12 Emil Ivov <emcho@sip-communicator.org>

Hey Linus,

You don't need to create a separate bundle at all. You can keep
everything in the ui bundle. The point of the change was to provde a new
ShutdownService so that the shutdown feature would more intuitive to
find. Programmers however wouldn't be concerned with who's actually
exporting it.

Cheers
Emil

Linus wrote:
> Hi Lubomir,
>
> Yes, it would seem to be one of a kind, I named it with camel case
> because of old java-habit, will correct that.
>
> Perhaps it would be better if the shutdown bundle were to be started
> right after the ui-service (with regards to that the UIService is the
> implementation of the shutdown interface, but does that matter?)
> and right before the argdelegation-service because thats the first time
> it will be used.
> The command handlers in the geek-communicator project will be
> in the argdelegation-service, and one of them will need the shutdown
> bundle.
>
> Should I send a new patch with the changes?
>
> Have a nice day!
> Linus
>
> 2009/8/12 Lubomir Marinov <lubomir.marinov@gmail.com
> <mailto:lubomir.marinov@gmail.com>>
>
> Hi Linus,
>
> Thank you for the additional information!
>
> I have a few questions, notes regarding this implementation though:
>
> - By looking at the file names in the sc-bundles bundles, it seems
> to
> me that the name shutdownTimeout.jar is the first of its kind and
> the
> SC way of naming would rather call it shutdowntimeout.jar or
> shutdown-timeout.jar.
>
>
> - Why is shutdownTimeout started before shutdown? As I get
> shutdownTimeout, it's pretty much the very last bundle to be started
> so that it can starting timing out on shutdown.
>
> - Why is shutdown started this late anyway? I see it only defines an
> interface and registers no service, yet it is kind of unclear to me.
>
>
>
> Thank you,
> Lubomir
>
> On Wed, Aug 12, 2009 at 2:02 AM, Linus<linus.wallgren@gmail.com >>> > <mailto:linus.wallgren@gmail.com>> wrote:
> > Hi again,
> > I knew there were something I had forgotten, sry about that :slight_smile:
> > You're right about it being a requirement for the Geek
> Communicator project.
> > I were looking for a way to implement my exit/quit commands and
> found the
> > beginShutdown() method in the UIService. Somehow this came up
> during a
> > discussing with Emil and we both agreed that this was the wrong
> place for a
> > shutdown method. We decided that it would be more intuitive to
> have it in
> > its
> > own bundle.
> > However this is, as you said, only an abstraction/separation of
> the
> > shutdown
> > method so it is no important update.
> > If something still is unclear just ask :slight_smile:
> > Have a nice day!
> > Linus
> >
> > 2009/8/11 Lubomir Marinov <lubomir.marinov@gmail.com
> <mailto:lubomir.marinov@gmail.com>>
> >>
> >> Hi Linus,
> >>
> >> I guess this abstraction and separation of the application
> shutdown
> >> initiation is necessary for the Geek Communicator project which
> is
> >> part of Google Summer of Code 2009. But could I please ask you to
> >> provide more information with respect to its necessity? I agree
> one
> >> may image the purpose of this modification from your involvement
> in
> >> the project but it's still a few extra brain cycles on each and
> every
> >> reader of your e-mail.
> >>
> >> Thank you,
> >> Lubomir
> >>
> >> On Tue, Aug 11, 2009 at 11:25 PM, Linus<linus.wallgren@gmail.com >>> > <mailto:linus.wallgren@gmail.com>> wrote:
> >> > Hello,
> >> > This patch creates a new bundle with just one purpose, to
> shutdown
> >> > Sip-Communicator.
> >> > Science there is now a shutdown bundle i also removed the
> >> > beginShutdown()
> >> > method from
> >> > the UIService and altered all code depending on it.
> >> > Any feedback is appreciated :slight_smile:
> >> > Have a nice day!
> >> > Linus
> >>
> >>
> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail:
> dev-unsubscribe@sip-communicator.dev.java.net
> <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
> >> For additional commands, e-mail:
> dev-help@sip-communicator.dev.java.net
> <mailto:dev-help@sip-communicator.dev.java.net>
> >>
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail:
> dev-unsubscribe@sip-communicator.dev.java.net
> <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
> For additional commands, e-mail:
> dev-help@sip-communicator.dev.java.net
> <mailto:dev-help@sip-communicator.dev.java.net>
>
>

--
Emil Ivov, Ph.D. 67000 Strasbourg,
Project Lead France
SIP Communicator
emcho@sip-communicator.org PHONE: +33.1.77.62.43.30
http://sip-communicator.org FAX: +33.1.77.62.47.31

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#10

Hi,
No problem :slight_smile:

Your changes seems good, however I cant really look at them because i have
some serious problem with eclipse now, look in the Geek Communicator thread
for details.

Have a nice day!
Linus

路路路

2009/8/14 Lubomir Marinov <lubomir.marinov@gmail.com>

Hi again Linus,

I just acknowledged your contribution of ShutdownService on our Team
and Contributors page. I'm sorry about the delay, I had a hard time
remembering my password.

Best regards,
Lubomir

On Fri, Aug 14, 2009 at 5:36 PM, Lubomir > Marinov<lubomir.marinov@gmail.com> wrote:
> Hello Linus,
>
> Thank you for the contribution! I've committed the patch you provided
> into r5809 and r5810 (I'm sorry about splitting it, my svn fu seems to
> be getting rusty and I forgot to add the new interface file in r5809).
>
> I hope you will not mind me fiddling with your patch and sharing a few
> more notes on it here:
>
> - By looking at the other services I thought services were supposed to
> be name with Service at the end. Besides, Emil explicitly used such a
> name in this letter. So I used the name ShutdownService instead of
> just Shutdown.
>
> - I modified the Javadoc of ShutdownService. Mine isn't all that
> useful but I thought "Shuts down SC" was a little too short.
>
> - shudownTimeout hadn't really died in your patch, it was still used
> as a package name. With the case sensitivity of the file names on some
> of the operating systems, I didn't risk it and used shutdowntimeout
> for the package name.
>
> - There were still traces of that new shutdown bundle you created in
> your previous patch and that was supposed to not exist in the new
> patch.
>
> - The formatting of the code you wrote (e.g. acquiring the
> ShutdownService reference) didn't fallow the coding conventions. I'm
> not sure mine did 100% but at least I tried to make it look like the
> other formatting in the respective files.
>
> - I introduced a method getShutdownService() (ah, then copied and
> pasted it) because stuffing the long BundleContext, getService,
> getServiceReference, etc. right where it's actually used with the
> existing indentation there looked almost too difficult to comprehend
> with the single glance that it deserves.
>
> Regards,
> Lubomir
>
> On Thu, Aug 13, 2009 at 1:31 AM, Linus<linus.wallgren@gmail.com> wrote:
>> Alright, lets try again :slight_smile:
>> The shutdown service is now registered through the ui service bundle
>> and the shutdownTimeout is now shutdown-timeout.
>> Have a nice day!
>> Linus
>>
>> 2009/8/12 Emil Ivov <emcho@sip-communicator.org>
>>>
>>> Hey Linus,
>>>
>>> You don't need to create a separate bundle at all. You can keep
>>> everything in the ui bundle. The point of the change was to provde a
new
>>> ShutdownService so that the shutdown feature would more intuitive to
>>> find. Programmers however wouldn't be concerned with who's actually
>>> exporting it.
>>>
>>> Cheers
>>> Emil
>>>
>>> Linus wrote:
>>> > Hi Lubomir,
>>> >
>>> > Yes, it would seem to be one of a kind, I named it with camel case
>>> > because of old java-habit, will correct that.
>>> >
>>> > Perhaps it would be better if the shutdown bundle were to be started
>>> > right after the ui-service (with regards to that the UIService is the
>>> > implementation of the shutdown interface, but does that matter?)
>>> > and right before the argdelegation-service because thats the first
time
>>> > it will be used.
>>> > The command handlers in the geek-communicator project will be
>>> > in the argdelegation-service, and one of them will need the shutdown
>>> > bundle.
>>> >
>>> > Should I send a new patch with the changes?
>>> >
>>> > Have a nice day!
>>> > Linus
>>> >
>>> > 2009/8/12 Lubomir Marinov <lubomir.marinov@gmail.com
>>> > <mailto:lubomir.marinov@gmail.com>>
>>> >
>>> > Hi Linus,
>>> >
>>> > Thank you for the additional information!
>>> >
>>> > I have a few questions, notes regarding this implementation
though:
>>> >
>>> > - By looking at the file names in the sc-bundles bundles, it
seems
>>> > to
>>> > me that the name shutdownTimeout.jar is the first of its kind and
>>> > the
>>> > SC way of naming would rather call it shutdowntimeout.jar or
>>> > shutdown-timeout.jar.
>>> >
>>> >
>>> > - Why is shutdownTimeout started before shutdown? As I get
>>> > shutdownTimeout, it's pretty much the very last bundle to be
started
>>> > so that it can starting timing out on shutdown.
>>> >
>>> > - Why is shutdown started this late anyway? I see it only defines
an
>>> > interface and registers no service, yet it is kind of unclear to
me.
>>> >
>>> >
>>> >
>>> > Thank you,
>>> > Lubomir
>>> >
>>> > On Wed, Aug 12, 2009 at 2:02 AM, Linus<linus.wallgren@gmail.com > >>> > <mailto:linus.wallgren@gmail.com>> wrote:
>>> > > Hi again,
>>> > > I knew there were something I had forgotten, sry about that :slight_smile:
>>> > > You're right about it being a requirement for the Geek
>>> > Communicator project.
>>> > > I were looking for a way to implement my exit/quit commands and
>>> > found the
>>> > > beginShutdown() method in the UIService. Somehow this came up
>>> > during a
>>> > > discussing with Emil and we both agreed that this was the wrong
>>> > place for a
>>> > > shutdown method. We decided that it would be more intuitive to
>>> > have it in
>>> > > its
>>> > > own bundle.
>>> > > However this is, as you said, only an abstraction/separation of
>>> > the
>>> > > shutdown
>>> > > method so it is no important update.
>>> > > If something still is unclear just ask :slight_smile:
>>> > > Have a nice day!
>>> > > Linus
>>> > >
>>> > > 2009/8/11 Lubomir Marinov <lubomir.marinov@gmail.com
>>> > <mailto:lubomir.marinov@gmail.com>>
>>> > >>
>>> > >> Hi Linus,
>>> > >>
>>> > >> I guess this abstraction and separation of the application
>>> > shutdown
>>> > >> initiation is necessary for the Geek Communicator project
which
>>> > is
>>> > >> part of Google Summer of Code 2009. But could I please ask you
to
>>> > >> provide more information with respect to its necessity? I
agree
>>> > one
>>> > >> may image the purpose of this modification from your
involvement
>>> > in
>>> > >> the project but it's still a few extra brain cycles on each
and
>>> > every
>>> > >> reader of your e-mail.
>>> > >>
>>> > >> Thank you,
>>> > >> Lubomir
>>> > >>
>>> > >> On Tue, Aug 11, 2009 at 11:25 PM, Linus< > linus.wallgren@gmail.com > >>> > <mailto:linus.wallgren@gmail.com>> wrote:
>>> > >> > Hello,
>>> > >> > This patch creates a new bundle with just one purpose, to
>>> > shutdown
>>> > >> > Sip-Communicator.
>>> > >> > Science there is now a shutdown bundle i also removed the
>>> > >> > beginShutdown()
>>> > >> > method from
>>> > >> > the UIService and altered all code depending on it.
>>> > >> > Any feedback is appreciated :slight_smile:
>>> > >> > Have a nice day!
>>> > >> > Linus
>>> > >>
>>> > >>
>>> > ---------------------------------------------------------------------
>>> > >> To unsubscribe, e-mail:
>>> > dev-unsubscribe@sip-communicator.dev.java.net
>>> > <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
>>> > >> For additional commands, e-mail:
>>> > dev-help@sip-communicator.dev.java.net
>>> > <mailto:dev-help@sip-communicator.dev.java.net>
>>> > >>
>>> > >
>>> > >
>>> >
>>> >
>>> > ---------------------------------------------------------------------
>>> > To unsubscribe, e-mail:
>>> > dev-unsubscribe@sip-communicator.dev.java.net
>>> > <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
>>> > For additional commands, e-mail:
>>> > dev-help@sip-communicator.dev.java.net
>>> > <mailto:dev-help@sip-communicator.dev.java.net>
>>> >
>>> >
>>>
>>> --
>>> Emil Ivov, Ph.D. 67000 Strasbourg,
>>> Project Lead France
>>> SIP Communicator
>>> emcho@sip-communicator.org PHONE:
+33.1.77.62.43.30
>>> http://sip-communicator.org FAX:
+33.1.77.62.47.31
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
>>> For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
>> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net