[sip-comm-dev] [PATCH] new placeCall method in UIService


#1

Hi,

This one-liner enables other services than UIService to place a call.
It calls CallManager to start the call and show the call panel (one
sentence, too many "call").

Cheers,

place_call_facility.patch (1.79 KB)

···

--
Sébastien Mazy


#2

Hi Sebastien,

Thanks for pointing this out!

Actually I think that we thought it otherwise. When some other bundle wants to place a call it creates the call through the protocol provider and then the gui for this call should be created automatically when the outgoingCallCreated event is triggered. But I'm seeing right now that the outgoingCallCreated method is not implemented in the gui CallManager. I'll fix this till the end of this week.

Thanks,
Yana

S�bastien Mazy wrote:

···

Hi,

This one-liner enables other services than UIService to place a call.
It calls CallManager to start the call and show the call panel (one
sentence, too many "call").

Cheers,

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Mine patch was a quick hack to get this working. Your solution is
definitely cleaner :slight_smile:

···

On Mon, Aug 11, 2008 at 11:17 AM, Yana Stamcheva <yana@sip-communicator.org> wrote:

Actually I think that we thought it otherwise. When some other bundle wants
to place a call it creates the call through the protocol provider and then
the gui for this call should be created automatically when the
outgoingCallCreated event is triggered. But I'm seeing right now that the
outgoingCallCreated method is not implemented in the gui CallManager. I'll
fix this till the end of this week.

--
Sébastien Mazy