[sip-comm-dev] [Patch] Issue 469


#1

https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=469

469_signin_frame_button_order.patch (664 Bytes)


#2

Hey Alan,

Thank you for working in the direction!

Actually, I saw in the svn log that the order was once changed, then
the change was reverted with the comment that it didn't take into
account the Mac OS X conventions which have the buttons as they are
now. For what I know, both Apple and Gnome HIG have the buttons in the
order Cancel, "Sign in" and Windows User Experience Guidelines have
them the other way i.e. "Sign in", Cancel. I don't know about KDE.

What's more important is that the svn comment with which the change
was reverted stated that a decision whether at all to be platform
sensitive was still pending. So we may first have to find enough
support in the community for such fine-grained platform sensitivity
because, if it's not considered a priority, we may be wasting the time
of the majority.

As to the fix, I believe, if it's at all going to be addressed, it
should be addressed in a generic way and not for a single dialog.
Eclipse is a great example in the case and it already has the solution
in JFace Dialog (if I'm not mistaken) - a super handles the creation
of the buttons (it can of course be overridden, customized, etc) and
defines standard buttons so that it can provide the correct order (the
labels of the buttons is of course customizable).

Best regards,
Lubo

···

On Thu, Oct 23, 2008 at 9:46 PM, Alan C Kelly <akelly7@gmu.edu> wrote:

https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=469

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

I think the most important thing is for our dialogs to be consistent, and I've always thought that this particular dialog stuck out because almost all our other dialogs have the buttons in the Windows default order.

···

----- Original Message -----

From: Lubomir Marinov <lubomir.marinov@gmail.com>

Date: Thursday, October 23, 2008 3:19 pm
Subject: Re: [sip-comm-dev] [Patch] Issue 469

Hey Alan,

Thank you for working in the direction!

Actually, I saw in the svn log that the order was once changed, then
the change was reverted with the comment that it didn't take into
account the Mac OS X conventions which have the buttons as they are
now. For what I know, both Apple and Gnome HIG have the buttons in the
order Cancel, "Sign in" and Windows User Experience Guidelines have
them the other way i.e. "Sign in", Cancel. I don't know about KDE.

What's more important is that the svn comment with which the change
was reverted stated that a decision whether at all to be platform
sensitive was still pending. So we may first have to find enough
support in the community for such fine-grained platform sensitivity
because, if it's not considered a priority, we may be wasting the time
of the majority.

As to the fix, I believe, if it's at all going to be addressed, it
should be addressed in a generic way and not for a single dialog.
Eclipse is a great example in the case and it already has the solution
in JFace Dialog (if I'm not mistaken) - a super handles the creation
of the buttons (it can of course be overridden, customized, etc) and
defines standard buttons so that it can provide the correct order (the
labels of the buttons is of course customizable).

Best regards,
Lubo

On Thu, Oct 23, 2008 at 9:46 PM, Alan C Kelly <akelly7@gmu.edu> wrote:
> https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=469
>
> -----------------------------------------------------------------
----
> To unsubscribe, e-mail: dev-unsubscribe@sip-
communicator.dev.java.net> For additional commands, e-mail: dev-
help@sip-communicator.dev.java.net

-------------------------------------------------------------------
--
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi Alan,

as Lubo has mentioned, I have committed the same fix you've proposed some days ago, but then I have changed my mind and reverted it.

I agree with both Lubo and you on this one. First I agree that the most important thing is that our dialogs should be consistent and that's why Lubo has created the issue in first place. But it's also a good moment to find a generic solutions for this one and I like the idea of Lubo.

May be for now we could swap buttons in Sign in dialog for consistency and then find a solution as the one Lubo has proposed that would prevent us from having such problems in the future. WDYT?

Cheers,
Yana

Alan C Kelly wrote:

···

I think the most important thing is for our dialogs to be consistent, and I've always thought that this particular dialog stuck out because almost all our other dialogs have the buttons in the Windows default order.

----- Original Message -----
From: Lubomir Marinov <lubomir.marinov@gmail.com>
Date: Thursday, October 23, 2008 3:19 pm
Subject: Re: [sip-comm-dev] [Patch] Issue 469

Hey Alan,

Thank you for working in the direction!

Actually, I saw in the svn log that the order was once changed, then
the change was reverted with the comment that it didn't take into
account the Mac OS X conventions which have the buttons as they are
now. For what I know, both Apple and Gnome HIG have the buttons in the
order Cancel, "Sign in" and Windows User Experience Guidelines have
them the other way i.e. "Sign in", Cancel. I don't know about KDE.

What's more important is that the svn comment with which the change
was reverted stated that a decision whether at all to be platform
sensitive was still pending. So we may first have to find enough
support in the community for such fine-grained platform sensitivity
because, if it's not considered a priority, we may be wasting the time
of the majority.

As to the fix, I believe, if it's at all going to be addressed, it
should be addressed in a generic way and not for a single dialog.
Eclipse is a great example in the case and it already has the solution
in JFace Dialog (if I'm not mistaken) - a super handles the creation
of the buttons (it can of course be overridden, customized, etc) and
defines standard buttons so that it can provide the correct order (the
labels of the buttons is of course customizable).

Best regards,
Lubo

On Thu, Oct 23, 2008 at 9:46 PM, Alan C Kelly <akelly7@gmu.edu> wrote:

https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=469

-----------------------------------------------------------------

----

To unsubscribe, e-mail: dev-unsubscribe@sip-

communicator.dev.java.net> For additional commands, e-mail: dev-
help@sip-communicator.dev.java.net

-------------------------------------------------------------------
--
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-
communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net