[sip-comm-dev] [PATCH] Fix for unregistering sip account that have connection failed


#1

Hi,
when I have a sip account that was not able to register because of a
connection fail it's state is

RegistrationState.CONNECTION_FAILED

When I want to delete this account, the
method
ProtocolProviderServiceSipImpl.unregister()
is called.
And in that method if the account is unregistering or unregistred it will do
nothing otherwise it will try to unregister.
But if the connection state is CONNECTION_FAILED, the problem is that it
will try to unregister then fail again and show an error dialog.
I think that when the state is CONNECTION_FAILED, the account is not
registered so it is not necessary to try to unregister and fail again

My patch fixes that problem

Matthieu

Unregister_sip_account_when_connection_failed.patch (812 Bytes)


#2

Hi Matthieu,

Your patch looks good! You can go ahead and commit it.

Cheers,
Yana

···

On Mar 25, 2010, at 2:54 PM, Matthieu Casanova wrote:

Hi,
when I have a sip account that was not able to register because of a connection fail it's state is

RegistrationState.CONNECTION_FAILED

When I want to delete this account, the
method
ProtocolProviderServiceSipImpl.unregister()
is called.
And in that method if the account is unregistering or unregistred it will do nothing otherwise it will try to unregister.
But if the connection state is CONNECTION_FAILED, the problem is that it will try to unregister then fail again and show an error dialog.
I think that when the state is CONNECTION_FAILED, the account is not registered so it is not necessary to try to unregister and fail again

My patch fixes that problem

Matthieu
<Unregister_sip_account_when_connection_failed.patch>---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi,
I forgot it, that's right, I just applied the patch

Matthieu

···

2010/4/9 Yana Stamcheva <yana@sip-communicator.org>:

Hi Matthieu,

Your patch looks good! You can go ahead and commit it.

Cheers,
Yana

On Mar 25, 2010, at 2:54 PM, Matthieu Casanova wrote:

Hi,
when I have a sip account that was not able to register because of a connection fail it's state is

RegistrationState.CONNECTION_FAILED

When I want to delete this account, the
method
ProtocolProviderServiceSipImpl.unregister()
is called.
And in that method if the account is unregistering or unregistred it will do nothing otherwise it will try to unregister.
But if the connection state is CONNECTION_FAILED, the problem is that it will try to unregister then fail again and show an error dialog.
I think that when the state is CONNECTION_FAILED, the account is not registered so it is not necessary to try to unregister and fail again

My patch fixes that problem

Matthieu
<Unregister_sip_account_when_connection_failed.patch>---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net