[sip-comm-dev] [PATCH] Fix for suspicious String comparison


#1

Hi,
I found a few strange String comparison like

string == ""
It can work in specific case of course if the string is interned or if we
are sure that it is the same instance, but it also can be a bug, so here is
a patch that fixes that

Matthieu

Fix_suspicious_String_comparison.patch (5.45 KB)


#2

Hi Matthieu,

As always, good catch! Committed and ack-ed.

Thanks!
Yana

ยทยทยท

On Feb 19, 2010, at 10:34 AM, Matthieu Casanova wrote:

Hi,
I found a few strange String comparison like

string == ""
It can work in specific case of course if the string is interned or if we are sure that it is the same instance, but it also can be a bug, so here is a patch that fixes that

Matthieu
<Fix_suspicious_String_comparison.patch>---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net