[sip-comm-dev] [PATCH] Fix for issue # 889


#1

Hi all, I have attached a patch to fix issue # 889.

Regards

UpdateCheckActivatorPlugin.patch (2.03 KB)

···

--
Abdur Rauf Rajar

BS Computer Science
School of Science and Engineering (SSE)
Lahore University of Management Sciences (LUMS)
Opposite Sector U, DHA, Lahore Cantt.


#2

Hi Abdur,

Thank you very much for your contribution!

As we talked earlier today over the IRC, I'd like to review your patch
and commit it in the very near future. While your modifications look
OK by just reading the patch, I'd like to ask you (without actually
trying the code myself) whether the existing dialog will update its
contents in the following scenario:

1. I check for updates or the check is automatically triggered upon
application startup and I get a dialog notifying me that there's a new
version Y available. It has a description which says that I have
version X installed and version Y is available for download and an
HTML which list the changes up to and including version Y.
2. I leave the dialog open and continue running the application until
yet another new version Z is built and made available on our servers.
3. Then I check for updates once again.

After step 3, I'd expect to have the dialog opened in step 1 to update
its texts i.e. the description should say that I have version X
installed and version Z is available for download and the HTML should
list the changes up to and including version Z. Do you think it will
work like that with your patch?

Regards,
Lyubomir

···

On Sat, Dec 18, 2010 at 4:13 PM, Abdur Rauf Rajar <raufrajar@gmail.com> wrote:

I have attached a patch to fix issue # 889.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hi Lyubomir,

I have attached a new patch which takes care of the scenario
you described. This patch updates the information on dialog
each time user tries to check for update (automatically or
manually).

I did not implemented it first time because I thought it was
very unlikely to occur.

And thanks for your time. I will try to contribute more.

Regards.

UpdateCheckActivatorPlugin_new.patch (2.21 KB)

···

--
Abdur Rauf Rajar

BS Computer Science
School of Science and Engineering (SSE)
Lahore University of Management Sciences (LUMS)
Opposite Sector U, DHA, Lahore Cantt.