Hi
Attached are the patches to fix issue #759.
https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=759.
ContactListFilterContextMenu_resources.patch (666 Bytes)
ContactListFilterContextMenu_MainFrame.patch (2.64 KB)
ContactListFilterContextMenu_RightButtonMenu.patch (5.52 KB)
--
Cheers,
Aki <http://akash.zxq.net>
Hi
Did anybody look into these patches?
I was just wondering if they are correct.
On Wed, Dec 22, 2010 at 4:56 PM, Akash Nawani <akash.nawani@gmail.com>wrote:
Hi
Attached are the patches to fix issue #759.
https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=759.--
Cheers,
Aki <http://akash.zxq.net>
--
Cheers,
Aki <http://akash.zxq.net>
Hello Aki,
I'm sorry I couldn't get back to you with a response sooner.
Thank you for your contribution! The patches look good. However, I
think we can do better in the following areas:
- Don't modify MainFrame because (1) its complicated enough as it is
and (2) the context menu of SearchField concerns it alone.
- Use setComponentPopupMenu of the SearchField to set a JPopupMenu,
don't install a mouse listener to intercept the right-button click.
- Don't create a specific class for the context menu, write a method
in the SearchField which builds a plain JPopupMenu.
Regards,
Lyubomir
On Wed, Jan 5, 2011 at 12:37 PM, Akash Nawani <akash.nawani@gmail.com> wrote:
Attached are the patches to fix issue
#759. https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=759.
Hi Lyubomir
Here are the new patches to make it better 
ContactListFilterContextMenu_SearchField.patch (4.99 KB)
ContactListFilterContextMenu_resources.patch (666 Bytes)
On Thu, Jan 27, 2011 at 12:34 AM, Lyubomir Marinov < lubo@sip-communicator.org> wrote:
On Wed, Jan 5, 2011 at 12:37 PM, Akash Nawani <akash.nawani@gmail.com> > wrote:
>> Attached are the patches to fix issue
>> #759. https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=759.Hello Aki,
I'm sorry I couldn't get back to you with a response sooner.
Thank you for your contribution! The patches look good. However, I
think we can do better in the following areas:- Don't modify MainFrame because (1) its complicated enough as it is
and (2) the context menu of SearchField concerns it alone.- Use setComponentPopupMenu of the SearchField to set a JPopupMenu,
don't install a mouse listener to intercept the right-button click.- Don't create a specific class for the context menu, write a method
in the SearchField which builds a plain JPopupMenu.Regards,
Lyubomir
--
Cheers,
Aki <http://akash.zxq.net>