This patch fixes the following issues:
* while in the dial panel, it was possible to place a call with an
empty call combo box
* while in another panel than contact list, call or call list panels,
pressing the call button did nothing
But there is still this one:
* while in the call list panel, once an item is selected in the
results list, it is impossible to place a call by typing in the call
Of course, this last issue could be solved by modifying
CallComboBox.java to make it clear the selection of the results list
of the call list panel (like it has already been done to clear the
selection of the contact list). However, I don't think it's the job of
the CallComboBox to check if any panel has chosen to supersede its
default action (which is calling the identifier typed in its editor).
We could rather make the user selection in the contact list or the
call list replace the call combo box editor's text (i.e. if you select
the metacontact "John Doe", "sip:email@example.com" - or whatever
his first callable identifier is - appears in the call combo box).
That way, the action performed after clicking the call button would be
more obvious to the user (the call button would always call the call
combo box editor's text). Currently, if you type a few letters in the
call combo box and then select a metacontact, the action performed
after clicking the call button is ambiguous for the user.
What do you think of that?
call_manager_fixes.patch (4.3 KB)