[sip-comm-dev] [Patch] Fix a few issues with the call manager


#1

Hi,

This patch fixes the following issues:
* while in the dial panel, it was possible to place a call with an
empty call combo box
* while in another panel than contact list, call or call list panels,
pressing the call button did nothing

But there is still this one:
* while in the call list panel, once an item is selected in the
results list, it is impossible to place a call by typing in the call
combo box

Of course, this last issue could be solved by modifying
CallComboBox.java to make it clear the selection of the results list
of the call list panel (like it has already been done to clear the
selection of the contact list). However, I don't think it's the job of
the CallComboBox to check if any panel has chosen to supersede its
default action (which is calling the identifier typed in its editor).
We could rather make the user selection in the contact list or the
call list replace the call combo box editor's text (i.e. if you select
the metacontact "John Doe", "sip:john.doe@provider.tld" - or whatever
his first callable identifier is - appears in the call combo box).
That way, the action performed after clicking the call button would be
more obvious to the user (the call button would always call the call
combo box editor's text). Currently, if you type a few letters in the
call combo box and then select a metacontact, the action performed
after clicking the call button is ambiguous for the user.

What do you think of that?

Cheers,

call_manager_fixes.patch (4.3 KB)

···

--
Sébastien Mazy


#2

Could someone have a look at this patch?

···

On Tue, Aug 12, 2008 at 1:57 AM, Sébastien Mazy <sebastien.mazy@insa-lyon.fr> wrote:

This patch fixes the following issues:
* while in the dial panel, it was possible to place a call with an
empty call combo box
* while in another panel than contact list, call or call list panels,
pressing the call button did nothing

--
Sébastien Mazy


#3

Hi Sébastien,

Could someone have a look at this patch?

I'm not one of the developers so I can't do anything official about it, but I thought I'd test out your patch. It looks like you made some good changes. Seems to work fine :slight_smile:

But there is still this one:
* while in the call list panel, once an item is selected in the
results list, it is impossible to place a call by typing in the call
combo box.

We could rather make the user selection in the contact list or
the call list replace the call combo box editor's text

That would be an excellent solution in my opinion, I also noticed some of these problems and was going to suggest the same thing.

Alan

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi Sebastien,

sorry for the late reply. Your patch looks very good! However we're in the middle of big modifications in the call gui and this could take some time (not more than a week). I'll make sure that we include your improvements in the new code.

Thanks!
Yana

Sébastien Mazy wrote:

···

On Tue, Aug 12, 2008 at 1:57 AM, Sébastien Mazy > <sebastien.mazy@insa-lyon.fr> wrote:

This patch fixes the following issues:
* while in the dial panel, it was possible to place a call with an
empty call combo box
* while in another panel than contact list, call or call list panels,
pressing the call button did nothing

Could someone have a look at this patch?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi Yana,

···

On Mon, Aug 25, 2008 at 2:09 PM, Yana Stamcheva <yana@sip-communicator.org> wrote:

sorry for the late reply. Your patch looks very good! However we're in the
middle of big modifications in the call gui and this could take some time
(not more than a week). I'll make sure that we include your improvements in
the new code.

Thanks! I'm looking forward the new GUI :slight_smile:

Cheers,

--
Sébastien Mazy