[sip-comm-dev] [PATCH] enhance build.xml to honor CPU srchitecture


#1

All,

attached a patch that inserts a check for the CPU architecture when
running on a Linux system and sets the native ld path to the correct
value. I've done this for Linux only, IMHO this should be done
for other systems as well. Some nasty error messages and exceptions
are gone now and SC is now in the sys tray.

Regards,
Werner

build-arch-patch.txt (884 Bytes)


#2

Applied, committed and ACK-ed.

Thanks Werner!

Emil

Werner Dittmann написа:

···

All,

attached a patch that inserts a check for the CPU architecture when
running on a Linux system and sets the native ld path to the correct
value. I've done this for Linux only, IMHO this should be done
for other systems as well. Some nasty error messages and exceptions
are gone now and SC is now in the sys tray.

Regards,
Werner

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hey Werner,

a quick note:

Werner Dittmann написа:

     <condition property="ld.library.path"
               value="\{lib\}/native/linux:{system.LD_LIBRARY_PATH}">
- <isset property="is.running.linux"/>
+ <and>
+ <isset property="is.running.linux"/>
+ <os arch="x86" />
+ </and>
+ </condition>

It turns out that (at least on my box) os.arch is "i386". I wasn't
seeing the systray as a result so I thought that it would probably be a
good idea to have a default value for the ld lib path property.

I've therefore removed the arch condition from this one and moved the
whole <condition> block underneath the amd64 one.

Could you please let me know if it still works for you?

Cheers
Emil

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Emil,

thanks for the fix - works on my AMD64 system.

Regards,
Werner

Emil Ivov schrieb:

···

Hey Werner,

a quick note:

Werner Dittmann написа:

     <condition property="ld.library.path"
               value="${lib}/native/linux:${system.LD_LIBRARY_PATH}">
- <isset property="is.running.linux"/>
+ <and>
+ <isset property="is.running.linux"/>
+ <os arch="x86" />
+ </and>
+ </condition>

It turns out that (at least on my box) os.arch is "i386". I wasn't
seeing the systray as a result so I thought that it would probably be a
good idea to have a default value for the ld lib path property.

I've therefore removed the arch condition from this one and moved the
whole <condition> block underneath the amd64 one.

Could you please let me know if it still works for you?

Cheers
Emil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net