[sip-comm-dev] [Patch] Dict Protocol and Account Wizard translation


#1

Hi,

This patch upgrade the dict protocol and the dict account wizard. News :
- Abstraction of the dict return code
- Rename the default contact
- Integration of the translation system
- French translation
- Correction of the error with the new account wizard (blank text).

Others corrections :
- French translation : Paramêtre -> Paramètre

Now, I will make a little update to the account wizard for the
protocol : split the current form into a simple form and an advanced
form.
And adding a method to disable the advanced button if there isn't any
advanced form.

@+

Damien

dict-protocol.patch (25.8 KB)


#2

Hello,

This is a upgrade of the last patch.
I've split the current dict account form into a simple and an advanced form.
And I've updated the new account dialog and the wizard page interface
to (dis)enable the advanced button.

I've reported the new method to all the others protocols accounts wizards.

Bye

Damien

dict-protocol.patch (36.6 KB)

···

2008/7/22 Damien Roth <damien.roth@gmail.com>:

Hi,

This patch upgrade the dict protocol and the dict account wizard. News :
- Abstraction of the dict return code
- Rename the default contact
- Integration of the translation system
- French translation
- Correction of the error with the new account wizard (blank text).

Others corrections :
- French translation : Paramêtre -> Paramètre

Now, I will make a little update to the account wizard for the
protocol : split the current form into a simple form and an advanced
form.
And adding a method to disable the advanced button if there isn't any
advanced form.

@+

Damien

--
Damien ROTH
Programmeur n.m : Celui qui résout un problème que vous n'aviez pas,
d'une façon que vous ne comprenez pas.


#3

Hi Damian,

nice patch!

There's something that caught my attention though and before applying the patch I wanted to discuss this with you.

In the AccountRegistrationWizard interface you've introduced a method called: boolean hasAdvancedForm(), which is used by the NewAccountDialog to detect if it should enable the "Advanced" button for the given protocol. However this bothers me a little, because the advanced form is actually the wizard itself and if one has implemented the AccountRegistrationWizard interface then he's making the advanced form.

Actually, I understand why this can be confusing. Normally, you'll be expecting to have to implement a SimpleForm interface and to have the advanced interface as an option. What we're doing there with the AccountRegistrationWizard and the getSimpleForm() method is exactly the inverse. I agree this is not the right way to manage account registration forms, but this was the easiest way to introduce the simple registration form without rewriting all account registration plugins. What I suggest is to keep it as it is for now and create an issue that would bring the question later on and we could modify the whole concept.

Cheers,
Yana

Damien Roth wrote:

···

Hello,

This is a upgrade of the last patch.
I've split the current dict account form into a simple and an advanced form.
And I've updated the new account dialog and the wizard page interface
to (dis)enable the advanced button.

I've reported the new method to all the others protocols accounts wizards.

Bye

Damien

2008/7/22 Damien Roth <damien.roth@gmail.com>:

Hi,

This patch upgrade the dict protocol and the dict account wizard. News :
- Abstraction of the dict return code
- Rename the default contact
- Integration of the translation system
- French translation
- Correction of the error with the new account wizard (blank text).

Others corrections :
- French translation : Param�tre -> Param�tre

Now, I will make a little update to the account wizard for the
protocol : split the current form into a simple form and an advanced
form.
And adding a method to disable the advanced button if there isn't any
advanced form.

@+

Damien

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hello Yana,

Actually, I understand why this can be confusing. Normally, you'll be
expecting to have to implement a SimpleForm interface and to have the
advanced interface as an option. What we're doing there with the
AccountRegistrationWizard and the getSimpleForm() method is exactly the
inverse. I agree this is not the right way to manage account registration
forms, but this was the easiest way to introduce the simple registration
form without rewriting all account registration plugins. What I suggest is
to keep it as it is for now and create an issue that would bring the
question later on and we could modify the whole concept.

Ok, I understand why, let's keep it in mind for the next version.

I've attached a version without the method, it contains :
- a little correction for the French translation: Paramêtre -> Paramètre
- the internationalization of the Dict protocol

Since I don't have the commit access yet, can you apply it ?

Bye

Damien

dict-translation.patch (32.9 KB)