[sip-comm-dev] [PATCH] AddContactWizard : disable back button when on first page


#1

Hi,
this patch disable the "back" button of the add contact wizard when
displaying the first page since it does nothing (and have nothing to do)

Matthieu

Disable_back_button_when_showing_the_first_page_of_the_wizard.patch (1.05 KB)


#2

Hi Matthieu,

thanks for pointing this out !! It should be fixed now (r6767).

Some more details here. Normally the WizardController distinguishes whether the back button is enabled depending on the "back page identifier" of each wizard page and the problem here was that the add contact wizard was not returning the correct back page identifier. Thus I wasn't able to use your patch, but it is fixed now and it allowed me also to notice the incorrect use of DEFAULT_PAGE_IDENTIFIER in all other wizards, which were using it instead of just returning null in order to indicate a non existing back page identifier.

Thanks again!

Cheers,
Yana

···

On Feb 16, 2010, at 11:11 AM, Matthieu Casanova wrote:

Hi,
this patch disable the "back" button of the add contact wizard when displaying the first page since it does nothing (and have nothing to do)

Matthieu
<Disable_back_button_when_showing_the_first_page_of_the_wizard.patch>---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Oh ok thank you for fixing that, I was not sure my solution was good in fact

Matthieu

···

2010/2/16 Yana Stamcheva <yana@sip-communicator.org>

Hi Matthieu,

thanks for pointing this out !! It should be fixed now (r6767).

Some more details here. Normally the WizardController distinguishes whether
the back button is enabled depending on the "back page identifier" of each
wizard page and the problem here was that the add contact wizard was not
returning the correct back page identifier. Thus I wasn't able to use your
patch, but it is fixed now and it allowed me also to notice the incorrect
use of DEFAULT_PAGE_IDENTIFIER in all other wizards, which were using it
instead of just returning null in order to indicate a non existing back page
identifier.

Thanks again!

Cheers,
Yana

On Feb 16, 2010, at 11:11 AM, Matthieu Casanova wrote:

> Hi,
> this patch disable the "back" button of the add contact wizard when
displaying the first page since it does nothing (and have nothing to do)
>
> Matthieu
>
<Disable_back_button_when_showing_the_first_page_of_the_wizard.patch>---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net