[sip-comm-dev] OTR Vol.2 Patch


#1

Hello all,

This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
because of the java.net maintenance downtime. It accumulates all of the
changes since the first patch which mostly consists of the GUI
implementation, otr4j improvements and JUnit testing.

otr_vol2.patch.zip (20.9 KB)

···

-

Among the various UI options, there is an option to globally disable OTR, to
do that you have to uncheck the "Options > Otr Configuration > Enable
Private Messaging" checkbox.

As said, I will continue to maintain the plugin and I look forward to
provide updates, solve possible problems and have fruitful discussions with
the rest of the community :slight_smile:


#2

George,

thanks for the patch - I'll take care of it tomorrow and integrate it with
trunk. After the test I'll give you feedback and chek it in.

Regards,
Werner

Geekius Caesar schrieb:

···

Hello all,

This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
because of the java.net maintenance downtime. It accumulates all of the
changes since the first patch which mostly consists of the GUI
implementation, otr4j improvements and JUnit testing.

-

Among the various UI options, there is an option to globally disable OTR, to
do that you have to uncheck the "Options > Otr Configuration > Enable
Private Messaging" checkbox.

As said, I will continue to maintain the plugin and I look forward to
provide updates, solve possible problems and have fruitful discussions with
the rest of the community :slight_smile:

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

George, all,

after integrating George's patch here a short summary:

- applying the went very smooth, no error messages, warning - well done.
- copied the new images which were not contained in the patch (it's not
  possible with the patch mechanism)
- started the tests - also went very well and fairly smooth.

Test setup: all local, using SC and Pidgin with OTR plugin, openfire server,
            at SC I disabled the "automatic OTR"

Test report:

- OTR mode and non-OTR mode work well, checked with wireshark
- starting OTR from SC and Pidgin works
- ending OTR also works
- Menus, images are ok, also the images display when the status
  changes

Some minor glitches:
- when in OTR mode and the partner goes offline (exiting Pidgin) then
  SC reports this but OTR mode stays "enabled". After I started pidgin
  again without OTR enabled and send a message then SC reports
  "unencrypted message received". Wouldn't it make sense to switch off
  OTR mode if the partner goes offline?

- some exceptions from configuration service popped up regarding illegal
  XML character (see attachement). IMHO this is not specific to OTR
  but it seems a generic problem (see the very last exception in the
  attachement).

Question to George:
- the previous version was much more "chatty" when switching OTR mode on
  or off, very similar to the pidgin OTR plugin. Did you disable this or
  did I miss something in the configuration?

Because the tests were ok so far I'm going to commit it after some cleanup
of my sandbox here.

Regards,
Werner

Geekius Caesar schrieb:

otr-test.txt (86.7 KB)

···

Hello all,

This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
because of the java.net maintenance downtime. It accumulates all of the
changes since the first patch which mostly consists of the GUI
implementation, otr4j improvements and JUnit testing.

-

Among the various UI options, there is an option to globally disable OTR, to
do that you have to uncheck the "Options > Otr Configuration > Enable
Private Messaging" checkbox.

As said, I will continue to maintain the plugin and I look forward to
provide updates, solve possible problems and have fruitful discussions with
the rest of the community :slight_smile:

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

George,

in your code for ScOtrEngineImpl you use a class that is available
since Java 6 and is not available in Java 5. Because CuriseControl builds SC
with Java 5 the compilation fails.

Can you give me some quick fix for this?

Regards,
Werner

Geekius Caesar schrieb:

···

Hello all,

This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
because of the java.net maintenance downtime. It accumulates all of the
changes since the first patch which mostly consists of the GUI
implementation, otr4j improvements and JUnit testing.

-

Among the various UI options, there is an option to globally disable OTR, to
do that you have to uncheck the "Options > Otr Configuration > Enable
Private Messaging" checkbox.

As said, I will continue to maintain the plugin and I look forward to
provide updates, solve possible problems and have fruitful discussions with
the rest of the community :slight_smile:

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Great! Thank you :slight_smile:

···

On Tue, Aug 25, 2009 at 5:44 PM, Werner Dittmann < Werner.Dittmann@t-online.de> wrote:

George,

thanks for the patch - I'll take care of it tomorrow and integrate it with
trunk. After the test I'll give you feedback and chek it in.

Regards,
Werner

Geekius Caesar schrieb:
> Hello all,
>
> This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
> because of the java.net maintenance downtime. It accumulates all of the
> changes since the first patch which mostly consists of the GUI
> implementation, otr4j improvements and JUnit testing.
>
> -
>
> Among the various UI options, there is an option to globally disable OTR,
to
> do that you have to uncheck the "Options > Otr Configuration > Enable
> Private Messaging" checkbox.
>
> As said, I will continue to maintain the plugin and I look forward to
> provide updates, solve possible problems and have fruitful discussions
with
> the rest of the community :slight_smile:
>
>
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

All,

I defer the commit of George's patch until we have a successful build
again. Who can fix the build problem?

Regards,
Werner

Werner Dittmann schrieb:

···

George, all,

after integrating George's patch here a short summary:

- applying the went very smooth, no error messages, warning - well done.
- copied the new images which were not contained in the patch (it's not
  possible with the patch mechanism)
- started the tests - also went very well and fairly smooth.

Test setup: all local, using SC and Pidgin with OTR plugin, openfire server,
            at SC I disabled the "automatic OTR"

Test report:

- OTR mode and non-OTR mode work well, checked with wireshark
- starting OTR from SC and Pidgin works
- ending OTR also works
- Menus, images are ok, also the images display when the status
  changes

Some minor glitches:
- when in OTR mode and the partner goes offline (exiting Pidgin) then
  SC reports this but OTR mode stays "enabled". After I started pidgin
  again without OTR enabled and send a message then SC reports
  "unencrypted message received". Wouldn't it make sense to switch off
  OTR mode if the partner goes offline?

- some exceptions from configuration service popped up regarding illegal
  XML character (see attachement). IMHO this is not specific to OTR
  but it seems a generic problem (see the very last exception in the
  attachement).

Question to George:
- the previous version was much more "chatty" when switching OTR mode on
  or off, very similar to the pidgin OTR plugin. Did you disable this or
  did I miss something in the configuration?

Because the tests were ok so far I'm going to commit it after some cleanup
of my sandbox here.

Regards,
Werner

Geekius Caesar schrieb:

Hello all,

This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
because of the java.net maintenance downtime. It accumulates all of the
changes since the first patch which mostly consists of the GUI
implementation, otr4j improvements and JUnit testing.

-

Among the various UI options, there is an option to globally disable OTR, to
do that you have to uncheck the "Options > Otr Configuration > Enable
Private Messaging" checkbox.

As said, I will continue to maintain the plugin and I look forward to
provide updates, solve possible problems and have fruitful discussions with
the rest of the community :slight_smile:

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hmm.. what class would that be? java.awt.Desktop maybe? There was a
compatibility-like setting in Eclipse that I'm looking for so I can
pin down those issues my self..

···

On Wed, Aug 26, 2009 at 1:29 PM, Werner Dittmann<Werner.Dittmann@t-online.de> wrote:

George,

in your code for ScOtrEngineImpl you use a class that is available
since Java 6 and is not available in Java 5. Because CuriseControl builds SC
with Java 5 the compilation fails.

Can you give me some quick fix for this?

Regards,
Werner

Geekius Caesar schrieb:

Hello all,

This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
because of the java.net maintenance downtime. It accumulates all of the
changes since the first patch which mostly consists of the GUI
implementation, otr4j improvements and JUnit testing.

-

Among the various UI options, there is an option to globally disable OTR, to
do that you have to uncheck the "Options > Otr Configuration > Enable
Private Messaging" checkbox.

As said, I will continue to maintain the plugin and I look forward to
provide updates, solve possible problems and have fruitful discussions with
the rest of the community :slight_smile:

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Some minor glitches:
- when in OTR mode and the partner goes offline (exiting Pidgin) then
SC reports this but OTR mode stays "enabled". After I started pidgin
again without OTR enabled and send a message then SC reports
"unencrypted message received". Wouldn't it make sense to switch off
OTR mode if the partner goes offline?

It makes perfect sense to end a private conversation if the partner
goes offline since his/her OTR state is lost when he/she goes offline.

- some exceptions from configuration service popped up regarding illegal
XML character (see attachement). IMHO this is not specific to OTR
but it seems a generic problem (see the very last exception in the
attachement).

I encode XMLEncode any settings prior to saving for that exact reason,
I will further investigate this.

Question to George:
- the previous version was much more "chatty" when switching OTR mode on
or off, very similar to the pidgin OTR plugin. Did you disable this or
did I miss something in the configuration?

How much chatty the client should be depends on the OTR policy. In
order to automatically establish encrypted sessions one has to enable
the "Automatically initiate private sessions" option which is
available both as a per contact and as a global option. The other
party client has to be configured similarly.

···

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#9

Hi George,

Your patch (and the previous version that is currently committed to the
trunk) is missing the image files for this plugin, so I'm getting an error
when the bundle is loaded. I'm guessing this is an issue with how you
created your patch files--any binary data are not being included.

-Alan

···

On Tue, Aug 25, 2009 at 11:54 AM, Geekius Caesar <geekius.caesar@gmail.com>wrote:

Great! Thank you :slight_smile:

On Tue, Aug 25, 2009 at 5:44 PM, Werner Dittmann < > Werner.Dittmann@t-online.de> wrote:

George,

thanks for the patch - I'll take care of it tomorrow and integrate it with
trunk. After the test I'll give you feedback and chek it in.

Regards,
Werner

Geekius Caesar schrieb:
> Hello all,
>
> This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
> because of the java.net maintenance downtime. It accumulates all of the
> changes since the first patch which mostly consists of the GUI
> implementation, otr4j improvements and JUnit testing.
>
> -
>
> Among the various UI options, there is an option to globally disable
OTR, to
> do that you have to uncheck the "Options > Otr Configuration > Enable
> Private Messaging" checkbox.
>
> As said, I will continue to maintain the plugin and I look forward to
> provide updates, solve possible problems and have fruitful discussions
with
> the rest of the community :slight_smile:
>
>
>
> ------------------------------------------------------------------------
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#10

Allan,

it works on my system. However. I'll crosscheck that the images
are really copied over to trunk and committed.

Regards,
Werner

Alan Kelly schrieb:

···

Hi George,

Your patch (and the previous version that is currently committed to the
trunk) is missing the image files for this plugin, so I'm getting an error
when the bundle is loaded. I'm guessing this is an issue with how you
created your patch files--any binary data are not being included.

-Alan

On Tue, Aug 25, 2009 at 11:54 AM, Geekius Caesar > <geekius.caesar@gmail.com>wrote:

Great! Thank you :slight_smile:

On Tue, Aug 25, 2009 at 5:44 PM, Werner Dittmann < >> Werner.Dittmann@t-online.de> wrote:

George,

thanks for the patch - I'll take care of it tomorrow and integrate it with
trunk. After the test I'll give you feedback and chek it in.

Regards,
Werner

Geekius Caesar schrieb:

Hello all,

This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
because of the java.net maintenance downtime. It accumulates all of the
changes since the first patch which mostly consists of the GUI
implementation, otr4j improvements and JUnit testing.

-

Among the various UI options, there is an option to globally disable

OTR, to

do that you have to uncheck the "Options > Otr Configuration > Enable
Private Messaging" checkbox.

As said, I will continue to maintain the plugin and I look forward to
provide updates, solve possible problems and have fruitful discussions

with

the rest of the community :slight_smile:

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#11

Hi,

lately sendAndRecieve test for filetransfer of jabber protocol was failing. I've just found the problem and commited a fix. It was that the filetransfer two quickly goes in completed state and doesn't goes through inProgress state.

But now another test failed :frowning: (this one doesn't fail on my dev machine). I will take a look again.

damencho

Werner Dittmann wrote:

···

All,

I defer the commit of George's patch until we have a successful build
again. Who can fix the build problem?

Regards,
Werner

Werner Dittmann schrieb:
  

George, all,

after integrating George's patch here a short summary:

- applying the went very smooth, no error messages, warning - well done.
- copied the new images which were not contained in the patch (it's not
  possible with the patch mechanism)
- started the tests - also went very well and fairly smooth.

Test setup: all local, using SC and Pidgin with OTR plugin, openfire server,
            at SC I disabled the "automatic OTR"

Test report:

- OTR mode and non-OTR mode work well, checked with wireshark
- starting OTR from SC and Pidgin works
- ending OTR also works
- Menus, images are ok, also the images display when the status
  changes

Some minor glitches:
- when in OTR mode and the partner goes offline (exiting Pidgin) then
  SC reports this but OTR mode stays "enabled". After I started pidgin
  again without OTR enabled and send a message then SC reports
  "unencrypted message received". Wouldn't it make sense to switch off
  OTR mode if the partner goes offline?

- some exceptions from configuration service popped up regarding illegal
  XML character (see attachement). IMHO this is not specific to OTR
  but it seems a generic problem (see the very last exception in the
  attachement).

Question to George:
- the previous version was much more "chatty" when switching OTR mode on
  or off, very similar to the pidgin OTR plugin. Did you disable this or
  did I miss something in the configuration?

Because the tests were ok so far I'm going to commit it after some cleanup
of my sandbox here.

Regards,
Werner

Geekius Caesar schrieb:
    

Hello all,

This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
because of the java.net maintenance downtime. It accumulates all of the
changes since the first patch which mostly consists of the GUI
implementation, otr4j improvements and JUnit testing.

-

Among the various UI options, there is an option to globally disable OTR, to
do that you have to uncheck the "Options > Otr Configuration > Enable
Private Messaging" checkbox.

As said, I will continue to maintain the plugin and I look forward to
provide updates, solve possible problems and have fruitful discussions with
the rest of the community :slight_smile:

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
      

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
    
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#12

The javadoc of java.swt.Desktop specifies that the class is indeed
available since 1.6.

Regardless of its availability, I think the BrowserLauncherService is
to used there anyway because the goal in the code in question seems to
be to open an URL and BrowserLauncherService is dedicated to that
purpose.

···

On Wed, Aug 26, 2009 at 3:57 PM, Geekius Caesar <geekius.caesar@gmail.com> wrote:

Hmm.. what class would that be? java.awt.Desktop maybe? There was a
compatibility-like setting in Eclipse that I'm looking for so I can
pin down those issues my self..

On Wed, Aug 26, 2009 at 1:29 PM, Werner > Dittmann<Werner.Dittmann@t-online.de> wrote:
> George,
>
> in your code for ScOtrEngineImpl you use a class that is available
> since Java 6 and is not available in Java 5. Because CuriseControl builds SC
> with Java 5 the compilation fails.
>
> Can you give me some quick fix for this?
>
> Regards,
> Werner
>
>
> Geekius Caesar schrieb:
>> Hello all,
>>
>> This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
>> because of the java.net maintenance downtime. It accumulates all of the
>> changes since the first patch which mostly consists of the GUI
>> implementation, otr4j improvements and JUnit testing.
>>
>> -
>>
>> Among the various UI options, there is an option to globally disable OTR, to
>> do that you have to uncheck the "Options > Otr Configuration > Enable
>> Private Messaging" checkbox.
>>
>> As said, I will continue to maintain the plugin and I look forward to
>> provide updates, solve possible problems and have fruitful discussions with
>> the rest of the community :slight_smile:

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#13

George,

maybe you hit the same trap as I did - the Eclipse compatibility
mode is just for the compiler, not for the installed libs AFAIK.

I've Java 6 installations on my systems but I can switch Eclipse
(and the Java compiler) to check against Java 5 compliant source.
However, it does not check for classes in the libraries if they are
Java 6 or Java 5 only.

Regards,
Werner

Geekius Caesar schrieb:

···

Hmm.. what class would that be? java.awt.Desktop maybe? There was a
compatibility-like setting in Eclipse that I'm looking for so I can
pin down those issues my self..

On Wed, Aug 26, 2009 at 1:29 PM, Werner > Dittmann<Werner.Dittmann@t-online.de> wrote:

George,

in your code for ScOtrEngineImpl you use a class that is available
since Java 6 and is not available in Java 5. Because CuriseControl builds SC
with Java 5 the compilation fails.

Can you give me some quick fix for this?

Regards,
Werner

Geekius Caesar schrieb:

Hello all,

This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
because of the java.net maintenance downtime. It accumulates all of the
changes since the first patch which mostly consists of the GUI
implementation, otr4j improvements and JUnit testing.

-

Among the various UI options, there is an option to globally disable OTR, to
do that you have to uncheck the "Options > Otr Configuration > Enable
Private Messaging" checkbox.

As said, I will continue to maintain the plugin and I look forward to
provide updates, solve possible problems and have fruitful discussions with
the rest of the community :slight_smile:

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#14

Hello Alan,

As far as I know there is no way to get SVN to include binary data in a diff
(patch), but I'm not an SVN expert so maybe I'm missing something here :>

···

On Wed, Aug 26, 2009 at 8:37 AM, Werner Dittmann < Werner.Dittmann@t-online.de> wrote:

Allan,

it works on my system. However. I'll crosscheck that the images
are really copied over to trunk and committed.

Regards,
Werner

Alan Kelly schrieb:
> Hi George,
>
> Your patch (and the previous version that is currently committed to the
> trunk) is missing the image files for this plugin, so I'm getting an
error
> when the bundle is loaded. I'm guessing this is an issue with how you
> created your patch files--any binary data are not being included.
>
> -Alan
>
> On Tue, Aug 25, 2009 at 11:54 AM, Geekius Caesar > > <geekius.caesar@gmail.com>wrote:
>
>> Great! Thank you :slight_smile:
>>
>>
>> On Tue, Aug 25, 2009 at 5:44 PM, Werner Dittmann < > >> Werner.Dittmann@t-online.de> wrote:
>>
>>> George,
>>>
>>> thanks for the patch - I'll take care of it tomorrow and integrate it
with
>>> trunk. After the test I'll give you feedback and chek it in.
>>>
>>> Regards,
>>> Werner
>>>
>>> Geekius Caesar schrieb:
>>>> Hello all,
>>>>
>>>> This is OTR Vol.2 Patch, I hadn't had the chance to create it
yesterday
>>>> because of the java.net maintenance downtime. It accumulates all of
the
>>>> changes since the first patch which mostly consists of the GUI
>>>> implementation, otr4j improvements and JUnit testing.
>>>>
>>>> -
>>>>
>>>> Among the various UI options, there is an option to globally disable
>>> OTR, to
>>>> do that you have to uncheck the "Options > Otr Configuration > Enable
>>>> Private Messaging" checkbox.
>>>>
>>>> As said, I will continue to maintain the plugin and I look forward to
>>>> provide updates, solve possible problems and have fruitful discussions
>>> with
>>>> the rest of the community :slight_smile:
>>>>
>>>>
>>>>
>>>>
------------------------------------------------------------------------
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
>>>> For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
>>> For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
>>>
>>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#15

Its fixed now :slight_smile:

Damian Minkov wrote:

···

Hi,

lately sendAndRecieve test for filetransfer of jabber protocol was failing. I've just found the problem and commited a fix. It was that the filetransfer two quickly goes in completed state and doesn't goes through inProgress state.

But now another test failed :frowning: (this one doesn't fail on my dev machine). I will take a look again.

damencho

Werner Dittmann wrote:

All,

I defer the commit of George's patch until we have a successful build
again. Who can fix the build problem?

Regards,
Werner

Werner Dittmann schrieb:

George, all,

after integrating George's patch here a short summary:

- applying the went very smooth, no error messages, warning - well done.
- copied the new images which were not contained in the patch (it's not
  possible with the patch mechanism)
- started the tests - also went very well and fairly smooth.

Test setup: all local, using SC and Pidgin with OTR plugin, openfire server,
            at SC I disabled the "automatic OTR"

Test report:

- OTR mode and non-OTR mode work well, checked with wireshark
- starting OTR from SC and Pidgin works
- ending OTR also works
- Menus, images are ok, also the images display when the status
  changes

Some minor glitches:
- when in OTR mode and the partner goes offline (exiting Pidgin) then
  SC reports this but OTR mode stays "enabled". After I started pidgin
  again without OTR enabled and send a message then SC reports
  "unencrypted message received". Wouldn't it make sense to switch off
  OTR mode if the partner goes offline?

- some exceptions from configuration service popped up regarding illegal
  XML character (see attachement). IMHO this is not specific to OTR
  but it seems a generic problem (see the very last exception in the
  attachement).

Question to George:
- the previous version was much more "chatty" when switching OTR mode on
  or off, very similar to the pidgin OTR plugin. Did you disable this or
  did I miss something in the configuration?

Because the tests were ok so far I'm going to commit it after some cleanup
of my sandbox here.

Regards,
Werner

Geekius Caesar schrieb:
   

Hello all,

This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
because of the java.net maintenance downtime. It accumulates all of the
changes since the first patch which mostly consists of the GUI
implementation, otr4j improvements and JUnit testing.

-

Among the various UI options, there is an option to globally disable OTR, to
do that you have to uncheck the "Options > Otr Configuration > Enable
Private Messaging" checkbox.

As said, I will continue to maintain the plugin and I look forward to
provide updates, solve possible problems and have fruitful discussions with
the rest of the community :slight_smile:

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
      

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
    
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#16

Then ScOtrEngineImpl.launchHelp should look like this:

<code>
ServiceReference ref = OtrActivator.bundleContext
    .getServiceReference(BrowserLauncherService.class.getName());

if (ref == null)
  return;

BrowserLauncherService service = (BrowserLauncherService)
OtrActivator.bundleContext
    .getService(ref);

service.openURL(OtrActivator.resourceService
    .getI18NString("plugin.otr.authbuddydialog.HELP_URI"));
</code>

···

On Wed, Aug 26, 2009 at 3:09 PM, Lubomir Marinov<lubomir.marinov@gmail.com> wrote:

The javadoc of java.swt.Desktop specifies that the class is indeed
available since 1.6.

Regardless of its availability, I think the BrowserLauncherService is
to used there anyway because the goal in the code in question seems to
be to open an URL and BrowserLauncherService is dedicated to that
purpose.

On Wed, Aug 26, 2009 at 3:57 PM, Geekius Caesar > <geekius.caesar@gmail.com> wrote:

Hmm.. what class would that be? java.awt.Desktop maybe? There was a
compatibility-like setting in Eclipse that I'm looking for so I can
pin down those issues my self..

On Wed, Aug 26, 2009 at 1:29 PM, Werner >> Dittmann<Werner.Dittmann@t-online.de> wrote:
> George,
>
> in your code for ScOtrEngineImpl you use a class that is available
> since Java 6 and is not available in Java 5. Because CuriseControl builds SC
> with Java 5 the compilation fails.
>
> Can you give me some quick fix for this?
>
> Regards,
> Werner
>
>
> Geekius Caesar schrieb:
>> Hello all,
>>
>> This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
>> because of the java.net maintenance downtime. It accumulates all of the
>> changes since the first patch which mostly consists of the GUI
>> implementation, otr4j improvements and JUnit testing.
>>
>> -
>>
>> Among the various UI options, there is an option to globally disable OTR, to
>> do that you have to uncheck the "Options > Otr Configuration > Enable
>> Private Messaging" checkbox.
>>
>> As said, I will continue to maintain the plugin and I look forward to
>> provide updates, solve possible problems and have fruitful discussions with
>> the rest of the community :slight_smile:

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#17

Looks good to me. Can you fix it in your OTR branch, than I do
a backport to trunk (no patch necessary because its just a few
lines).

Regards,
Werner

Geekius Caesar schrieb:

···

Then ScOtrEngineImpl.launchHelp should look like this:

<code>
ServiceReference ref = OtrActivator.bundleContext
    .getServiceReference(BrowserLauncherService.class.getName());

if (ref == null)
  return;

BrowserLauncherService service = (BrowserLauncherService)
OtrActivator.bundleContext
    .getService(ref);

service.openURL(OtrActivator.resourceService
    .getI18NString("plugin.otr.authbuddydialog.HELP_URI"));
</code>

On Wed, Aug 26, 2009 at 3:09 PM, Lubomir > Marinov<lubomir.marinov@gmail.com> wrote:

The javadoc of java.swt.Desktop specifies that the class is indeed
available since 1.6.

Regardless of its availability, I think the BrowserLauncherService is
to used there anyway because the goal in the code in question seems to
be to open an URL and BrowserLauncherService is dedicated to that
purpose.

On Wed, Aug 26, 2009 at 3:57 PM, Geekius Caesar >> <geekius.caesar@gmail.com> wrote:

Hmm.. what class would that be? java.awt.Desktop maybe? There was a
compatibility-like setting in Eclipse that I'm looking for so I can
pin down those issues my self..

On Wed, Aug 26, 2009 at 1:29 PM, Werner >>> Dittmann<Werner.Dittmann@t-online.de> wrote:

George,

in your code for ScOtrEngineImpl you use a class that is available
since Java 6 and is not available in Java 5. Because CuriseControl builds SC
with Java 5 the compilation fails.

Can you give me some quick fix for this?

Regards,
Werner

Geekius Caesar schrieb:

Hello all,

This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
because of the java.net maintenance downtime. It accumulates all of the
changes since the first patch which mostly consists of the GUI
implementation, otr4j improvements and JUnit testing.

-

Among the various UI options, there is an option to globally disable OTR, to
do that you have to uncheck the "Options > Otr Configuration > Enable
Private Messaging" checkbox.

As said, I will continue to maintain the plugin and I look forward to
provide updates, solve possible problems and have fruitful discussions with
the rest of the community :slight_smile:

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#18

Hi,

after yesterdays commit of OTR keybindings stopped working. It was a problem with ClassCastException in gui.
I wanted just to mention it because the problem was due to inserting, a Jmenu into gui like PluginComponent.
This is fixed now with r5868.

damencho

Werner Dittmann wrote:

···

George,

maybe you hit the same trap as I did - the Eclipse compatibility
mode is just for the compiler, not for the installed libs AFAIK.

I've Java 6 installations on my systems but I can switch Eclipse
(and the Java compiler) to check against Java 5 compliant source.
However, it does not check for classes in the libraries if they are
Java 6 or Java 5 only.

Regards,
Werner

Geekius Caesar schrieb:
  

Hmm.. what class would that be? java.awt.Desktop maybe? There was a
compatibility-like setting in Eclipse that I'm looking for so I can
pin down those issues my self..

On Wed, Aug 26, 2009 at 1:29 PM, Werner >> Dittmann<Werner.Dittmann@t-online.de> wrote:
    

George,

in your code for ScOtrEngineImpl you use a class that is available
since Java 6 and is not available in Java 5. Because CuriseControl builds SC
with Java 5 the compilation fails.

Can you give me some quick fix for this?

Regards,
Werner

Geekius Caesar schrieb:
      

Hello all,

This is OTR Vol.2 Patch, I hadn't had the chance to create it yesterday
because of the java.net maintenance downtime. It accumulates all of the
changes since the first patch which mostly consists of the GUI
implementation, otr4j improvements and JUnit testing.

-

Among the various UI options, there is an option to globally disable OTR, to
do that you have to uncheck the "Options > Otr Configuration > Enable
Private Messaging" checkbox.

As said, I will continue to maintain the plugin and I look forward to
provide updates, solve possible problems and have fruitful discussions with
the rest of the community :slight_smile:

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#19

Hi,

···

On Wed, 26 Aug 2009, Geekius Caesar wrote:

As far as I know there is no way to get SVN to include binary data in a
diff (patch), but I'm not an SVN expert so maybe I'm missing something
here :>

I think you are correct; SVN does not ship any tool to apply patches, so
it cannot extend the diff format (in contrast to Git, which can handle
binary files in diffs very well). So I think the only way to get these
binary files into SVN is to post a .zip containing them.

Ciao,
Dscho

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#20

Thanks. OTR commit is on its way. :slight_smile:

Damian Minkov schrieb:

···

Its fixed now :slight_smile:

Damian Minkov wrote:

Hi,

lately sendAndRecieve test for filetransfer of jabber protocol was
failing. I've just found the problem and commited a fix. It was that
the filetransfer two quickly goes in completed state and doesn't goes
through inProgress state.

But now another test failed :frowning: (this one doesn't fail on my dev
machine). I will take a look again.

damencho

Werner Dittmann wrote:

All,

I defer the commit of George's patch until we have a successful build
again. Who can fix the build problem?

Regards,
Werner

Werner Dittmann schrieb:

George, all,

after integrating George's patch here a short summary:

- applying the went very smooth, no error messages, warning - well
done.
- copied the new images which were not contained in the patch (it's not
  possible with the patch mechanism)
- started the tests - also went very well and fairly smooth.

Test setup: all local, using SC and Pidgin with OTR plugin, openfire
server,
            at SC I disabled the "automatic OTR"

Test report:

- OTR mode and non-OTR mode work well, checked with wireshark
- starting OTR from SC and Pidgin works
- ending OTR also works
- Menus, images are ok, also the images display when the status
  changes

Some minor glitches:
- when in OTR mode and the partner goes offline (exiting Pidgin) then
  SC reports this but OTR mode stays "enabled". After I started pidgin
  again without OTR enabled and send a message then SC reports
  "unencrypted message received". Wouldn't it make sense to switch off
  OTR mode if the partner goes offline?

- some exceptions from configuration service popped up regarding
illegal
  XML character (see attachement). IMHO this is not specific to OTR
  but it seems a generic problem (see the very last exception in the
  attachement).

Question to George:
- the previous version was much more "chatty" when switching OTR
mode on
  or off, very similar to the pidgin OTR plugin. Did you disable
this or
  did I miss something in the configuration?

Because the tests were ok so far I'm going to commit it after some
cleanup
of my sandbox here.

Regards,
Werner

Geekius Caesar schrieb:
  

Hello all,

This is OTR Vol.2 Patch, I hadn't had the chance to create it
yesterday
because of the java.net maintenance downtime. It accumulates all of
the
changes since the first patch which mostly consists of the GUI
implementation, otr4j improvements and JUnit testing.

-

Among the various UI options, there is an option to globally
disable OTR, to
do that you have to uncheck the "Options > Otr Configuration > Enable
Private Messaging" checkbox.

As said, I will continue to maintain the plugin and I look forward to
provide updates, solve possible problems and have fruitful
discussions with
the rest of the community :slight_smile:

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail:
dev-help@sip-communicator.dev.java.net
      

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
    
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net