[sip-comm-dev] online notification plugin


#1

Hi,

with some friends, we have developped a plugin to be notified when selected contacts change their status to online. That was a funny experience and because the resultat works, we submit here our code. In the attachement, you can find the sources, a little user documentation and the modified build.xmd and felix.properties for easily compile and running the plugin.

Tom

onlineNotifier.tar.gz (53.7 KB)


#2

Hi Tom,

thanks for your contribution! I saw you created an issue on the issue tracker, thanks for doing so.

We'll try to review and commit your work as soon as possible!

Thanks again,
Emil

Tom Remoleur wrote:

···

Hi,

with some friends, we have developped a plugin to be notified when selected contacts change their status to online. That was a funny experience and because the resultat works, we submit here our code. In the attachement, you can find the sources, a little user documentation and the modified build.xmd and felix.properties for easily compile and running the plugin.

Tom

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#3

Hello again Tom, all,

I haven't yet had the time to review your plugin, but I thought I'd drop you a note to let you know I haven't completely forgotten about it.

Incidentally, if anyone else finds the time to try this out, please do. I think the plugin implements nice features that would be quite handy in SIP Communicator.

Cheers
Emil

Emil Ivov wrote:

···

Hi Tom,

thanks for your contribution! I saw you created an issue on the issue tracker, thanks for doing so.

We'll try to review and commit your work as soon as possible!

Thanks again,
Emil

Tom Remoleur wrote:

Hi,

with some friends, we have developped a plugin to be notified when selected contacts change their status to online. That was a funny experience and because the resultat works, we submit here our code. In the attachement, you can find the sources, a little user documentation and the modified build.xmd and felix.properties for easily compile and running the plugin.

Tom

------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#4

Hi Bruce,

really sorry for the delay! I've missed your mail somehow:(

I've just committed your fix. Thanks!

and sorry again..
Yana

Xia, Zhi Feng (Bruce) wrote:

···

I did not get any response. Anybody taking care of code changes and bug fixes?

Thanks,
Bruce

-----Original Message-----
From: Xia, Zhi Feng (Bruce)
Sent: 2007��4��4�� 14:15
To: 'dev@sip-communicator.dev.java.net'
Cc: Tom Remoleur
Subject: RE: [sip-comm-dev] CallManager change and adding sip account issues

I added code to allow calling from dialpad. Attached the modified CallManager.java. The change is from line 261 to 267.

I'm also looking at another problems: when the configuration file has empty account and contact list, adding a sip account or contact will cause null pointer exception. I don't know if this is known issue or we already got fix?

Thanks,
Bruce

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#5

Hi Tom,

I've just created an issue for the integration of the "online notification"
plugin in the SIP Communicator. You could find it here:
https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=348.

I've started to look at the code and I hope I'll finish it these days. I'll
stay in touch with you if some questions arise or just to inform you of the
status of the issue.

Yana

···

On 3/30/07, Emil Ivov <emcho@emcho.com> wrote:

Hello again Tom, all,

I haven't yet had the time to review your plugin, but I thought I'd drop
you a note to let you know I haven't completely forgotten about it.

Incidentally, if anyone else finds the time to try this out, please do.
I think the plugin implements nice features that would be quite handy in
SIP Communicator.

Cheers
Emil

Emil Ivov wrote:
> Hi Tom,
>
> thanks for your contribution! I saw you created an issue on the issue
> tracker, thanks for doing so.
>
> We'll try to review and commit your work as soon as possible!
>
> Thanks again,
> Emil
>
> Tom Remoleur wrote:
>> Hi,
>>
>> with some friends, we have developped a plugin to be notified when
>> selected contacts change their status to online. That was a funny
>> experience and because the resultat works, we submit here our code. In
>> the attachement, you can find the sources, a little user documentation
>> and the modified build.xmd and felix.properties for easily compile and
>> running the plugin.
>>
>> Tom
>>
------------------------------------------------------------------------
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
>> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
> For additional commands, e-mail: dev-help@sip-communicator.dev.java.net
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#6

Hi Tom, All,

I've made some tests with your plugin and it's really great!!! I like the sound :slight_smile:

Before commiting it, I would like to share with you some ideas for enhancements that I had when looking on the plugin. Hope you don't mind:)

- I think we should stop the sound when user clicks "ok" on the notification window. (Right now the sound continues playing even if the user has clicked "ok" on the notification window:)
- When user changes hers state from "Free for chat" to "Online" there's no need to notify. Vice versa also.
- We could hide all the options in the settings window in "Advanced options" or "Configurations" or something like that. I think it would be more user friendly that way.
(For those of you who don't know, the configuration options appear in a separate window when user clicks on the "Add online notification" menu item right clicking on a contact. The options are the following :
    *Permanent notification
    *Save the notification when sip-com is closed
    *Play a sound when the contact connects
    *Open a popup when the contact connects)

- The plugin should implement the MetaContactListListener in order to remove notification configurations for contacts that are removed from the contact list. Otherwise we have an exception, when a permanent notification is saved in the configuration file and the contact is removed after that.
- When I saw for the first time "Permanent notification" and "Save notification when SIP-Comm is closed", I was a little confused - Isn't it the same thing. Then I read the description in the attached doc and now I see the difference. To generalize I think you've meant three cases here:

1) Notify me the next time the contact comes online
2) Notify me every time this user comes online til restart
3) Notify me always when this contact comes online

If I'm right and that's really what you meant, I propose that we delete the second option. I don't think it's worth the complexity that it brings for the user. We should also think of better titles for these options in order to facilitate the user (I'm not convinced that the ones I wrote above are the right ones).

Another last thing is that the popup could be now replaced by a systray message. I know that you have already this idea, but it wasn't possible at that time, as the systray plugin was not yet implemented.

WDYT about all these? All comments and ideas from others are also welcome!

Yana

Yana Stamcheva wrote:

···

Hi Tom,

I've just created an issue for the integration of the "online notification" plugin in the SIP Communicator. You could find it here: https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=348.

I've started to look at the code and I hope I'll finish it these days. I'll stay in touch with you if some questions arise or just to inform you of the status of the issue.

Yana

On 3/30/07, *Emil Ivov* <emcho@emcho.com <mailto:emcho@emcho.com>> wrote:

    Hello again Tom, all,

    I haven't yet had the time to review your plugin, but I thought
    I'd drop
    you a note to let you know I haven't completely forgotten about it.

    Incidentally, if anyone else finds the time to try this out,
    please do.
    I think the plugin implements nice features that would be quite
    handy in
    SIP Communicator.

    Cheers
    Emil

    Emil Ivov wrote:
    > Hi Tom,
    >
    > thanks for your contribution! I saw you created an issue on the
    issue
    > tracker, thanks for doing so.
    >
    > We'll try to review and commit your work as soon as possible!
    >
    > Thanks again,
    > Emil
    >
    > Tom Remoleur wrote:
    >> Hi,
    >>
    >> with some friends, we have developped a plugin to be notified when
    >> selected contacts change their status to online. That was a funny
    >> experience and because the resultat works, we submit here our
    code. In
    >> the attachement, you can find the sources, a little user
    documentation
    >> and the modified build.xmd and felix.properties for easily
    compile and
    >> running the plugin.
    >>
    >> Tom
    >>
    ------------------------------------------------------------------------
    >>
    ---------------------------------------------------------------------
    >> To unsubscribe, e-mail:
    dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
    >> For additional commands, e-mail:
    dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>
    >
    ---------------------------------------------------------------------
    > To unsubscribe, e-mail:
    dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
    > For additional commands, e-mail:
    dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>
    >

    ---------------------------------------------------------------------
    To unsubscribe, e-mail:
    dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
    For additional commands, e-mail:
    dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#7

Hey Yana and Tom,

Very good points Yana!

I only have one question. When you say:

1) Notify me the next time the contact comes online
2) Notify me every time this user comes online til restart
3) Notify me always when this contact comes online

If I'm right and that's really what you meant, I propose that we delete the second option. I don't think it's worth the complexity that it brings for the user. We should also think of better titles for these options in order to facilitate the user

You actually meant delete the second option and make option 1 persistent by default right?

Emil

Yana Stamcheva wrote:

···

Hi Tom, All,

I've made some tests with your plugin and it's really great!!! I like the sound :slight_smile:

Before commiting it, I would like to share with you some ideas for enhancements that I had when looking on the plugin. Hope you don't mind:)

- I think we should stop the sound when user clicks "ok" on the notification window. (Right now the sound continues playing even if the user has clicked "ok" on the notification window:)
- When user changes hers state from "Free for chat" to "Online" there's no need to notify. Vice versa also.
- We could hide all the options in the settings window in "Advanced options" or "Configurations" or something like that. I think it would be more user friendly that way.
(For those of you who don't know, the configuration options appear in a separate window when user clicks on the "Add online notification" menu item right clicking on a contact. The options are the following :
    *Permanent notification
    *Save the notification when sip-com is closed
    *Play a sound when the contact connects
    *Open a popup when the contact connects)

- The plugin should implement the MetaContactListListener in order to remove notification configurations for contacts that are removed from the contact list. Otherwise we have an exception, when a permanent notification is saved in the configuration file and the contact is removed after that.
- When I saw for the first time "Permanent notification" and "Save notification when SIP-Comm is closed", I was a little confused - Isn't it the same thing. Then I read the description in the attached doc and now I see the difference. To generalize I think you've meant three cases here:

1) Notify me the next time the contact comes online
2) Notify me every time this user comes online til restart
3) Notify me always when this contact comes online

If I'm right and that's really what you meant, I propose that we delete the second option. I don't think it's worth the complexity that it brings for the user. We should also think of better titles for these options in order to facilitate the user (I'm not convinced that the ones I wrote above are the right ones).

Another last thing is that the popup could be now replaced by a systray message. I know that you have already this idea, but it wasn't possible at that time, as the systray plugin was not yet implemented.

WDYT about all these? All comments and ideas from others are also welcome!

Yana

Yana Stamcheva wrote:

Hi Tom,

I've just created an issue for the integration of the "online notification" plugin in the SIP Communicator. You could find it here: https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=348.

I've started to look at the code and I hope I'll finish it these days. I'll stay in touch with you if some questions arise or just to inform you of the status of the issue.

Yana

On 3/30/07, *Emil Ivov* <emcho@emcho.com <mailto:emcho@emcho.com>> wrote:

    Hello again Tom, all,

    I haven't yet had the time to review your plugin, but I thought
    I'd drop
    you a note to let you know I haven't completely forgotten about it.

    Incidentally, if anyone else finds the time to try this out,
    please do.
    I think the plugin implements nice features that would be quite
    handy in
    SIP Communicator.

    Cheers
    Emil

    Emil Ivov wrote:
    > Hi Tom,
    >
    > thanks for your contribution! I saw you created an issue on the
    issue
    > tracker, thanks for doing so.
    >
    > We'll try to review and commit your work as soon as possible!
    >
    > Thanks again,
    > Emil
    >
    > Tom Remoleur wrote:
    >> Hi,
    >>
    >> with some friends, we have developped a plugin to be notified when
    >> selected contacts change their status to online. That was a funny
    >> experience and because the resultat works, we submit here our
    code. In
    >> the attachement, you can find the sources, a little user
    documentation
    >> and the modified build.xmd and felix.properties for easily
    compile and
    >> running the plugin.
    >>
    >> Tom
    >>
    ------------------------------------------------------------------------
    >>
    ---------------------------------------------------------------------
    >> To unsubscribe, e-mail:
    dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
    >> For additional commands, e-mail:
    dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>
    >
    ---------------------------------------------------------------------
    > To unsubscribe, e-mail:
    dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
    > For additional commands, e-mail:
    dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>
    >

    ---------------------------------------------------------------------
    To unsubscribe, e-mail:
    dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
    For additional commands, e-mail:
    dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net


#8

Hi Emil,
Emil Ivov wrote:

Hey Yana and Tom,

Very good points Yana!

I only have one question. When you say:

1) Notify me the next time the contact comes online
2) Notify me every time this user comes online til restart
3) Notify me always when this contact comes online

If I'm right and that's really what you meant, I propose that we delete the second option. I don't think it's worth the complexity that it brings for the user. We should also think of better titles for these options in order to facilitate the user

You actually meant delete the second option and make option 1 persistent by default right?

Yes, right. I meant that we will be notified next time the selected contact comes online (no matter if this would be before or after restarting the application).
Yana

···

Emil

Yana Stamcheva wrote:

Hi Tom, All,

I've made some tests with your plugin and it's really great!!! I like the sound :slight_smile:

Before commiting it, I would like to share with you some ideas for enhancements that I had when looking on the plugin. Hope you don't mind:)

- I think we should stop the sound when user clicks "ok" on the notification window. (Right now the sound continues playing even if the user has clicked "ok" on the notification window:)
- When user changes hers state from "Free for chat" to "Online" there's no need to notify. Vice versa also.
- We could hide all the options in the settings window in "Advanced options" or "Configurations" or something like that. I think it would be more user friendly that way.
(For those of you who don't know, the configuration options appear in a separate window when user clicks on the "Add online notification" menu item right clicking on a contact. The options are the following :
    *Permanent notification
    *Save the notification when sip-com is closed
    *Play a sound when the contact connects
    *Open a popup when the contact connects)

- The plugin should implement the MetaContactListListener in order to remove notification configurations for contacts that are removed from the contact list. Otherwise we have an exception, when a permanent notification is saved in the configuration file and the contact is removed after that.
- When I saw for the first time "Permanent notification" and "Save notification when SIP-Comm is closed", I was a little confused - Isn't it the same thing. Then I read the description in the attached doc and now I see the difference. To generalize I think you've meant three cases here:

1) Notify me the next time the contact comes online
2) Notify me every time this user comes online til restart
3) Notify me always when this contact comes online

If I'm right and that's really what you meant, I propose that we delete the second option. I don't think it's worth the complexity that it brings for the user. We should also think of better titles for these options in order to facilitate the user (I'm not convinced that the ones I wrote above are the right ones).

Another last thing is that the popup could be now replaced by a systray message. I know that you have already this idea, but it wasn't possible at that time, as the systray plugin was not yet implemented.

WDYT about all these? All comments and ideas from others are also welcome!

Yana

Yana Stamcheva wrote:

Hi Tom,

I've just created an issue for the integration of the "online notification" plugin in the SIP Communicator. You could find it here: https://sip-communicator.dev.java.net/issues/show_bug.cgi?id=348.

I've started to look at the code and I hope I'll finish it these days. I'll stay in touch with you if some questions arise or just to inform you of the status of the issue.

Yana

On 3/30/07, *Emil Ivov* <emcho@emcho.com <mailto:emcho@emcho.com>> >>> wrote:

    Hello again Tom, all,

    I haven't yet had the time to review your plugin, but I thought
    I'd drop
    you a note to let you know I haven't completely forgotten about it.

    Incidentally, if anyone else finds the time to try this out,
    please do.
    I think the plugin implements nice features that would be quite
    handy in
    SIP Communicator.

    Cheers
    Emil

    Emil Ivov wrote:
    > Hi Tom,
    >
    > thanks for your contribution! I saw you created an issue on the
    issue
    > tracker, thanks for doing so.
    >
    > We'll try to review and commit your work as soon as possible!
    >
    > Thanks again,
    > Emil
    >
    > Tom Remoleur wrote:
    >> Hi,
    >>
    >> with some friends, we have developped a plugin to be notified when
    >> selected contacts change their status to online. That was a funny
    >> experience and because the resultat works, we submit here our
    code. In
    >> the attachement, you can find the sources, a little user
    documentation
    >> and the modified build.xmd and felix.properties for easily
    compile and
    >> running the plugin.
    >>
    >> Tom
    >>
    ------------------------------------------------------------------------

    >>
    ---------------------------------------------------------------------
    >> To unsubscribe, e-mail:
    dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
    >> For additional commands, e-mail:
    dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>
    >
    ---------------------------------------------------------------------
    > To unsubscribe, e-mail:
    dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
    > For additional commands, e-mail:
    dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>
    >

    ---------------------------------------------------------------------
    To unsubscribe, e-mail:
    dev-unsubscribe@sip-communicator.dev.java.net
    <mailto:dev-unsubscribe@sip-communicator.dev.java.net>
    For additional commands, e-mail:
    dev-help@sip-communicator.dev.java.net
    <mailto:dev-help@sip-communicator.dev.java.net>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@sip-communicator.dev.java.net
For additional commands, e-mail: dev-help@sip-communicator.dev.java.net